This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /var/lib/copr- rpmbuild/results/mise/diff.txt See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* ISC License", "*No copyright* MIT License", "*No copyright* Apache License 2.0", "BSD 0-Clause License", "*No copyright* The Unlicense", "Apache License 2.0", "BSD 2-Clause License", "*No copyright* Apache License (v2.0) or MIT license and/or MIT License", "Apache License 2.0 and/or MIT License", "*No copyright* Creative Commons CC0 1.0", "*No copyright* Mozilla Public License 2.0", "*No copyright* MIT No Attribution", "*No copyright* BSD 3-Clause License and/or Creative Commons Attribution 3.0 and/or MIT License", "BSD 3-Clause License", "*No copyright* Apache License (v2.0) or MIT license", "Apache License (v2.0) or MIT license and/or BSD 3-Clause License", "Apache License (v2.0) or MIT license", "BSD 1-Clause License", "zlib License", "ISC License", "Unicode License Agreement - Data Files and Software (2016)", "*No copyright* Apache License 2.0 and/or MIT License", "*No copyright* Apache License 2.0 and/or MIT License and/or zlib License", "Apache License 2.0 and/or BSD 3-Clause License", "Apache License 2.0 and/or GNU Lesser General Public License v2.1 or later and/or MIT License", "*No copyright* Boost Software License 1.0", "Apple Public Source License 2.0", "*No copyright* zlib License", "Apache License 2.0 and/or GNU General Public License, Version 2", "GNU Lesser General Public License, Version 3", "*No copyright* Public domain", "Apache License (v2.0) or MIT license and/or MIT License", "MIT License and/or Public domain", "GNU General Public License, Version 2", "GNU Lesser General Public License, Version 2.1", "FSF All Permissive License", "*No copyright* W3C License", "Apache License 2.0 [generated file]", "Apache License 2.0 and/or Boost Software License 1.0", "GNU General Public License v2.0 or later", "BSD 3-Clause License [generated file]", "Apache License 2.0 and/or MIT License and/or SIL Open Font License 1.1", "SIL Open Font License 1.1", "BSD 2-Clause with views sentence", "GNU Lesser General Public License v2.1 or later", "FSF Unlimited License (with License Retention)", "*No copyright* GNU General Public License, Version 2", "*No copyright* GNU Lesser General Public License". 33332 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/mise/licensecheck.txt [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/mise [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/mise [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 5029 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: mise-2025.7.29-1.fc43.aarch64.rpm mise-2025.7.29-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpvmvx9mvb')] checks: 32, packages: 2 mise.aarch64: E: zero-length /usr/lib64/mise/.disable-self-update mise.aarch64: W: unstripped-binary-or-object /usr/bin/mise mise.aarch64: E: spelling-error ('dev', 'Summary(en_US) dev -> deb, derv, div') mise.aarch64: E: spelling-error ('env', 'Summary(en_US) env -> enc, en, envy') mise.aarch64: E: spelling-error ('nvm', '%description -l en_US nvm -> NV') mise.aarch64: E: spelling-error ('rbenv', '%description -l en_US rbenv -> verbena') mise.aarch64: E: spelling-error ('pyenv', '%description -l en_US pyenv -> envy') mise.src: E: spelling-error ('dev', 'Summary(en_US) dev -> deb, derv, div') mise.src: E: spelling-error ('env', 'Summary(en_US) env -> enc, en, envy') mise.src: E: spelling-error ('nvm', '%description -l en_US nvm -> NV') mise.src: E: spelling-error ('rbenv', '%description -l en_US rbenv -> verbena') mise.src: E: spelling-error ('pyenv', '%description -l en_US pyenv -> envy') mise.aarch64: W: only-non-binary-in-usr-lib mise.spec: W: no-%check-section mise.spec:77: W: macro-in-%changelog %{version} mise.spec:78: W: macro-in-%changelog %{version} mise.spec: W: invalid-url Source1: mise-vendor-2025.7.29.tar.gz mise.aarch64: W: hidden-file-or-dir /usr/lib64/mise/.disable-self-update mise.aarch64: W: crypto-policy-non-compliance-openssl /usr/bin/mise SSL_CTX_set_cipher_list 2 packages and 0 specfiles checked; 11 errors, 8 warnings, 7 filtered, 11 badness; has taken 4.6 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "mise". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/jdx/mise/archive/v2025.7.29/mise-2025.7.29.tar.gz : CHECKSUM(SHA256) this package : 304cee9e870fb4e4d237faf3e8bb9781bb866d4b1a6848c123fcda86d3bacb2a CHECKSUM(SHA256) upstream package : c421eb07317fc45791e3f2183c2d25c705152b5cc0ae09ef7e2ba5175cb15bef diff -r also reports differences Requires -------- mise (rpmlib, GLIBC filtered): ld-linux-aarch64.so.1()(64bit) libc.so.6()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libgcc_s.so.1(GCC_4.2.0)(64bit) libm.so.6()(64bit) libssl.so.3()(64bit) libssl.so.3(OPENSSL_3.0.0)(64bit) rtld(GNU_HASH) Provides -------- mise: mise mise(aarch-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name mise --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-aarch64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: Ocaml, SugarActivity, Perl, PHP, Java, Haskell, Python, fonts, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH