This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - The License field must be a valid SPDX expression. Note: Not a valid SPDX expression 'Proprietary+GPLv2'. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 - Packages have proper BuildRequires/Requires on javapackages-tools (jpackage-utils) - Javadoc documentation files are generated and included in -javadoc subpackage Note: No javadoc subpackage present. Note: Javadocs are optional for Fedora versions >= 21 See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation - Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Note: No javadoc subpackage present See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation - Bundled jar/class files should be removed before build Note: Jar files in source (see attachment) See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Java/#_pre_built_dependencies ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "FSF Unlimited License [generated file]", "GNU General Public License v3.0 or later", "X11 License [generated file]", "GNU General Public License v2.0 or later", "GNU General Public License, Version 2", "*No copyright* GNU General Public License, Version 2", "OpenSSL License", "Apache License 1.0 and/or OpenSSL License", "*No copyright* Public domain", "GNU Lesser General Public License v2.1 or later", "GNU General Public License (v2 or later) or GNU Lesser General Public License (v2.1 or later) and/or GNU General Public License v2.0 or later and/or Mozilla Public License 1.1", "Unicode strict", "*No copyright* GNU Lesser General Public License v2.1 or later", "*No copyright* GNU General Public License v2.0 or later". 129 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/makemkv/licensecheck.txt [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/MakeMKV [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor, /usr/share/icons/hicolor/64x64/apps, /usr/share/icons/hicolor/128x128, /usr/share/icons/hicolor/32x32/apps, /usr/share/MakeMKV, /usr/share/icons/hicolor/16x16, /usr/share/icons/hicolor/64x64, /usr/share/icons/hicolor/22x22, /usr/share/icons/hicolor/32x32, /usr/share/icons/hicolor/256x256/apps, /usr/share/icons/hicolor/128x128/apps, /usr/share/icons/hicolor/16x16/apps, /usr/share/icons/hicolor/256x256, /usr/share/icons/hicolor/22x22/apps [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled() if unbundling is not possible. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Maven: [ ]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: Old add_to_maven_depmap macro is not being used ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: https://www.makemkv.com/download/old/makemkv-bin-1.17.7.tar.gz, Source1: https://www.makemkv.com/download/old/makemkv- oss-1.17.7.tar.gz See: https://docs.fedoraproject.org/en-US/packaging- guidelines/SourceURL/ [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [ ]: Packages are noarch unless they use JNI Note: makemkv subpackage is not noarch. Please verify manually [ ]: Package uses upstream build method (ant/maven/etc.) ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 4751360 bytes in /usr/share [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: makemkv-1.17.7-1.fc43.x86_64.rpm makemkv-1.17.7-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp_z37xjw8')] checks: 32, packages: 2 makemkv.x86_64: W: unstripped-binary-or-object /usr/bin/makemkv makemkv.x86_64: W: unstripped-binary-or-object /usr/bin/mmccextr makemkv.x86_64: W: unstripped-binary-or-object /usr/bin/mmgplsrv makemkv.x86_64: W: unstripped-binary-or-object /usr/lib64/libdriveio.so.0 makemkv.x86_64: W: unstripped-binary-or-object /usr/lib64/libmakemkv.so.1 makemkv.x86_64: W: unstripped-binary-or-object /usr/lib64/libmmbd.so.0 makemkv.src: E: spelling-error ('transcoder', 'Summary(en_US) transcoder -> trans coder, trans-coder, transponder') makemkv.src: E: spelling-error ('transcoder', '%description -l en_US transcoder -> trans coder, trans-coder, transponder') makemkv.src: E: spelling-error ('decrypted', '%description -l en_US decrypted -> encrypted') makemkv.x86_64: E: spelling-error ('transcoder', 'Summary(en_US) transcoder -> trans coder, trans-coder, transponder') makemkv.x86_64: E: spelling-error ('transcoder', '%description -l en_US transcoder -> trans coder, trans-coder, transponder') makemkv.x86_64: E: spelling-error ('decrypted', '%description -l en_US decrypted -> encrypted') makemkv.spec: W: specfile-warning sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory makemkv.x86_64: E: shared-library-not-executable /usr/lib64/libdriveio.so.0 makemkv.x86_64: E: shared-library-not-executable /usr/lib64/libmakemkv.so.1 makemkv.x86_64: E: shared-library-not-executable /usr/lib64/libmmbd.so.0 makemkv.x86_64: W: position-independent-executable-suggested /usr/bin/makemkvcon makemkv.x86_64: W: no-manual-page-for-binary makemkv makemkv.x86_64: W: no-manual-page-for-binary makemkvcon makemkv.x86_64: W: no-manual-page-for-binary mmccextr makemkv.x86_64: W: no-manual-page-for-binary mmgplsrv makemkv.x86_64: W: no-manual-page-for-binary sdftool makemkv.x86_64: W: no-documentation makemkv.src: E: no-changelogname-tag makemkv.x86_64: E: no-changelogname-tag makemkv.src: W: invalid-license Proprietary+GPLv2 makemkv.x86_64: W: invalid-license Proprietary+GPLv2 makemkv.x86_64: E: explicit-lib-dependency ffmpeg-libs 2 packages and 0 specfiles checked; 12 errors, 16 warnings, 28 filtered, 12 badness; has taken 1.5 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "makemkv". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Requires -------- makemkv (rpmlib, GLIBC filtered): ffmpeg-libs libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.15)(64bit) libQt5DBus.so.5()(64bit) libQt5DBus.so.5(Qt_5)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libavcodec.so.61()(64bit) libavcodec.so.61(LIBAVCODEC_61)(64bit) libavutil.so.59()(64bit) libavutil.so.59(LIBAVUTIL_59)(64bit) libc.so.6()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libdl.so.2()(64bit) libexpat.so.1()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libz.so.1()(64bit) libz.so.1(ZLIB_1.2.0)(64bit) rtld(GNU_HASH) Provides -------- makemkv: application() application(makemkv.desktop) libmmbd.so.0()(64bit) makemkv makemkv(x86-64) Jar and class files in source ----------------------------- ./makemkv-1.17.7-build/makemkv-bin-1.17.7/src/share/blues.jar Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name makemkv --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-43-x86_64 Active plugins: C/C++, Java, Generic, Shell-api Disabled plugins: Python, SugarActivity, PHP, fonts, Ocaml, R, Haskell, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH