{"object_kind":"push","event_name":"push","before":"fd83a13c6dc1ccddeff628df76406ab6554ecb4d","after":"a3615b9a6310b627f28451a08fcbb833cb8ce154","ref":"refs/heads/main","ref_protected":false,"checkout_sha":"a3615b9a6310b627f28451a08fcbb833cb8ce154","message":null,"user_id":1255007,"user_name":"Josephine Pfeiffer","user_username":"josie","user_email":"josie@redhat.com","user_avatar":"https://gitlab.freedesktop.org/uploads/-/system/user/avatar/1255007/avatar.png","project_id":411,"project":{"id":411,"name":"NetworkManager","description":"NetworkManager — network management daemon","web_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","avatar_url":"https://gitlab.freedesktop.org/uploads/-/system/project/avatar/411/nm_logo.png","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","namespace":"NetworkManager","visibility_level":20,"path_with_namespace":"NetworkManager/NetworkManager","default_branch":"main","ci_config_path":"","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git"},"commits":[{"id":"10426744f40edfc93ff5beeb00c6e97fac9a7e46","message":"libnm: fix normalization order for Bluetooth NAP connections\n\n_normalize_required_settings() added the ethernet setting a bridge needs\nbefore adding the bridge setting a NAP profile needs, so the bridge it\nsynthesized for NAP never got one. Verification then failed as\nnormalizable and nm_connection_normalize() warned and hit\ng_return_val_if_reached(), which users see on stderr when creating a\nBluetooth hotspot with the documented nmcli-examples(7) command.\n\nThe profile still got stored & nmcli discards the return value, and the\ndaemon's own normalize pass then adds the missing ethernet setting.\n\nFixes: 41291ef773f7 ('core/connection: ensure wired settings are around for bridges')\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/1996\n","title":"libnm: fix normalization order for Bluetooth NAP connections","timestamp":"2026-08-20T12:16:11+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/10426744f40edfc93ff5beeb00c6e97fac9a7e46","author":{"name":"Josephine Pfeiffer","email":"josie@redhat.com"},"added":[],"modified":["src/libnm-core-impl/nm-connection.c","src/libnm-core-impl/tests/test-general.c"],"removed":[]},{"id":"8b67c90c3c1d1afe8d755b6068c70a4d4a755ba9","message":"libnm: fix inverted condition when detecting the Bluetooth type\n\n_nm_connection_detect_bluetooth_type() inferred a type only when\nbluetooth.type was already set, which is backwards. verify() calls it\nexactly when the property is missing, so a profile carrying a gsm/cdma\nor bridge setting was rejected as incomplete instead of normalized,\nwhile a profile with an explicit type could get it overwritten by the\ninferred one during normalization.\n\nFixes: 9b28c9ba91f6 ('core: infer the bluetooth type from the presence of the supplemental settings')\n","title":"libnm: fix inverted condition when detecting the Bluetooth type","timestamp":"2026-08-20T12:31:05+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/8b67c90c3c1d1afe8d755b6068c70a4d4a755ba9","author":{"name":"Josephine Pfeiffer","email":"josie@redhat.com"},"added":[],"modified":["src/libnm-core-impl/nm-connection.c","src/libnm-core-impl/tests/test-general.c"],"removed":[]},{"id":"a3615b9a6310b627f28451a08fcbb833cb8ce154","message":"merge: branch 'jp/bt-nap-normalize'\n\nFix the normalization order that left Bluetooth NAP profiles failing\nverification, and the inverted condition in the Bluetooth type detection\nthe same path depends on.\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/1996\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2502\n","title":"merge: branch 'jp/bt-nap-normalize'","timestamp":"2026-08-20T13:58:35+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/a3615b9a6310b627f28451a08fcbb833cb8ce154","author":{"name":"Josephine Pfeiffer","email":"josie@redhat.com"},"added":[],"modified":["src/libnm-core-impl/nm-connection.c","src/libnm-core-impl/tests/test-general.c"],"removed":[]}],"total_commits_count":3,"push_options":{},"repository":{"name":"NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","description":"NetworkManager — network management daemon","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","visibility_level":20}}