This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files in -devel subpackage, if present. Note: nim : /usr/share/nim/cycle.h nim : /usr/share/nim/genode_cpp/signals.h nim : /usr/share/nim/genode_cpp/syslocks.h nim : /usr/share/nim/genode_cpp/threads.h nim : /usr/share/nim/nimbase.h nim : /usr/share/nim/wrappers/linenoise/linenoise.h See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE.txt is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/nim See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License", "BSD 3-Clause License", "*No copyright* BSD 3-Clause License", "Boost Software License 1.0", "Apache License 2.0", "BSD 2-Clause License", "GNU Library General Public License v2 or later [obsolete FSF postal address (Mass Ave)]", "*No copyright* GNU Lesser General Public License, Version 3 and/or MIT License", "*No copyright* Apache License 2.0 and/or MIT License". 32010 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/nim/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled() if unbundling is not possible. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 272 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: https://nim- lang.org/download/nim-2.2.6.tar.xz See: https://docs.fedoraproject.org/en-US/packaging- guidelines/SourceURL/ [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in nim- tools [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 9000960 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: nim-2.2.6-1.fc44.aarch64.rpm nim-tools-2.2.6-1.fc44.aarch64.rpm nim-doc-2.2.6-1.fc44.noarch.rpm nim-2.2.6-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpfnfoi114')] checks: 32, packages: 4 nim.aarch64: E: zero-length /usr/share/nimble/pkgs/nim-2.2.6/compiler/plugins/plugins.nimble nim.spec: W: specfile-warning sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory nim.aarch64: W: non-conffile-in-etc /etc/nim/config.nims nim.aarch64: W: non-conffile-in-etc /etc/nim/nim.cfg nim.aarch64: W: non-conffile-in-etc /etc/nim/nimdoc.cfg nim.aarch64: W: non-conffile-in-etc /etc/nim/nimdoc.tex.cfg nim.aarch64: W: non-conffile-in-etc /etc/nim/rename.rules.cfg nim.aarch64: W: no-manual-page-for-binary nim nim.aarch64: W: no-manual-page-for-binary nimble nim-tools.aarch64: W: no-manual-page-for-binary nim-gdb nim-tools.aarch64: W: no-manual-page-for-binary nim_dbg nim-tools.aarch64: W: no-manual-page-for-binary nimgrep nim-tools.aarch64: W: no-manual-page-for-binary niminst nim-tools.aarch64: W: no-manual-page-for-binary nimpretty nim-tools.aarch64: W: no-manual-page-for-binary nimsuggest nim-tools.aarch64: W: no-manual-page-for-binary testament nim-tools.aarch64: W: no-documentation nim.aarch64: W: devel-file-in-non-devel-package /usr/share/nim/cycle.h nim.aarch64: W: devel-file-in-non-devel-package /usr/share/nim/genode_cpp/signals.h nim.aarch64: W: devel-file-in-non-devel-package /usr/share/nim/genode_cpp/syslocks.h nim.aarch64: W: devel-file-in-non-devel-package /usr/share/nim/genode_cpp/threads.h nim.aarch64: W: devel-file-in-non-devel-package /usr/share/nim/nimbase.h nim.aarch64: W: devel-file-in-non-devel-package /usr/share/nim/wrappers/linenoise/linenoise.c nim.aarch64: W: devel-file-in-non-devel-package /usr/share/nim/wrappers/linenoise/linenoise.h 4 packages and 0 specfiles checked; 1 errors, 23 warnings, 14 filtered, 1 badness; has taken 2.1 s Rpmlint (debuginfo) ------------------- Checking: nim-debuginfo-2.2.6-1.fc44.aarch64.rpm nim-tools-debuginfo-2.2.6-1.fc44.aarch64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpbiloci2k')] checks: 32, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 27 filtered, 0 badness; has taken 4.8 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "nim-tools". (none): E: there is no installed rpm "nim-debuginfo". (none): E: there is no installed rpm "nim-tools-debuginfo". (none): E: there is no installed rpm "nim-doc". (none): E: there is no installed rpm "nim". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 5 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/nim-lang/atlas/archive/9cf7e5fb46d341b7e8755312ed460d130a091a72/atlas-9cf7e5fb46d341b7e8755312ed460d130a091a72.tar.gz : CHECKSUM(SHA256) this package : a17d1a1b1cdfd143938cfc13816e06249e27d6cbb8ac454d9d59b82e4ee05a24 CHECKSUM(SHA256) upstream package : a17d1a1b1cdfd143938cfc13816e06249e27d6cbb8ac454d9d59b82e4ee05a24 https://github.com/nim-lang/sat/archive/faf1617f44d7632ee9601ebc13887644925dcc01/sat-faf1617f44d7632ee9601ebc13887644925dcc01.tar.gz : CHECKSUM(SHA256) this package : dfb90aa7fa629bb7bd395ae041410362439492600d06978d29ba726c16ef4077 CHECKSUM(SHA256) upstream package : dfb90aa7fa629bb7bd395ae041410362439492600d06978d29ba726c16ef4077 https://github.com/nim-lang/asyncftpclient/archive/0350c36d9545040f1038258d7a815493a6103de0/asyncftpclient-0350c36d9545040f1038258d7a815493a6103de0.tar.gz : CHECKSUM(SHA256) this package : 97c72b8f1f57855a4b992930bd31d12cc4a5e78e5c73f9b9eb1c2b22d73e1eb3 CHECKSUM(SHA256) upstream package : 97c72b8f1f57855a4b992930bd31d12cc4a5e78e5c73f9b9eb1c2b22d73e1eb3 https://github.com/nim-lang/punycode/archive/03fa3cf9f37c0fbcbdf400c37d9be7a458660dd6/punycode-03fa3cf9f37c0fbcbdf400c37d9be7a458660dd6.tar.gz : CHECKSUM(SHA256) this package : 37e3b16a428f4883070ac8262e5a942e642f5561c8b884b22b53712afbf954f9 CHECKSUM(SHA256) upstream package : 37e3b16a428f4883070ac8262e5a942e642f5561c8b884b22b53712afbf954f9 https://github.com/nim-lang/smtp/archive/46ad524ada896bc45869d63077362718ca52873b/smtp-46ad524ada896bc45869d63077362718ca52873b.tar.gz : CHECKSUM(SHA256) this package : ca7ba03e11e064f8d923bd6311152d8056fe667e9218ec6c2d57af4f922ace91 CHECKSUM(SHA256) upstream package : ca7ba03e11e064f8d923bd6311152d8056fe667e9218ec6c2d57af4f922ace91 https://github.com/nim-lang/db_connector/archive/fba8db1fee20d73e07d79a1af1539fe7d129d065/db_connector-fba8db1fee20d73e07d79a1af1539fe7d129d065.tar.gz : CHECKSUM(SHA256) this package : 7bf04432191544d7c43f2131b70176119ac32708357a2d31a365344dcd304fad CHECKSUM(SHA256) upstream package : 7bf04432191544d7c43f2131b70176119ac32708357a2d31a365344dcd304fad https://github.com/nim-lang/checksums/archive/8ee781a713184dcf66ea0235aad865fa65b5c7ff/checksums-8ee781a713184dcf66ea0235aad865fa65b5c7ff.tar.gz : CHECKSUM(SHA256) this package : f27f205c340a4cd77aefc0bcbc2802b2d881955ed0d1c6fe9fef0008fdca8d9f CHECKSUM(SHA256) upstream package : f27f205c340a4cd77aefc0bcbc2802b2d881955ed0d1c6fe9fef0008fdca8d9f https://github.com/nim-lang/htmlparser/archive/c3ab4d5157759ad1a3b67be5b4562f44c55c0ef7/htmlparser-c3ab4d5157759ad1a3b67be5b4562f44c55c0ef7.tar.gz : CHECKSUM(SHA256) this package : a1985ae9439ea4caf3a79332b2bac26035d72c06b1275608d22001924dae48f9 CHECKSUM(SHA256) upstream package : a1985ae9439ea4caf3a79332b2bac26035d72c06b1275608d22001924dae48f9 Requires -------- nim (rpmlib, GLIBC filtered): gcc ld-linux-aarch64.so.1()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) redhat-rpm-config rtld(GNU_HASH) nim-tools (rpmlib, GLIBC filtered): /usr/bin/bash ld-linux-aarch64.so.1()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) rtld(GNU_HASH) nim-doc (rpmlib, GLIBC filtered): Provides -------- nim: nim nim(aarch-64) nim-tools: nim-tools nim-tools(aarch-64) nim-doc: nim-doc Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name nim --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-44-aarch64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: SugarActivity, fonts, Perl, PHP, R, Java, Ocaml, Python, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH