This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Q Public License 1.0", "*No copyright* Q Public License", "Q Public License 1.0", "FSF Unlimited License [generated file]", "BSD 2-clause NetBSD License and/or BSD 4-Clause License and/or Q Public License 1.0", "BSD-4-Clause (University of California-Specific) and/or Q Public License 1.0", "BSD 2-Clause License", "Public domain", "Q Public License", "MIT License and/or Public domain and/or Q Public License 1.0", "BSD 3-Clause License", "GNU General Public License v3.0 or later", "GNU General Public License v2.0 or later", "GNU General Public License v2.0 or later [generated file]", "NTP License", "X11 License [generated file]", "FSF Unlimited License (with License Retention) and/or GNU General Public License, Version 2", "FSF Unlimited License (with License Retention)", "MIT License and/or Public domain", "ICU License", "*No copyright* ICU License", "FSF Unlimited License (with License Retention) and/or GNU General Public License and/or GNU Lesser General Public License", "Boost Software License 1.0", "*No copyright* Public domain". 851 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/sdl-hercules/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 832616 bytes in 46 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in sdl- hercules-data [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: sdl-hercules-4.7-1.fc42.x86_64.rpm sdl-hercules-data-4.7-1.fc42.noarch.rpm sdl-hercules-4.7-1.fc42.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpu_9pj5__')] checks: 32, packages: 3 sdl-hercules.x86_64: W: no-manual-page-for-binary cckd2ckd sdl-hercules.x86_64: W: no-manual-page-for-binary cckd642ckd sdl-hercules.x86_64: W: no-manual-page-for-binary cckdcdsk sdl-hercules.x86_64: W: no-manual-page-for-binary cckdcdsk64 sdl-hercules.x86_64: W: no-manual-page-for-binary cckdcomp sdl-hercules.x86_64: W: no-manual-page-for-binary cckdcomp64 sdl-hercules.x86_64: W: no-manual-page-for-binary cckddiag64 sdl-hercules.x86_64: W: no-manual-page-for-binary cckdmap sdl-hercules.x86_64: W: no-manual-page-for-binary cckdswap sdl-hercules.x86_64: W: no-manual-page-for-binary cckdswap64 sdl-hercules.x86_64: W: no-manual-page-for-binary cfba2fba sdl-hercules.x86_64: W: no-manual-page-for-binary cfba642fba sdl-hercules.x86_64: W: no-manual-page-for-binary ckd2cckd sdl-hercules.x86_64: W: no-manual-page-for-binary ckd2cckd64 sdl-hercules.x86_64: W: no-manual-page-for-binary convto64 sdl-hercules.x86_64: W: no-manual-page-for-binary dasdcat sdl-hercules.x86_64: W: no-manual-page-for-binary dasdconv sdl-hercules.x86_64: W: no-manual-page-for-binary dasdconv64 sdl-hercules.x86_64: W: no-manual-page-for-binary dasdcopy sdl-hercules.x86_64: W: no-manual-page-for-binary dasdcopy64 sdl-hercules.x86_64: W: no-manual-page-for-binary dasdinit sdl-hercules.x86_64: W: no-manual-page-for-binary dasdinit64 sdl-hercules.x86_64: W: no-manual-page-for-binary dasdisup sdl-hercules.x86_64: W: no-manual-page-for-binary dasdlist sdl-hercules.x86_64: W: no-manual-page-for-binary dasdload sdl-hercules.x86_64: W: no-manual-page-for-binary dasdload64 sdl-hercules.x86_64: W: no-manual-page-for-binary dasdls sdl-hercules.x86_64: W: no-manual-page-for-binary dasdpdsu sdl-hercules.x86_64: W: no-manual-page-for-binary dasdser sdl-hercules.x86_64: W: no-manual-page-for-binary dmap2hrc sdl-hercules.x86_64: W: no-manual-page-for-binary fba2cfba sdl-hercules.x86_64: W: no-manual-page-for-binary fba2cfba64 sdl-hercules.x86_64: W: no-manual-page-for-binary hercifc sdl-hercules.x86_64: W: no-manual-page-for-binary herclin sdl-hercules.x86_64: W: no-manual-page-for-binary hercules sdl-hercules.x86_64: W: no-manual-page-for-binary hetget sdl-hercules.x86_64: W: no-manual-page-for-binary hetinit sdl-hercules.x86_64: W: no-manual-page-for-binary hetmap sdl-hercules.x86_64: W: no-manual-page-for-binary hetupd sdl-hercules.x86_64: W: no-manual-page-for-binary maketape sdl-hercules.x86_64: W: no-manual-page-for-binary tapecopy sdl-hercules.x86_64: W: no-manual-page-for-binary tapemap sdl-hercules.x86_64: W: no-manual-page-for-binary tapesplt sdl-hercules.x86_64: W: no-manual-page-for-binary tfprint sdl-hercules.x86_64: W: no-manual-page-for-binary tfswap sdl-hercules.x86_64: W: no-manual-page-for-binary txt2card sdl-hercules-data.noarch: W: no-documentation sdl-hercules-data.noarch: W: files-duplicate /usr/share/hercules/images/dial4.gif /usr/share/hercules/images/dial2.gif:/usr/share/hercules/images/dial3.gif sdl-hercules.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/lib64/hercules/hdt1403.so sdl-hercules.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/lib64/hercules/hdt2703.so sdl-hercules.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/lib64/hercules/hdt3088.so sdl-hercules.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/lib64/hercules/hdt3270.so sdl-hercules.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/lib64/hercules/hdt3505.so sdl-hercules.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/lib64/hercules/hdt3525.so sdl-hercules.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/lib64/hercules/hdt3705.so sdl-hercules.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/lib64/hercules/hdttcpnje.so sdl-hercules.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/lib64/libherc.so.4.7.0 sdl-hercules.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/lib64/libhercd.so.4.7.0 3 packages and 0 specfiles checked; 0 errors, 58 warnings, 124 filtered, 0 badness; has taken 2.0 s Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "sdl-hercules-data". (none): E: there is no installed rpm "sdl-hercules". (none): E: there is no installed rpm "sdl-hercules-debuginfo". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Unversioned so-files -------------------- sdl-hercules: /usr/lib64/hercules/dyncrypt.so sdl-hercules: /usr/lib64/hercules/dyngui.so sdl-hercules: /usr/lib64/hercules/hdt1052c.so sdl-hercules: /usr/lib64/hercules/hdt1403.so sdl-hercules: /usr/lib64/hercules/hdt2703.so sdl-hercules: /usr/lib64/hercules/hdt2880.so sdl-hercules: /usr/lib64/hercules/hdt3088.so sdl-hercules: /usr/lib64/hercules/hdt3270.so sdl-hercules: /usr/lib64/hercules/hdt3420.so sdl-hercules: /usr/lib64/hercules/hdt3505.so sdl-hercules: /usr/lib64/hercules/hdt3525.so sdl-hercules: /usr/lib64/hercules/hdt3705.so sdl-hercules: /usr/lib64/hercules/hdtdummy.so sdl-hercules: /usr/lib64/hercules/hdteq.so sdl-hercules: /usr/lib64/hercules/hdtptp.so sdl-hercules: /usr/lib64/hercules/hdtqeth.so sdl-hercules: /usr/lib64/hercules/hdttcpnje.so sdl-hercules: /usr/lib64/hercules/hdtzfcp.so Source checksums ---------------- https://github.com/SDL-Hercules-390/hyperion/archive/Release_4.7/hyperion-Release_4.7.tar.gz : CHECKSUM(SHA256) this package : 74c747773e0b5639164f6f69ce9220e1bd1d4853c5c4f18329da21c03aebe388 CHECKSUM(SHA256) upstream package : 74c747773e0b5639164f6f69ce9220e1bd1d4853c5c4f18329da21c03aebe388 Requires -------- sdl-hercules (rpmlib, GLIBC filtered): /usr/bin/sh libbz2.so.1()(64bit) libc.so.6()(64bit) libcap.so.2()(64bit) libhdt3420_not_mod.so.4()(64bit) libherc.so.4()(64bit) libhercd.so.4()(64bit) libhercs.so.4()(64bit) libherct.so.4()(64bit) libhercu.so.4()(64bit) libm.so.6()(64bit) libresolv.so.2()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) sdl-hercules-data sdl-hercules-data (rpmlib, GLIBC filtered): Provides -------- sdl-hercules: bundled(dyn76) bundled(musl-headers) bundled(netbsd-getopt) libhdt3420_not_mod.so.4()(64bit) libherc.so.4()(64bit) libhercd.so.4()(64bit) libhercs.so.4()(64bit) libherct.so.4()(64bit) libhercu.so.4()(64bit) sdl-hercules sdl-hercules(x86-64) sdl-hercules-data: sdl-hercules-data AutoTools: Obsoleted m4s found ------------------------------ AC_PROG_LIBTOOL found in: sdl-hercules-4.7-build/hyperion- Release_4.7/configure.ac:443, sdl-hercules-4.7-build/hyperion- Release_4.7/configure.ac:457, sdl-hercules-4.7-build/hyperion- Release_4.7/configure.ac:524 Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name sdl-hercules --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, C/C++, Generic Disabled plugins: PHP, fonts, Python, R, Ocaml, SugarActivity, Haskell, Java, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH