This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/bat, /usr/share/nvim/site/compiler, /usr/share/nvim/site/ftplugin, /usr/share/bat/syntaxes, /usr/share/nautilus-python, /usr/share/nvim/site/ftdetect, /usr/share/nvim/site/syntax [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/kio, /usr/share/icons/hicolor/128x128@2, /usr/share/nvim/site/syntax, /usr/share/bat, /usr/share/vim/vimfiles, /usr/share/icons/hicolor/256x256, /usr/share/icons/hicolor/128x128@2/apps, /usr/share/icons/hicolor/32x32, /usr/share/vim/vimfiles/ftplugin, /usr/share/icons/hicolor/16x16/apps, /usr/share/icons/hicolor/256x256@2, /usr/share/icons/hicolor/32x32@2/apps, /usr/share/nvim/site/compiler, /usr/share/vim/vimfiles/compiler, /usr/share/nvim/site/ftplugin, /usr/share/vim/vimfiles/ftdetect, /usr/share/nvim, /usr/share/nautilus-python, /usr/share/kio/servicemenus, /usr/share/icons/hicolor/256x256/apps, /usr/share/icons/hicolor/1024x1024, /usr/share/icons/hicolor/16x16, /usr/share/nautilus-python/extensions, /usr/share/nvim/site/ftdetect, /usr/share/icons/hicolor/1024x1024/apps, /usr/share/vim/vimfiles/syntax, /usr/share/icons/hicolor/128x128, /usr/share/icons/hicolor/16x16@2/apps, /usr/share/icons/hicolor/32x32/apps, /usr/share/bat/syntaxes, /usr/share/icons/hicolor/16x16@2, /usr/share/vim, /usr/share/icons/hicolor, /usr/share/icons/hicolor/256x256@2/apps, /usr/share/icons/hicolor/32x32@2, /usr/share/icons/hicolor/128x128/apps, /usr/share/icons/hicolor/512x512/apps, /usr/share/icons/hicolor/512x512, /usr/share/nvim/site [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 11219 bytes in 1 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source31: https://deps.files.ghostty.org/wayland- protocols-258d8f88f2c8c25a830c6316f87d23ce1a0f12d9.tar.gz, Source30: https://deps.files.ghostty.org/wayland-9cb3d7aa9dc995ffafdbdef7ab86a949d0fb0e7d.tar.gz, Source23: https://deps.files.ghostty.org/ziglyph-b89d43d1e3fb01b6074bc1f7fc980324b04d26a5.tar.gz, Source1: https://release.files.ghostty.org/1.1.0/ghostty-1.1.0.tar.gz.minisig, Source0: https://release.files.ghostty.org/1.1.0/ghostty-1.1.0.tar.gz See: https://docs.fedoraproject.org/en-US/packaging- guidelines/SourceURL/ [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ghostty- terminfo [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1986560 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: ghostty-1.1.0-1.fc42.x86_64.rpm ghostty-terminfo-1.1.0-1.fc42.noarch.rpm ghostty-1.1.0-1.fc42.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpweq9d7j3')] checks: 32, packages: 3 ghostty-terminfo.noarch: W: no-documentation ghostty.spec:188: W: macro-in-comment %{fontversion} ghostty.x86_64: W: hidden-file-or-dir /usr/share/ghostty/shell-integration/zsh/.zshenv ghostty.x86_64: W: cross-directory-hard-link /usr/share/icons/hicolor/512x512/apps/com.mitchellh.ghostty.png /usr/share/icons/hicolor/256x256@2/apps/com.mitchellh.ghostty.png ghostty.x86_64: W: cross-directory-hard-link /usr/share/vim/vimfiles/compiler/ghostty.vim /usr/share/nvim/site/compiler/ghostty.vim ghostty.x86_64: W: cross-directory-hard-link /usr/share/vim/vimfiles/ftdetect/ghostty.vim /usr/share/nvim/site/ftdetect/ghostty.vim ghostty.x86_64: W: cross-directory-hard-link /usr/share/vim/vimfiles/ftplugin/ghostty.vim /usr/share/nvim/site/ftplugin/ghostty.vim ghostty.x86_64: W: cross-directory-hard-link /usr/share/vim/vimfiles/syntax/ghostty.vim /usr/share/nvim/site/syntax/ghostty.vim ghostty-terminfo.noarch: W: cross-directory-hard-link /usr/share/terminfo/x/xterm-ghostty /usr/share/terminfo/g/ghostty 3 packages and 0 specfiles checked; 0 errors, 9 warnings, 11 filtered, 0 badness; has taken 1.4 s Rpmlint (debuginfo) ------------------- Checking: ghostty-debuginfo-1.1.0-1.fc42.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp9bejeblb')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.4 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "ghostty-debuginfo". (none): E: there is no installed rpm "ghostty". ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s (none): E: there is no installed rpm "ghostty-terminfo". There are no files to process nor additional arguments. Nothing to do, aborting. Source checksums ---------------- https://github.com/KDE/plasma-wayland-protocols/archive/db525e8f9da548cffa2ac77618dd0fbe7f511b86/plasma-wayland-protocols-db525e8f9da548cffa2ac77618dd0fbe7f511b86.tar.gz : CHECKSUM(SHA256) this package : 5c58ba214acd8e6bca3426dc08b022c46a8dd997b29a1b3e28badf71c20df441 CHECKSUM(SHA256) upstream package : 5c58ba214acd8e6bca3426dc08b022c46a8dd997b29a1b3e28badf71c20df441 https://codeberg.org/ifreund/zig-wayland/archive/fbfe3b4ac0b472a27b1f1a67405436c58cbee12d.tar.gz : CHECKSUM(SHA256) this package : 46d032b2da8afc645822ab932b529f0fbad1482adfbb302f083d59f4313595d7 CHECKSUM(SHA256) upstream package : 46d032b2da8afc645822ab932b529f0fbad1482adfbb302f083d59f4313595d7 https://github.com/mitchellh/zig-js/archive/d0b8b0a57c52fbc89f9d9fecba75ca29da7dd7d1/zig-js-d0b8b0a57c52fbc89f9d9fecba75ca29da7dd7d1.tar.gz : CHECKSUM(SHA256) this package : 7f235e0956c2f5401a28963a261019953d00e3bf4cfc029830f2161196c3583d CHECKSUM(SHA256) upstream package : 7f235e0956c2f5401a28963a261019953d00e3bf4cfc029830f2161196c3583d https://github.com/mitchellh/zig-objc/archive/9b8ba849b0f58fe207ecd6ab7c147af55b17556e/zig-objc-9b8ba849b0f58fe207ecd6ab7c147af55b17556e.tar.gz : CHECKSUM(SHA256) this package : 1fe1c86e1d93db7bb3aec83dff5fef97d22bd470806b6a73793c7ace4b491fd4 CHECKSUM(SHA256) upstream package : 1fe1c86e1d93db7bb3aec83dff5fef97d22bd470806b6a73793c7ace4b491fd4 https://codeberg.org/atman/zg/archive/v0.13.2.tar.gz#/zg-0.13.2.tar.gz : CHECKSUM(SHA256) this package : db1f614fb6d8abd2896162d539fdb56be42f4c6fc5ec7593f982b5e48311ccd6 CHECKSUM(SHA256) upstream package : db1f614fb6d8abd2896162d539fdb56be42f4c6fc5ec7593f982b5e48311ccd6 https://github.com/zigimg/zigimg/archive/3a667bdb3d7f0955a5a51c8468eac83210c1439e/zigimg-3a667bdb3d7f0955a5a51c8468eac83210c1439e.tar.gz : CHECKSUM(SHA256) this package : ca4851f5551f0542f491fda03ef15e649f5e6a323783588ba6690aa7e7fc6c5b CHECKSUM(SHA256) upstream package : ca4851f5551f0542f491fda03ef15e649f5e6a323783588ba6690aa7e7fc6c5b https://github.com/natecraddock/zf/archive/ed99ca18b02dda052e20ba467e90b623c04690dd/zf-ed99ca18b02dda052e20ba467e90b623c04690dd.tar.gz : CHECKSUM(SHA256) this package : fe82ebc98dd541f8dbb508be50ffa7e85253540fd8c487ad8cefba3afae1ebf1 CHECKSUM(SHA256) upstream package : fe82ebc98dd541f8dbb508be50ffa7e85253540fd8c487ad8cefba3afae1ebf1 https://github.com/google/wuffs/archive/refs/tags/v0.4.0-alpha.9/wuffs-0.4.0-alpha.9.tar.gz : CHECKSUM(SHA256) this package : 9e4cd20abe96e6c4c6ede9c3057108860126e7be2e2c3e35515476c250be1c13 CHECKSUM(SHA256) upstream package : 9e4cd20abe96e6c4c6ede9c3057108860126e7be2e2c3e35515476c250be1c13 https://github.com/getsentry/breakpad/archive/b99f444ba5f6b98cac261cbb391d8766b34a5918/sentry-breakpad-b99f444ba5f6b98cac261cbb391d8766b34a5918.tar.gz : CHECKSUM(SHA256) this package : 6cca98943d1a990766cef61077c09aff5938063fe17a1efe1228e5412b6d6ad9 CHECKSUM(SHA256) upstream package : 6cca98943d1a990766cef61077c09aff5938063fe17a1efe1228e5412b6d6ad9 https://github.com/ocornut/imgui/archive/e391fe2e66eb1c96b1624ae8444dc64c23146ef4/imgui-e391fe2e66eb1c96b1624ae8444dc64c23146ef4.tar.gz : CHECKSUM(SHA256) this package : a05fd01e04cf11ab781e28387c621d2e420f1e6044c8e27a25e603ea99ef7860 CHECKSUM(SHA256) upstream package : a05fd01e04cf11ab781e28387c621d2e420f1e6044c8e27a25e603ea99ef7860 https://github.com/mitchellh/libxev/archive/31eed4e337fed7b0149319e5cdbb62b848c24fbd/libxev-31eed4e337fed7b0149319e5cdbb62b848c24fbd.tar.gz : CHECKSUM(SHA256) this package : 5473fdd0d4f2b4867c519b1844a38ec4de3dd3f23acafe9e738d2c3fccb9309f CHECKSUM(SHA256) upstream package : 5473fdd0d4f2b4867c519b1844a38ec4de3dd3f23acafe9e738d2c3fccb9309f https://github.com/google/highway/archive/refs/tags/1.1.0/highway-1.1.0.tar.gz : CHECKSUM(SHA256) this package : 354a8b4539b588e70b98ec70844273e3f2741302c4c377bcc4e81b3d1866f7c9 CHECKSUM(SHA256) upstream package : 354a8b4539b588e70b98ec70844273e3f2741302c4c377bcc4e81b3d1866f7c9 https://github.com/KhronosGroup/glslang/archive/refs/tags/14.2.0/glslang-14.2.0.tar.gz : CHECKSUM(SHA256) this package : 14a2edbb509cb3e51a9a53e3f5e435dbf5971604b4b833e63e6076e8c0a997b5 CHECKSUM(SHA256) upstream package : 14a2edbb509cb3e51a9a53e3f5e435dbf5971604b4b833e63e6076e8c0a997b5 https://github.com/getsentry/sentry-native/archive/refs/tags/0.7.8/sentry-native-0.7.8.tar.gz : CHECKSUM(SHA256) this package : 2ac6497cc8d61a8d31093e47addb8c9b2c45b16b0705bb334a835b6423c318df CHECKSUM(SHA256) upstream package : 2ac6497cc8d61a8d31093e47addb8c9b2c45b16b0705bb334a835b6423c318df https://github.com/rockorager/libvaxis/archive/dc0a228a5544988d4a920cfb40be9cd28db41423/libvaxis-dc0a228a5544988d4a920cfb40be9cd28db41423.tar.gz : CHECKSUM(SHA256) this package : a058b1d7a34046de8cd5a1e55e51dcc291797e69e14ac48ad3003f2a89ea3643 CHECKSUM(SHA256) upstream package : a058b1d7a34046de8cd5a1e55e51dcc291797e69e14ac48ad3003f2a89ea3643 https://github.com/rockorager/libvaxis/archive/6d729a2dc3b934818dffe06d2ba3ce02841ed74b/libvaxis-6d729a2dc3b934818dffe06d2ba3ce02841ed74b.tar.gz : CHECKSUM(SHA256) this package : 38236ce86976aeeab97419b8b88c6cf778685f0ffe9fec75f9b2037d0183c77b CHECKSUM(SHA256) upstream package : 38236ce86976aeeab97419b8b88c6cf778685f0ffe9fec75f9b2037d0183c77b https://github.com/KhronosGroup/SPIRV-Cross/archive/476f384eb7d9e48613c45179e502a15ab95b6b49/SPIRV-Cross-476f384eb7d9e48613c45179e502a15ab95b6b49.tar.gz : CHECKSUM(SHA256) this package : b52b6fcfc45e7fa69b1f06a1362c155473444e2cc09995556b156c53ba6657e3 CHECKSUM(SHA256) upstream package : b52b6fcfc45e7fa69b1f06a1362c155473444e2cc09995556b156c53ba6657e3 https://github.com/vancluever/z2d/archive/4638bb02a9dc41cc2fb811f092811f6a951c752a/z2d-4638bb02a9dc41cc2fb811f092811f6a951c752a.tar.gz : CHECKSUM(SHA256) this package : 3f4509e7844efef5720daf9490197e4043a3ce830c10548e4dec503ffb815df7 CHECKSUM(SHA256) upstream package : 3f4509e7844efef5720daf9490197e4043a3ce830c10548e4dec503ffb815df7 https://github.com/mbadolato/iTerm2-Color-Schemes/archive/0e23daf59234fc892cba949562d7bf69204594bb/iTerm2-Color-Schemes-0e23daf59234fc892cba949562d7bf69204594bb.tar.gz : CHECKSUM(SHA256) this package : 2acc06085a83d5338192f6aab517053a6f7a4db22a86a5043a0d6ed727bf7f4b CHECKSUM(SHA256) upstream package : 2acc06085a83d5338192f6aab517053a6f7a4db22a86a5043a0d6ed727bf7f4b https://github.com/nemtrif/utfcpp/archive/refs/tags/v4.0.5/utfcpp-4.0.5.tar.gz : CHECKSUM(SHA256) this package : ffc668a310e77607d393f3c18b32715f223da1eac4c4d6e0579a11df8e6b59cf CHECKSUM(SHA256) upstream package : ffc668a310e77607d393f3c18b32715f223da1eac4c4d6e0579a11df8e6b59cf Requires -------- ghostty (rpmlib, GLIBC filtered): ghostty-terminfo ld-linux-x86-64.so.2()(64bit) libX11.so.6()(64bit) libadwaita-1.so.0()(64bit) libadwaita-1.so.0(LIBADWAITA_1_0)(64bit) libc.so.6()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-4.so.1()(64bit) libharfbuzz.so.0()(64bit) libm.so.6()(64bit) libonig.so.5()(64bit) libsimdutf.so.14()(64bit) libwayland-client.so.0()(64bit) ghostty-terminfo (rpmlib, GLIBC filtered): ncurses-base Provides -------- ghostty: application() application(com.mitchellh.ghostty.desktop) bundled(font(CodeNewRoman)) bundled(font(CozetteVector)) bundled(font(GeistMono)) bundled(font(Inconsolata)) bundled(font(JetBrainsMonoNerdFont)) bundled(font(JetBrainsMonoNoNF)) bundled(font(JuliaMono)) bundled(font(KawkabMono)) bundled(font(Lilex)) bundled(font(MonaspaceNeon)) bundled(font(NotoColorEmoji)) bundled(font(NotoEmoji)) bundled(glslang) bundled(libvaxis) bundled(libxev) bundled(mach-glfw) bundled(plasma-wayland-protocols) bundled(spirv-cross) bundled(wayland) bundled(wayland-protocols) bundled(z2d) bundled(zf) bundled(zig-js) bundled(zig-objc) bundled(zig-wayland) bundled(ziglyph) ghostty ghostty(x86-64) ghostty-terminfo: ghostty-terminfo Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name ghostty --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-42-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Haskell, SugarActivity, fonts, Ocaml, Python, Perl, Java, PHP, C/C++, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH