This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* Apache License 2.0". 1125 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/rocm- examples/licensecheck.txt [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 29971 bytes in 1 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: rocm-examples-6.3.3-1.fc43.x86_64.rpm rocm-examples-6.3.3-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpd1ls9wk7')] checks: 32, packages: 2 rocm-examples.x86_64: W: no-manual-page-for-binary applications_bitonic_sort rocm-examples.x86_64: W: no-manual-page-for-binary applications_convolution rocm-examples.x86_64: W: no-manual-page-for-binary applications_floyd_warshall rocm-examples.x86_64: W: no-manual-page-for-binary applications_histogram rocm-examples.x86_64: W: no-manual-page-for-binary applications_monte_carlo_pi rocm-examples.x86_64: W: no-manual-page-for-binary applications_prefix_sum rocm-examples.x86_64: W: no-manual-page-for-binary hip_bandwidth rocm-examples.x86_64: W: no-manual-page-for-binary hip_bit_extract rocm-examples.x86_64: W: no-manual-page-for-binary hip_cooperative_groups rocm-examples.x86_64: W: no-manual-page-for-binary hip_device_globals rocm-examples.x86_64: W: no-manual-page-for-binary hip_device_query rocm-examples.x86_64: W: no-manual-page-for-binary hip_dynamic_shared rocm-examples.x86_64: W: no-manual-page-for-binary hip_events rocm-examples.x86_64: W: no-manual-page-for-binary hip_gpu_arch rocm-examples.x86_64: W: no-manual-page-for-binary hip_hello_world rocm-examples.x86_64: W: no-manual-page-for-binary hip_hipify rocm-examples.x86_64: W: no-manual-page-for-binary hip_inline_assembly rocm-examples.x86_64: W: no-manual-page-for-binary hip_matrix_multiplication rocm-examples.x86_64: W: no-manual-page-for-binary hip_module_api rocm-examples.x86_64: W: no-manual-page-for-binary hip_moving_average rocm-examples.x86_64: W: no-manual-page-for-binary hip_multi_gpu_data_transfer rocm-examples.x86_64: W: no-manual-page-for-binary hip_occupancy rocm-examples.x86_64: W: no-manual-page-for-binary hip_runtime_compilation rocm-examples.x86_64: W: no-manual-page-for-binary hip_saxpy rocm-examples.x86_64: W: no-manual-page-for-binary hip_shared_memory rocm-examples.x86_64: W: no-manual-page-for-binary hip_streams rocm-examples.x86_64: W: no-manual-page-for-binary hip_texture_management rocm-examples.x86_64: W: no-manual-page-for-binary hip_warp_shuffle rocm-examples.x86_64: W: no-manual-page-for-binary hipblas_gemm_strided_batched rocm-examples.x86_64: W: no-manual-page-for-binary hipblas_her rocm-examples.x86_64: W: no-manual-page-for-binary hipblas_scal rocm-examples.x86_64: W: no-manual-page-for-binary hipcub_device_radix_sort rocm-examples.x86_64: W: no-manual-page-for-binary hipcub_device_sum rocm-examples.x86_64: W: no-manual-page-for-binary hipfft_plan_d2z rocm-examples.x86_64: W: no-manual-page-for-binary hipfft_plan_z2z rocm-examples.x86_64: W: no-manual-page-for-binary hipsolver_getrf rocm-examples.x86_64: W: no-manual-page-for-binary hipsolver_syevd rocm-examples.x86_64: W: no-manual-page-for-binary hipsolver_syevdx rocm-examples.x86_64: W: no-manual-page-for-binary hipsolver_syevj rocm-examples.x86_64: W: no-manual-page-for-binary hipsolver_syevj_batched rocm-examples.x86_64: W: no-manual-page-for-binary hipsolver_sygvd rocm-examples.x86_64: W: no-manual-page-for-binary hipsolver_sygvj rocm-examples.x86_64: W: no-manual-page-for-binary reduction_example_v1 rocm-examples.x86_64: W: no-manual-page-for-binary reduction_example_v2 rocm-examples.x86_64: W: no-manual-page-for-binary reduction_example_v3 rocm-examples.x86_64: W: no-manual-page-for-binary reduction_example_v4 rocm-examples.x86_64: W: no-manual-page-for-binary reduction_example_v5 rocm-examples.x86_64: W: no-manual-page-for-binary reduction_example_v6 rocm-examples.x86_64: W: no-manual-page-for-binary reduction_example_v7 rocm-examples.x86_64: W: no-manual-page-for-binary reduction_example_v8 rocm-examples.x86_64: W: no-manual-page-for-binary reduction_example_v9 rocm-examples.x86_64: W: no-manual-page-for-binary rocblas_axpy rocm-examples.x86_64: W: no-manual-page-for-binary rocblas_dot rocm-examples.x86_64: W: no-manual-page-for-binary rocblas_gemm rocm-examples.x86_64: W: no-manual-page-for-binary rocblas_gemm_strided_batched rocm-examples.x86_64: W: no-manual-page-for-binary rocblas_gemv rocm-examples.x86_64: W: no-manual-page-for-binary rocblas_her rocm-examples.x86_64: W: no-manual-page-for-binary rocblas_nrm2 rocm-examples.x86_64: W: no-manual-page-for-binary rocblas_scal rocm-examples.x86_64: W: no-manual-page-for-binary rocblas_swap rocm-examples.x86_64: W: no-manual-page-for-binary rocfft_callback rocm-examples.x86_64: W: no-manual-page-for-binary rocfft_multi_gpu rocm-examples.x86_64: W: no-manual-page-for-binary rocprim_block_sum rocm-examples.x86_64: W: no-manual-page-for-binary rocprim_device_sum rocm-examples.x86_64: W: no-manual-page-for-binary rocrand_simple_distributions_cpp rocm-examples.x86_64: W: no-manual-page-for-binary rocsolver_getf2 rocm-examples.x86_64: W: no-manual-page-for-binary rocsolver_getri rocm-examples.x86_64: W: no-manual-page-for-binary rocsolver_syev rocm-examples.x86_64: W: no-manual-page-for-binary rocsolver_syev_batched rocm-examples.x86_64: W: no-manual-page-for-binary rocsolver_syev_strided_batched rocm-examples.x86_64: W: no-manual-page-for-binary rocsparse_bsric0 rocm-examples.x86_64: W: no-manual-page-for-binary rocsparse_bsrilu0 rocm-examples.x86_64: W: no-manual-page-for-binary rocsparse_bsrmm rocm-examples.x86_64: W: no-manual-page-for-binary rocsparse_bsrmv rocm-examples.x86_64: W: no-manual-page-for-binary rocsparse_bsrsm rocm-examples.x86_64: W: no-manual-page-for-binary rocsparse_bsrsv rocm-examples.x86_64: W: no-manual-page-for-binary rocsparse_bsrxmv rocm-examples.x86_64: W: no-manual-page-for-binary rocsparse_coomv rocm-examples.x86_64: W: no-manual-page-for-binary rocsparse_csric0 rocm-examples.x86_64: W: no-manual-page-for-binary rocsparse_csrilu0 rocm-examples.x86_64: W: no-manual-page-for-binary rocsparse_csritilu0 rocm-examples.x86_64: W: no-manual-page-for-binary rocsparse_csritsv rocm-examples.x86_64: W: no-manual-page-for-binary rocsparse_csrmm rocm-examples.x86_64: W: no-manual-page-for-binary rocsparse_csrmv rocm-examples.x86_64: W: no-manual-page-for-binary rocsparse_csrsm rocm-examples.x86_64: W: no-manual-page-for-binary rocsparse_csrsv rocm-examples.x86_64: W: no-manual-page-for-binary rocsparse_ellmv rocm-examples.x86_64: W: no-manual-page-for-binary rocsparse_gebsrmm rocm-examples.x86_64: W: no-manual-page-for-binary rocsparse_gebsrmv rocm-examples.x86_64: W: no-manual-page-for-binary rocsparse_gemmi rocm-examples.x86_64: W: no-manual-page-for-binary rocsparse_gemvi rocm-examples.x86_64: W: no-manual-page-for-binary rocsparse_gpsv rocm-examples.x86_64: W: no-manual-page-for-binary rocsparse_gtsv rocm-examples.x86_64: W: no-manual-page-for-binary rocsparse_sddmm rocm-examples.x86_64: W: no-manual-page-for-binary rocsparse_spitsv rocm-examples.x86_64: W: no-manual-page-for-binary rocsparse_spmv rocm-examples.x86_64: W: no-manual-page-for-binary rocsparse_spsm rocm-examples.x86_64: W: no-manual-page-for-binary rocsparse_spsv rocm-examples.x86_64: W: no-manual-page-for-binary rocthrust_device_ptr rocm-examples.x86_64: W: no-manual-page-for-binary rocthrust_norm rocm-examples.x86_64: W: no-manual-page-for-binary rocthrust_reduce_sum rocm-examples.x86_64: W: no-manual-page-for-binary rocthrust_remove_points rocm-examples.x86_64: W: no-manual-page-for-binary rocthrust_saxpy rocm-examples.x86_64: W: no-manual-page-for-binary rocthrust_vectors rocm-examples.spec: W: no-%check-section 2 packages and 0 specfiles checked; 0 errors, 105 warnings, 7 filtered, 0 badness; has taken 6.1 s Rpmlint (debuginfo) ------------------- Checking: rocm-examples-debuginfo-6.3.3-1.fc43.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp1vus54tz')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 211 filtered, 0 badness; has taken 4.5 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "rocm-examples". (none): E: there is no installed rpm "rocm-examples-debuginfo". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/ROCm/rocm-examples/archive/rocm-6.3.3.tar.gz#/rocm-examples-6.3.3.tar.gz : CHECKSUM(SHA256) this package : 5e5bdffb4bf56d30c5f8dd8fda95d162362d17e446396e6b6a3afe8d293039f3 CHECKSUM(SHA256) upstream package : 5e5bdffb4bf56d30c5f8dd8fda95d162362d17e446396e6b6a3afe8d293039f3 Requires -------- rocm-examples (rpmlib, GLIBC filtered): libamdhip64.so.6()(64bit) libamdhip64.so.6(hip_4.2)(64bit) libamdhip64.so.6(hip_6.0)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) libhipblas.so.2()(64bit) libhipfft.so.0()(64bit) libhiprand.so.1()(64bit) libhiprtc.so.6()(64bit) libhipsolver.so.0()(64bit) libm.so.6()(64bit) librocblas.so.4()(64bit) librocfft.so.0()(64bit) librocrand.so.1()(64bit) librocsolver.so.0()(64bit) librocsparse.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) Provides -------- rocm-examples: rocm-examples rocm-examples(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name rocm-examples --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: PHP, R, Java, fonts, Haskell, Perl, Ocaml, Python, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH