This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/chatterino2 See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "BSD 3-Clause License", "*No copyright* MIT License", "Boost Software License 1.0", "*No copyright* Boost Software License 1.0", "MIT No Attribution and/or The Unlicense", "*No copyright* Apache License 2.0", "MIT No Attribution", "OpenSSL License", "GNU Lesser General Public License, Version 3", "*No copyright* BSD 2-Clause License", "BSD 3-Clause License and/or JSON License and/or MIT License", "MIT License and/or The Unlicense", "*No copyright* The Unlicense". 1588 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/chatterino2/licensecheck.txt [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 57549 bytes in 9 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: chatterino2-2.5.2-1.fc42.x86_64.rpm chatterino2-2.5.2-1.fc42.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpw1wo30qe')] checks: 32, packages: 2 chatterino2.src: E: spelling-error ('tv', '%description -l en_US tv -> TV, tb, t') chatterino2.x86_64: E: spelling-error ('tv', '%description -l en_US tv -> TV, tb, t') chatterino2.x86_64: W: no-manual-page-for-binary chatterino chatterino2.src: W: invalid-license zlib chatterino2.x86_64: W: invalid-license zlib chatterino2.x86_64: W: files-duplicate /usr/share/icons/hicolor/256x256/apps/com.chatterino.chatterino.png /usr/share/icons/hicolor/256x256/apps/chatterino.png 2 packages and 0 specfiles checked; 2 errors, 4 warnings, 7 filtered, 2 badness; has taken 0.6 s Rpmlint (debuginfo) ------------------- Checking: chatterino2-debuginfo-2.5.2-1.fc42.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpvdp_qspc')] checks: 32, packages: 1 chatterino2-debuginfo.x86_64: W: invalid-license zlib 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 5 filtered, 0 badness; has taken 2.6 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "chatterino2". (none): E: there is no installed rpm "chatterino2-debuginfo". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/martinmoene/expected-lite/archive/5b5caad7cd57d5ba3ca796bf1521b131d73ca405/expected-lite-5b5caad.tar.gz : CHECKSUM(SHA256) this package : b370637186a19e3a21a55babe8962966572ccd7fb29d8f89551f876993b7063c CHECKSUM(SHA256) upstream package : b370637186a19e3a21a55babe8962966572ccd7fb29d8f89551f876993b7063c https://github.com/mackron/miniaudio/archive/4a5b74bef029b3592c54b6048650ee5f972c1a48/miniaudio-4a5b74b.tar.gz : CHECKSUM(SHA256) this package : aacb63f571608210e69c5562eb8a9e3d1cb936bdee7a2eb8ffbc40f63888d8e8 CHECKSUM(SHA256) upstream package : aacb63f571608210e69c5562eb8a9e3d1cb936bdee7a2eb8ffbc40f63888d8e8 https://github.com/arsenm/sanitizers-cmake/archive/0573e2ea8651b9bb3083f193c41eb086497cc80a/sanitizers-cmake-0573e2e.tar.gz : CHECKSUM(SHA256) this package : 8788e94b71e08a58442f8e73d9cf718cdd9eb21ffc3d8f7ee2e5fed7a10c2d32 CHECKSUM(SHA256) upstream package : 8788e94b71e08a58442f8e73d9cf718cdd9eb21ffc3d8f7ee2e5fed7a10c2d32 https://github.com/Neargye/magic_enum/archive/e55b9b54d5cf61f8e117cafb17846d7d742dd3b4/magic_enum-e55b9b5.tar.gz : CHECKSUM(SHA256) this package : bdb15ee58b44988a493b514194ca7e770b7c69d8af0c93d4447bcfa5fc044e3a CHECKSUM(SHA256) upstream package : bdb15ee58b44988a493b514194ca7e770b7c69d8af0c93d4447bcfa5fc044e3a https://github.com/pajlada/serialize/archive/17946d65a41a72b447da37df6e314cded9650c32/serialize-17946d6.tar.gz : CHECKSUM(SHA256) this package : d33129527018ea5dc46abf97009a4417c0e219c46e4db87d4dd4ce146ac45f63 CHECKSUM(SHA256) upstream package : d33129527018ea5dc46abf97009a4417c0e219c46e4db87d4dd4ce146ac45f63 https://github.com/pajlada/signals/archive/d06770649a7e83db780865d09c313a876bf0f4eb/signals-d067706.tar.gz : CHECKSUM(SHA256) this package : ee0291c3efafa71eb50d671c807f069737fec798706f11d2ba407fb296c3c0df CHECKSUM(SHA256) upstream package : ee0291c3efafa71eb50d671c807f069737fec798706f11d2ba407fb296c3c0df https://github.com/pajlada/settings/archive/9e9c2f65f4ae195a96329a90fd6ae24c24fb8f2f/settings-9e9c2f6.tar.gz : CHECKSUM(SHA256) this package : cdd9fcdab5554b3b5ff60995101735486f72883b3246e944dbe30dca24e12d8f CHECKSUM(SHA256) upstream package : cdd9fcdab5554b3b5ff60995101735486f72883b3246e944dbe30dca24e12d8f https://github.com/Chatterino/libcommuni/archive/2979eb96262756047a8dca47f2e509168138c0d0/libcommuni-2979eb9.tar.gz : CHECKSUM(SHA256) this package : 6da5abb774f5f2474ef198ace5db45529ef88eb003fdef0be128fef212fd720b CHECKSUM(SHA256) upstream package : 6da5abb774f5f2474ef198ace5db45529ef88eb003fdef0be128fef212fd720b https://github.com/Chatterino/chatterino2/archive/v2.5.2/chatterino2-2.5.2.tar.gz : CHECKSUM(SHA256) this package : f399a73638d474491e97429d1677409caf32a8f3544f713693370513903b6b7f CHECKSUM(SHA256) upstream package : f399a73638d474491e97429d1677409caf32a8f3544f713693370513903b6b7f Requires -------- chatterino2 (rpmlib, GLIBC filtered): hicolor-icon-theme libQt6Core.so.6()(64bit) libQt6Core.so.6(Qt_6)(64bit) libQt6Core.so.6(Qt_6.9)(64bit) libQt6Core5Compat.so.6()(64bit) libQt6Core5Compat.so.6(Qt_6)(64bit) libQt6Gui.so.6()(64bit) libQt6Gui.so.6(Qt_6)(64bit) libQt6Network.so.6()(64bit) libQt6Network.so.6(Qt_6)(64bit) libQt6Widgets.so.6()(64bit) libQt6Widgets.so.6(Qt_6)(64bit) libc.so.6()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libqt6keychain.so.1()(64bit) libssl.so.3()(64bit) libssl.so.3(OPENSSL_3.0.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) qt6-qtimageformats qt6-qtsvg rtld(GNU_HASH) Provides -------- chatterino2: application() application(com.chatterino.chatterino.desktop) bundled(expected-lite) bundled(libcommuni) bundled(magic_enum) bundled(miniaudio) bundled(sanitizers-cmake) bundled(serialize) bundled(settings) bundled(signals) chatterino2 chatterino2(x86-64) metainfo() metainfo(com.chatterino.chatterino.appdata.xml) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name chatterino2 --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-42-x86_64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: Perl, fonts, Python, Ocaml, Haskell, SugarActivity, Java, R, PHP Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH