This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License", "*No copyright* Apache License 2.0", "*No copyright* The Unlicense", "zlib License", "*No copyright* Mozilla Public License 2.0", "Apache License 2.0", "ISC License", "BSD 2-Clause License", "BSD 0-Clause License", "BSD 3-Clause License", "*No copyright* Boost Software License 1.0", "Unicode License Agreement - Data Files and Software (2016)", "Apache License 2.0 and/or BSD 3-Clause License", "*No copyright* Apache License", "Boost Software License 1.0", "ISC License and/or MIT License", "*No copyright* Creative Commons Attribution 4.0 and/or MIT License", "The Perl 5 License", "Apache License 2.0 and/or MIT License", "CNRI Python Open Source GPL Compatible License Agreement", "*No copyright* Apache License (v2.0) or MIT license", "Apache License 2.0 and/or GNU Lesser General Public License v2.1 or later and/or MIT License", "Apache License (v2.0) or MIT license", "GNU General Public License", "GNU General Public License v3.0 or later", "Apache License 2.0 [generated file]", "Apache License 2.0 and/or Boost Software License 1.0", "Boost Software License 1.0 and/or MIT License", "BSD 3-Clause License [generated file]", "*No copyright* GNU General Public License, Version 2", "Apache License 2.0 and/or GNU Affero General Public License v3.0 and/or MIT License". 29270 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/redisearch/licensecheck.txt [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled() if unbundling is not possible. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 24191 bytes in 4 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: redisearch-1.0.0-1.fc44.x86_64.rpm redisearch-1.0.0-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpzu_v3iln')] checks: 32, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 14 filtered, 0 badness; has taken 7.4 s Rpmlint (debuginfo) ------------------- Checking: redisearch-debuginfo-1.0.0-1.fc44.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp0xx4mjq8')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 26 filtered, 0 badness; has taken 2.4 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "redisearch-debuginfo". (none): E: there is no installed rpm "redisearch". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Unversioned so-files -------------------- redisearch: /usr/lib64/redis/modules/libVectorSimilarity.so redisearch: /usr/lib64/redis/modules/libVectorSimilaritySpaces.so redisearch: /usr/lib64/redis/modules/libVectorSimilaritySpaces_no_optimization.so redisearch: /usr/lib64/redis/modules/libcpu_features.so redisearch: /usr/lib64/redis/modules/redisearch.so Source checksums ---------------- https://github.com/AngelYanev/redisearch-rpm/releases/download/v8.6.0/redisearch-8.6.0.tar.gz : CHECKSUM(SHA256) this package : d687d4faad7047ba1213920740cac5260d241da9ff0c867f7771c90811902e48 CHECKSUM(SHA256) upstream package : d687d4faad7047ba1213920740cac5260d241da9ff0c867f7771c90811902e48 https://github.com/AngelYanev/redisearch-rpm/releases/download/v8.6.0/redisearch-vendor-8.6.0.tar.gz : CHECKSUM(SHA256) this package : 32c6defca0f3aea2e61231b6f929e6e6dd4612adac20d626a5569d252eb71bcd CHECKSUM(SHA256) upstream package : 32c6defca0f3aea2e61231b6f929e6e6dd4612adac20d626a5569d252eb71bcd https://github.com/google/cpu_features/archive/refs/tags/v0.10.1.tar.gz#/cpu_features-0.10.1.tar.gz : CHECKSUM(SHA256) this package : 52639b380fced11d738f8b151dbfee63fb94957731d07f1966c812e5b90cbad4 CHECKSUM(SHA256) upstream package : 52639b380fced11d738f8b151dbfee63fb94957731d07f1966c812e5b90cbad4 https://github.com/jfalcou/eve/archive/refs/tags/v2023.02.15.tar.gz#/eve-2023.02.15.tar.gz : CHECKSUM(SHA256) this package : 7a5fb59c0e6ef3bef3e8b36d62e138d31e7f2a9f1bdfe95a8e96512b207f84c5 CHECKSUM(SHA256) upstream package : 7a5fb59c0e6ef3bef3e8b36d62e138d31e7f2a9f1bdfe95a8e96512b207f84c5 https://github.com/Tessil/robin-map/archive/refs/tags/v1.4.0.tar.gz#/robin-map-1.4.0.tar.gz : CHECKSUM(SHA256) this package : 7930dbf9634acfc02686d87f615c0f4f33135948130b8922331c16d90a03250c CHECKSUM(SHA256) upstream package : 7930dbf9634acfc02686d87f615c0f4f33135948130b8922331c16d90a03250c https://github.com/fmtlib/fmt/archive/refs/tags/11.2.0.tar.gz#/fmt-11.2.0.tar.gz : CHECKSUM(SHA256) this package : bc23066d87ab3168f27cef3e97d545fa63314f5c79df5ea444d41d56f962c6af CHECKSUM(SHA256) upstream package : bc23066d87ab3168f27cef3e97d545fa63314f5c79df5ea444d41d56f962c6af https://github.com/gabime/spdlog/archive/refs/tags/v1.15.3.tar.gz#/spdlog-1.15.3.tar.gz : CHECKSUM(SHA256) this package : 15a04e69c222eb6c01094b5c7ff8a249b36bb22788d72519646fb85feb267e67 CHECKSUM(SHA256) upstream package : 15a04e69c222eb6c01094b5c7ff8a249b36bb22788d72519646fb85feb267e67 https://github.com/marzer/tomlplusplus/archive/refs/tags/v3.3.0.tar.gz#/tomlplusplus-3.3.0.tar.gz : CHECKSUM(SHA256) this package : fc1a5eb410f3c67e90e5ad1264a1386d020067cfb01b633cc8c0441789aa6cf2 CHECKSUM(SHA256) upstream package : fc1a5eb410f3c67e90e5ad1264a1386d020067cfb01b633cc8c0441789aa6cf2 Requires -------- redisearch (rpmlib, GLIBC filtered): (redis >= 8.5 with redis < 8.7) config(redisearch) ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libgcc_s.so.1(GCC_4.2.0)(64bit) libm.so.6()(64bit) libssl.so.3()(64bit) libssl.so.3(OPENSSL_3.0.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.7)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) Provides -------- redisearch: bundled(RedisModulesSDK) bundled(VectorSimilarity) bundled(cndict) bundled(cpu_features) bundled(crate(buffer)) bundled(crate(build_utils)) bundled(crate(c_ffi_utils)) bundled(crate(document)) bundled(crate(document_ffi)) bundled(crate(ffi)) bundled(crate(field)) bundled(crate(fnv)) bundled(crate(fnv_ffi)) bundled(crate(inverted_index)) bundled(crate(inverted_index_ffi)) bundled(crate(iterators_ffi)) bundled(crate(low_memory_thin_vec)) bundled(crate(low_memory_thin_vec_ffi)) bundled(crate(module_init_ffi)) bundled(crate(nix)) bundled(crate(qint)) bundled(crate(query_error)) bundled(crate(query_error_ffi)) bundled(crate(redis-module)) bundled(crate(redis-module-macros-internals)) bundled(crate(redisearch_rs)) bundled(crate(result_processor)) bundled(crate(result_processor_ffi)) bundled(crate(rlookup)) bundled(crate(rlookup_ffi)) bundled(crate(rqe_iterators)) bundled(crate(rqe_iterators_interop)) bundled(crate(search_result)) bundled(crate(search_result_ffi)) bundled(crate(slots_tracker)) bundled(crate(slots_tracker_ffi)) bundled(crate(sorting_vector)) bundled(crate(sorting_vector_ffi)) bundled(crate(tracing_redismodule)) bundled(crate(trie_rs)) bundled(crate(triemap_ffi)) bundled(crate(types_ffi)) bundled(crate(value)) bundled(crate(value_ffi)) bundled(crate(varint)) bundled(crate(varint_ffi)) bundled(crate(wildcard)) bundled(crate(workspace_hack)) bundled(eve) bundled(fast_float) bundled(fmt) bundled(friso) bundled(geohash) bundled(hiredis) bundled(libuv) bundled(miniz) bundled(nunicode) bundled(phonetics) bundled(readies) bundled(rmutil) bundled(robin-map) bundled(s2geometry) bundled(snowball) bundled(spdlog) bundled(thpool) bundled(tomlplusplus) config(redisearch) redisearch redisearch(x86-64) Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name redisearch --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-44-x86_64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: Java, Python, PHP, SugarActivity, Haskell, fonts, Ocaml, Perl, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH