class Railroader::CheckSkipBeforeFilter
At the moment, this looks for
skip_before_filter :verify_authenticity_token, :except => [...]
which is essentially a blacklist approach (no actions are checked EXCEPT the ones listed) versus a whitelist approach (ONLY the actions listed will skip the check)
Public Instance Methods
process_skip_filter(filter, controller)
click to toggle source
# File lib/railroader/checks/check_skip_before_filter.rb, line 23 def process_skip_filter filter, controller case skip_except_value filter when :verify_authenticity_token warn :class => controller.name, # ugh this should be a controller warning, too :warning_type => "Cross-Site Request Forgery", :warning_code => :csrf_blacklist, :message => "Use whitelist (:only => [..]) when skipping CSRF check", :code => filter, :confidence => :medium, :file => controller.file when :login_required, :authenticate_user!, :require_user warn :controller => controller.name, :warning_code => :auth_blacklist, :warning_type => "Authentication", :message => "Use whitelist (:only => [..]) when skipping authentication", :code => filter, :confidence => :medium, :link => "authentication_whitelist", :file => controller.file end end
run_check()
click to toggle source
# File lib/railroader/checks/check_skip_before_filter.rb, line 15 def run_check tracker.controllers.each do |_name, controller| controller.skip_filters.each do |filter| process_skip_filter filter, controller end end end
skip_except_value(filter)
click to toggle source
# File lib/railroader/checks/check_skip_before_filter.rb, line 46 def skip_except_value filter return false unless call? filter first_arg = filter.first_arg last_arg = filter.last_arg if symbol? first_arg and hash? last_arg if hash_access(last_arg, :except) return first_arg.value end end false end