class RuboCop::Cop::Chef::Modernize::RespondToInMetadata

It is not longer necessary respond_to?(:foo) or defined?(foo) in metadata. This was used to support new metadata methods in Chef 11 and early versions of Chef 12.

@example

#### incorrect
chef_version '>= 13' if respond_to?(:chef_version)
chef_version '>= 13' if defined?(chef_version)
chef_version '>= 13' unless defined?(Ridley::Chef::Cookbook::Metadata)
if defined(chef_version)
  chef_version '>= 13'
end

#### correct
chef_version '>= 13'

Constants

MSG

Public Instance Methods

on_defined?(node) click to toggle source
# File lib/rubocop/cop/chef/modernize/respond_to_metadata.rb, line 59
def on_defined?(node)
  # When the if statement is if modifier like `foo if respond_to?(:foo)` then
  # node.if_branch is the actual method call we want to extract.
  # If a series of metadata methods are wrapped in an if statement then the content we want
  # is a block under the if statement and node.parent.if_branch can get us that block
  node = node.parent if node.parent.conditional? # we want the whole conditional statement
  add_offense(node, severity: :refactor) do |corrector|
    corrector.replace(node, node.if_branch.source)
  end
end
on_if(node) click to toggle source
# File lib/rubocop/cop/chef/modernize/respond_to_metadata.rb, line 45
def on_if(node)
  if_respond_to?(node) do
    add_offense(node, severity: :refactor) do |corrector|
      # When the if statement is if modifier like `foo if respond_to?(:foo)` then
      # node.if_branch is the actual method call we want to extract.
      # If a series of metadata methods are wrapped in an if statement then the content we want
      # is a block under the if statement and node.parent.if_branch can get us that block
      node = node.parent unless node.if_type?

      corrector.replace(node, node.if_branch.source)
    end
  end
end