class RubbyCop::Cop::Style::ParenthesesAroundCondition

This cop checks for the presence of superfluous parentheses around the condition of if/unless/while/until.

Public Instance Methods

on_if(node) click to toggle source
# File lib/rubbycop/cop/style/parentheses_around_condition.rb, line 12
def on_if(node)
  return if node.ternary?

  process_control_op(node)
end
on_until(node) click to toggle source
# File lib/rubbycop/cop/style/parentheses_around_condition.rb, line 22
def on_until(node)
  process_control_op(node)
end
on_while(node) click to toggle source
# File lib/rubbycop/cop/style/parentheses_around_condition.rb, line 18
def on_while(node)
  process_control_op(node)
end

Private Instance Methods

message(node) click to toggle source
# File lib/rubbycop/cop/style/parentheses_around_condition.rb, line 48
def message(node)
  kw = node.keyword
  article = kw == 'while' ? 'a' : 'an'
  "Don't use parentheses around the condition of #{article} `#{kw}`."
end
modifier_op?(node) click to toggle source
# File lib/rubbycop/cop/style/parentheses_around_condition.rb, line 40
def modifier_op?(node)
  return false if node.if_type? && node.ternary?
  return true if node.rescue_type?

  MODIFIER_NODES.include?(node.type) &&
    node.modifier_form?
end
process_control_op(node) click to toggle source
# File lib/rubbycop/cop/style/parentheses_around_condition.rb, line 28
def process_control_op(node)
  cond = node.condition

  return unless cond.begin_type?
  return if cond.children.empty?
  return if modifier_op?(cond.children.first)
  return if parens_required?(node.children.first)
  return if safe_assignment?(cond) && safe_assignment_allowed?

  add_offense(cond, :expression, message(node))
end