class RubbyCop::Cop::Lint::LiteralInCondition
This cop checks for literals used as the conditions or as operands in and/or expressions serving as the conditions of if/while/until.
@example
# bad if 20 do_something end
@example
# bad if some_var && true do_something end
@example
# good if some_var && some_condition do_something end
Constants
- MSG
Public Instance Methods
message(node)
click to toggle source
# File lib/rubbycop/cop/lint/literal_in_condition.rb, line 68 def message(node) format(MSG, node.source) end
on_case(case_node)
click to toggle source
# File lib/rubbycop/cop/lint/literal_in_condition.rb, line 56 def on_case(case_node) if case_node.condition check_case(case_node) else case_node.each_when do |when_node| next unless when_node.conditions.all?(&:literal?) add_offense(when_node, :expression) end end end
on_if(node)
click to toggle source
# File lib/rubbycop/cop/lint/literal_in_condition.rb, line 36 def on_if(node) check_for_literal(node) end
on_until(node)
click to toggle source
# File lib/rubbycop/cop/lint/literal_in_condition.rb, line 48 def on_until(node) check_for_literal(node) end
on_until_post(node)
click to toggle source
# File lib/rubbycop/cop/lint/literal_in_condition.rb, line 52 def on_until_post(node) check_for_literal(node) end
on_while(node)
click to toggle source
# File lib/rubbycop/cop/lint/literal_in_condition.rb, line 40 def on_while(node) check_for_literal(node) end
on_while_post(node)
click to toggle source
# File lib/rubbycop/cop/lint/literal_in_condition.rb, line 44 def on_while_post(node) check_for_literal(node) end
Private Instance Methods
basic_literal?(node)
click to toggle source
# File lib/rubbycop/cop/lint/literal_in_condition.rb, line 82 def basic_literal?(node) if node.array_type? primitive_array?(node) else node.basic_literal? end end
check_case(case_node)
click to toggle source
# File lib/rubbycop/cop/lint/literal_in_condition.rb, line 116 def check_case(case_node) condition = case_node.condition return if condition.array_type? && !primitive_array?(condition) return if condition.dstr_type? handle_node(condition) end
check_for_literal(node)
click to toggle source
# File lib/rubbycop/cop/lint/literal_in_condition.rb, line 74 def check_for_literal(node) if node.condition.literal? add_offense(node.condition, :expression) else check_node(node.condition) end end
check_node(node)
click to toggle source
# File lib/rubbycop/cop/lint/literal_in_condition.rb, line 94 def check_node(node) return unless node if node.keyword_bang? receiver, = *node handle_node(receiver) elsif LOGICAL_OPERATOR_NODES.include?(node.type) node.each_child_node { |op| handle_node(op) } elsif node.begin_type? && node.children.one? handle_node(node.children.first) end end
handle_node(node)
click to toggle source
# File lib/rubbycop/cop/lint/literal_in_condition.rb, line 108 def handle_node(node) if node.literal? add_offense(node, :expression) elsif %i[send and or begin].include?(node.type) check_node(node) end end
primitive_array?(node)
click to toggle source
# File lib/rubbycop/cop/lint/literal_in_condition.rb, line 90 def primitive_array?(node) node.children.all? { |n| basic_literal?(n) } end