class RailsBestPractices::Reviews::CheckDestroyReturnValueReview
Review
all code to make sure we either check the return value of “destroy” or use “destroy!”
Review
process:
Track which nodes are used by 'if', 'unless', '&&' nodes etc. as we pass them by. Check all "save" calls to check the return value is used by a node we have visited.
Public Instance Methods
model_classnames()
click to toggle source
# File lib/rails_best_practices/reviews/check_destroy_return_value_review.rb, line 52 def model_classnames @model_classnames ||= models.map(&:to_s) end
return_value_is_used?(node)
click to toggle source
# File lib/rails_best_practices/reviews/check_destroy_return_value_review.rb, line 46 def return_value_is_used?(node) return false unless @used_return_value_of (node == @used_return_value_of) || @used_return_value_of.include?(node) end