{ "issues": [ { "result": "fail", "text": "If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang.", "note": "No gcc, gcc-c++ or clang found in BuildRequires", "name": "CheckGccBuildRequires", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/" }, { "result": "fail", "text": "Spec file name must match the spec package %{name}, in the format %{name}.spec.", "note": "ghostty-1.0.0.spec should be ghostty.spec ", "name": "CheckSpecName", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_spec_file_naming" } ], "results": { "MUST": { "C/C++": [ { "result": "pending", "text": "Provides: bundled(gnulib) in place as required.", "note": "Sources not installed", "name": "CheckBundledGnulib", "url": "https://fedoraproject.org/wiki/Bundled_Libraries#Requirement_if_you_bundle" }, { "result": "fail", "text": "If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang.", "note": "No gcc, gcc-c++ or clang found in BuildRequires", "name": "CheckGccBuildRequires", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/" }, { "result": "pass", "text": "Package does not contain any libtool archives (.la)", "note": null, "name": "CheckLibToolArchives", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-libraries" }, { "result": "pending", "text": "Package does not contain kernel modules.", "note": null, "name": "CheckNoKernelModules", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/what-can-be-packaged/#_no_external_kernel_modules" }, { "result": "pass", "text": "Package contains no static executables.", "note": null, "name": "CheckNoStaticExecutables", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_statically_linking_executables" }, { "result": "pass", "text": "Rpath absent or only used for internal libs.", "note": null, "name": "CheckRPATH", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_beware_of_rpath" } ], "Generic": [ { "result": "pending", "text": "Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines.", "note": null, "name": "CheckApprovedLicense", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/" }, { "result": "pending", "text": "%build honors applicable compiler flags or justifies otherwise.", "note": null, "name": "CheckBuildCompilerFlags", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_compiler_flags" }, { "result": "pass", "text": "Package uses either %{buildroot} or $RPM_BUILD_ROOT", "note": null, "name": "CheckBuildrootMacros", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros" }, { "result": "pending", "text": "Package contains no bundled libraries without FPC exception.", "note": "Especially check following dirs for bundled code: /var/lib/copr-rpmbuild/results/ghostty/upstream-unpacked/Source0/ghostty-1.0.0/include, /var/lib/copr-rpmbuild/results/ghostty/upstream-unpacked/Source0/ghostty-1.0.0/.zig-cache/p/1220446be831adcca918167647c06c7b825849fa3fba5f22da394667974537a9c77e/include, /var/lib/copr-rpmbuild/results/ghostty/upstream-unpacked/Source0/ghostty-1.0.0/pkg/libxml2/override/include, /var/lib/copr-rpmbuild/results/ghostty/upstream-unpacked/Source0/ghostty-1.0.0/.zig-cache/p/1220446be831adcca918167647c06c7b825849fa3fba5f22da394667974537a9c77e/external, /var/lib/copr-rpmbuild/results/ghostty/upstream-unpacked/Source0/ghostty-1.0.0/.zig-cache/p/12206029de146b685739f69b10a6f08baee86b3d0a5f9a659fa2b2b66c9602078bbf/include, /var/lib/copr-rpmbuild/results/ghostty/upstream-unpacked/Source0/ghostty-1.0.0/ghostty-source/pkg/breakpad/vendor/third_party, /var/lib/copr-rpmbuild/results/ghostty/upstream-unpacked/Source0/ghostty-1.0.0/pkg/breakpad/vendor/third_party, /var/lib/copr-rpmbuild/results/ghostty/upstream-unpacked/Source0/ghostty-1.0.0/ghostty-source/vendor/glad/include, /var/lib/copr-rpmbuild/results/ghostty/upstream-unpacked/Source0/ghostty-1.0.0/.zig-cache/p/1220b81f6ecfb3fd222f76cf9106fecfa6554ab07ec7fdc4124b9bb063ae2adf969d/builds/amiga/include, /var/lib/copr-rpmbuild/results/ghostty/upstream-unpacked/Source0/ghostty-1.0.0/.zig-cache/p/12201278a1a05c0ce0b6eb6026c65cd3e9247aa041b1c260324bf29cee559dd23ba1/glslang/Include, /var/lib/copr-rpmbuild/results/ghostty/upstream-unpacked/Source0/ghostty-1.0.0/.zig-cache/p/12207b7a5b538ffb7fb18f954ae17d2f8490b6e3778a9e30564ad82c58ee8da52361/include, /var/lib/copr-rpmbuild/results/ghostty/upstream-unpacked/Source0/ghostty-1.0.0/pkg/fontconfig/override/include, /var/lib/copr-rpmbuild/results/ghostty/upstream-unpacked/Source0/ghostty-1.0.0/.zig-cache/p/1220fb3b5586e8be67bc3feb34cbe749cf42a60d628d2953632c2f8141302748c8da/include, /var/lib/copr-rpmbuild/results/ghostty/upstream-unpacked/Source0/ghostty-1.0.0/.zig-cache/p/12207fd37bb8251919c112dcdd8f616a491857b34a451f7e4486490077206dc2a1ea/src/common/android/testing/include, /var/lib/copr-rpmbuild/results/ghostty/upstream-unpacked/Source0/ghostty-1.0.0/.zig-cache/p/12207fd37bb8251919c112dcdd8f616a491857b34a451f7e4486490077206dc2a1ea/src/third_party, /var/lib/copr-rpmbuild/results/ghostty/upstream-unpacked/Source0/ghostty-1.0.0/ghostty-source/pkg/fontconfig/override/include, /var/lib/copr-rpmbuild/results/ghostty/upstream-unpacked/Source0/ghostty-1.0.0/vendor/glad/include, /var/lib/copr-rpmbuild/results/ghostty/upstream-unpacked/Source0/ghostty-1.0.0/.zig-cache/p/1220bc6b9daceaf7c8c60f3c3998058045ba0c5c5f48ae255ff97776d9cd8bfc6402/examples/libs, /var/lib/copr-rpmbuild/results/ghostty/upstream-unpacked/Source0/ghostty-1.0.0/.zig-cache/p/12207fd37bb8251919c112dcdd8f616a491857b34a451f7e4486490077206dc2a1ea/src/common/android/include, /var/lib/copr-rpmbuild/results/ghostty/upstream-unpacked/Source0/ghostty-1.0.0/ghostty-source/include, /var/lib/copr-rpmbuild/results/ghostty/upstream-unpacked/Source0/ghostty-1.0.0/.zig-cache/p/12201278a1a05c0ce0b6eb6026c65cd3e9247aa041b1c260324bf29cee559dd23ba1/External, /var/lib/copr-rpmbuild/results/ghostty/upstream-unpacked/Source0/ghostty-1.0.0/.zig-cache/p/1220b81f6ecfb3fd222f76cf9106fecfa6554ab07ec7fdc4124b9bb063ae2adf969d/include, /var/lib/copr-rpmbuild/results/ghostty/upstream-unpacked/Source0/ghostty-1.0.0/.zig-cache/p/122032442d95c3b428ae8e526017fad881e7dc78eab4d558e9a58a80bfbd65a64f7d/include, /var/lib/copr-rpmbuild/results/ghostty/upstream-unpacked/Source0/ghostty-1.0.0/ghostty-source/pkg/libxml2/override/include", "name": "CheckBundledLibs", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling" }, { "result": "pending", "text": "Changelog in prescribed format.", "note": null, "name": "CheckChangelogFormat", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs" }, { "result": "pass", "text": "Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install.", "note": null, "name": "CheckCleanBuildroot", "url": "(this test has no URL)" }, { "result": "pending", "text": "Sources contain only permissible code or content.", "note": null, "name": "CheckCodeAndContent", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/what-can-be-packaged/#_impermissible_content" }, { "result": "pass", "text": "Macros in Summary, %description expandable at SRPM build time.", "note": null, "name": "CheckDescMacros", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_source_rpm_buildtime_macros" }, { "result": "pass", "text": "Package contains desktop file if it is a GUI application.", "note": null, "name": "CheckDesktopFile", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files" }, { "result": "pass", "text": "Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file.", "note": null, "name": "CheckDesktopFileInstall", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files" }, { "result": "pending", "text": "Development files must be in a -devel package", "note": null, "name": "CheckDevelFilesInDevel", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages" }, { "result": "pending", "text": "Package requires other packages for directories it uses.", "note": "No known owner of /usr/share/bat/syntaxes, /usr/share/nvim/site/ftplugin, /usr/share/bat, /usr/share/ghostty, /usr/share/nvim/site/ftdetect, /usr/share/nvim/site/syntax", "name": "CheckDirectoryRequire", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_ownership" }, { "result": "pass", "text": "Dist tag is present.", "note": null, "name": "CheckDistTag", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/DistTag/" }, { "result": "pending", "text": "Package uses nothing in %doc for runtime.", "note": null, "name": "CheckDocRuntime", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation" }, { "result": "pass", "text": "Package does not contain duplicates in %files.", "note": null, "name": "CheckFileDuplicates", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_duplicate_files" }, { "result": "pass", "text": "Permissions on files are set properly.", "note": null, "name": "CheckFilePermissions", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_permissions" }, { "result": "pending", "text": "Package complies to the Packaging Guidelines", "note": null, "name": "CheckGuidelines", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/" }, { "result": "pass", "text": "Package must not depend on deprecated() packages.", "note": null, "name": "CheckIfDepsDeprecated", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/" }, { "result": "pending", "text": "If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license.", "note": null, "name": "CheckLicensInDoc", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text" }, { "result": "pending", "text": "License field in the package spec file matches the actual license.", "note": "There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: \"Unknown or generated\", \"MIT License\", \"*No copyright* MIT License\", \"libpng License\", \"MIT License and/or The Unlicense\", \"*No copyright* MIT License and/or X11 License\", \"Apache License 2.0 and/or MIT License\", \"*No copyright* Apache License 2.0\", \"Apache License (v2.0) or MIT license\", \"Historical Permission Notice and Disclaimer - sell variant and/or MIT (old) and/or NTP License (legal disclaimer)\", \"Historical Permission Notice and Disclaimer - sell variant and/or NTP License (legal disclaimer)\", \"Historical Permission Notice and Disclaimer - sell variant and/or NTP License (legal disclaimer) [generated file]\", \"FSF Unlimited License (with License Retention) [generated file]\", \"GNU General Public License v2.0 or later [generated file]\", \"GNU General Public License v3.0 or later\", \"FSF Unlimited License (with License Retention)\", \"FSF Unlimited License [generated file]\", \"X11 License [generated file]\", \"GNU General Public License v2.0 or later\", \"BSD 3-Clause License\", \"Apache License 2.0\", \"Mozilla Public License 2.0\", \"FSF All Permissive License\", \"BSD 3-Clause License and/or Unicode License Agreement - Data Files and Software (2015)\", \"BSD 3-Clause License [generated file]\", \"*No copyright* libpng License\", \"libpng License [generated file]\", \"*No copyright* Public domain\", \"Freetype Project License\", \"MIT (old)\", \"*No copyright* CeCILL-C License\", \"BSD 2-Clause License\", \"*No copyright* Boost Software License 1.0\", \"Creative Commons Attribution 4.0\", \"Khronos License\", \"zlib License\", \"SIL Open Font License 1.1\", \"*No copyright* SIL Open Font License 1.1\", \"*No copyright* GNU General Public License v3.0 or later\", \"Historical Permission Notice and Disclaimer - sell variant\", \"*No copyright* Historical Permission Notice and Disclaimer - sell variant and/or NTP License (legal disclaimer)\", \"Historical Permission Notice and Disclaimer - sell variant and/or NTP License\", \"GNU General Public License\", \"FSF Unlimited License (with License Retention) and/or GNU General Public License and/or GNU Lesser General Public License\", \"FSF Unlimited License (with License Retention) and/or GNU General Public License, Version 2\", \"*No copyright* Creative Commons Attribution-ShareAlike 4.0\", \"*No copyright* Creative Commons Attribution-ShareAlike 3.0\", \"FSF Unlimited License (with License Retention) and/or GNU General Public License v2.0 or later\", \"Freetype Project License [generated file]\", \"GNU General Public License, Version 2\", \"GNU Lesser General Public License, Version 2.1\", \"ISC License\", \"*No copyright* The Unlicense [generated file]\", \"BSD 2-Clause License [generated file]\", \"Boost Software License 1.0\", \"*No copyright* Creative Commons Attribution 4.0\", \"*No copyright* Apache License (v2.0) or MIT license\", \"Creative Commons CC0 1.0\", \"Apache License 2.0 and/or BSD 3-Clause License\", \"Unicode License Agreement - Data Files and Software (2015)\", \"BSD 4-Clause License and/or GNU General Public License v2.0 or later [obsolete FSF postal address (Temple Place)]\", \"BSD 4-Clause License\", \"Public domain\", \"MIT Open Group variant\", \"*No copyright* W3C License\", \"NTP License\", \"*No copyright* zlib License\", \"curl License\", \"*No copyright* Clarified Artistic License\", \"*No copyright* MIT License and/or SIL Open Font License 1.1 with Reserved Font Name\", \"SIL Open Font License\", \"Apple Public Source License 2.0 and/or BSD-4-Clause (University of California-Specific)\", \"Apache License 2.0 and/or BSD 2-Clause License\", \"Apple Public Source License 2.0\", \"Freetype Project License and/or XFree86 License\", \"Apache License\", \"*No copyright* GNU General Public License\". 29514 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/ghostty/licensecheck.txt", "name": "CheckLicenseField", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_valid_license_short_names" }, { "result": "pass", "text": "The License field must be a valid SPDX expression.", "note": null, "name": "CheckLicenseFieldSPDX", "url": "https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1" }, { "result": "pending", "text": "Package consistently uses macros (instead of hard-coded directory names).", "note": null, "name": "CheckMacros", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros" }, { "result": "pass", "text": "Package use %makeinstall only when make install DESTDIR=... doesn't work.", "note": null, "name": "CheckMakeinstall", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_why_the_makeinstall_macro_should_not_be_used" }, { "result": "pass", "text": "Package is named using only allowed ASCII characters.", "note": null, "name": "CheckNameCharset", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/" }, { "result": "pending", "text": "Package is named according to the Package Naming Guidelines.", "note": null, "name": "CheckNaming", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/" }, { "result": "pending", "text": "Package does not generate any conflict.", "note": null, "name": "CheckNoConflicts", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_conflicts" }, { "result": "pass", "text": "Package does not use a name that already exists.", "note": null, "name": "CheckNoNameConflict", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names" }, { "result": "pending", "text": "Package obeys FHS, except libexecdir and /usr/target.", "note": null, "name": "CheckObeysFHS", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_filesystem_layout" }, { "result": "pending", "text": "If the package is a rename of another package, proper Obsoletes and Provides are present.", "note": null, "name": "CheckObsoletesForRename", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#renaming-or-replacing-existing-packages" }, { "result": "pending", "text": "Package must own all directories that it creates.", "note": "Directories without known owners: /usr/share/kio, /usr/share/icons/hicolor/512x512/apps, /usr/share/icons/hicolor/32x32@2, /usr/share/vim/vimfiles/syntax, /usr/share/nvim, /usr/share/icons/hicolor/16x16@2/apps, /usr/share/vim, /usr/share/icons/hicolor/512x512, /usr/share/icons/hicolor/32x32, /usr/share/terminfo/x, /usr/share/icons/hicolor, /usr/share/icons/hicolor/16x16/apps, /usr/share/bat/syntaxes, /usr/share/icons/hicolor/256x256@2, /usr/share/vim/vimfiles/ftdetect, /usr/share/icons/hicolor/128x128/apps, /usr/share/nvim/site/ftplugin, /usr/share/bat, /usr/share/ghostty, /usr/share/icons/hicolor/256x256, /usr/share/nvim/site, /usr/share/kio/servicemenus, /usr/share/vim/vimfiles, /usr/share/vim/vimfiles/ftplugin, /usr/share/icons/hicolor/256x256@2/apps, /usr/share/terminfo, /usr/share/icons/hicolor/16x16, /usr/share/nvim/site/ftdetect, /usr/share/icons/hicolor/128x128@2/apps, /usr/share/nvim/site/syntax, /usr/share/terminfo/g, /usr/share/icons/hicolor/128x128@2, /usr/share/icons/hicolor/256x256/apps, /usr/share/icons/hicolor/16x16@2, /usr/share/icons/hicolor/32x32@2/apps, /usr/share/icons/hicolor/128x128, /usr/share/icons/hicolor/32x32/apps", "name": "CheckOwnDirs", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_ownership" }, { "result": "pass", "text": "Package does not own files or directories owned by other packages.", "note": null, "name": "CheckOwnOther", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_ownership" }, { "result": "pass", "text": "Package is not relocatable.", "note": null, "name": "CheckRelocatable", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_relocatable_packages" }, { "result": "pending", "text": "Requires correct, justified where necessary.", "note": null, "name": "CheckRequires", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_requires" }, { "result": "pass", "text": "Sources used to build the package match the upstream source, as provided in the spec URL.", "note": null, "name": "CheckSourceMD5", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/" }, { "result": "pending", "text": "Spec file is legible and written in American English.", "note": null, "name": "CheckSpecLegibility", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_spec_legibility" }, { "result": "fail", "text": "Spec file name must match the spec package %{name}, in the format %{name}.spec.", "note": "ghostty-1.0.0.spec should be ghostty.spec ", "name": "CheckSpecName", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_spec_file_naming" }, { "result": "pending", "text": "Package contains systemd file(s) if in need.", "note": null, "name": "CheckSystemdScripts", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/" }, { "result": "pass", "text": "File names are valid UTF-8.", "note": null, "name": "CheckUTF8Filenames", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_non_ascii_filenames" }, { "result": "pending", "text": "Useful -debuginfo package or justification otherwise.", "note": null, "name": "CheckUsefulDebuginfo", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_debuginfo_packages" }, { "result": "pending", "text": "Package is not known to require an ExcludeArch tag.", "note": null, "name": "generic-excludearch", "url": "https://fedoraproject.org/wiki/Architectures#ExcludeArch_.26_ExclusiveArch" }, { "result": "pass", "text": "Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files.", "note": "Documentation size is 0 bytes in 0 files. ", "name": "generic-large-docs", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation" }, { "result": "pass", "text": "Packages must not store files under /srv, /opt or /usr/local", "note": null, "name": "generic-srv-opt", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation" }, { "result": "pending", "text": "Package successfully compiles and builds into binary rpms on at least one supported primary architecture.", "note": "Using prebuilt packages", "name": "CheckBuild", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_support" }, { "result": "pass", "text": "Package installs properly.", "note": null, "name": "CheckPackageInstalls", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/" }, { "result": "pass", "text": "Rpmlint is run on all rpms the build produces.", "note": "There are rpmlint messages (see attachment).", "name": "CheckRpmlint", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_use_rpmlint" } ] }, "SHOULD": { "Generic": [ { "result": "fail", "text": "Reviewer should test that the package builds in mock.", "note": null, "name": "CheckBuildInMock", "url": "https://fedoraproject.org/wiki/PackageMaintainers/MockTricks" }, { "result": "pass", "text": "Buildroot is not present", "note": null, "name": "CheckBuildroot", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/" }, { "result": "pass", "text": "Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT)", "note": null, "name": "CheckClean", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections" }, { "result": "pending", "text": "If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it.", "note": null, "name": "CheckContainsLicenseText", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text" }, { "result": "pass", "text": "No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.", "note": null, "name": "CheckFileRequires", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_dependencies" }, { "result": "pending", "text": "Final provides and requires are sane (see attachments).", "note": null, "name": "CheckFinalRequiresProvides", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/" }, { "result": "pending", "text": "Package functions as described.", "note": null, "name": "CheckFunctionAsDescribed", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/" }, { "result": "pass", "text": "Packager, Vendor, PreReq, Copyright tags should not be in spec file", "note": null, "name": "CheckIllegalSpecTags", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections" }, { "result": "pending", "text": "Latest version is packaged.", "note": null, "name": "CheckLatestVersionIsPackaged", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/" }, { "result": "pending", "text": "Package does not include license text files separate from upstream.", "note": null, "name": "CheckLicenseUpstream", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text" }, { "result": "pending", "text": "SourceX tarball generation or download is documented.", "note": "Package contains tarball without URL, check comments", "name": "CheckSourceComment", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/" }, { "result": "pass", "text": "SourceX is a working URL.", "note": null, "name": "CheckSourceUrl", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/" }, { "result": "pending", "text": "Sources are verified with gpgverify first in %prep if upstream publishes signatures.", "note": "gpgverify is not used.", "name": "CheckSourceVerification", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_source_file_verification" }, { "result": "pending", "text": "Package should compile and build into binary rpms on all supported architectures.", "note": null, "name": "CheckSupportAllArchs", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_support" }, { "result": "pending", "text": "%check is present and all tests pass.", "note": null, "name": "CheckTestSuites", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_test_suites" }, { "result": "pending", "text": "Packages should try to preserve timestamps of original installed files.", "note": null, "name": "CheckTimeStamps", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_timestamps" }, { "result": "pass", "text": "Spec use %global instead of %define unless justified.", "note": null, "name": "CheckUseGlobal", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_global_preferred_over_define" } ] }, "EXTRA": { "Generic": [ { "result": "pending", "text": "Large data in /usr/share should live in a noarch subpackage if package is arched.", "note": "Arch-ed rpms have a total of 1382400 bytes in /usr/share ", "name": "generic-large-data", "url": "https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines" }, { "result": "pass", "text": "Rpmlint is run on all installed packages.", "note": "No rpmlint messages.", "name": "CheckRpmlintInstalled", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_use_rpmlint" }, { "result": "fail", "text": "Spec file according to URL is the same as in SRPM.", "note": "Bad spec filename: /var/lib/copr-rpmbuild/results/ghostty/srpm-unpacked/ghostty-1.0.0.spec", "name": "CheckSpecAsInSRPM", "url": "(this test has no URL)" } ] } }, "attachments": [ { "header": "Rpmlint", "text": "Checking: ghostty-1.0.0-1.fc41.x86_64.rpm\n ghostty-1.0.0-1.fc41.src.rpm\n============================ rpmlint session starts ============================\nrpmlint: 2.5.0\nconfiguration:\n /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml\n /etc/xdg/rpmlint/fedora-spdx-licenses.toml\n /etc/xdg/rpmlint/fedora.toml\n /etc/xdg/rpmlint/scoring.toml\n /etc/xdg/rpmlint/users-groups.toml\n /etc/xdg/rpmlint/warn-on-functions.toml\nrpmlintrc: [PosixPath('/tmp/tmpqe9ixage')]\nchecks: 32, packages: 2\n\nghostty-1.0.0.spec:68: W: macro-in-comment %fdupes\nghostty-1.0.0.spec:119: W: macro-in-comment %license\nghostty-1.0.0.spec: W: invalid-url Source0: ghostty-1.0.0.tar.gz\nghostty.src: E: invalid-spec-name\nghostty.src: W: inconsistent-file-extension ghostty-1.0.0.tar.gz\nghostty.x86_64: W: hidden-file-or-dir /usr/share/ghostty/shell-integration/zsh/.zshenv\nghostty.x86_64: W: cross-directory-hard-link /usr/share/icons/hicolor/512x512/apps/com.mitchellh.ghostty.png /usr/share/icons/hicolor/256x256@2/apps/com.mitchellh.ghostty.png\nghostty.x86_64: W: cross-directory-hard-link /usr/share/terminfo/x/xterm-ghostty /usr/share/terminfo/g/ghostty\nghostty.x86_64: W: cross-directory-hard-link /usr/share/vim/vimfiles/ftdetect/ghostty.vim /usr/share/nvim/site/ftdetect/ghostty.vim\nghostty.x86_64: W: cross-directory-hard-link /usr/share/vim/vimfiles/ftplugin/ghostty.vim /usr/share/nvim/site/ftplugin/ghostty.vim\nghostty.x86_64: W: cross-directory-hard-link /usr/share/vim/vimfiles/syntax/ghostty.vim /usr/share/nvim/site/syntax/ghostty.vim\n 2 packages and 0 specfiles checked; 1 errors, 10 warnings, 7 filtered, 1 badness; has taken 3.1 s \n\n\n" }, { "header": "Rpmlint (installed packages)", "text": "============================ rpmlint session starts ============================\nrpmlint: 2.5.0\nconfiguration:\n /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml\n /etc/xdg/rpmlint/fedora-spdx-licenses.toml\n /etc/xdg/rpmlint/fedora.toml\n /etc/xdg/rpmlint/scoring.toml\n /etc/xdg/rpmlint/users-groups.toml\n /etc/xdg/rpmlint/warn-on-functions.toml\nchecks: 32, packages: 1\n\n 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s \n(none): E: there is no installed rpm \"ghostty\".\nThere are no files to process nor additional arguments.\nNothing to do, aborting.\n\n" }, { "header": "", "text": "Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24\nCommand line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name ghostty --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg\nBuildroot used: fedora-41-x86_64\nActive plugins: Generic, C/C++, Shell-api\nDisabled plugins: fonts, Ocaml, Python, Perl, R, Haskell, Java, PHP, SugarActivity\nDisabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH\n" }, { "header": "Requires", "text": "ghostty (rpmlib, GLIBC filtered):\n ld-linux-x86-64.so.2()(64bit)\n libadwaita-1.so.0()(64bit)\n libadwaita-1.so.0(LIBADWAITA_1_0)(64bit)\n libc.so.6()(64bit)\n libfontconfig.so.1()(64bit)\n libfreetype.so.6()(64bit)\n libgio-2.0.so.0()(64bit)\n libglib-2.0.so.0()(64bit)\n libgobject-2.0.so.0()(64bit)\n libgtk-4.so.1()(64bit)\n libharfbuzz.so.0()(64bit)\n libm.so.6()(64bit)\n libonig.so.5()(64bit)\n\n" }, { "header": "Provides", "text": "ghostty:\n application()\n application(com.mitchellh.ghostty.desktop)\n ghostty\n ghostty(x86-64)\n\n" } ] }