This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Spec file name must match the spec package %{name}, in the format %{name}.spec. Note: ghostty-1.0.0.spec should be ghostty.spec See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_spec_file_naming ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [ ]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License", "libpng License", "MIT License and/or The Unlicense", "*No copyright* MIT License and/or X11 License", "Apache License 2.0 and/or MIT License", "*No copyright* Apache License 2.0", "Apache License (v2.0) or MIT license", "Historical Permission Notice and Disclaimer - sell variant and/or MIT (old) and/or NTP License (legal disclaimer)", "Historical Permission Notice and Disclaimer - sell variant and/or NTP License (legal disclaimer)", "Historical Permission Notice and Disclaimer - sell variant and/or NTP License (legal disclaimer) [generated file]", "FSF Unlimited License (with License Retention) [generated file]", "GNU General Public License v2.0 or later [generated file]", "GNU General Public License v3.0 or later", "FSF Unlimited License (with License Retention)", "FSF Unlimited License [generated file]", "X11 License [generated file]", "GNU General Public License v2.0 or later", "BSD 3-Clause License", "Apache License 2.0", "Mozilla Public License 2.0", "FSF All Permissive License", "BSD 3-Clause License and/or Unicode License Agreement - Data Files and Software (2015)", "BSD 3-Clause License [generated file]", "*No copyright* libpng License", "libpng License [generated file]", "*No copyright* Public domain", "Freetype Project License", "MIT (old)", "*No copyright* CeCILL-C License", "BSD 2-Clause License", "*No copyright* Boost Software License 1.0", "Creative Commons Attribution 4.0", "Khronos License", "zlib License", "SIL Open Font License 1.1", "*No copyright* SIL Open Font License 1.1", "*No copyright* GNU General Public License v3.0 or later", "Historical Permission Notice and Disclaimer - sell variant", "*No copyright* Historical Permission Notice and Disclaimer - sell variant and/or NTP License (legal disclaimer)", "Historical Permission Notice and Disclaimer - sell variant and/or NTP License", "GNU General Public License", "FSF Unlimited License (with License Retention) and/or GNU General Public License and/or GNU Lesser General Public License", "FSF Unlimited License (with License Retention) and/or GNU General Public License, Version 2", "*No copyright* Creative Commons Attribution- ShareAlike 4.0", "*No copyright* Creative Commons Attribution- ShareAlike 3.0", "FSF Unlimited License (with License Retention) and/or GNU General Public License v2.0 or later", "Freetype Project License [generated file]", "GNU General Public License, Version 2", "GNU Lesser General Public License, Version 2.1", "ISC License", "*No copyright* The Unlicense [generated file]", "BSD 2-Clause License [generated file]", "Boost Software License 1.0", "*No copyright* Creative Commons Attribution 4.0", "*No copyright* Apache License (v2.0) or MIT license", "Creative Commons CC0 1.0", "Apache License 2.0 and/or BSD 3-Clause License", "Unicode License Agreement - Data Files and Software (2015)", "BSD 4-Clause License and/or GNU General Public License v2.0 or later [obsolete FSF postal address (Temple Place)]", "BSD 4-Clause License", "Public domain", "MIT Open Group variant", "*No copyright* W3C License", "NTP License", "*No copyright* zlib License", "curl License", "*No copyright* Clarified Artistic License", "*No copyright* MIT License and/or SIL Open Font License 1.1 with Reserved Font Name", "SIL Open Font License", "Apple Public Source License 2.0 and/or BSD-4-Clause (University of California- Specific)", "Apache License 2.0 and/or BSD 2-Clause License", "Apple Public Source License 2.0", "Freetype Project License and/or XFree86 License", "Apache License", "*No copyright* GNU General Public License". 29514 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/ghostty/licensecheck.txt [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/bat/syntaxes, /usr/share/nvim/site/ftplugin, /usr/share/bat, /usr/share/ghostty, /usr/share/nvim/site/ftdetect, /usr/share/nvim/site/syntax [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/kio, /usr/share/icons/hicolor/512x512/apps, /usr/share/icons/hicolor/32x32@2, /usr/share/vim/vimfiles/syntax, /usr/share/nvim, /usr/share/icons/hicolor/16x16@2/apps, /usr/share/vim, /usr/share/icons/hicolor/512x512, /usr/share/icons/hicolor/32x32, /usr/share/terminfo/x, /usr/share/icons/hicolor, /usr/share/icons/hicolor/16x16/apps, /usr/share/bat/syntaxes, /usr/share/icons/hicolor/256x256@2, /usr/share/vim/vimfiles/ftdetect, /usr/share/icons/hicolor/128x128/apps, /usr/share/nvim/site/ftplugin, /usr/share/bat, /usr/share/ghostty, /usr/share/icons/hicolor/256x256, /usr/share/nvim/site, /usr/share/kio/servicemenus, /usr/share/vim/vimfiles, /usr/share/vim/vimfiles/ftplugin, /usr/share/icons/hicolor/256x256@2/apps, /usr/share/terminfo, /usr/share/icons/hicolor/16x16, /usr/share/nvim/site/ftdetect, /usr/share/icons/hicolor/128x128@2/apps, /usr/share/nvim/site/syntax, /usr/share/terminfo/g, /usr/share/icons/hicolor/128x128@2, /usr/share/icons/hicolor/256x256/apps, /usr/share/icons/hicolor/16x16@2, /usr/share/icons/hicolor/32x32@2/apps, /usr/share/icons/hicolor/128x128, /usr/share/icons/hicolor/32x32/apps [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. Note: Especially check following dirs for bundled code: /var/lib/copr- rpmbuild/results/ghostty/upstream- unpacked/Source0/ghostty-1.0.0/include, /var/lib/copr- rpmbuild/results/ghostty/upstream-unpacked/Source0/ghostty-1.0.0/.zig- cache/p/1220446be831adcca918167647c06c7b825849fa3fba5f22da394667974537a9c77e/include, /var/lib/copr-rpmbuild/results/ghostty/upstream- unpacked/Source0/ghostty-1.0.0/pkg/libxml2/override/include, /var/lib/copr-rpmbuild/results/ghostty/upstream- unpacked/Source0/ghostty-1.0.0/.zig- cache/p/1220446be831adcca918167647c06c7b825849fa3fba5f22da394667974537a9c77e/external, /var/lib/copr-rpmbuild/results/ghostty/upstream- unpacked/Source0/ghostty-1.0.0/.zig- cache/p/12206029de146b685739f69b10a6f08baee86b3d0a5f9a659fa2b2b66c9602078bbf/include, /var/lib/copr-rpmbuild/results/ghostty/upstream- unpacked/Source0/ghostty-1.0.0/ghostty- source/pkg/breakpad/vendor/third_party, /var/lib/copr- rpmbuild/results/ghostty/upstream- unpacked/Source0/ghostty-1.0.0/pkg/breakpad/vendor/third_party, /var/lib/copr-rpmbuild/results/ghostty/upstream- unpacked/Source0/ghostty-1.0.0/ghostty-source/vendor/glad/include, /var/lib/copr-rpmbuild/results/ghostty/upstream- unpacked/Source0/ghostty-1.0.0/.zig- cache/p/1220b81f6ecfb3fd222f76cf9106fecfa6554ab07ec7fdc4124b9bb063ae2adf969d/builds/amiga/include, /var/lib/copr-rpmbuild/results/ghostty/upstream- unpacked/Source0/ghostty-1.0.0/.zig- cache/p/12201278a1a05c0ce0b6eb6026c65cd3e9247aa041b1c260324bf29cee559dd23ba1/glslang/Include, /var/lib/copr-rpmbuild/results/ghostty/upstream- unpacked/Source0/ghostty-1.0.0/.zig- cache/p/12207b7a5b538ffb7fb18f954ae17d2f8490b6e3778a9e30564ad82c58ee8da52361/include, /var/lib/copr-rpmbuild/results/ghostty/upstream- unpacked/Source0/ghostty-1.0.0/pkg/fontconfig/override/include, /var/lib/copr-rpmbuild/results/ghostty/upstream- unpacked/Source0/ghostty-1.0.0/.zig- cache/p/1220fb3b5586e8be67bc3feb34cbe749cf42a60d628d2953632c2f8141302748c8da/include, /var/lib/copr-rpmbuild/results/ghostty/upstream- unpacked/Source0/ghostty-1.0.0/.zig- cache/p/12207fd37bb8251919c112dcdd8f616a491857b34a451f7e4486490077206dc2a1ea/src/common/android/testing/include, /var/lib/copr-rpmbuild/results/ghostty/upstream- unpacked/Source0/ghostty-1.0.0/.zig- cache/p/12207fd37bb8251919c112dcdd8f616a491857b34a451f7e4486490077206dc2a1ea/src/third_party, /var/lib/copr-rpmbuild/results/ghostty/upstream- unpacked/Source0/ghostty-1.0.0/ghostty- source/pkg/fontconfig/override/include, /var/lib/copr- rpmbuild/results/ghostty/upstream- unpacked/Source0/ghostty-1.0.0/vendor/glad/include, /var/lib/copr- rpmbuild/results/ghostty/upstream-unpacked/Source0/ghostty-1.0.0/.zig- cache/p/1220bc6b9daceaf7c8c60f3c3998058045ba0c5c5f48ae255ff97776d9cd8bfc6402/examples/libs, /var/lib/copr-rpmbuild/results/ghostty/upstream- unpacked/Source0/ghostty-1.0.0/.zig- cache/p/12207fd37bb8251919c112dcdd8f616a491857b34a451f7e4486490077206dc2a1ea/src/common/android/include, /var/lib/copr-rpmbuild/results/ghostty/upstream- unpacked/Source0/ghostty-1.0.0/ghostty-source/include, /var/lib/copr- rpmbuild/results/ghostty/upstream-unpacked/Source0/ghostty-1.0.0/.zig- cache/p/12201278a1a05c0ce0b6eb6026c65cd3e9247aa041b1c260324bf29cee559dd23ba1/External, /var/lib/copr-rpmbuild/results/ghostty/upstream- unpacked/Source0/ghostty-1.0.0/.zig- cache/p/1220b81f6ecfb3fd222f76cf9106fecfa6554ab07ec7fdc4124b9bb063ae2adf969d/include, /var/lib/copr-rpmbuild/results/ghostty/upstream- unpacked/Source0/ghostty-1.0.0/.zig- cache/p/122032442d95c3b428ae8e526017fad881e7dc78eab4d558e9a58a80bfbd65a64f7d/include, /var/lib/copr-rpmbuild/results/ghostty/upstream- unpacked/Source0/ghostty-1.0.0/ghostty- source/pkg/libxml2/override/include [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Bad spec filename: /var/lib/copr-rpmbuild/results/ghostty/srpm- unpacked/ghostty-1.0.0.spec See: (this test has no URL) [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1382400 bytes in /usr/share [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: ghostty-1.0.0-1.fc41.x86_64.rpm ghostty-1.0.0-1.fc41.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpqe9ixage')] checks: 32, packages: 2 ghostty-1.0.0.spec:68: W: macro-in-comment %fdupes ghostty-1.0.0.spec:119: W: macro-in-comment %license ghostty-1.0.0.spec: W: invalid-url Source0: ghostty-1.0.0.tar.gz ghostty.src: E: invalid-spec-name ghostty.src: W: inconsistent-file-extension ghostty-1.0.0.tar.gz ghostty.x86_64: W: hidden-file-or-dir /usr/share/ghostty/shell-integration/zsh/.zshenv ghostty.x86_64: W: cross-directory-hard-link /usr/share/icons/hicolor/512x512/apps/com.mitchellh.ghostty.png /usr/share/icons/hicolor/256x256@2/apps/com.mitchellh.ghostty.png ghostty.x86_64: W: cross-directory-hard-link /usr/share/terminfo/x/xterm-ghostty /usr/share/terminfo/g/ghostty ghostty.x86_64: W: cross-directory-hard-link /usr/share/vim/vimfiles/ftdetect/ghostty.vim /usr/share/nvim/site/ftdetect/ghostty.vim ghostty.x86_64: W: cross-directory-hard-link /usr/share/vim/vimfiles/ftplugin/ghostty.vim /usr/share/nvim/site/ftplugin/ghostty.vim ghostty.x86_64: W: cross-directory-hard-link /usr/share/vim/vimfiles/syntax/ghostty.vim /usr/share/nvim/site/syntax/ghostty.vim 2 packages and 0 specfiles checked; 1 errors, 10 warnings, 7 filtered, 1 badness; has taken 3.1 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s (none): E: there is no installed rpm "ghostty". There are no files to process nor additional arguments. Nothing to do, aborting. Requires -------- ghostty (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) libadwaita-1.so.0()(64bit) libadwaita-1.so.0(LIBADWAITA_1_0)(64bit) libc.so.6()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-4.so.1()(64bit) libharfbuzz.so.0()(64bit) libm.so.6()(64bit) libonig.so.5()(64bit) Provides -------- ghostty: application() application(com.mitchellh.ghostty.desktop) ghostty ghostty(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name ghostty --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-41-x86_64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: fonts, Ocaml, Python, Perl, R, Haskell, Java, PHP, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH