This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - The License field must be a valid SPDX expression. Note: Not a valid SPDX expression 'GPL-3.0-only AND Zlib AND (WxWindows- exception-3.1 WITH LGPL-2.0-or-later)'. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 - Spec file name must match the spec package %{name}, in the format %{name}.spec. Note: openmw-copr.spec should be openmw.spec See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_spec_file_naming ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Unknown or generated", "zlib License", "MIT License", "Apache License 2.0 and/or MIT License", "Boost Software License 1.0". 51 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/openmw/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. Note: Especially check following dirs for bundled code: /var/lib/copr- rpmbuild/results/openmw/upstream- unpacked/Source3/recastnavigation-1.6.0/DebugUtils/Include, /var/lib/copr-rpmbuild/results/openmw/upstream- unpacked/Source3/recastnavigation-1.6.0/DetourTileCache/Include, /var/lib/copr-rpmbuild/results/openmw/upstream- unpacked/Source3/recastnavigation-1.6.0/Recast/Include, /var/lib/copr- rpmbuild/results/openmw/upstream- unpacked/Source3/recastnavigation-1.6.0/RecastDemo/Include, /var/lib/copr-rpmbuild/results/openmw/upstream- unpacked/Source3/recastnavigation-1.6.0/Detour/Include, /var/lib/copr- rpmbuild/results/openmw/upstream- unpacked/Source3/recastnavigation-1.6.0/DetourCrowd/Include [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 254606 bytes in 3 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Bad spec filename: /var/lib/copr-rpmbuild/results/openmw/srpm- unpacked/openmw-copr.spec See: (this test has no URL) [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 2682880 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: openmw-0.49.0-5.fc42.x86_64.rpm openmw-cs-0.49.0-5.fc42.x86_64.rpm openmw-tools-0.49.0-5.fc42.x86_64.rpm openmw-0.49.0-5.fc42.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp45nr71zz')] checks: 32, packages: 4 openmw.x86_64: E: zero-length /etc/openmw/defaults-cs.bin openmw-tools.x86_64: W: summary-ended-with-dot Utility programs for OpenMW. openmw.src: E: spelling-error ('roleplaying', '%description -l en_US roleplaying -> role playing, role-playing, overplaying') openmw.x86_64: E: spelling-error ('roleplaying', '%description -l en_US roleplaying -> role playing, role-playing, overplaying') openmw.x86_64: W: non-conffile-in-etc /etc/openmw/defaults-cs.bin openmw.x86_64: W: non-conffile-in-etc /etc/openmw/defaults.bin openmw.x86_64: W: non-conffile-in-etc /etc/openmw/gamecontrollerdb.txt openmw.x86_64: W: non-conffile-in-etc /etc/openmw/openmw.cfg openmw.x86_64: W: no-manual-page-for-binary openmw openmw.x86_64: W: no-manual-page-for-binary openmw-bulletobjecttool openmw.x86_64: W: no-manual-page-for-binary openmw-essimporter openmw.x86_64: W: no-manual-page-for-binary openmw-iniimporter openmw.x86_64: W: no-manual-page-for-binary openmw-launcher openmw.x86_64: W: no-manual-page-for-binary openmw-navmeshtool openmw.x86_64: W: no-manual-page-for-binary openmw-wizard openmw-cs.x86_64: W: no-manual-page-for-binary openmw-cs openmw-tools.x86_64: W: no-manual-page-for-binary bsatool openmw-tools.x86_64: W: no-manual-page-for-binary esmtool openmw-tools.x86_64: W: no-manual-page-for-binary niftest openmw-cs.x86_64: W: no-documentation openmw-tools.x86_64: W: no-documentation openmw.src: W: name-repeated-in-summary OpenMW openmw.x86_64: W: name-repeated-in-summary OpenMW openmw.src: E: invalid-spec-name openmw.src: W: invalid-license-exception LGPL-2.0-or-later openmw.x86_64: W: invalid-license-exception LGPL-2.0-or-later openmw-cs.x86_64: W: invalid-license-exception LGPL-2.0-or-later openmw-tools.x86_64: W: invalid-license-exception LGPL-2.0-or-later openmw.src: W: invalid-license WxWindows-exception-3.1 openmw.x86_64: W: invalid-license WxWindows-exception-3.1 openmw-cs.x86_64: W: invalid-license WxWindows-exception-3.1 openmw-tools.x86_64: W: invalid-license WxWindows-exception-3.1 openmw.x86_64: W: incoherent-version-in-changelog 0.49.0-1 ['0.49.0-5.fc42', '0.49.0-5'] openmw.x86_64: W: files-duplicate /usr/share/pixmaps/openmw.png /usr/share/openmw/resources/openmw.png openmw.x86_64: W: files-duplicate /usr/share/openmw/resources/translations/wizard_de.qm /usr/share/openmw/resources/translations/launcher_de.qm openmw.x86_64: W: files-duplicate /usr/share/openmw/resources/vfs/mygui/openmw_mainmenu.skin.xml /usr/share/openmw/resources/vfs/mygui/openmw_dialogue_window.skin.xml 4 packages and 0 specfiles checked; 4 errors, 32 warnings, 16 filtered, 4 badness; has taken 6.6 s Rpmlint (debuginfo) ------------------- Checking: openmw-debuginfo-0.49.0-5.fc42.x86_64.rpm openmw-tools-debuginfo-0.49.0-5.fc42.x86_64.rpm openmw-cs-debuginfo-0.49.0-5.fc42.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp26n1qslm')] checks: 32, packages: 3 openmw-cs-debuginfo.x86_64: W: invalid-license-exception LGPL-2.0-or-later openmw-debuginfo.x86_64: W: invalid-license-exception LGPL-2.0-or-later openmw-tools-debuginfo.x86_64: W: invalid-license-exception LGPL-2.0-or-later openmw-cs-debuginfo.x86_64: W: invalid-license WxWindows-exception-3.1 openmw-debuginfo.x86_64: W: invalid-license WxWindows-exception-3.1 openmw-tools-debuginfo.x86_64: W: invalid-license WxWindows-exception-3.1 3 packages and 0 specfiles checked; 0 errors, 6 warnings, 38 filtered, 0 badness; has taken 34.6 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "openmw-cs". (none): E: there is no installed rpm "openmw-tools". (none): E: there is no installed rpm "openmw-debuginfo". (none): E: there is no installed rpm "openmw-cs-debuginfo". (none): E: there is no installed rpm "openmw". (none): E: there is no installed rpm "openmw-tools-debuginfo". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 6 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/recastnavigation/recastnavigation/archive/v1.6.0/recastnavigation-1.6.0.tar.gz : CHECKSUM(SHA256) this package : d48ca0121962fa0639502c0f56c4e3ae72f98e55d88727225444f500775c0074 CHECKSUM(SHA256) upstream package : d48ca0121962fa0639502c0f56c4e3ae72f98e55d88727225444f500775c0074 https://github.com/OpenMW/osg/archive/3.6/osg-3.6.tar.gz : CHECKSUM(SHA256) this package : f77aefab6efe4690bf7aa34b3f130f5c3a27ce72eb14a413b88648df8b73448b CHECKSUM(SHA256) upstream package : f77aefab6efe4690bf7aa34b3f130f5c3a27ce72eb14a413b88648df8b73448b https://github.com/bulletphysics/bullet3/archive/3.25/bullet3-3.25.tar.gz : CHECKSUM(SHA256) this package : c45afb6399e3f68036ddb641c6bf6f552bf332d5ab6be62f7e6c54eda05ceb77 CHECKSUM(SHA256) upstream package : c45afb6399e3f68036ddb641c6bf6f552bf332d5ab6be62f7e6c54eda05ceb77 https://github.com/OpenMW/openmw/archive/openmw-0.49.0/openmw-openmw-0.49.0.tar.gz : CHECKSUM(SHA256) this package : 5f31741d61cf7c736bbe522a1a33342773c7e1b713e7e20f3717eb8da2b1733d CHECKSUM(SHA256) upstream package : 5f31741d61cf7c736bbe522a1a33342773c7e1b713e7e20f3717eb8da2b1733d Requires -------- openmw (rpmlib, GLIBC filtered): libGL.so.1()(64bit) libMyGUIEngine.so.3.4.3()(64bit) libQt6Core.so.6()(64bit) libQt6Core.so.6(Qt_6)(64bit) libQt6Core.so.6(Qt_6.9)(64bit) libQt6Gui.so.6()(64bit) libQt6Gui.so.6(Qt_6)(64bit) libQt6Svg.so.6()(64bit) libQt6Svg.so.6(Qt_6)(64bit) libQt6Widgets.so.6()(64bit) libQt6Widgets.so.6(Qt_6)(64bit) libSDL2-2.0.so.0()(64bit) libX11.so.6()(64bit) libXinerama.so.1()(64bit) libXrandr.so.2()(64bit) libavcodec.so.61()(64bit) libavcodec.so.61(LIBAVCODEC_61)(64bit) libavformat.so.61()(64bit) libavformat.so.61(LIBAVFORMAT_61)(64bit) libavutil.so.59()(64bit) libavutil.so.59(LIBAVUTIL_59)(64bit) libboost_iostreams.so.1.83.0()(64bit) libboost_program_options.so.1.83.0()(64bit) libc.so.6()(64bit) libcollada-dom2.5-dp.so.0()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libicui18n.so.76()(64bit) libicuuc.so.76()(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) libluajit-5.1.so.2()(64bit) liblz4.so.1()(64bit) libm.so.6()(64bit) libopenal.so.1()(64bit) libpng16.so.16()(64bit) libpng16.so.16(PNG16_0)(64bit) libsqlite3.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.7)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libswresample.so.5()(64bit) libswresample.so.5(LIBSWRESAMPLE_5)(64bit) libswscale.so.8()(64bit) libswscale.so.8(LIBSWSCALE_8)(64bit) libunshield.so.1()(64bit) libyaml-cpp.so.0.8()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) openmw-cs (rpmlib, GLIBC filtered): libGL.so.1()(64bit) libMyGUIEngine.so.3.4.3()(64bit) libQt6Core.so.6()(64bit) libQt6Core.so.6(Qt_6)(64bit) libQt6Core.so.6(Qt_6.9)(64bit) libQt6Gui.so.6()(64bit) libQt6Gui.so.6(Qt_6)(64bit) libQt6Network.so.6()(64bit) libQt6Network.so.6(Qt_6)(64bit) libQt6OpenGLWidgets.so.6()(64bit) libQt6OpenGLWidgets.so.6(Qt_6)(64bit) libQt6Svg.so.6()(64bit) libQt6Svg.so.6(Qt_6)(64bit) libQt6Widgets.so.6()(64bit) libQt6Widgets.so.6(Qt_6)(64bit) libSDL2-2.0.so.0()(64bit) libboost_iostreams.so.1.83.0()(64bit) libboost_program_options.so.1.83.0()(64bit) libc.so.6()(64bit) libcollada-dom2.5-dp.so.0()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) liblz4.so.1()(64bit) libm.so.6()(64bit) libpng16.so.16()(64bit) libpng16.so.16(PNG16_0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libyaml-cpp.so.0.8()(64bit) libz.so.1()(64bit) openmw(x86-64) rtld(GNU_HASH) openmw-tools (rpmlib, GLIBC filtered): libGL.so.1()(64bit) libboost_iostreams.so.1.83.0()(64bit) libboost_program_options.so.1.83.0()(64bit) libc.so.6()(64bit) libcollada-dom2.5-dp.so.0()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) liblz4.so.1()(64bit) libm.so.6()(64bit) libpng16.so.16()(64bit) libpng16.so.16(PNG16_0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libz.so.1()(64bit) openmw(x86-64) rtld(GNU_HASH) Provides -------- openmw: application() application(org.openmw.launcher.desktop) metainfo() metainfo(openmw.appdata.xml) openmw openmw(x86-64) openmw-cs: application() application(org.openmw.cs.desktop) openmw-cs openmw-cs(x86-64) openmw-tools: openmw-tools openmw-tools(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name openmw --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-42-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: Java, fonts, Perl, PHP, Haskell, R, Ocaml, Python, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH