This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package uses either %{buildroot} or $RPM_BUILD_ROOT Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/postfix, https://src.fedoraproject.org/modules/postfix, https://src.fedoraproject.org/tests/postfix See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1403978 bytes in 74 files. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_documentation ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/libexec, /usr/share/man/man5, /usr, /usr/share, /usr/bin, /usr/src/debug, /usr/lib/sysusers.d, /usr/sbin, /usr/lib, /etc/sasl2, /usr/lib64, /usr/src, /usr/share/man/man8, /etc/pam.d, /var, /etc, /usr/lib/systemd, /usr/share/doc, /var/lib/misc, /usr/share/man, /usr/lib/systemd/system, /var/spool, /var/lib, /usr/share/man/man1 [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/libexec, /usr/share/man/man5, /usr, /usr/share, /usr/bin, /usr/src/debug, /usr/lib/sysusers.d, /usr/sbin, /usr/lib, /etc/sasl2, /usr/lib64, /usr/src, /usr/share/man/man8, /etc/pam.d, /var, /etc, /usr/lib/systemd, /usr/share/doc, /var/lib/misc, /usr/share/man, /usr/lib/systemd/system, /var/spool, /var/lib, /usr/share/man/man1 [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in postfix [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [ ]: Package contains the mandatory BuildRequires and Requires:. ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make %{?_smp_mflags} macro. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in postfix- perl-scripts , postfix-mysql , postfix-pgsql , postfix-sqlite , postfix-cdb , postfix-ldap , postfix-lmdb , postfix-pcre [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define postfix_user postfix, %define maildrop_group postdrop, %define postfix_config_dir %{_sysconfdir}/postfix, %define postfix_daemon_dir %{_libexecdir}/postfix, %define postfix_shlib_dir %{_libdir}/postfix, %define postfix_command_dir %{_sbindir}, %define postfix_queue_dir %{_var}/spool/postfix, %define postfix_data_dir %{_var}/lib/postfix, %define postfix_doc_dir %{?_pkgdocdir}%{!?_pkgdocdir:%{_docdir}/%{name}-%{version}}, %define postfix_sample_dir %{postfix_doc_dir}/samples, %define postfix_readme_dir %{postfix_doc_dir}/README_FILES, %define pflogsumm_ver 1.1.5 [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 2027520 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: postfix-3.9.0-8.fc39.x86_64.rpm postfix-perl-scripts-3.9.0-8.fc39.x86_64.rpm postfix-mysql-3.9.0-8.fc39.x86_64.rpm postfix-pgsql-3.9.0-8.fc39.x86_64.rpm postfix-sqlite-3.9.0-8.fc39.x86_64.rpm postfix-cdb-3.9.0-8.fc39.x86_64.rpm postfix-ldap-3.9.0-8.fc39.x86_64.rpm postfix-lmdb-3.9.0-8.fc39.x86_64.rpm postfix-pcre-3.9.0-8.fc39.x86_64.rpm postfix-debuginfo-3.9.0-8.fc39.x86_64.rpm postfix-debugsource-3.9.0-8.fc39.x86_64.rpm postfix-3.9.0-8.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpnbif1hlk')] checks: 32, packages: 12 postfix.spec:75: W: unversioned-explicit-provides MTA postfix.spec:75: W: unversioned-explicit-provides smtpd postfix.spec:75: W: unversioned-explicit-provides smtpdaemon postfix.spec:75: W: unversioned-explicit-provides server(smtp) postfix-perl-scripts.x86_64: E: spelling-error ('summarizer', '%description -l en_US summarizer -> summarize, summarizes, summarized') postfix.x86_64: E: setgid-binary /usr/sbin/postdrop postdrop 2755 postfix.x86_64: E: setgid-binary /usr/sbin/postlog postdrop 2755 postfix.x86_64: E: setgid-binary /usr/sbin/postqueue postdrop 2755 postfix.x86_64: W: percent-in-%post postfix-perl-scripts.x86_64: W: obsolete-not-provided postfix postfix.x86_64: E: non-standard-executable-perm /usr/sbin/postdrop 2755 postfix.x86_64: E: non-standard-executable-perm /usr/sbin/postlog 2755 postfix.x86_64: E: non-standard-executable-perm /usr/sbin/postqueue 2755 postfix.x86_64: E: non-standard-dir-perm /var/spool/postfix/active 700 postfix.x86_64: E: non-standard-dir-perm /var/spool/postfix/bounce 700 postfix.x86_64: E: non-standard-dir-perm /var/spool/postfix/corrupt 700 postfix.x86_64: E: non-standard-dir-perm /var/spool/postfix/defer 700 postfix.x86_64: E: non-standard-dir-perm /var/spool/postfix/deferred 700 postfix.x86_64: E: non-standard-dir-perm /var/spool/postfix/flush 700 postfix.x86_64: E: non-standard-dir-perm /var/spool/postfix/hold 700 postfix.x86_64: E: non-standard-dir-perm /var/spool/postfix/incoming 700 postfix.x86_64: E: non-standard-dir-perm /var/spool/postfix/maildrop 730 postfix.x86_64: E: non-standard-dir-perm /var/spool/postfix/private 700 postfix.x86_64: E: non-standard-dir-perm /var/spool/postfix/public 710 postfix.x86_64: E: non-standard-dir-perm /var/spool/postfix/saved 700 postfix.x86_64: E: non-standard-dir-perm /var/spool/postfix/trace 700 postfix.x86_64: W: non-conffile-in-etc /etc/postfix/dynamicmaps.cf postfix.x86_64: W: non-conffile-in-etc /etc/postfix/postfix-files postfix-cdb.x86_64: W: non-conffile-in-etc /etc/postfix/dynamicmaps.cf.d/cdb postfix-cdb.x86_64: W: non-conffile-in-etc /etc/postfix/postfix-files.d/cdb postfix-ldap.x86_64: W: non-conffile-in-etc /etc/postfix/dynamicmaps.cf.d/ldap postfix-ldap.x86_64: W: non-conffile-in-etc /etc/postfix/postfix-files.d/ldap postfix-lmdb.x86_64: W: non-conffile-in-etc /etc/postfix/dynamicmaps.cf.d/lmdb postfix-lmdb.x86_64: W: non-conffile-in-etc /etc/postfix/postfix-files.d/lmdb postfix-mysql.x86_64: W: non-conffile-in-etc /etc/postfix/dynamicmaps.cf.d/mysql postfix-mysql.x86_64: W: non-conffile-in-etc /etc/postfix/postfix-files.d/mysql postfix-pcre.x86_64: W: non-conffile-in-etc /etc/postfix/dynamicmaps.cf.d/pcre postfix-pcre.x86_64: W: non-conffile-in-etc /etc/postfix/postfix-files.d/pcre postfix-pgsql.x86_64: W: non-conffile-in-etc /etc/postfix/dynamicmaps.cf.d/pgsql postfix-pgsql.x86_64: W: non-conffile-in-etc /etc/postfix/postfix-files.d/pgsql postfix-sqlite.x86_64: W: non-conffile-in-etc /etc/postfix/dynamicmaps.cf.d/sqlite postfix-sqlite.x86_64: W: non-conffile-in-etc /etc/postfix/postfix-files.d/sqlite postfix.x86_64: W: no-manual-page-for-binary mailq.postfix postfix.x86_64: W: no-manual-page-for-binary newaliases.postfix postfix.x86_64: W: no-manual-page-for-binary rmail postfix.x86_64: W: no-manual-page-for-binary rmail.postfix postfix.x86_64: W: no-manual-page-for-binary sendmail.postfix postfix-perl-scripts.x86_64: E: no-binary postfix.src: W: name-repeated-in-summary Postfix postfix.x86_64: W: name-repeated-in-summary Postfix postfix.spec:50: W: mixed-use-of-spaces-and-tabs (spaces: line 50, tab: line 36) postfix.x86_64: W: install-file-in-docs /usr/share/doc/postfix/README_FILES/INSTALL postfix-debugsource.x86_64: E: files-duplicated-waste 552724 postfix.x86_64: W: files-duplicate /etc/postfix/master.cf.proto /etc/postfix/master.cf postfix.x86_64: W: files-duplicate /usr/share/man/man1/newaliases.postfix.1.gz /usr/share/man/man1/mailq.postfix.1.gz postfix.x86_64: W: files-duplicate /usr/share/man/man8/trace.8.gz /usr/share/man/man8/defer.8.gz postfix.x86_64: W: dangerous-command-in-%pre rm postfix.x86_64: W: dangerous-command-in-%post mv postfix.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/lib64/postfix/libpostfix-util.so postfix.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/libexec/postfix/local 12 packages and 0 specfiles checked; 22 errors, 38 warnings, 325 filtered, 22 badness; has taken 4.9 s Rpmlint (debuginfo) ------------------- Checking: postfix-cdb-debuginfo-3.9.0-8.fc39.x86_64.rpm postfix-ldap-debuginfo-3.9.0-8.fc39.x86_64.rpm postfix-pgsql-debuginfo-3.9.0-8.fc39.x86_64.rpm postfix-lmdb-debuginfo-3.9.0-8.fc39.x86_64.rpm postfix-sqlite-debuginfo-3.9.0-8.fc39.x86_64.rpm postfix-debuginfo-3.9.0-8.fc39.x86_64.rpm postfix-mysql-debuginfo-3.9.0-8.fc39.x86_64.rpm postfix-pcre-debuginfo-3.9.0-8.fc39.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmplxw71m31')] checks: 32, packages: 8 8 packages and 0 specfiles checked; 0 errors, 0 warnings, 152 filtered, 0 badness; has taken 1.7 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "postfix-ldap-debuginfo". (none): E: there is no installed rpm "postfix-mysql". (none): E: there is no installed rpm "postfix-cdb". (none): E: there is no installed rpm "postfix-lmdb". (none): E: there is no installed rpm "postfix-debuginfo". (none): E: there is no installed rpm "postfix-cdb-debuginfo". (none): E: there is no installed rpm "postfix-sqlite". (none): E: there is no installed rpm "postfix-pgsql-debuginfo". (none): E: there is no installed rpm "postfix-lmdb-debuginfo". (none): E: there is no installed rpm "postfix-pcre". (none): E: there is no installed rpm "postfix-pcre-debuginfo". (none): E: there is no installed rpm "postfix-perl-scripts". (none): E: there is no installed rpm "postfix-pgsql". (none): E: there is no installed rpm "postfix-sqlite-debuginfo". (none): E: there is no installed rpm "postfix-ldap". (none): E: there is no installed rpm "postfix-debugsource". (none): E: there is no installed rpm "postfix". (none): E: there is no installed rpm "postfix-mysql-debuginfo". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 18 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Unversioned so-files -------------------- postfix: /usr/lib64/postfix/libpostfix-dns.so postfix: /usr/lib64/postfix/libpostfix-global.so postfix: /usr/lib64/postfix/libpostfix-master.so postfix: /usr/lib64/postfix/libpostfix-tls.so postfix: /usr/lib64/postfix/libpostfix-util.so postfix-mysql: /usr/lib64/postfix/postfix-mysql.so postfix-pgsql: /usr/lib64/postfix/postfix-pgsql.so postfix-sqlite: /usr/lib64/postfix/postfix-sqlite.so postfix-cdb: /usr/lib64/postfix/postfix-cdb.so postfix-ldap: /usr/lib64/postfix/postfix-ldap.so postfix-lmdb: /usr/lib64/postfix/postfix-lmdb.so postfix-pcre: /usr/lib64/postfix/postfix-pcre.so Source checksums ---------------- http://jimsun.linxnet.com/downloads/pflogsumm-1.1.5.tar.gz : CHECKSUM(SHA256) this package : da6443679117de5109fd7d65fe915286c20ad1ecee63fe07d8cdddd0b75fe466 CHECKSUM(SHA256) upstream package : da6443679117de5109fd7d65fe915286c20ad1ecee63fe07d8cdddd0b75fe466 ftp://ftp.porcupine.org/mirrors/postfix-release/official/postfix-3.9.0.tar.gz : CHECKSUM(SHA256) this package : 56f5e420e7c25455a4e96c19b672f80f9a0a35fb5becc9247c9e3d5dcc617f34 CHECKSUM(SHA256) upstream package : 56f5e420e7c25455a4e96c19b672f80f9a0a35fb5becc9247c9e3d5dcc617f34 Requires -------- postfix (rpmlib, GLIBC filtered): /bin/sh /usr/bin/bash /usr/bin/openssl /usr/bin/sh /usr/sbin/alternatives config(postfix) diffutils findutils hostname libc.so.6()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libdb-5.3.so()(64bit) libicuuc.so.73()(64bit) libnsl.so.3()(64bit) libnsl.so.3(LIBNSL_2.0)(64bit) libsasl2.so.3()(64bit) libssl.so.3()(64bit) libssl.so.3(OPENSSL_3.0.0)(64bit) policycoreutils rtld(GNU_HASH) systemd systemd-sysv postfix-perl-scripts (rpmlib, GLIBC filtered): /usr/bin/perl perl(Date::Calc) perl(File::Find) perl(Getopt::Long) perl(Getopt::Std) perl(IO::File) perl(locale) perl(strict) perl(vars) postfix postfix-mysql (rpmlib, GLIBC filtered): libc.so.6()(64bit) libmariadb.so.3()(64bit) libmariadb.so.3(libmysqlclient_18)(64bit) postfix rtld(GNU_HASH) postfix-pgsql (rpmlib, GLIBC filtered): libc.so.6()(64bit) libpq.so.5()(64bit) libpq.so.5(RHPG_9.6)(64bit) postfix rtld(GNU_HASH) postfix-sqlite (rpmlib, GLIBC filtered): libc.so.6()(64bit) libsqlite3.so.0()(64bit) postfix rtld(GNU_HASH) postfix-cdb (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcdb.so.1()(64bit) postfix rtld(GNU_HASH) postfix-ldap (rpmlib, GLIBC filtered): libc.so.6()(64bit) liblber.so.2()(64bit) liblber.so.2(OPENLDAP_2.200)(64bit) libldap.so.2()(64bit) libldap.so.2(OPENLDAP_2.200)(64bit) postfix rtld(GNU_HASH) postfix-lmdb (rpmlib, GLIBC filtered): libc.so.6()(64bit) liblmdb.so.0.0.0()(64bit) postfix rtld(GNU_HASH) postfix-pcre (rpmlib, GLIBC filtered): libc.so.6()(64bit) libpcre2-8.so.0()(64bit) postfix rtld(GNU_HASH) postfix-debuginfo (rpmlib, GLIBC filtered): postfix-debugsource (rpmlib, GLIBC filtered): Provides -------- postfix: MTA config(postfix) group(postdrop) group(postfix) postfix postfix(x86-64) server(smtp) smtpd smtpdaemon user(postfix) postfix-perl-scripts: postfix-perl-scripts postfix-perl-scripts(x86-64) postfix-pflogsumm postfix-mysql: postfix-mysql postfix-mysql(x86-64) postfix-pgsql: postfix-pgsql postfix-pgsql(x86-64) postfix-sqlite: postfix-sqlite postfix-sqlite(x86-64) postfix-cdb: postfix-cdb postfix-cdb(x86-64) postfix-ldap: postfix-ldap postfix-ldap(x86-64) postfix-lmdb: postfix-lmdb postfix-lmdb(x86-64) postfix-pcre: postfix-pcre postfix-pcre(x86-64) postfix-debuginfo: debuginfo(build-id) postfix-debuginfo postfix-debuginfo(x86-64) postfix-debugsource: postfix-debugsource postfix-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name postfix --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-39-x86_64 Active plugins: Perl, Shell-api, Generic, C/C++ Disabled plugins: fonts, Ocaml, SugarActivity, PHP, Java, Python, R, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH