This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - The License field must be a valid SPDX expression. Note: Not a valid SPDX expression 'GPLv2+'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /var/lib/copr- rpmbuild/results/aravis-0.8/diff.txt See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10880210 bytes in 1002 files. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_documentation ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* GNU Lesser General Public License, Version 2.1", "GNU Lesser General Public License, Version 2.1", "GNU Lesser General Public License v2.1 or later", "MIT License", "*No copyright* GNU Lesser General Public License v2.1 or later", "Creative Commons CC0 1.0", "Apache License 2.0", "Apache License 2.0 and/or GNU General Public License, Version 3", "Creative Commons Attribution-ShareAlike 3.0", "Apache License 2.0 and/or GNU General Public License v3.0 or later", "Apache License 2.0 and/or Creative Commons Attribution-ShareAlike 3.0 and/or Creative Commons CC0 1.0 and/or GNU General Public License, Version 2 and/or GNU Library General Public License, Version 2.0 and/or SIL Open Font License 1.1 with Reserved Font Name", "*No copyright* Apache License 2.0", "*No copyright* BSD 2-Clause License", "*No copyright* Creative Commons CC0 1.0", "GNU General Public License, Version 2", "GNU Library General Public License, Version 2.0", "*No copyright* Mozilla Public License 1.1", "SIL Open Font License 1.1", "Apache License 2.0 and/or Creative Commons CC0 1.0", "Apache License 2.0 and/or BSD 2-Clause License", "GNU General Public License, Version 3", "Apache License 2.0 and/or SIL Open Font License 1.1". 205 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/aravis-0.8/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/22x22/apps, /usr/share/icons/hicolor/32x32/apps, /usr/share/icons/hicolor/128x128/apps, /usr/share/icons/hicolor/48x48/apps, /usr/share/icons/hicolor/128x128, /usr/share/icons/hicolor/22x22, /usr/share/icons/hicolor/256x256/apps, /usr/share/icons/hicolor/48x48, /usr/share/icons/hicolor, /usr/share/icons/hicolor/32x32, /usr/share/icons/hicolor/256x256 [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: The spec file handles locales properly. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in aravis-0.8-devel , aravis-0.8-viewer , aravis-0.8-gstreamer1 [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Scriptlets must be sane, if used. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 13240320 bytes in /usr/share aravis-0.8-devel-0.8.35-1.fc42.s390x.rpm:13096960 See: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines [!]: Spec file according to URL is the same as in SRPM. Note: Bad spec filename: /var/lib/copr- rpmbuild/results/aravis-0.8/srpm-unpacked/aravis-0.8.spec See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: aravis-0.8-0.8.35-1.fc42.s390x.rpm aravis-0.8-devel-0.8.35-1.fc42.s390x.rpm aravis-0.8-viewer-0.8.35-1.fc42.s390x.rpm aravis-0.8-gstreamer1-0.8.35-1.fc42.s390x.rpm aravis-0.8-0.8.35-1.fc42.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpgxw9nl30')] checks: 32, packages: 5 aravis-0.8.s390x: E: spelling-error ('gobject', '%description -l en_US gobject -> object, g object') aravis-0.8.s390x: E: spelling-error ('ethernet', '%description -l en_US ethernet -> Ethernet, ether net, ether-net') aravis-0.8.src: E: spelling-error ('gobject', '%description -l en_US gobject -> object, g object') aravis-0.8.src: E: spelling-error ('ethernet', '%description -l en_US ethernet -> Ethernet, ether net, ether-net') aravis-0.8-devel.s390x: E: spelling-error ('gobject', '%description -l en_US gobject -> object, g object') aravis-0.8-devel.s390x: E: spelling-error ('ethernet', '%description -l en_US ethernet -> Ethernet, ether net, ether-net') aravis-0.8-gstreamer1.s390x: E: spelling-error ('gobject', '%description -l en_US gobject -> object, g object') aravis-0.8-gstreamer1.s390x: E: spelling-error ('ethernet', '%description -l en_US ethernet -> Ethernet, ether net, ether-net') aravis-0.8-viewer.s390x: E: spelling-error ('gobject', '%description -l en_US gobject -> object, g object') aravis-0.8-viewer.s390x: E: spelling-error ('ethernet', '%description -l en_US ethernet -> Ethernet, ether net, ether-net') aravis-0.8-viewer.s390x: W: obsolete-not-provided aravis-0.4-viewer aravis-0.8.s390x: W: no-manual-page-for-binary arv-camera-test-0.8 aravis-0.8.s390x: W: no-manual-page-for-binary arv-fake-gv-camera-0.8 aravis-0.8.s390x: W: no-manual-page-for-binary arv-test-0.8 aravis-0.8.s390x: W: no-manual-page-for-binary arv-tool-0.8 aravis-0.8-viewer.s390x: W: no-manual-page-for-binary arv-viewer-0.8 aravis-0.8-gstreamer1.s390x: W: no-documentation aravis-0.8.spec: W: no-%check-section aravis-0.8.spec:28: W: mixed-use-of-spaces-and-tabs (spaces: line 28, tab: line 2) aravis-0.8.s390x: W: invalid-license GPLv2+ aravis-0.8.src: W: invalid-license GPLv2+ aravis-0.8-devel.s390x: W: invalid-license GPLv2+ aravis-0.8-gstreamer1.s390x: W: invalid-license GPLv2+ aravis-0.8-viewer.s390x: W: invalid-license GPLv2+ aravis-0.8.s390x: W: file-not-utf8 /usr/share/man/man1/arv-camera-test-0.8.1.gz aravis-0.8.s390x: W: file-not-utf8 /usr/share/man/man1/arv-test-0.8.1.gz aravis-0.8.s390x: W: file-not-utf8 /usr/share/man/man1/arv-tool-0.8.1.gz aravis-0.8-viewer.s390x: W: file-not-utf8 /usr/share/man/man1/arv-viewer-0.8.1.gz aravis-0.8.s390x: E: explicit-lib-dependency libxml2 aravis-0.8.s390x: E: description-line-too-long Aravis is a glib/gobject based library for video acquisition using Genicam cameras. It currently implements the gigabit ethernet and USB3 protocols used by industrial cameras. aravis-0.8.src: E: description-line-too-long Aravis is a glib/gobject based library for video acquisition using Genicam cameras. It currently implements the gigabit ethernet and USB3 protocols used by industrial cameras. aravis-0.8-devel.s390x: E: description-line-too-long Aravis is a glib/gobject based library for video acquisition using Genicam cameras. It currently implements the gigabit ethernet and USB3 protocols used by industrial cameras. aravis-0.8-gstreamer1.s390x: E: description-line-too-long Aravis is a glib/gobject based library for video acquisition using Genicam cameras. It currently implements the gigabit ethernet and USB3 protocols used by industrial cameras. aravis-0.8-viewer.s390x: E: description-line-too-long Aravis is a glib/gobject based library for video acquisition using Genicam cameras. It currently implements the gigabit ethernet and USB3 protocols used by industrial cameras. 5 packages and 0 specfiles checked; 16 errors, 18 warnings, 20 filtered, 16 badness; has taken 1.2 s Rpmlint (debuginfo) ------------------- Checking: aravis-0.8-gstreamer1-debuginfo-0.8.35-1.fc42.s390x.rpm aravis-0.8-debuginfo-0.8.35-1.fc42.s390x.rpm aravis-0.8-viewer-debuginfo-0.8.35-1.fc42.s390x.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpp0gz7pxd')] checks: 32, packages: 3 aravis-0.8-debuginfo.s390x: W: invalid-license GPLv2+ aravis-0.8-gstreamer1-debuginfo.s390x: W: invalid-license GPLv2+ aravis-0.8-viewer-debuginfo.s390x: W: invalid-license GPLv2+ 3 packages and 0 specfiles checked; 0 errors, 3 warnings, 30 filtered, 0 badness; has taken 0.4 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "aravis-0.8-debuginfo". (none): E: there is no installed rpm "aravis-0.8-gstreamer1". (none): E: there is no installed rpm "aravis-0.8". (none): E: there is no installed rpm "aravis-0.8-viewer-debuginfo". (none): E: there is no installed rpm "aravis-0.8-devel". (none): E: there is no installed rpm "aravis-0.8-viewer". (none): E: there is no installed rpm "aravis-0.8-gstreamer1-debuginfo". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 7 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Unversioned so-files -------------------- aravis-0.8-gstreamer1: /usr/lib64/gstreamer-1.0/libgstaravis.0.8.so Source checksums ---------------- https://gitlab.gnome.org/GNOME/gi-docgen/-/archive/2025.3/gi-docgen-2025.4.tar.bz2 : CHECKSUM(SHA256) this package : bb6208dfbb1051fea5c5fabf2d98f016720b11f1240b4891f342d0f6d99a0a66 CHECKSUM(SHA256) upstream package : 2d39bfbd9995e87d04426b33e92f92bc35f7045d9d65e96e38b25278733d398e https://github.com/AravisProject/aravis/releases/download/0.8.35/aravis-0.8.35.tar.xz : CHECKSUM(SHA256) this package : 8089af991fc3a2644ab04b2ddf82623cd663d80c7ebbdefa93ddbc17ea702ddb CHECKSUM(SHA256) upstream package : 8089af991fc3a2644ab04b2ddf82623cd663d80c7ebbdefa93ddbc17ea702ddb diff -r also reports differences Requires -------- aravis-0.8 (rpmlib, GLIBC filtered): glib2 libaravis-0.8.so.0()(64bit) libc.so.6()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libm.so.6()(64bit) libusb-1.0.so.0()(64bit) libxml2 libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.5.8)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) libxml2.so.2(LIBXML2_2.6.21)(64bit) libxml2.so.2(LIBXML2_2.6.23)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) aravis-0.8-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config aravis-0.8 libaravis-0.8.so.0()(64bit) pkgconfig(gio-2.0) pkgconfig(glib-2.0) pkgconfig(gobject-2.0) pkgconfig(gthread-2.0) pkgconfig(libusb-1.0) pkgconfig(libxml-2.0) pkgconfig(zlib) aravis-0.8-viewer (rpmlib, GLIBC filtered): /bin/sh aravis-0.8 gstreamer1-plugins-bad-free gstreamer1-plugins-base gstreamer1-plugins-good gtk3 libaravis-0.8.so.0()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgdk-3.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgstapp-1.0.so.0()(64bit) libgstbase-1.0.so.0()(64bit) libgstreamer-1.0.so.0()(64bit) libgstvideo-1.0.so.0()(64bit) libgtk-3.so.0()(64bit) libm.so.6()(64bit) rtld(GNU_HASH) aravis-0.8-gstreamer1 (rpmlib, GLIBC filtered): aravis-0.8 gstreamer1-plugins-base libaravis-0.8.so.0()(64bit) libc.so.6()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgstbase-1.0.so.0()(64bit) libgstreamer-1.0.so.0()(64bit) rtld(GNU_HASH) Provides -------- aravis-0.8: aravis-0.8 aravis-0.8(s390-64) libaravis-0.8.so.0()(64bit) aravis-0.8-devel: aravis-0.8-devel aravis-0.8-devel(s390-64) pkgconfig(aravis-0.8) aravis-0.8-viewer: application() application(org.aravis.viewer-0.8.desktop) aravis-0.8-viewer aravis-0.8-viewer(s390-64) metainfo() metainfo(org.aravis.viewer-0.8.metainfo.xml) aravis-0.8-gstreamer1: aravis-0.8-gstreamer1 aravis-0.8-gstreamer1(s390-64) gstreamer1(element-aravissrc)()(64bit) libgstaravis.0.8.so()(64bit) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name aravis-0.8 --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-42-s390x Active plugins: Shell-api, Generic, C/C++ Disabled plugins: Haskell, Perl, Java, R, fonts, Python, SugarActivity, PHP, Ocaml Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH