This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Mozilla Public License 2.0", "Apache License 2.0", "FSF Unlimited License", "Apache License (v2.0) or MIT license", "MIT License", "FSF Unlimited License [generated file]", "Mozilla Public License 2.0", "GNU General Public License v2.0 or later", "GNU General Public License v3.0 or later", "*No copyright* Mozilla Public License 2.0 [generated file]", "*No copyright* MIT License and/or Mozilla Public License 2.0", "MIT License and/or Mozilla Public License 2.0", "*No copyright* Public domain", "BSD 2-Clause License", "Historical Permission Notice and Disclaimer - sell variant", "*No copyright* BSD 3-Clause License", "GNU Lesser General Public License, Version 2.1 and/or Mozilla Public License", "GNU Lesser General Public License, Version 2.1", "*No copyright* GNU Lesser General Public License, Version 2.1", "MIT (old)", "*No copyright* MIT License", "BSD 3-Clause License", "ICU License and/or Mozilla Public License 2.0", "University of Illinois/NCSA Open Source License", "Unicode License Agreement - Data Files and Software (2016)", "NTP License", "*No copyright* Mozilla Public License 2.0 and/or W3C License", "GNU Lesser General Public License, Version 3", "*No copyright* Apache License 2.0", "*No copyright* BSD 2-Clause License", "ISC License", "*No copyright* ISC License", "*No copyright* BSD 3-Clause Clear License", "*No copyright* libpng License", "libpng License", "Freetype Project License", "*No copyright* GNU General Public License", "Apache License 2.0 and/or MIT License", "Apache License 2.0 and/or Mozilla Public License 2.0", "Apache License 2.0 and/or BSD 0-Clause License [generated file]", "*No copyright* Apache License 2.0 [generated file]", "*No copyright* Mozilla Public License 1.1 and/or Mozilla Public License 2.0", "*No copyright* Boost Software License 1.0", "GNU General Public License, Version 2", "GNU Lesser General Public License v2.1 or later", "*No copyright* Apache License (v2.0) or MIT license", "BSD 3-Clause License and/or Mozilla Public License 2.0", "*No copyright* Mozilla Public License 1.1", "*No copyright* GNU General Public License and/or GNU Lesser General Public License, Version 2.1", "GNU Lesser General Public License", "SIL Open Font License 1.1", "FSF All Permissive License and/or FSF Unlimited License (with License Retention) [generated file]", "Historical Permission Notice and Disclaimer - sell variant [generated file]", "BSD 2-Clause License and/or BSD 3-Clause License and/or Mozilla Public License 2.0", "BSD 3-Clause License and/or GNU General Public License, Version 2", "*No copyright* SIL Open Font License", "*No copyright* SIL Open Font License 1.1", "*No copyright* GNU Lesser General Public License v2.1 or later", "zlib License", "BSD 3-Clause License and/or GNU Lesser General Public License v2.1 or later", "GNU Lesser General Public License v2.1 or later [obsolete FSF postal address (Temple Place)]", "BSD 2-clause FreeBSD License", "BSD 2-Clause License and/or BSD 2-clause FreeBSD License", "Freetype Project License [generated file]", "BSD 3-Clause License and/or NTP License", "GNU Library General Public License v2 or later", "*No copyright* Common Public License 1.0 and/or bzip2 and libbzip2 License and/or zlib License", "BSD 3-Clause License and/or Creative Commons Attribution 3.0 and/or MIT License", "*No copyright* Apache License 2.0 and/or BSD 3-Clause License and/or ISC License and/or MIT License", "Academic Free License v2.1 and/or MIT License", "*No copyright* GNU General Public License v2.0 or later", "Apache License 2.0 and/or BSD 3-Clause License and/or Creative Commons CC0 1.0", "Khronos License and/or MIT License", "Boost Software License 1.0", "Apache License 2.0 [generated file]", "*No copyright* Apache License", "BSD 0-Clause License", "*No copyright* The Unlicense", "*No copyright* Apache License (v2.0) or MIT license and/or MIT License", "*No copyright* BSD 3-Clause License and/or Creative Commons Attribution 3.0 and/or MIT License", "*No copyright* MIT License and/or The Unlicense", "Apache License (v2.0) or MIT license and/or BSD 3-Clause License", "Apache License 2.0 and/or BSD 3-Clause License", "*No copyright* Apache License 2.0 and/or MIT License", "*No copyright* Creative Commons CC0 1.0", "curl License", "FSF All Permissive License", "BSD 3-Clause License and/or Unicode strict", "BSD 3-Clause License [generated file]", "FSF Unlimited License (with License Retention) [generated file]", "*No copyright* Apache License 2.0 and/or Public domain", "Apache License 2.0 and/or Public domain", "*No copyright* BSD 3-Clause License and/or Mozilla Public License 2.0", "BSD 2-Clause License and/or GNU Lesser General Public License, Version 2.1", "BSD 2-Clause License and/or Mozilla Public License 2.0", "Khronos License", "GNU General Public License (v2 or later) or GNU Lesser General Public License (v2.1 or later) and/or GNU General Public License v2.0 or later and/or Mozilla Public License 1.1", "*No copyright* GNU Lesser General Public License", "GNU Lesser General Public License, Version 2.1 and/or Mozilla Public License 1.1", "GNU Lesser General Public License, Version 2.1 and/or Mozilla Public License 1.1 [obsolete FSF postal address (Temple Place)]", "Historical Permission Notice and Disclaimer - sell variant and/or NTP License (legal disclaimer)", "GNU Lesser General Public License, Version 2.1 and/or Historical Permission Notice and Disclaimer - sell variant and/or Mozilla Public License 1.1", "Historical Permission Notice and Disclaimer - sell variant and/or MIT Open Group variant", "ICU License", "*No copyright* LaTeX Project Public License and/or Mozilla Public License 2.0", "LaTeX Project Public License 1 and/or Mozilla Public License 2.0", "LaTeX Project Public License and/or Mozilla Public License 2.0", "LaTeX Project Public License and/or Mozilla Public License 2.0 [generated file]", "*No copyright* Apache License 2.0 and/or Mozilla Public License 2.0", "SIL Open Font License 1.0", "FSF Unlimited License (with License Retention) and/or GNU General Public License, Version 2 [generated file]", "X11 License [generated file]", "Public domain", "MIT Open Group variant", "*No copyright* Beerware License and/or Mozilla Public License 2.0", "Mozilla Public License 2.0 and/or NTP License", "Creative Commons Attribution 3.0", "*No copyright* Mozilla Public License", "*No copyright* Mozilla Public License 2.0 and/or NTP License", "*No copyright* zlib License", "*No copyright* Creative Commons Attribution 3.0", "CNRI Python License and/or MIT License", "MIT License and/or Public domain", "Python Software Foundation License 2.0", "*No copyright* Python Software Foundation License 2.0", "MIT License and/or Python Software Foundation License 2.0", "*No copyright* Artistic License", "*No copyright* Artistic License and/or GNU General Public License v2.0 or later", "*No copyright* GNU General Public License, Version 3", "Apache License (v2.0) or MIT license and/or MIT License", "*No copyright* Creative Commons Attribution-ShareAlike 4.0", "Apache License 2.0 and/or Boost Software License 1.0", "BSD 3-Clause License and/or MIT License", "GNU General Public License v2.0 or later [generated file]", "*No copyright* BSD 3-Clause License and/or W3C License", "*No copyright* Apache License 2.0 and/or ISC License", "GNU General Public License v2.0 or later [obsolete FSF postal address (Temple Place)]", "*No copyright* Mozilla Public License 2.0 and/or The Perl 5 License", "GNU General Public License", "*No copyright* OpenSSL License", "Apache License", "*No copyright* Creative Commons Attribution-ShareAlike 3.0", "BSD 2-Clause with views sentence", "Apache License 2.0 and/or MIT License and/or Mozilla Public License 2.0", "BSD 3-Clause License and/or Boost Software License 1.0", "Apple Public Source License 2.0 and/or BSD-4-Clause (University of California-Specific)", "Unicode License Agreement - Data Files and Software (2015)", "*No copyright* NTP License", "BSD 4-Clause License", "GNU Lesser General Public License, Version 2.1 [obsolete FSF postal address (Temple Place)]", "BSD 3-Clause License and/or Creative Commons ShareAlike", "Freetype Project License and/or XFree86 License", "BSD 3-Clause No Nuclear Warranty", "Open LDAP Public License v2.8", "*No copyright* GNU General Public License, Version 2", "*No copyright* Clarified Artistic License", "*No copyright* W3C License", "Apache License 2.0 and/or BSD 2-Clause License", "Apple Public Source License 2.0", "*No copyright* Creative Commons Attribution 4.0", "Creative Commons Attribution 4.0". 316236 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/mozjs128/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/src/debug, /usr/include, /usr/bin, /usr/lib, /usr/lib64, /usr/share/doc, /usr/lib64/pkgconfig, /usr, /usr/src, /usr/share, /usr/share/licenses [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64, /usr/share/doc, /usr/lib64/pkgconfig, /usr, /usr/src/debug, /usr/include, /usr/bin, /usr/src, /usr/share, /usr/share/licenses, /usr/lib [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 696 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define autorelease(e:s:pb:n) %{?-p:0.}%{lua:, %define _lto_cflags %{nil} [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: mozjs128-128.1.0-2.fc41.x86_64.rpm mozjs128-devel-128.1.0-2.fc41.x86_64.rpm mozjs128-debuginfo-128.1.0-2.fc41.x86_64.rpm mozjs128-debugsource-128.1.0-2.fc41.x86_64.rpm mozjs128-128.1.0-2.fc41.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpe6l8j1z5')] checks: 32, packages: 5 mozjs128-devel.x86_64: W: no-manual-page-for-binary js128 mozjs128-devel.x86_64: W: no-documentation 5 packages and 0 specfiles checked; 0 errors, 2 warnings, 33 filtered, 0 badness; has taken 5.6 s Rpmlint (debuginfo) ------------------- Checking: mozjs128-debuginfo-128.1.0-2.fc41.x86_64.rpm mozjs128-devel-debuginfo-128.1.0-2.fc41.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpdt0c69c0')] checks: 32, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 10 filtered, 0 badness; has taken 1.6 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "mozjs128-debuginfo". (none): E: there is no installed rpm "mozjs128". (none): E: there is no installed rpm "mozjs128-devel". (none): E: there is no installed rpm "mozjs128-devel-debuginfo". (none): E: there is no installed rpm "mozjs128-debugsource". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 5 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://ftp.mozilla.org/pub/firefox/releases/128.1.0esr/source/firefox-128.1.0esr.source.tar.xz : CHECKSUM(SHA256) this package : ccdab622a395622abc6d80040a11715ad81a614f601db6672c05b98ac91fd9b5 CHECKSUM(SHA256) upstream package : ccdab622a395622abc6d80040a11715ad81a614f601db6672c05b98ac91fd9b5 Requires -------- mozjs128 (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libgcc_s.so.1(GCC_4.2.0)(64bit) libicui18n.so.74()(64bit) libicuuc.so.74()(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) mozjs128-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libgcc_s.so.1(GCC_4.2.0)(64bit) libicui18n.so.74()(64bit) libicuuc.so.74()(64bit) libm.so.6()(64bit) libmozjs-128.so.0()(64bit) libreadline.so.8()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libz.so.1()(64bit) mozjs128(x86-64) rtld(GNU_HASH) mozjs128-debuginfo (rpmlib, GLIBC filtered): mozjs128-debugsource (rpmlib, GLIBC filtered): Provides -------- mozjs128: libmozjs-128.so.0()(64bit) libmozjs-128.so.0(mozjs_128)(64bit) mozjs128 mozjs128(x86-64) mozjs128-devel: mozjs128-devel mozjs128-devel(x86-64) pkgconfig(mozjs-128) mozjs128-debuginfo: debuginfo(build-id) libmozjs-128.so.0.0.0-128.1.0-2.fc41.x86_64.debug()(64bit) mozjs128-debuginfo mozjs128-debuginfo(x86-64) mozjs128-debugsource: mozjs128-debugsource mozjs128-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name mozjs128 --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: Haskell, fonts, PHP, Ocaml, R, Java, Perl, SugarActivity, Python Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH