# needed for test content %{?perl_default_filter} %global __provides_exclude_from %{?_provides_exclude_from:%_provides_exclude_from|}%{_datadir}/fedora-review/ %global __requires_exclude_from %{?_requires_exclude_from:%_requires_exclude_from|}%{_datadir}/fedora-review/test/ #invoke with "--with tests" to enable tests %bcond_with tests # See notes in make_release which patches this. ## global git_tag .e79b66b # Support jenkins build number if available. %global build_nr %(echo "${BUILD_NUMBER:+.}${BUILD_NUMBER:-%%{nil\\}}") Name: fedora-review Version: 0.10.0 Release: 11%{?build_nr}%{?git_tag}%{?dist} Summary: Review tool for fedora rpm packages License: GPL-2.0-or-later URL: https://pagure.io/FedoraReview Source0: https://releases.pagure.org/FedoraReview/%{name}-%{version}%{?git_tag}.tar.gz # adapted from https://pagure.io/FedoraReview/c/c9aa1122cd046ea3c6f43be4bb352c383c2e56ad.patch Patch0: %{name}-shebang-fix.diff # https://pagure.io/FedoraReview/pull-request/513 Patch1: %{name}-dnf-from-bootstrap-buildroot.patch # https://pagure.io/FedoraReview/pull-request/521 Patch2: %{name}-deps-use-mock-shell-not-pm-cmd.patch # Patch3: %{name}-tmpfs-keep-mounted.patch BuildArch: noarch BuildRequires: mock >= 3.0 BuildRequires: python3-setuptools BuildRequires: python3-beautifulsoup4 BuildRequires: python3-bugzilla BuildRequires: python3-packaging BuildRequires: python3-urlgrabber BuildRequires: python3-straight-plugin BuildRequires: python3-devel BuildRequires: python3-rpm BuildRequires: python3-dnf Requires: bc Requires: fedora-packager Requires: python3-beautifulsoup4 Requires: python3-bugzilla Requires: python3-packaging Requires: python3-urlgrabber Requires: python3-straight-plugin Requires: python3-rpm Requires: python3-dnf # licensecheck used to be in rpmdevtools, moved to devscripts later # this is compatible with both situations without ifdefs Requires: %{_bindir}/licensecheck Requires: license-validate # We require DNF and the repoquery command Requires: dnf Requires: dnf-command(repoquery) # Ugh, we now require mock since we import modules from it... Requires: mock >= 3.0 # Let's be consistent with the name used on pagure.io Provides: FedoraReview = %{version}-%{release} Provides: %{name}-php-phpci = %{version}-%{release} Obsoletes: %{name}-php-phpci < %{version}-%{release} %description This tool automates much of the dirty work when reviewing a package for the Fedora Package Collection like: * Downloading SRPM & SPEC. * Download upstream source * Check md5sums * Build and install package in mock. * Run rpmlint. * Generate a review template, which becomes the starting point for the review work. The tool is composed of plugins, one for each supported language. As of today, there is plugins for C/C++, Ruby, java, R, perl and python. There is also support for external tests that can be written in a simple way in bash. %package plugin-ruby Summary: Enhanced ruby tests for fedora-review Requires: %{name} = %{version}-%{release} %description plugin-ruby fedora-review ruby-specific tests, not installed by default. %package tests Summary: Test and test data files for fedora-review Requires: %{name} = %{version}-%{release} Requires: python3-nose %description tests Tests are packaged separately due to space concerns. %prep %autosetup -p1 %build %py3_build %install %py3_install pkg_dir="%{buildroot}/%{python3_sitelib}/FedoraReview" ln -s %{_datadir}/%{name}/scripts $pkg_dir/scripts ln -s %{_datadir}/%{name}/plugins $pkg_dir/plugins cd test bash < restore-links.sh rm restore-links.sh remember-links cd .. cp -ar test "%{buildroot}%{_datadir}/%{name}" cp -a pycodestyle.conf pylint.conf "%{buildroot}%{_datadir}/%{name}" %check %if %{with tests} cd test export REVIEW_LOGLEVEL=warning export MAKE_RELEASE=1 mock --quiet -r fedora-38-x86_64 --init mock --quiet -r fedora-38-x86_64 --uniqueext=hugo --init %{__python3} -m unittest discover -f %endif %files %doc README %license COPYING AUTHORS %{python3_sitelib}/FedoraReview %{python3_sitelib}/fedora_review-%{version}-py%{python3_version}.egg-info %{_bindir}/fedora-review %{_bindir}/fedora-create-review %{_bindir}/koji-download-scratch %{_mandir}/man1/%{name}.1.* %{_mandir}/man1/fedora-create-review.1.* %dir %{_datadir}/%{name} %{_datadir}/%{name}/plugins %exclude %{_datadir}/%{name}/plugins/ruby.py %{_datadir}/%{name}/scripts %{_datadir}/%{name}/pycodestyle.conf %{_datadir}/%{name}/pylint.conf %files plugin-ruby %{_datadir}/%{name}/plugins/ruby.py %files tests %doc test/README.test %{_datadir}/%{name}/test %changelog * Tue Aug 06 2024 Jakub Kadlcik - 0.10.0-11 - rebuilt * Sun Aug 04 2024 Jakub Kadlcik - 0.10.0-10 - Apply https://pagure.io/FedoraReview/pull-request/521 * Wed Jul 17 2024 Fedora Release Engineering - 0.10.0-9 - Rebuilt for https://fedoraproject.org/wiki/Fedora_41_Mass_Rebuild * Mon Jun 24 2024 Python Maint - 0.10.0-8 - Rebuilt for Python 3.13 * Sun Mar 10 2024 Jakub Kadlcik - 0.10.0-7 - The PR#513 was updated, format new patch * Sat Mar 09 2024 Jakub Kadlcik - 0.10.0-6 - Apply https://pagure.io/FedoraReview/pull-request/513 * Wed Jan 24 2024 Fedora Release Engineering - 0.10.0-5 - Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild * Fri Jan 19 2024 Fedora Release Engineering - 0.10.0-4 - Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild * Thu Aug 03 2023 Benson Muite - 0.10.0-3 - Add bc as a required dependency * Wed Jul 26 2023 Michel Alexandre Salim - 0.10.0-2 - Properly fix shebangs to invoke Python 3 * Mon Jul 24 2023 Michel Alexandre Salim - 0.10.0-1 - New upstream release 0.10.0 - Use SPDX license identifier * Wed Jul 19 2023 Fedora Release Engineering - 0.9.0-4 - Rebuilt for https://fedoraproject.org/wiki/Fedora_39_Mass_Rebuild * Wed Jun 28 2023 Python Maint - 0.9.0-3 - Rebuilt for Python 3.12 * Thu Jan 19 2023 Fedora Release Engineering - 0.9.0-2 - Rebuilt for https://fedoraproject.org/wiki/Fedora_38_Mass_Rebuild * Tue Aug 23 2022 Michel Alexandre Salim - 0.9.0-1 - New upstream release 0.9.0 * Thu Jul 21 2022 Fedora Release Engineering - 0.8.0-3 - Rebuilt for https://fedoraproject.org/wiki/Fedora_37_Mass_Rebuild * Wed Jun 15 2022 Python Maint - 0.8.0-2 - Rebuilt for Python 3.11 * Thu Apr 07 2022 Neal Gompa - 0.8.0-1 - New upstream release 0.8.0 * Thu Jan 20 2022 Fedora Release Engineering - 0.7.6-6 - Rebuilt for https://fedoraproject.org/wiki/Fedora_36_Mass_Rebuild * Wed Jul 21 2021 Fedora Release Engineering - 0.7.6-5 - Rebuilt for https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild * Fri Jun 04 2021 Python Maint - 0.7.6-4 - Rebuilt for Python 3.10 * Tue Jan 26 2021 Fedora Release Engineering - 0.7.6-3 - Rebuilt for https://fedoraproject.org/wiki/Fedora_34_Mass_Rebuild * Mon Dec 21 2020 Neal Gompa - 0.7.6-2 - Backport fix for fedora-create-review to make rhbz settings optional - Backport fix for fedora-review crashing on package reviews (rhbz#1903589) * Tue Nov 10 2020 Neal Gompa - 0.7.6-1 - New upstream release 0.7.6 * Mon Jul 27 2020 Fedora Release Engineering - 0.7.5-3 - Rebuilt for https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild * Tue May 26 2020 Miro Hrončok - 0.7.5-2 - Rebuilt for Python 3.9 * Sun Feb 16 2020 Neal Gompa - 0.7.5-1 - New upstream release 0.7.5 * Tue Jan 28 2020 Fedora Release Engineering - 0.7.4-2 - Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild * Sat Dec 07 2019 Neal Gompa - 0.7.4-1 - New upstream release 0.7.4 * Wed Sep 18 2019 Neal Gompa - 0.7.3-1 - New upstream release 0.7.3 * Mon Aug 19 2019 Miro Hrončok - 0.7.2-3 - Rebuilt for Python 3.8 * Thu Jul 25 2019 Fedora Release Engineering - 0.7.2-2 - Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild * Tue Apr 09 2019 Neal Gompa - 0.7.2-1 - New upstream release 0.7.2 * Sun Mar 24 2019 Neal Gompa - 0.7.1-2 - Backport fix to add missing logging import * Thu Mar 21 2019 Neal Gompa - 0.7.1-1 - New upstream release 0.7.1 * Sun Mar 17 2019 Neal Gompa - 0.7.0-1 - New upstream release 0.7.0 - Switch to Python 3 * Thu Jan 31 2019 Fedora Release Engineering - 0.6.1-11 - Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild * Fri Jul 13 2018 Fedora Release Engineering - 0.6.1-10 - Rebuilt for https://fedoraproject.org/wiki/Fedora_29_Mass_Rebuild * Thu Mar 01 2018 Iryna Shcherbina - 0.6.1-9 - Update Python 2 dependency declarations to new packaging standards (See https://fedoraproject.org/wiki/FinalizingFedoraSwitchtoPython3) * Wed Feb 07 2018 Fedora Release Engineering - 0.6.1-8 - Rebuilt for https://fedoraproject.org/wiki/Fedora_28_Mass_Rebuild * Wed Jul 26 2017 Fedora Release Engineering - 0.6.1-7 - Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Mass_Rebuild * Mon Jun 05 2017 Björn Esser - 0.6.1-6 - Fix shebangs in %%{_bindir} * Fri Jun 02 2017 Björn Esser - 0.6.1-5 - Add mock-option '--no-bootstrap-chroot' to defaults, if mock >= 1.4.1 - Update spec file to recent guidelines - Change package url and source to Pagure * Fri Feb 10 2017 Fedora Release Engineering - 0.6.1-4 - Rebuilt for https://fedoraproject.org/wiki/Fedora_26_Mass_Rebuild * Thu Oct 06 2016 Pierre-Yves Chibon - 0.6.1-3 - Drop requirement to python-argparse now that it has been in python's stdlib for so long * Tue Jul 19 2016 Fedora Release Engineering - 0.6.1-2 - https://fedoraproject.org/wiki/Changes/Automatic_Provides_for_Python_RPM_Packages * Mon May 02 2016 Alec Leamas - 0.6.1-1.f03e4e7 - New upstream release 0.6.1 * Tue Feb 16 2016 Orion Poplawski - 0.6.0-4 - Exclude test content from perl requires * Wed Feb 03 2016 Fedora Release Engineering - 0.6.0-3 - Rebuilt for https://fedoraproject.org/wiki/Fedora_24_Mass_Rebuild * Wed Jun 17 2015 Fedora Release Engineering - 0.6.0-2 - Rebuilt for https://fedoraproject.org/wiki/Fedora_23_Mass_Rebuild * Wed May 20 2015 Alec Leamas - 0.6.0-1.afb5485 - Update to 0.6.0 * Mon May 04 2015 Pierre-Yves Chibon - 0.5.3-1 - Update to 0.5.3 * Wed Apr 22 2015 Adam Miller - 0.5.2-3 - Add conditional for unittest2 for epel7 (thanks mcepl@redhat.com for the fix) * Mon Jan 19 2015 Stanislav Ochotnicky - 0.5.2-2 - Add patch for rhbz#1151943 * Mon Jul 14 2014 Stanislav Ochotnicky - 0.5.2-1 - Update to latest upstream bugfix release * Sat Jun 07 2014 Fedora Release Engineering - 0.5.1-3 - Rebuilt for https://fedoraproject.org/wiki/Fedora_21_Mass_Rebuild * Mon Jan 13 2014 Stanislav Ochotnicky - 0.5.1-2 - Backport fixes for several bugs - Resolves: rhbz#1044580 - Resolves: rhbz#1049042 * Fri Dec 13 2013 Stanislav Ochotnicky - 0.5.1-1 - Update to latest upstream (0.5.1) * Tue Oct 15 2013 Stanislav Ochotnicky - 0.5.0-3 - Really use phpcompatinfo instead of phpci * Mon Oct 14 2013 Stanislav Ochotnicky - 0.5.0-2 - Fix requires for licensecheck (#1016309) - Remove separate php plugin subpackage (#971875) * Fri Aug 30 2013 Stanislav Ochotnicky - 0.5.0-1 - Updating to upstream 0.5.0 * Sat Aug 03 2013 Fedora Release Engineering - 0.4.1-4 - Rebuilt for https://fedoraproject.org/wiki/Fedora_20_Mass_Rebuild * Wed Jul 17 2013 Petr Pisar - 0.4.1-3 - Perl 5.18 rebuild * Thu May 30 2013 Stanislav Ochotnicky - 0.4.1-2 - Backport fix for #967571 * Mon Apr 29 2013 Stanislav Ochotnicky - 0.4.1-1 - Update to latest upstream version * Tue Feb 19 2013 Stanislav Ochotnicky - 0.4.0-4 - Fix rhbz912182 - Reorganize patches a bit * Fri Feb 8 2013 Stanislav Ochotnicky - 0.4.0-3 - Fix rhbz908830 and rhbz908830 - Add patch for REVIEW_NO_MOCKGROUP_TEST environment variable - Remove old patch * Mon Feb 04 2013 Pierre-Yves Chibon - 0.4.0-2 - Add Patch0 (0001-Fix-syntax-error.patch) from Ralph Bean fixing fedora-create-review * Mon Jan 28 2013 Stanislav Ochotnicky - 0.4.0-1 - Updating to upstream 0.4.0 * Wed Nov 07 2012 Pierre-Yves Chibon - 0.3.1-3 - Backport from upstream's git fix to RHBZ#874246 (Patch0) * Thu Oct 25 2012 Stanislav Ochotnicky - 0.3.1-2 - Add symlink to scripts directory so they are loaded * Tue Sep 25 2012 Stanislav Ochotnicky - 0.3.1-1 - Update to lastest upstream (0.3.1) - Fix loading of system-wide plugins - Add back suport for EL6 * Mon Sep 24 2012 Stanislav Ochotnicky - 0.3.0-1 - Update to lastest upstream (0.3.0) - Remove no longer needed build workarounds * Thu Aug 9 2012 Stanislav Ochotnicky - 0.2.2-1 - Update to lastest upstream (0.2.2) - Add koji-download-scratch script * Thu Jul 19 2012 Fedora Release Engineering - 0.2.0-2 - Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild * Wed Jul 11 2012 Stanislav Ochotnicky - 0.2.0-1 - Update to latest release (0.2.0) * Fri Feb 24 2012 Stanislav Ochotnicky - 0.1.3-1 - Update to latest bugfix release * Fri Jan 13 2012 Stanislav Ochotnicky - 0.1.2-1 - Update to latest bugfix release - Add fedora-create-review script * Fri Jan 13 2012 Fedora Release Engineering - 0.1.1-3 - Rebuilt for https://fedoraproject.org/wiki/Fedora_17_Mass_Rebuild * Wed Jan 11 2012 Pierre-Yves Chibon - 0.1.1-2 - Add wget as requires * Wed Nov 23 2011 Stanislav Ochotnicky - 0.1.1-1 - New upstream bugfix release * Wed Nov 16 2011 Stanislav Ochotnicky - 0.1.0-2 - Remove things not needed in el6+ * Thu Nov 10 2011 Pierre-Yves Chibon - 0.1.0-1 - Initial packaging work for Fedora