This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
ones are mandatory, though)
- Remove this text
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
Note: No gcc, gcc-c++ or clang found in BuildRequires
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
- If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %license.
Note: License file furo.js.LICENSE.txt is not marked as %license
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/LicensingGuidelines/#_license_text
- Package does not use a name that already exists.
Note: A package with this name already exists. Please check
https://src.fedoraproject.org/rpms/incus
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/Naming/#_conflicting_package_names
===== MUST items =====
C/C++:
[ ]: Provides: bundled(gnulib) in place as required.
Note: Sources not installed
[ ]: Package does not contain kernel modules.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
Generic:
[ ]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. Licenses found: "Unknown or generated", "*No
copyright* Apache License 2.0", "Apache License 2.0", "GNU Lesser
General Public License v2.1 or later", "*No copyright* GNU Lesser
General Public License, Version 2.1", "GNU General Public License,
Version 2", "*No copyright* GNU General Public License, Version 2",
"*No copyright* GNU Lesser General Public License, Version 3", "GNU
Lesser General Public License, Version 3", "BSD 3-Clause License",
"GNU General Public License v2.0 or later", "FSF All Permissive
License", "GNU Lesser General Public License, Version 2.1", "MIT
License", "*No copyright* MIT License", "Apache License 2.0 and/or MIT
License", "ISC License", "BSD 2-Clause License", "*No copyright*
Mozilla Public License 2.0", "Apache License 2.0 and/or BSD 3-Clause
License", "*No copyright* The Unlicense", "BSD 3-Clause License and/or
ISC License", "*No copyright* BSD 2-Clause License", "OpenSSL
License". 5906 files have unknown license. Detailed output of
licensecheck in /var/lib/copr-rpmbuild/results/incus/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: Package requires other packages for directories it uses.
Note: No known owner of /var/lib/selinux/targeted/active/modules/200
[ ]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/sysctl.d,
/var/lib/selinux, /var/lib/selinux/targeted/active/modules,
/var/lib/selinux/targeted/active,
/usr/share/selinux/packages/targeted,
/var/lib/selinux/targeted/active/modules/200,
/var/lib/selinux/targeted
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
Note: Especially check following dirs for bundled code: /var/lib/copr-
rpmbuild/results/incus/upstream-
unpacked/Source0/incus-6.9/vendor/cowsql/test/unit/ext, /var/lib/copr-
rpmbuild/results/incus/upstream-
unpacked/Source0/incus-6.9/vendor/raft/include, /var/lib/copr-
rpmbuild/results/incus/upstream-
unpacked/Source0/incus-6.9/vendor/cowsql/include, /var/lib/copr-
rpmbuild/results/incus/upstream-
unpacked/Source0/incus-6.9/doc/html/third_party
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: The spec file handles locales properly.
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: The License field must be a valid SPDX expression.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: systemd_post is invoked in %post, systemd_preun in %preun, and
systemd_postun in %postun for Systemd service files.
Note: Systemd service file(s) in incus
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[!]: Reviewer should test that the package builds in mock.
[ ]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in incus-
selinux , incus-client , incus-tools , incus-agent
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[ ]: Scriptlets must be sane, if used.
[ ]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[ ]: Package should compile and build into binary rpms on all supported
architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
files.
[ ]: Spec use %global instead of %define unless justified.
Note: %define requiring justification: %define gotestflags -buildmode
pie -compiler gc -v -tags libsqlite3
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on debuginfo package(s).
Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
Note: No rpmlint messages.
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
Rpmlint
-------
Checking: incus-6.9-0.1.fc40.s390x.rpm
incus-selinux-6.9-0.1.fc40.noarch.rpm
incus-client-6.9-0.1.fc40.s390x.rpm
incus-tools-6.9-0.1.fc40.s390x.rpm
incus-agent-6.9-0.1.fc40.s390x.rpm
incus-doc-6.9-0.1.fc40.noarch.rpm
incus-6.9-0.1.fc40.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
/usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpxgdoeaq5')]
checks: 32, packages: 7
incus-doc.noarch: E: zero-length /usr/share/doc/incus-doc/html/_static/scripts/furo-extensions.js
incus.s390x: W: tmpfile-not-in-filelist /run/incus
incus-agent.s390x: E: statically-linked-binary /usr/bin/incus-agent
incus-tools.s390x: E: statically-linked-binary /usr/bin/incus-migrate
incus-tools.s390x: E: spelling-error ('unmap', '%description -l en_US unmap -> unman, uncap')
incus-tools.s390x: E: spelling-error ('uids', '%description -l en_US uids -> yids, ids, aids')
incus-tools.s390x: E: spelling-error ('gids', '%description -l en_US gids -> digs, gods, ids')
incus-tools.s390x: E: spelling-error ('lxc', '%description -l en_US lxc -> lxi, lac')
incus-tools.s390x: E: spelling-error ('lxd', '%description -l en_US lxd -> led, lxi, lid')
incus.s390x: W: post-without-tmpfile-creation /usr/lib/tmpfiles.d/incus.conf
incus-agent.s390x: W: position-independent-executable-suggested /usr/bin/incus-agent
incus-tools.s390x: W: position-independent-executable-suggested /usr/bin/incus-migrate
incus.s390x: E: non-standard-dir-perm /var/cache/incus 700
incus.s390x: E: non-standard-dir-perm /var/lib/incus 711
incus.s390x: E: non-standard-dir-perm /var/log/incus 700
incus-selinux.noarch: E: non-readable /var/lib/selinux/targeted/active/modules/200/incus 0
incus-selinux.noarch: W: no-documentation
incus.spec:342: W: macro-in-comment %gobuildflags
incus.s390x: W: log-files-without-logrotate ['/var/log/incus']
incus-doc.noarch: W: hidden-file-or-dir /usr/share/doc/incus-doc/html/.buildinfo
incus-doc.noarch: W: files-duplicate /usr/share/doc/incus-doc/html/_static/design-tabs.js /usr/share/doc/incus-doc/html/_sphinx_design_static/design-tabs.js
incus-doc.noarch: W: files-duplicate /usr/share/doc/incus-doc/html/_static/sphinx-design.min.css /usr/share/doc/incus-doc/html/_sphinx_design_static/sphinx-design.min.css
incus-selinux.noarch: W: dangerous-command-in-%pre cp
incus-selinux.noarch: W: dangerous-command-in-%postun rm
incus-selinux.noarch: W: dangerous-command-in-%posttrans rm
incus-selinux.noarch: W: dangerous-command-in-%post rm
7 packages and 0 specfiles checked; 12 errors, 14 warnings, 29 filtered, 12 badness; has taken 2.7 s
Rpmlint (debuginfo)
-------------------
Checking: incus-client-debuginfo-6.9-0.1.fc40.s390x.rpm
incus-tools-debuginfo-6.9-0.1.fc40.s390x.rpm
incus-agent-debuginfo-6.9-0.1.fc40.s390x.rpm
incus-debuginfo-6.9-0.1.fc40.s390x.rpm
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
/usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpppjm0g8u')]
checks: 32, packages: 4
4 packages and 0 specfiles checked; 0 errors, 0 warnings, 34 filtered, 0 badness; has taken 1.9 s
Rpmlint (installed packages)
----------------------------
(none): E: there is no installed rpm "incus-debuginfo".
(none): E: there is no installed rpm "incus-agent".
(none): E: there is no installed rpm "incus-tools".
(none): E: there is no installed rpm "incus".
(none): E: there is no installed rpm "incus-tools-debuginfo".
(none): E: there is no installed rpm "incus-client".
(none): E: there is no installed rpm "incus-selinux".
(none): E: there is no installed rpm "incus-doc".
(none): E: there is no installed rpm "incus-client-debuginfo".
(none): E: there is no installed rpm "incus-agent-debuginfo".
There are no files to process nor additional arguments.
Nothing to do, aborting.
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
/usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 10
0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s
Source checksums
----------------
https://github.com/swagger-api/swagger-ui/raw/v5.18.2/dist//swagger-ui.css#/swagger-ui-5.18.2.css :
CHECKSUM(SHA256) this package : 8f33d996025317049d4a9864f421eab2b2a247872f388026fa94c654913259e7
CHECKSUM(SHA256) upstream package : 8f33d996025317049d4a9864f421eab2b2a247872f388026fa94c654913259e7
https://github.com/swagger-api/swagger-ui/raw/v5.18.2/dist//swagger-ui-standalone-preset.js#/swagger-ui-5.18.2-standalone-preset.js :
CHECKSUM(SHA256) this package : 6c5a3338e69d84e7b05117b9ba7b141d24bd3fc102a9eb02e804d3b04dcec5a1
CHECKSUM(SHA256) upstream package : 6c5a3338e69d84e7b05117b9ba7b141d24bd3fc102a9eb02e804d3b04dcec5a1
https://github.com/swagger-api/swagger-ui/raw/v5.18.2/dist//swagger-ui-bundle.js#/swagger-ui-5.18.2-bundle.js :
CHECKSUM(SHA256) this package : c50b94bbc4f02394326fb7aed1f4fb693b3677f4b3d3344e0d6131808cbf281f
CHECKSUM(SHA256) upstream package : c50b94bbc4f02394326fb7aed1f4fb693b3677f4b3d3344e0d6131808cbf281f
https://linuxcontainers.org/downloads/incus/incus-6.9.tar.xz :
CHECKSUM(SHA256) this package : b8dca8d4aa6e39593402e8c366c9dd741904ecf5ce0dba89d0cef3c0d7166813
CHECKSUM(SHA256) upstream package : b8dca8d4aa6e39593402e8c366c9dd741904ecf5ce0dba89d0cef3c0d7166813
Requires
--------
incus (rpmlib, GLIBC filtered):
(incus-selinux = 6.9-0.1.fc40 if selinux-policy-targeted)
(nftables if iptables-nft)
/bin/sh
/usr/bin/sh
attr
config(incus)
dnsmasq
ebtables
incus-client
iptables
libacl.so.1()(64bit)
libacl.so.1(ACL_1.0)(64bit)
libc.so.6()(64bit)
libcap.so.2()(64bit)
libcowsql.so.0()(64bit)
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit)
libgcc_s.so.1(GCC_3.3.1)(64bit)
liblxc.so.1()(64bit)
libresolv.so.2()(64bit)
libsqlite3.so.0()(64bit)
libudev.so.1()(64bit)
libudev.so.1(LIBUDEV_183)(64bit)
libudev.so.1(LIBUDEV_189)(64bit)
libudev.so.1(LIBUDEV_199)(64bit)
lxcfs
rsync
rtld(GNU_HASH)
shadow-utils
squashfs-tools
systemd
tar
xdelta
xz
incus-selinux (rpmlib, GLIBC filtered):
/bin/sh
container-selinux
libselinux-utils
policycoreutils
policycoreutils-python-utils
selinux-policy
selinux-policy-base
incus-client (rpmlib, GLIBC filtered):
gettext
libc.so.6()(64bit)
libresolv.so.2()(64bit)
rtld(GNU_HASH)
incus-tools (rpmlib, GLIBC filtered):
incus(s390-64)
libacl.so.1()(64bit)
libacl.so.1(ACL_1.0)(64bit)
libc.so.6()(64bit)
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit)
libgcc_s.so.1(GCC_3.3.1)(64bit)
liblxc.so.1()(64bit)
libresolv.so.2()(64bit)
rtld(GNU_HASH)
incus-agent (rpmlib, GLIBC filtered):
incus(s390-64)
incus-doc (rpmlib, GLIBC filtered):
Provides
--------
incus:
config(incus)
group(incus)
group(incus-admin)
incus
incus(s390-64)
incus-selinux:
incus-selinux
incus-client:
incus-client
incus-client(s390-64)
incus-tools:
incus-tools
incus-tools(s390-64)
incus-agent:
incus-agent
incus-agent(s390-64)
incus-doc:
incus-doc
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name incus --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg
Buildroot used: fedora-40-s390x
Active plugins: Shell-api, Generic, C/C++
Disabled plugins: PHP, Java, fonts, Ocaml, Python, SugarActivity, R, Perl, Haskell
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH