This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-Clause License", "Boost Software License 1.0", "*No copyright* Boost Software License 1.0", "FSF Unlimited License (with License Retention) and/or GNU General Public License v2.0 or later [generated file]", "GNU General Public License v2.0 or later [generated file]", "GNU General Public License v3.0 or later", "FSF Unlimited License [generated file]", "X11 License [generated file]", "MIT License", "*No copyright* MIT License", "Apache License 2.0 and/or Boost Software License 1.0", "*No copyright* Apache License 2.0", "CNRI Python Open Source GPL Compatible License Agreement", "GNU General Public License v2.0 or later", "Creative Commons Attribution-ShareAlike 4.0", "*No copyright* Public domain", "*No copyright* Apache License 2.0 and/or Boost Software License 1.0", "Unicode License Agreement - Data Files and Software (2016)", "*No copyright* BSD 3-Clause License". 5073 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/wsddn/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in wsddn [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: wsddn-1.21-2.fc42.aarch64.rpm wsddn-debuginfo-1.21-2.fc42.aarch64.rpm wsddn-debugsource-1.21-2.fc42.aarch64.rpm wsddn-1.21-2.fc42.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpjswjhcce')] checks: 32, packages: 4 wsddn.spec: W: no-%check-section 4 packages and 0 specfiles checked; 0 errors, 1 warnings, 21 filtered, 0 badness; has taken 2.1 s Rpmlint (debuginfo) ------------------- Checking: wsddn-debuginfo-1.21-2.fc42.aarch64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpybyd6twm')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.7 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "wsddn". (none): E: there is no installed rpm "wsddn-debuginfo". (none): E: there is no installed rpm "wsddn-debugsource". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/marzer/tomlplusplus/tarball/v3.4.0#/tomlplusplus.tgz : CHECKSUM(SHA256) this package : 8874014da21de8d1414d9914c8f3c6b5f315c23a75951b33df46048c13dda12f CHECKSUM(SHA256) upstream package : 8874014da21de8d1414d9914c8f3c6b5f315c23a75951b33df46048c13dda12f https://github.com/gershnik/sys_string/tarball/v2.20#/sys_string.tgz : CHECKSUM(SHA256) this package : d2a0aa64e3e20e8f01ece30fa618393401d78bc9065b034aecf96814c0389c6f CHECKSUM(SHA256) upstream package : d2a0aa64e3e20e8f01ece30fa618393401d78bc9065b034aecf96814c0389c6f https://github.com/gabime/spdlog/tarball/v1.15.3#/spdlog.tgz : CHECKSUM(SHA256) this package : 2f33b90dee78e9a910abbba1a294398277d4608831c6b8161ac74a7ca5493b49 CHECKSUM(SHA256) upstream package : 2f33b90dee78e9a910abbba1a294398277d4608831c6b8161ac74a7ca5493b49 https://github.com/gershnik/ptl/tarball/v1.7#/ptl.tgz : CHECKSUM(SHA256) this package : e3efb37f71846ba7d10165bef7f62a581dd3e7c8f4ac185bb86d4069bc4ec9ed CHECKSUM(SHA256) upstream package : e3efb37f71846ba7d10165bef7f62a581dd3e7c8f4ac185bb86d4069bc4ec9ed https://github.com/ned14/outcome/tarball/v2.2.12#/outcome.tgz : CHECKSUM(SHA256) this package : 838ed35d1bdedcfe9cee2186b51d023404274418f2868798fefac5a54e8bb403 CHECKSUM(SHA256) upstream package : 838ed35d1bdedcfe9cee2186b51d023404274418f2868798fefac5a54e8bb403 https://github.com/gershnik/modern-uuid/tarball/v1.8#/modern-uuid.tgz : CHECKSUM(SHA256) this package : bb3fb3e53b45cd7e6b977835cfc7ef25680e92b68daf709b1f494f46697dae02 CHECKSUM(SHA256) upstream package : bb3fb3e53b45cd7e6b977835cfc7ef25680e92b68daf709b1f494f46697dae02 https://gitlab.gnome.org/GNOME/libxml2/-/archive/v2.14.5/libxml2-v2.14.5.tar.gz#/libxml2.tgz : CHECKSUM(SHA256) this package : 54968c8ab8723c2d75a38fc45810e8cf60d44991e0887661bf9905a4042ad108 CHECKSUM(SHA256) upstream package : 54968c8ab8723c2d75a38fc45810e8cf60d44991e0887661bf9905a4042ad108 https://github.com/gershnik/intrusive_shared_ptr/tarball/v1.9#/isptr.tgz : CHECKSUM(SHA256) this package : f9095609a2226f3aa6dbfcd4726a8521a56f4fd2f426b0898d92acd1f133aa6d CHECKSUM(SHA256) upstream package : f9095609a2226f3aa6dbfcd4726a8521a56f4fd2f426b0898d92acd1f133aa6d https://github.com/fmtlib/fmt/tarball/11.2.0#/fmt.tgz : CHECKSUM(SHA256) this package : 15b7d9723d16e6ecbf83438a1611a2910879eaa5bc8d0e0fd8197c2f18f993be CHECKSUM(SHA256) upstream package : 15b7d9723d16e6ecbf83438a1611a2910879eaa5bc8d0e0fd8197c2f18f993be https://downloads.sourceforge.net/asio/asio-1.30.2.tar.gz#/asio.tgz : CHECKSUM(SHA256) this package : 12e7bb4dada8bc1191de9d550a59ee658ce4e645ffc97c911c099ab4e8699d55 CHECKSUM(SHA256) upstream package : 12e7bb4dada8bc1191de9d550a59ee658ce4e645ffc97c911c099ab4e8699d55 https://github.com/gershnik/argum/tarball/v2.6#/argum.tgz : CHECKSUM(SHA256) this package : 72b2b6805da7bf022e8111f3c2f3ed08ae6c23daa0ad336de56f2bd133d653c4 CHECKSUM(SHA256) upstream package : 72b2b6805da7bf022e8111f3c2f3ed08ae6c23daa0ad336de56f2bd133d653c4 https://github.com/gershnik/wsdd-native/tarball/v1.21#/wsddn.tgz : CHECKSUM(SHA256) this package : ba605604e450248da81c6336fd51f0ca894a65bcdce0301e488ba81ffa5b577f CHECKSUM(SHA256) upstream package : ba605604e450248da81c6336fd51f0ca894a65bcdce0301e488ba81ffa5b577f Requires -------- wsddn (rpmlib, GLIBC filtered): /bin/sh config(wsddn) firewalld-filesystem ld-linux-aarch64.so.1()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.7)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) systemd wsddn-debuginfo (rpmlib, GLIBC filtered): wsddn-debugsource (rpmlib, GLIBC filtered): Provides -------- wsddn: config(wsddn) wsddn wsddn(aarch-64) wsddn-debuginfo: debuginfo(build-id) wsddn-debuginfo wsddn-debuginfo(aarch-64) wsddn-debugsource: wsddn-debugsource wsddn-debugsource(aarch-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name wsddn --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-42-aarch64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: Java, R, fonts, PHP, Perl, Haskell, SugarActivity, Python, Ocaml Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH