This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/edk2 See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 2-Clause Plus Patent License", "BSD 2-Clause Plus Patent License and/or MIT License", "BSD 2-Clause License and/or BSD 2-Clause Plus Patent License", "BSD 2-Clause License and/or GNU General Public License v2.0 or later", "BSD 2-Clause Plus Patent License [generated file]", "*No copyright* BSD 2-Clause Plus Patent License", "MIT License", "BSD 2-Clause Plus Patent License and/or BSD 3-Clause License", "*No copyright* Public domain", "BSD 2-Clause Plus Patent License and/or Public domain", "BSD 3-Clause License", "*No copyright* MIT License", "*No copyright* Apache License 2.0", "Apache License 2.0", "BSD 2-Clause Plus Patent License and/or OpenSSL License", "BSD 4-Clause License and/or ISC License", "Apple MIT License and/or BSD 2-Clause Plus Patent License", "BSD 2-Clause Plus Patent License and/or Intel Open Source License", "*No copyright* GNU General Public License, Version 2", "GNU General Public License, Version 2". 586 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/edk2/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 127147 bytes in 3 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [ ]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in edk2-ovmf , edk2-aarch64 , edk2-tools , edk2-ovmf-ia32 , edk2-ovmf-xen , edk2-experimental , edk2-riscv64 , edk2-loongarch64 , edk2-ext4 , edk2-tools-python [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define autorelease(e:s:pb:n) %{?-p:0.}%{lua:, %define build_arches x86_64 aarch64 riscv64, %define GITDATE 20241117, %define GITCOMMIT 0f3867fa6ef0, %define TOOLCHAIN GCC, %define PLATFORMS_COMMIT 4b3530dfbbda, %define OPENSSL_VER 3.0.7, %define OPENSSL_COMMIT 8e5beb77088bfec064d60506b1e76ddb0ac417fe, %define DBXDATE 20230509, %define silent --silent, %define build_ovmf 0, %define build_aarch64 0, %define build_ovmf 1, %define build_aarch64 1, %define build_riscv64 0, %define build_loongarch64 0, %define build_ovmf 1, %define build_aarch64 1, %define build_riscv64 1, %define build_loongarch64 1, %define cross %{defined fedora}, %define disable_werror %{defined fedora} [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: edk2-ovmf-20241117-5.fc40.noarch.rpm edk2-aarch64-20241117-5.fc40.noarch.rpm edk2-tools-20241117-5.fc40.x86_64.rpm edk2-tools-doc-20241117-5.fc40.noarch.rpm edk2-ovmf-ia32-20241117-5.fc40.noarch.rpm edk2-ovmf-xen-20241117-5.fc40.noarch.rpm edk2-experimental-20241117-5.fc40.noarch.rpm edk2-riscv64-20241117-5.fc40.noarch.rpm edk2-loongarch64-20241117-5.fc40.noarch.rpm edk2-ext4-20241117-5.fc40.noarch.rpm edk2-tools-python-20241117-5.fc40.noarch.rpm edk2-20241117-5.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpbn4rz5px')] checks: 32, packages: 12 edk2-ovmf.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/edk2-ovmf/README edk2.spec:261: W: unversioned-explicit-provides bundled(openssl) edk2.spec:270: W: unversioned-explicit-provides bundled(openssl) edk2.spec:279: W: unversioned-explicit-provides bundled(openssl) edk2-loongarch64.noarch: W: summary-not-capitalized loongarch Virtual Machine Firmware edk2-experimental.noarch: W: obsolete-not-provided edk2-ovmf-experimental edk2-tools.x86_64: W: no-manual-page-for-binary DevicePath edk2-tools.x86_64: W: no-manual-page-for-binary EfiRom edk2-tools.x86_64: W: no-manual-page-for-binary GenCrc32 edk2-tools.x86_64: W: no-manual-page-for-binary GenFfs edk2-tools.x86_64: W: no-manual-page-for-binary GenFv edk2-tools.x86_64: W: no-manual-page-for-binary GenFw edk2-tools.x86_64: W: no-manual-page-for-binary GenSec edk2-tools.x86_64: W: no-manual-page-for-binary LzmaCompress edk2-tools.x86_64: W: no-manual-page-for-binary LzmaF86Compress edk2-tools.x86_64: W: no-manual-page-for-binary TianoCompress edk2-tools.x86_64: W: no-manual-page-for-binary VfrCompile edk2-tools.x86_64: W: no-manual-page-for-binary VolInfo edk2-tools-python.noarch: W: no-manual-page-for-binary BPDG edk2-tools-python.noarch: W: no-manual-page-for-binary Ecc edk2-tools-python.noarch: W: no-manual-page-for-binary GenDepex edk2-tools-python.noarch: W: no-manual-page-for-binary GenFds edk2-tools-python.noarch: W: no-manual-page-for-binary GenPatchPcdTable edk2-tools-python.noarch: W: no-manual-page-for-binary PatchPcdValue edk2-tools-python.noarch: W: no-manual-page-for-binary TargetTool edk2-tools-python.noarch: W: no-manual-page-for-binary Trim edk2-tools-python.noarch: W: no-manual-page-for-binary UPT edk2-tools-python.noarch: W: no-manual-page-for-binary build edk2-aarch64.noarch: W: no-documentation edk2-ext4.noarch: W: no-documentation edk2-loongarch64.noarch: W: no-documentation edk2-ovmf-ia32.noarch: W: no-documentation edk2-ovmf-xen.noarch: W: no-documentation edk2-riscv64.noarch: W: no-documentation edk2-tools.x86_64: W: no-documentation edk2-tools-python.noarch: W: no-documentation edk2.spec:467: W: mixed-use-of-spaces-and-tabs (spaces: line 30, tab: line 467) edk2.spec:140: W: macro-in-comment %prep edk2.spec: W: invalid-url Source6: dtc-1.7.0.tar.xz edk2.spec: W: invalid-url Source5: jansson-2.13.1.tar.bz2 edk2.spec: W: invalid-url Source4: edk2-platforms-4b3530dfbbda.tar.xz edk2.spec: W: invalid-url Source2: openssl-rhel-8e5beb77088bfec064d60506b1e76ddb0ac417fe.tar.xz edk2.spec: W: invalid-url Source0: edk2-0f3867fa6ef0.tar.xz edk2-tools-python.noarch: E: files-duplicated-waste 357174 edk2-tools-python.noarch: W: files-duplicate /usr/share/edk2/Python/Eot/CParser3/CLexer.py /usr/share/edk2/Python/Ecc/CParser3/CLexer.py edk2-tools-python.noarch: W: files-duplicate /usr/share/edk2/Python/Eot/CParser4/CParser.py /usr/share/edk2/Python/Ecc/CParser4/CParser.py edk2-tools-python.noarch: W: files-duplicate /usr/share/edk2/Python/Workspace/__init__.py /usr/share/edk2/Python/Ecc/MetaFileWorkspace/__init__.py edk2-tools-python.noarch: W: files-duplicate /usr/share/edk2/Python/UPT/Xml/__init__.py /usr/share/edk2/Python/Ecc/Xml/__init__.py:/usr/share/edk2/Python/UPT/Library/Xml/__init__.py edk2-ovmf-xen.noarch: E: arch-independent-package-contains-binary-or-object /usr/share/edk2/xen/OVMF.fd 12 packages and 0 specfiles checked; 2 errors, 47 warnings, 43 filtered, 2 badness; has taken 7.2 s Rpmlint (debuginfo) ------------------- Checking: edk2-tools-debuginfo-20241117-5.fc40.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpisq02s_8')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 30 filtered, 0 badness; has taken 0.5 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "edk2-tools-doc". (none): E: there is no installed rpm "edk2-tools-python". (none): E: there is no installed rpm "edk2-loongarch64". (none): E: there is no installed rpm "edk2-ovmf". (none): E: there is no installed rpm "edk2-ext4". (none): E: there is no installed rpm "edk2-ovmf-xen". (none): E: there is no installed rpm "edk2-riscv64". (none): E: there is no installed rpm "edk2-experimental". (none): E: there is no installed rpm "edk2-ovmf-ia32". (none): E: there is no installed rpm "edk2-tools-debuginfo". (none): E: there is no installed rpm "edk2-tools". (none): E: there is no installed rpm "edk2-aarch64". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 12 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Requires -------- edk2-ovmf (rpmlib, GLIBC filtered): edk2-aarch64 (rpmlib, GLIBC filtered): edk2-tools (rpmlib, GLIBC filtered): /usr/bin/bash libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) edk2-tools-doc (rpmlib, GLIBC filtered): edk2-ovmf-ia32 (rpmlib, GLIBC filtered): edk2-ovmf-xen (rpmlib, GLIBC filtered): edk2-experimental (rpmlib, GLIBC filtered): edk2-riscv64 (rpmlib, GLIBC filtered): edk2-loongarch64 (rpmlib, GLIBC filtered): edk2-ext4 (rpmlib, GLIBC filtered): edk2-tools-python (rpmlib, GLIBC filtered): /usr/bin/sh python3 Provides -------- edk2-ovmf: OVMF bundled(openssl) edk2-ovmf edk2-aarch64: AAVMF bundled(openssl) edk2-aarch64 edk2-tools: edk2-tools edk2-tools(x86-64) edk2-tools-doc: edk2-tools-doc edk2-ovmf-ia32: bundled(openssl) edk2-ovmf-ia32 edk2-ovmf-xen: bundled(openssl) edk2-ovmf-xen edk2-experimental: bundled(openssl) edk2-experimental edk2-riscv64: edk2-riscv64 edk2-loongarch64: edk2-loongarch64 edk2-ext4: edk2-ext4 edk2-tools-python: edk2-tools-python Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name edk2 --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-40-x86_64 Active plugins: Python, Generic, Shell-api, C/C++ Disabled plugins: fonts, Ocaml, Haskell, PHP, Java, SugarActivity, Perl, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH