{"object_kind":"push","event_name":"push","before":"45fc6a1a4539cca4b956699bba2e2734b596516f","after":"d51f5d30ec7f322f1d3c6d64672de37f87bd7355","ref":"refs/heads/jv/nmtui-lo","ref_protected":false,"checkout_sha":"d51f5d30ec7f322f1d3c6d64672de37f87bd7355","message":null,"user_id":94502,"user_name":"Jan Vaclav","user_username":"jvaclav","user_email":"jvaclav@redhat.com","user_avatar":"https://secure.gravatar.com/avatar/63438947499d1b23df20545a5f7834ebf1fd6a34a1d5f6baad97d6e2d40df256?s=80&d=identicon","project_id":411,"project":{"id":411,"name":"NetworkManager","description":"NetworkManager — network management daemon","web_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","avatar_url":"https://gitlab.freedesktop.org/uploads/-/system/project/avatar/411/nm_logo.png","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","namespace":"NetworkManager","visibility_level":20,"path_with_namespace":"NetworkManager/NetworkManager","default_branch":"main","ci_config_path":"","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git"},"commits":[{"id":"4ed1d04aff349c0749a6dcf50809483b2eaf978c","message":"libnm-glib-aux: add nm_puint64_hash()/nm_puint64_equal()\n\nThe two new functions can be used as GHashFunc and GEqualFunc when\ncreating hash tables whose keys are pointers to a guint64.\n","title":"libnm-glib-aux: add nm_puint64_hash()/nm_puint64_equal()","timestamp":"2025-04-02T11:18:02+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/4ed1d04aff349c0749a6dcf50809483b2eaf978c","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/libnm-glib-aux/nm-hash-utils.c","src/libnm-glib-aux/nm-hash-utils.h"],"removed":[]},{"id":"dbc4ff0a1d8f872dbc4676b62b4bb1ae60b98b3e","message":"libnm-glib-aux: add nm_ip6_addr_get_subnet_id()\n\nAdd function nm_ip6_addr_get_subnet_id() to get the subnet ID of a\nIPv6 address.\n","title":"libnm-glib-aux: add nm_ip6_addr_get_subnet_id()","timestamp":"2025-04-02T11:18:02+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/dbc4ff0a1d8f872dbc4676b62b4bb1ae60b98b3e","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/libnm-glib-aux/nm-inet-utils.c","src/libnm-glib-aux/nm-inet-utils.h","src/libnm-glib-aux/tests/test-shared-general.c"],"removed":[]},{"id":"037b14965e2953bd73394c762e184617ca834206","message":"libnmc-setting: add new flag for property descriptors\n\nAdd a new flag \"print_hex_negative_as_base10\" in the property\ndescriptor _NMMetaPropertyTypData.\n\nNormally, when a property has \"base = 16\", it is printed as unsigned\neven if the gtype is signed.\n\nFor some properties, we want to print the hexadecimal representation\nfor positive values, and the base10 representation with minus sign for\nnegative values. A typical use case is to encode the default value as\n\"-1\" and use positive values as a hexadecimal number.\n","title":"libnmc-setting: add new flag for property descriptors","timestamp":"2025-04-02T11:18:02+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/037b14965e2953bd73394c762e184617ca834206","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/libnmc-setting/nm-meta-setting-desc.c","src/libnmc-setting/nm-meta-setting-desc.h"],"removed":[]},{"id":"4a8bedcd8980aed7b41a0f76e76e00dab58798c7","message":"device: remove the prefix-delegation IP configuration on cleanup\n\nWhen a device in IPv6 shared mode obtains a prefix, it adds a new l3cd\nof type L3_CONFIG_DATA_TYPE_PD_6 for that prefix. However, that l3cd\nis never removed later and so the address lingers on the interface\neven after the connection goes down. Remove the l3cd on cleanup.\n","title":"device: remove the prefix-delegation IP configuration on cleanup","timestamp":"2025-04-02T11:18:02+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/4a8bedcd8980aed7b41a0f76e76e00dab58798c7","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/core/devices/nm-device.c"],"removed":[]},{"id":"b372caf0c4355ff0a9296e4d18bde69444e6474f","message":"libnm, nmcli: introduce new \"prefix-delegation\" setting\n\nIntroduce a new \"prefix-delegation\" setting. It contains properties\nrelated to the configuration of downstream interfaces using IPv6\nprefix-delegation. The only property at the moment is \"subnet-id\",\nwhich specifies which prefix to choose when the delegation contains\nmultiple /64 networks.\n","title":"libnm, nmcli: introduce new \"prefix-delegation\" setting","timestamp":"2025-04-02T11:21:59+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/b372caf0c4355ff0a9296e4d18bde69444e6474f","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":["src/libnm-core-impl/nm-setting-prefix-delegation.c","src/libnm-core-public/nm-setting-prefix-delegation.h"],"modified":["NEWS","docs/libnm/libnm-docs.xml","src/libnm-client-impl/libnm.ver","src/libnm-client-public/NetworkManager.h","src/libnm-client-public/nm-autoptr.h","src/libnm-core-impl/gen-metadata-nm-settings-libnm-core.xml.in","src/libnm-core-impl/meson.build","src/libnm-core-impl/nm-meta-setting-base-impl.c","src/libnm-core-intern/nm-core-internal.h","src/libnm-core-intern/nm-meta-setting-base-impl.h","src/libnm-core-public/meson.build","src/libnm-core-public/nm-core-types.h","src/libnmc-setting/nm-meta-setting-base-impl.c","src/libnmc-setting/nm-meta-setting-base-impl.h","src/libnmc-setting/nm-meta-setting-desc.c","src/libnmc-setting/settings-docs.h.in","src/nmcli/connections.c","src/nmcli/gen-metadata-nm-settings-nmcli.xml.in","vapi/NM-1.0.metadata"],"removed":[]},{"id":"b6386b3d2727eca57319bb38c2f3a23ecd92ba64","message":"core: support prefix-delegation.subnet-id\n","title":"core: support prefix-delegation.subnet-id","timestamp":"2025-04-02T11:21:59+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/b6386b3d2727eca57319bb38c2f3a23ecd92ba64","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/core/devices/nm-device.c","src/core/nm-policy.c"],"removed":[]},{"id":"355edef8b5fadbf2c1d3ad0b4a33dadab10cdfe2","message":"merge: branch 'bg/prefix-delegation'\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2162\n","title":"merge: branch 'bg/prefix-delegation'","timestamp":"2025-04-02T17:05:57+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/355edef8b5fadbf2c1d3ad0b4a33dadab10cdfe2","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":["src/libnm-core-impl/nm-setting-prefix-delegation.c","src/libnm-core-public/nm-setting-prefix-delegation.h"],"modified":["NEWS","docs/libnm/libnm-docs.xml","src/core/devices/nm-device.c","src/core/nm-policy.c","src/libnm-client-impl/libnm.ver","src/libnm-client-public/NetworkManager.h","src/libnm-client-public/nm-autoptr.h","src/libnm-core-impl/gen-metadata-nm-settings-libnm-core.xml.in","src/libnm-core-impl/meson.build","src/libnm-core-impl/nm-meta-setting-base-impl.c","src/libnm-core-intern/nm-core-internal.h","src/libnm-core-intern/nm-meta-setting-base-impl.h","src/libnm-core-public/meson.build","src/libnm-core-public/nm-core-types.h","src/libnm-glib-aux/nm-hash-utils.c","src/libnm-glib-aux/nm-hash-utils.h","src/libnm-glib-aux/nm-inet-utils.c","src/libnm-glib-aux/nm-inet-utils.h","src/libnm-glib-aux/tests/test-shared-general.c","src/libnmc-setting/nm-meta-setting-base-impl.c","src/libnmc-setting/nm-meta-setting-base-impl.h","src/libnmc-setting/nm-meta-setting-desc.c","src/libnmc-setting/nm-meta-setting-desc.h","src/libnmc-setting/settings-docs.h.in","src/nmcli/connections.c","src/nmcli/gen-metadata-nm-settings-nmcli.xml.in","vapi/NM-1.0.metadata"],"removed":[]},{"id":"cbdd0d9cca34f4e1cbd177e347e14265e1afaf6c","message":"core: fail early if we cannot get current FEC value\n\nIf we cannot get current FEC value probably we won't be able to set it a\nfew lines later. Also, if it fails to set, we try to use the value of\nthe old one that we tried to retrieve without success. In that case, the\nvariable old_fec_mode would be uninitialized. Fix it by returning early\nif we cannot get the current value.\n\nFixes: 19bed3121fb6 ('ethtool: support Forward Error Correction(fec)')\n","title":"core: fail early if we cannot get current FEC value","timestamp":"2025-04-03T09:44:54+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/cbdd0d9cca34f4e1cbd177e347e14265e1afaf6c","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/core/devices/nm-device.c"],"removed":[]},{"id":"245f0e0b35d385e966289080dbd2594e74a189b2","message":"core: optimize hash table search in _ethtool_fec_set\n\nBreak the loop as soon as we've found the value.\n\nFixes: 19bed3121fb6 ('ethtool: support Forward Error Correction(fec)')\n","title":"core: optimize hash table search in _ethtool_fec_set","timestamp":"2025-04-03T09:44:59+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/245f0e0b35d385e966289080dbd2594e74a189b2","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/core/devices/nm-device.c"],"removed":[]},{"id":"a4401ae0a6a0f5e241fe02beee7a7f14b4264ae9","message":"merge: branch 'ih/fec-uninit-var'\n\ncore: fail early if we cannot get current FEC value\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2177","title":"merge: branch 'ih/fec-uninit-var'","timestamp":"2025-04-07T11:05:25+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/a4401ae0a6a0f5e241fe02beee7a7f14b4264ae9","author":{"name":"Íñigo Huguet","email":"inigohuguet@hotmail.com"},"added":[],"modified":["src/core/devices/nm-device.c"],"removed":[]},{"id":"7ab3f0999f644232beb66efaaf17d72a7087b286","message":"nm-cloud-setup: removed excess validation check fields\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2150\n","title":"nm-cloud-setup: removed excess validation check fields","timestamp":"2025-04-07T15:25:49+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/7ab3f0999f644232beb66efaaf17d72a7087b286","author":{"name":"Herman Semenov","email":"GermanAizek@yandex.ru"},"added":[],"modified":["src/nm-cloud-setup/nmcs-provider-oci.c"],"removed":[]},{"id":"cc0222ba01bcb44bd5777fff94a9727d61461615","message":"nmcli/connections: fix build with libedit\n\nThis has always been broken (libedit-0:3.1-17.20160618cvs.fc26 is too\nold to work and libedit-0:3.1-20.20170329cvs.fc27.x86_64 has this type\nmismatch), but new GCC complains (14, 15).\n\n  ../src/nmcli/connections.c: In function ‘nmcli_editor_tab_completion’:\n  ../src/nmcli/connections.c:6862:64: error: assignment to ‘void (*)(char **, int,  int)’ from incompatible pointer type ‘void (*)(void)’ [-Wincompatible-pointer-types]\n   6862 |                             rl_completion_display_matches_hook = uuid_display_hook;\n        |                                                                ^\n  ../src/nmcli/connections.c:6909:60: error: assignment to ‘void (*)(char **, int,  int)’ from incompatible pointer type ‘void (*)(void)’ [-Wincompatible-pointer-types]\n   6909 |                         rl_completion_display_matches_hook = uuid_display_hook;\n        |                                                            ^\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2172\n","title":"nmcli/connections: fix build with libedit","timestamp":"2025-04-07T15:27:59+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/cc0222ba01bcb44bd5777fff94a9727d61461615","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/nmcli/connections.c"],"removed":[]},{"id":"42edb37499fdf848ec751b059a361fd37eab69d5","message":"bond-slb: initialize dest hw address in GARP packets\n\nDetected by Coverity:\n    1. NetworkManager-1.53.1/src/core/nm-bond-manager.c:885:5: var_decl: Declaring variable \"data\" without initializer.\n    7. NetworkManager-1.53.1/src/core/nm-bond-manager.c:948:13: uninit_use_in_call: Using uninitialized value \"data\". Field \"data.d_hw_addr\" is uninitialized when calling \"sendto\".\n       946|               unaligned_write_ne32(data.s_ip_addr, tmp_addr);\n       947|               unaligned_write_ne32(data.d_ip_addr, tmp_addr);\n       948|->             if (sendto(sockfd, &data, sizeof(data), 0, (struct sockaddr *) &addr, sizeof(addr)) < 0)\n       949|                   return FALSE;\n       950|           }\n\nFixes: 3f2f922dd943 ('bonding: send ARP announcement on bonding-slb link/carrier down')\n","title":"bond-slb: initialize dest hw address in GARP packets","timestamp":"2025-04-07T14:15:09+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/42edb37499fdf848ec751b059a361fd37eab69d5","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/core/nm-bond-manager.c"],"removed":[]},{"id":"ae7de5b353b8bdbfefd6a67c8fe53678cf78a60a","message":"core: fix use after free in ping operations\n\nDetected by coverity, the ping_op pointers are used after being freed in\ncleanup_ping_operations. Although calling to g_list_remove is probably\nsafe because it only needs the value of the pointer, not to dereference\nit, better to follow best practices. One of the use after free was\nactually an error because we dereference ping_op->log_domain.\n\nFixes: 658aef0fa185 ('connection: Support connection.ip-ping-addresses')\n","title":"core: fix use after free in ping operations","timestamp":"2025-04-07T14:15:09+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/ae7de5b353b8bdbfefd6a67c8fe53678cf78a60a","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/core/devices/nm-device.c"],"removed":[]},{"id":"9edfc0438cb6391b01999022567e6ed5aa6bb8db","message":"n-dhcp4: fix resource leaks\n\nThe function n_dhcp4_c_connection_send_request does not release or take\nownership of its request argument. Because of that, setting it to NULL\nin the caller prevents the auto-cleanup of the variable to be executed,\ncausing a resource leak. Fix it.\n\nFixes: e23b3c9c3ac8 ('Squashed 'shared/n-dhcp4/' content from commit fb1d43449')\nFixes: 243cc433fb77 ('n-dhcp4: add new client probe function to send RELEASE message')\n","title":"n-dhcp4: fix resource leaks","timestamp":"2025-04-07T14:15:09+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/9edfc0438cb6391b01999022567e6ed5aa6bb8db","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/n-dhcp4/src/n-dhcp4-c-probe.c"],"removed":[]},{"id":"95b9b4b6782f91080a605c6e2314f067eff24fde","message":"merge: branch 'ih/coverity'\n\nFix some defects detected by Coverity\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2174","title":"merge: branch 'ih/coverity'","timestamp":"2025-04-07T14:15:27+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/95b9b4b6782f91080a605c6e2314f067eff24fde","author":{"name":"Íñigo Huguet","email":"inigohuguet@hotmail.com"},"added":[],"modified":["src/core/devices/nm-device.c","src/core/nm-bond-manager.c","src/n-dhcp4/src/n-dhcp4-c-probe.c"],"removed":[]},{"id":"f01e5fbf2de7ea97a7feb31505a3e560860bfc1d","message":"nmtui: add support for configuring loopback interface\n","title":"nmtui: add support for configuring loopback interface","timestamp":"2025-04-10T11:13:24+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/f01e5fbf2de7ea97a7feb31505a3e560860bfc1d","author":{"name":"Jan Vaclav","email":"jvaclav@redhat.com"},"added":["src/nmtui/nmt-page-loopback.c","src/nmtui/nmt-page-loopback.h"],"modified":["NEWS","src/libnm-core-impl/nm-connection.c","src/nmtui/meson.build","src/nmtui/nm-editor-utils.c","src/nmtui/nmt-connect-connection-list.c","src/nmtui/nmt-editor.c"],"removed":[]},{"id":"51c861f6a8fbc635d6ff320972895a7d6c2cfc69","message":"core/devices: generate connections with autoconnect=true\n","title":"core/devices: generate connections with autoconnect=true","timestamp":"2025-04-10T11:13:24+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/51c861f6a8fbc635d6ff320972895a7d6c2cfc69","author":{"name":"Jan Vaclav","email":"jvaclav@redhat.com"},"added":[],"modified":["src/core/devices/nm-device.c"],"removed":[]},{"id":"d51f5d30ec7f322f1d3c6d64672de37f87bd7355","message":"nmtui/editor: hide \"device\" field for loopback connections\n","title":"nmtui/editor: hide \"device\" field for loopback connections","timestamp":"2025-04-10T11:13:24+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/d51f5d30ec7f322f1d3c6d64672de37f87bd7355","author":{"name":"Jan Vaclav","email":"jvaclav@redhat.com"},"added":[],"modified":["src/nmtui/nmt-editor.c","src/nmtui/nmt-page-loopback.c","src/nmtui/nmt-page-loopback.h"],"removed":[]}],"total_commits_count":19,"push_options":{},"repository":{"name":"NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","description":"NetworkManager — network management daemon","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","visibility_level":20}}