{"object_kind":"push","event_name":"push","before":"2e1bdffe79f30a469f241f0e096b94b30e23e5d9","after":"d02e27be8eee7c333e98bee4f471fdccaf59efce","ref":"refs/heads/lr/oci-vm-new-conn","ref_protected":false,"checkout_sha":"d02e27be8eee7c333e98bee4f471fdccaf59efce","message":null,"user_id":1031,"user_name":"Lubomir Rintel","user_username":"lkundrak","user_email":"","user_avatar":"https://secure.gravatar.com/avatar/0c78b09297e4f43bda3282627ada927e031aabd945d9a02df75ae525a18952a8?s=80&d=identicon","project_id":411,"project":{"id":411,"name":"NetworkManager","description":"NetworkManager — network management daemon","web_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","avatar_url":"https://gitlab.freedesktop.org/uploads/-/system/project/avatar/411/nm_logo.png","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","namespace":"NetworkManager","visibility_level":20,"path_with_namespace":"NetworkManager/NetworkManager","default_branch":"main","ci_config_path":"","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git"},"commits":[{"id":"cbdd0d9cca34f4e1cbd177e347e14265e1afaf6c","message":"core: fail early if we cannot get current FEC value\n\nIf we cannot get current FEC value probably we won't be able to set it a\nfew lines later. Also, if it fails to set, we try to use the value of\nthe old one that we tried to retrieve without success. In that case, the\nvariable old_fec_mode would be uninitialized. Fix it by returning early\nif we cannot get the current value.\n\nFixes: 19bed3121fb6 ('ethtool: support Forward Error Correction(fec)')\n","title":"core: fail early if we cannot get current FEC value","timestamp":"2025-04-03T09:44:54+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/cbdd0d9cca34f4e1cbd177e347e14265e1afaf6c","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/core/devices/nm-device.c"],"removed":[]},{"id":"245f0e0b35d385e966289080dbd2594e74a189b2","message":"core: optimize hash table search in _ethtool_fec_set\n\nBreak the loop as soon as we've found the value.\n\nFixes: 19bed3121fb6 ('ethtool: support Forward Error Correction(fec)')\n","title":"core: optimize hash table search in _ethtool_fec_set","timestamp":"2025-04-03T09:44:59+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/245f0e0b35d385e966289080dbd2594e74a189b2","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/core/devices/nm-device.c"],"removed":[]},{"id":"a4401ae0a6a0f5e241fe02beee7a7f14b4264ae9","message":"merge: branch 'ih/fec-uninit-var'\n\ncore: fail early if we cannot get current FEC value\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2177","title":"merge: branch 'ih/fec-uninit-var'","timestamp":"2025-04-07T11:05:25+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/a4401ae0a6a0f5e241fe02beee7a7f14b4264ae9","author":{"name":"Íñigo Huguet","email":"inigohuguet@hotmail.com"},"added":[],"modified":["src/core/devices/nm-device.c"],"removed":[]},{"id":"7ab3f0999f644232beb66efaaf17d72a7087b286","message":"nm-cloud-setup: removed excess validation check fields\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2150\n","title":"nm-cloud-setup: removed excess validation check fields","timestamp":"2025-04-07T15:25:49+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/7ab3f0999f644232beb66efaaf17d72a7087b286","author":{"name":"Herman Semenov","email":"GermanAizek@yandex.ru"},"added":[],"modified":["src/nm-cloud-setup/nmcs-provider-oci.c"],"removed":[]},{"id":"cc0222ba01bcb44bd5777fff94a9727d61461615","message":"nmcli/connections: fix build with libedit\n\nThis has always been broken (libedit-0:3.1-17.20160618cvs.fc26 is too\nold to work and libedit-0:3.1-20.20170329cvs.fc27.x86_64 has this type\nmismatch), but new GCC complains (14, 15).\n\n  ../src/nmcli/connections.c: In function ‘nmcli_editor_tab_completion’:\n  ../src/nmcli/connections.c:6862:64: error: assignment to ‘void (*)(char **, int,  int)’ from incompatible pointer type ‘void (*)(void)’ [-Wincompatible-pointer-types]\n   6862 |                             rl_completion_display_matches_hook = uuid_display_hook;\n        |                                                                ^\n  ../src/nmcli/connections.c:6909:60: error: assignment to ‘void (*)(char **, int,  int)’ from incompatible pointer type ‘void (*)(void)’ [-Wincompatible-pointer-types]\n   6909 |                         rl_completion_display_matches_hook = uuid_display_hook;\n        |                                                            ^\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2172\n","title":"nmcli/connections: fix build with libedit","timestamp":"2025-04-07T15:27:59+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/cc0222ba01bcb44bd5777fff94a9727d61461615","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/nmcli/connections.c"],"removed":[]},{"id":"42edb37499fdf848ec751b059a361fd37eab69d5","message":"bond-slb: initialize dest hw address in GARP packets\n\nDetected by Coverity:\n    1. NetworkManager-1.53.1/src/core/nm-bond-manager.c:885:5: var_decl: Declaring variable \"data\" without initializer.\n    7. NetworkManager-1.53.1/src/core/nm-bond-manager.c:948:13: uninit_use_in_call: Using uninitialized value \"data\". Field \"data.d_hw_addr\" is uninitialized when calling \"sendto\".\n       946|               unaligned_write_ne32(data.s_ip_addr, tmp_addr);\n       947|               unaligned_write_ne32(data.d_ip_addr, tmp_addr);\n       948|->             if (sendto(sockfd, &data, sizeof(data), 0, (struct sockaddr *) &addr, sizeof(addr)) < 0)\n       949|                   return FALSE;\n       950|           }\n\nFixes: 3f2f922dd943 ('bonding: send ARP announcement on bonding-slb link/carrier down')\n","title":"bond-slb: initialize dest hw address in GARP packets","timestamp":"2025-04-07T14:15:09+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/42edb37499fdf848ec751b059a361fd37eab69d5","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/core/nm-bond-manager.c"],"removed":[]},{"id":"ae7de5b353b8bdbfefd6a67c8fe53678cf78a60a","message":"core: fix use after free in ping operations\n\nDetected by coverity, the ping_op pointers are used after being freed in\ncleanup_ping_operations. Although calling to g_list_remove is probably\nsafe because it only needs the value of the pointer, not to dereference\nit, better to follow best practices. One of the use after free was\nactually an error because we dereference ping_op->log_domain.\n\nFixes: 658aef0fa185 ('connection: Support connection.ip-ping-addresses')\n","title":"core: fix use after free in ping operations","timestamp":"2025-04-07T14:15:09+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/ae7de5b353b8bdbfefd6a67c8fe53678cf78a60a","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/core/devices/nm-device.c"],"removed":[]},{"id":"9edfc0438cb6391b01999022567e6ed5aa6bb8db","message":"n-dhcp4: fix resource leaks\n\nThe function n_dhcp4_c_connection_send_request does not release or take\nownership of its request argument. Because of that, setting it to NULL\nin the caller prevents the auto-cleanup of the variable to be executed,\ncausing a resource leak. Fix it.\n\nFixes: e23b3c9c3ac8 ('Squashed 'shared/n-dhcp4/' content from commit fb1d43449')\nFixes: 243cc433fb77 ('n-dhcp4: add new client probe function to send RELEASE message')\n","title":"n-dhcp4: fix resource leaks","timestamp":"2025-04-07T14:15:09+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/9edfc0438cb6391b01999022567e6ed5aa6bb8db","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/n-dhcp4/src/n-dhcp4-c-probe.c"],"removed":[]},{"id":"95b9b4b6782f91080a605c6e2314f067eff24fde","message":"merge: branch 'ih/coverity'\n\nFix some defects detected by Coverity\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2174","title":"merge: branch 'ih/coverity'","timestamp":"2025-04-07T14:15:27+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/95b9b4b6782f91080a605c6e2314f067eff24fde","author":{"name":"Íñigo Huguet","email":"inigohuguet@hotmail.com"},"added":[],"modified":["src/core/devices/nm-device.c","src/core/nm-bond-manager.c","src/n-dhcp4/src/n-dhcp4-c-probe.c"],"removed":[]},{"id":"0efbb454faf80db774c3685f00a90ec9a4ddc709","message":"cloud-setup: split up _nmc_skip_connection_by_type()\n\nSplit _nmc_skip_connection_by_type() so that we can get a little\nmore finely grained error reporting.\n","title":"cloud-setup: split up _nmc_skip_connection_by_type()","timestamp":"2025-04-10T11:42:14+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/0efbb454faf80db774c3685f00a90ec9a4ddc709","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/nm-cloud-setup/main.c","src/tests/client/test-client.py"],"removed":[]},{"id":"cb95f25d7a60e99bc02488e5fe9cf0bca166398c","message":"cloud-setup: add device argument to nmcs_add_and_activate()\n\nThis will allow us to add & complete connections for existing devices,\nsuch as VNICs on OCI VMs.\n","title":"cloud-setup: add device argument to nmcs_add_and_activate()","timestamp":"2025-04-10T11:42:14+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/cb95f25d7a60e99bc02488e5fe9cf0bca166398c","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/nm-cloud-setup/main.c","src/nm-cloud-setup/nm-cloud-setup-utils.c","src/nm-cloud-setup/nm-cloud-setup-utils.h"],"removed":[]},{"id":"c6cc2023c18a918f2f5d8b6103290cc13e39a6d0","message":"cloud-setup: factor out creation of new connection\n\nWe're going to create connections on wired devices for OCI VM VNICs, and\nthey're going to also need the same user setting. Factor it out.\n","title":"cloud-setup: factor out creation of new connection","timestamp":"2025-04-10T11:42:14+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/c6cc2023c18a918f2f5d8b6103290cc13e39a6d0","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/nm-cloud-setup/main.c"],"removed":[]},{"id":"33c648b6d14606b8ae29289ef6fb2e1345019eb3","message":"cloud-setup: add a chicken bit variable for creation of new connections\n\nMake it possible to opt in or out of the behavior of creating\nconnections for disconnected devices. It's not clear why such policy was\nin place, and the feature might come useful outside OCI.\n\nLet's add an (undocumented) knob to configure the behavior. We might\nremove it (and perhaps make the behaviour default everywhere), or\ndocument and keep it if it turns out we need to use it.\n","title":"cloud-setup: add a chicken bit variable for creation of new connections","timestamp":"2025-04-10T11:42:14+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/33c648b6d14606b8ae29289ef6fb2e1345019eb3","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/nm-cloud-setup/main.c","src/nm-cloud-setup/nm-cloud-setup-utils.h"],"removed":[]},{"id":"52cf1447960ca60faab91fc459460482cc49ae34","message":"cloud-setup: configure disconnected wired devices on OCI\n\nOn OCI VMs (virtual machines, as opposed to BM -- bare metal), the VNICs\ndon't get their addresses via DHCP and need us to get the address from\nthe metadata and apply it.\n\nhttps://issues.redhat.com/browse/NMT-1432\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2180\n","title":"cloud-setup: configure disconnected wired devices on OCI","timestamp":"2025-04-10T11:42:14+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/52cf1447960ca60faab91fc459460482cc49ae34","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/nm-cloud-setup/main.c","src/nm-cloud-setup/nm-cloud-setup-utils.c"],"removed":[]},{"id":"468162c1ab778cf91641e5f4df3fa9aedad843e7","message":"test/nm-service: default the devices to DISCONNETED not UNAVAILABLE\n\nIt is a little odd that client tests connect \"UNAVAILABLE\" devices, and\nthe devices return to \"DISCONNECTED\" after deactivation.\n\nIt differs from what happens in reality, and some client tools\n(hey nm-cloud-setup) can break when they rightly assume that the\ndevice is not ready for activation when it's \"UNAVAILABLE\" not\n\"DISCONNECTED\".\n","title":"test/nm-service: default the devices to DISCONNETED not UNAVAILABLE","timestamp":"2025-04-10T11:42:14+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/468162c1ab778cf91641e5f4df3fa9aedad843e7","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/tests/client/test-client.check-on-disk/test_002.expected","src/tests/client/test-client.check-on-disk/test_003.expected","src/tests/client/test-client.check-on-disk/test_004.expected","tools/test-networkmanager-service.py"],"removed":[]},{"id":"c980574e22897c94c66582291b3a21147dc51424","message":"test-client: expand MAC addresses from variable\n\nLess literals, more expanded variables. Makes it a little easier to read\nfor me.\n","title":"test-client: expand MAC addresses from variable","timestamp":"2025-04-10T11:42:14+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/c980574e22897c94c66582291b3a21147dc51424","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/tests/client/test-client.py"],"removed":[]},{"id":"39c748a499d9198bd1844650f446e46b696c9238","message":"test-client: split up _mock_devices()\n\nThe new VM OCI VNIC tests will need to create the devices, but leave one\ndisconnected.\n","title":"test-client: split up _mock_devices()","timestamp":"2025-04-10T11:42:15+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/39c748a499d9198bd1844650f446e46b696c9238","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/tests/client/test-client.py"],"removed":[]},{"id":"d02e27be8eee7c333e98bee4f471fdccaf59efce","message":"test-client: add test for OCI VNIC on VM\n\nTests that we create a connection for disconnected device.\n","title":"test-client: add test for OCI VNIC on VM","timestamp":"2025-04-10T11:42:15+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/d02e27be8eee7c333e98bee4f471fdccaf59efce","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/tests/client/test-client.py"],"removed":[]}],"total_commits_count":18,"push_options":{},"repository":{"name":"NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","description":"NetworkManager — network management daemon","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","visibility_level":20}}