{"object_kind":"push","event_name":"push","before":"980cd6ae827f60d69fc80c6c7fd3fa19040b21f5","after":"ffd8aceaaf85fca54df30b2b43d05616f16d5007","ref":"refs/heads/ih/nmcli-ovs-port-type","ref_protected":false,"checkout_sha":"ffd8aceaaf85fca54df30b2b43d05616f16d5007","message":null,"user_id":94562,"user_name":"Íñigo Huguet","user_username":"ihuguet","user_email":"","user_avatar":"https://gitlab.freedesktop.org/uploads/-/system/user/avatar/94562/avatar.png","project_id":411,"project":{"id":411,"name":"NetworkManager","description":"NetworkManager — network management daemon","web_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","avatar_url":"https://gitlab.freedesktop.org/uploads/-/system/project/avatar/411/nm_logo.png","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","namespace":"NetworkManager","visibility_level":20,"path_with_namespace":"NetworkManager/NetworkManager","default_branch":"main","ci_config_path":"","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git"},"commits":[{"id":"cbdd0d9cca34f4e1cbd177e347e14265e1afaf6c","message":"core: fail early if we cannot get current FEC value\n\nIf we cannot get current FEC value probably we won't be able to set it a\nfew lines later. Also, if it fails to set, we try to use the value of\nthe old one that we tried to retrieve without success. In that case, the\nvariable old_fec_mode would be uninitialized. Fix it by returning early\nif we cannot get the current value.\n\nFixes: 19bed3121fb6 ('ethtool: support Forward Error Correction(fec)')\n","title":"core: fail early if we cannot get current FEC value","timestamp":"2025-04-03T09:44:54+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/cbdd0d9cca34f4e1cbd177e347e14265e1afaf6c","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/core/devices/nm-device.c"],"removed":[]},{"id":"245f0e0b35d385e966289080dbd2594e74a189b2","message":"core: optimize hash table search in _ethtool_fec_set\n\nBreak the loop as soon as we've found the value.\n\nFixes: 19bed3121fb6 ('ethtool: support Forward Error Correction(fec)')\n","title":"core: optimize hash table search in _ethtool_fec_set","timestamp":"2025-04-03T09:44:59+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/245f0e0b35d385e966289080dbd2594e74a189b2","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/core/devices/nm-device.c"],"removed":[]},{"id":"a4401ae0a6a0f5e241fe02beee7a7f14b4264ae9","message":"merge: branch 'ih/fec-uninit-var'\n\ncore: fail early if we cannot get current FEC value\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2177","title":"merge: branch 'ih/fec-uninit-var'","timestamp":"2025-04-07T11:05:25+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/a4401ae0a6a0f5e241fe02beee7a7f14b4264ae9","author":{"name":"Íñigo Huguet","email":"inigohuguet@hotmail.com"},"added":[],"modified":["src/core/devices/nm-device.c"],"removed":[]},{"id":"7ab3f0999f644232beb66efaaf17d72a7087b286","message":"nm-cloud-setup: removed excess validation check fields\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2150\n","title":"nm-cloud-setup: removed excess validation check fields","timestamp":"2025-04-07T15:25:49+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/7ab3f0999f644232beb66efaaf17d72a7087b286","author":{"name":"Herman Semenov","email":"GermanAizek@yandex.ru"},"added":[],"modified":["src/nm-cloud-setup/nmcs-provider-oci.c"],"removed":[]},{"id":"cc0222ba01bcb44bd5777fff94a9727d61461615","message":"nmcli/connections: fix build with libedit\n\nThis has always been broken (libedit-0:3.1-17.20160618cvs.fc26 is too\nold to work and libedit-0:3.1-20.20170329cvs.fc27.x86_64 has this type\nmismatch), but new GCC complains (14, 15).\n\n  ../src/nmcli/connections.c: In function ‘nmcli_editor_tab_completion’:\n  ../src/nmcli/connections.c:6862:64: error: assignment to ‘void (*)(char **, int,  int)’ from incompatible pointer type ‘void (*)(void)’ [-Wincompatible-pointer-types]\n   6862 |                             rl_completion_display_matches_hook = uuid_display_hook;\n        |                                                                ^\n  ../src/nmcli/connections.c:6909:60: error: assignment to ‘void (*)(char **, int,  int)’ from incompatible pointer type ‘void (*)(void)’ [-Wincompatible-pointer-types]\n   6909 |                         rl_completion_display_matches_hook = uuid_display_hook;\n        |                                                            ^\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2172\n","title":"nmcli/connections: fix build with libedit","timestamp":"2025-04-07T15:27:59+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/cc0222ba01bcb44bd5777fff94a9727d61461615","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/nmcli/connections.c"],"removed":[]},{"id":"42edb37499fdf848ec751b059a361fd37eab69d5","message":"bond-slb: initialize dest hw address in GARP packets\n\nDetected by Coverity:\n    1. NetworkManager-1.53.1/src/core/nm-bond-manager.c:885:5: var_decl: Declaring variable \"data\" without initializer.\n    7. NetworkManager-1.53.1/src/core/nm-bond-manager.c:948:13: uninit_use_in_call: Using uninitialized value \"data\". Field \"data.d_hw_addr\" is uninitialized when calling \"sendto\".\n       946|               unaligned_write_ne32(data.s_ip_addr, tmp_addr);\n       947|               unaligned_write_ne32(data.d_ip_addr, tmp_addr);\n       948|->             if (sendto(sockfd, &data, sizeof(data), 0, (struct sockaddr *) &addr, sizeof(addr)) < 0)\n       949|                   return FALSE;\n       950|           }\n\nFixes: 3f2f922dd943 ('bonding: send ARP announcement on bonding-slb link/carrier down')\n","title":"bond-slb: initialize dest hw address in GARP packets","timestamp":"2025-04-07T14:15:09+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/42edb37499fdf848ec751b059a361fd37eab69d5","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/core/nm-bond-manager.c"],"removed":[]},{"id":"ae7de5b353b8bdbfefd6a67c8fe53678cf78a60a","message":"core: fix use after free in ping operations\n\nDetected by coverity, the ping_op pointers are used after being freed in\ncleanup_ping_operations. Although calling to g_list_remove is probably\nsafe because it only needs the value of the pointer, not to dereference\nit, better to follow best practices. One of the use after free was\nactually an error because we dereference ping_op->log_domain.\n\nFixes: 658aef0fa185 ('connection: Support connection.ip-ping-addresses')\n","title":"core: fix use after free in ping operations","timestamp":"2025-04-07T14:15:09+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/ae7de5b353b8bdbfefd6a67c8fe53678cf78a60a","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/core/devices/nm-device.c"],"removed":[]},{"id":"9edfc0438cb6391b01999022567e6ed5aa6bb8db","message":"n-dhcp4: fix resource leaks\n\nThe function n_dhcp4_c_connection_send_request does not release or take\nownership of its request argument. Because of that, setting it to NULL\nin the caller prevents the auto-cleanup of the variable to be executed,\ncausing a resource leak. Fix it.\n\nFixes: e23b3c9c3ac8 ('Squashed 'shared/n-dhcp4/' content from commit fb1d43449')\nFixes: 243cc433fb77 ('n-dhcp4: add new client probe function to send RELEASE message')\n","title":"n-dhcp4: fix resource leaks","timestamp":"2025-04-07T14:15:09+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/9edfc0438cb6391b01999022567e6ed5aa6bb8db","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/n-dhcp4/src/n-dhcp4-c-probe.c"],"removed":[]},{"id":"95b9b4b6782f91080a605c6e2314f067eff24fde","message":"merge: branch 'ih/coverity'\n\nFix some defects detected by Coverity\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2174","title":"merge: branch 'ih/coverity'","timestamp":"2025-04-07T14:15:27+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/95b9b4b6782f91080a605c6e2314f067eff24fde","author":{"name":"Íñigo Huguet","email":"inigohuguet@hotmail.com"},"added":[],"modified":["src/core/devices/nm-device.c","src/core/nm-bond-manager.c","src/n-dhcp4/src/n-dhcp4-c-probe.c"],"removed":[]},{"id":"d0b400a328e6b5da704cbbacb78f4bcc934ad2e3","message":"nmcli: connection: process port-type, type and controller first\n\nIf the connection is a port we need to set the connection.port-type\nproperty. Usually this property is guessed by nmcli depending on the\nconnection type or the chosen controller, so it doesn't need to be\nspecified by the user. However, if it is explicitly set by the user\nwe should not guess, but just use it.\n\nWhen we process arguments like \"controller\" or \"type\" we call custom\nfunctions like set_connection_controller that will guess the port-type\nif needed. By processing port-type first, it will be set in the\nconnection by the time that these other properties are processed, so they\nwon't try to guess.\n\nAfter port-type, process connection.type and connection.controller, as we\nare usually capable of deducing the port-type from them. Type needs to\nbe processed first because some types like bond-slave or ovs-port have\nonly one possible port-type value so we must not try to guess from the\ncontroller.\n\nFixes: c5324ed285af ('nmcli: streamline connection addition')\n","title":"nmcli: connection: process port-type, type and controller first","timestamp":"2025-04-11T08:06:24+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/d0b400a328e6b5da704cbbacb78f4bcc934ad2e3","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/nmcli/connections.c","src/nmcli/connections.h","src/nmcli/devices.c"],"removed":[]},{"id":"21a6246d5a5aea3b36415e8296525ad649b5d81f","message":"nmcli: connection: don't overwrite port-type if explicitly set\n\nWhen processing the \"type\" property we deduce the port-type in some\ncases and set it. If the user has chosen a port-type we must not\noverwrite it. In any case, we should raise an error when validating the\nconnection.\n\nFixes: c5324ed285af ('nmcli: streamline connection addition')\n","title":"nmcli: connection: don't overwrite port-type if explicitly set","timestamp":"2025-04-11T08:06:24+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/21a6246d5a5aea3b36415e8296525ad649b5d81f","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/nmcli/connections.c"],"removed":[]},{"id":"4943abc4298f2be9e660f409a62251b32cb33c1b","message":"nmcli: choose the right port-type for OVS\n\nNormally it is possible not to define port-type in nmcli and it deduces\nit from connection.type or connection.controller. Some types like 'bond-slave'\nhave a single possible value for port-type. In other cases nmcli deduces\nthe port-type by getting the controller's type, like 'bond'.\n\nFor OVS connections, the second method of guessing by the controller's\ntype was used.  However, in OVS it is common to have different devices\nwith the same name, causing nmcli to use \"ovs-interface\" as port-type\nif it matched by controller name.\n\nFix if by deducing the port-type from the connection's type. An ovs-port\nconnection must always have port-type=ovs-bridge, and an ovs-interface\nconnection must always have port-type=ovs-port.\n\nNote that this is something that should be done in the daemon, not in\nthe clients, but this is a small patch that makes it to work in nmcli,\nat least. Without this, the mechanism of guessing from the parent would\nact, leading to wrong results.\n\nIdeally, all this should be done in the daemon, but currently many\nchecks in nmcli/libnm depends on having the port-type set, and it\nwould be lot of work to change it.\n\nFixes: c5324ed285af ('nmcli: streamline connection addition')\n","title":"nmcli: choose the right port-type for OVS","timestamp":"2025-04-11T08:06:25+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/4943abc4298f2be9e660f409a62251b32cb33c1b","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/nmcli/connections.c"],"removed":[]},{"id":"ffd8aceaaf85fca54df30b2b43d05616f16d5007","message":"nmcli: improve the warning message about no controller found\n\nWhen nmcli tries to match a controller it filters by its type. The\ncontroller's type must match with the port's port-type. If no controller\nmatches, the printed warning was \"doesn't refer to any existing\nprofile\". However, the profile might exist, but with wrong type. Improve\nthe message so it makes that clear.\n\nFixes: aa12bb353bca ('cli: discover slave type for a connection with a master')\n","title":"nmcli: improve the warning message about no controller found","timestamp":"2025-04-11T08:06:25+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/ffd8aceaaf85fca54df30b2b43d05616f16d5007","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/nmcli/connections.c"],"removed":[]}],"total_commits_count":13,"push_options":{},"repository":{"name":"NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","description":"NetworkManager — network management daemon","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","visibility_level":20}}