{"object_kind":"push","event_name":"push","before":"319269b0ce1ac13f2de3b20e8ed823c6cb8ace49","after":"ade617c8224f1911d8cad916097d6f275b66ad52","ref":"refs/heads/jv/nmtui-lo","ref_protected":false,"checkout_sha":"ade617c8224f1911d8cad916097d6f275b66ad52","message":null,"user_id":94502,"user_name":"Jan Vaclav","user_username":"jvaclav","user_email":"jvaclav@redhat.com","user_avatar":"https://secure.gravatar.com/avatar/63438947499d1b23df20545a5f7834ebf1fd6a34a1d5f6baad97d6e2d40df256?s=80&d=identicon","project_id":411,"project":{"id":411,"name":"NetworkManager","description":"NetworkManager — network management daemon","web_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","avatar_url":"https://gitlab.freedesktop.org/uploads/-/system/project/avatar/411/nm_logo.png","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","namespace":"NetworkManager","visibility_level":20,"path_with_namespace":"NetworkManager/NetworkManager","default_branch":"main","ci_config_path":"","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git"},"commits":[{"id":"961be7d971c403d7583c2b30f5979d0074f849ce","message":"cloud-setup: split up _nmc_skip_connection_by_type()\n\nSplit _nmc_skip_connection_by_type() so that we can get a little\nmore finely grained error reporting.\n","title":"cloud-setup: split up _nmc_skip_connection_by_type()","timestamp":"2025-04-11T11:42:54+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/961be7d971c403d7583c2b30f5979d0074f849ce","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/nm-cloud-setup/main.c","src/tests/client/test-client.py"],"removed":[]},{"id":"9895540a2447f46b4eba80cc41014272ca5f149d","message":"cloud-setup: add device argument to nmcs_add_and_activate()\n\nThis will allow us to add & complete connections for existing devices,\nsuch as VNICs on OCI VMs.\n","title":"cloud-setup: add device argument to nmcs_add_and_activate()","timestamp":"2025-04-11T11:43:00+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/9895540a2447f46b4eba80cc41014272ca5f149d","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/nm-cloud-setup/main.c","src/nm-cloud-setup/nm-cloud-setup-utils.c","src/nm-cloud-setup/nm-cloud-setup-utils.h"],"removed":[]},{"id":"93960639e8d99a8aba7975d4eba172c74b26ecc1","message":"cloud-setup: factor out creation of new connection\n\nWe're going to create connections on wired devices for OCI VM VNICs, and\nthey're going to also need the same user setting. Factor it out.\n","title":"cloud-setup: factor out creation of new connection","timestamp":"2025-04-11T11:43:20+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/93960639e8d99a8aba7975d4eba172c74b26ecc1","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/nm-cloud-setup/main.c"],"removed":[]},{"id":"0540b3c9bcdd56de9545858c9467156ce35a014b","message":"cloud-setup: add a chicken bit variable for creation of new connections\n\nMake it possible to opt in or out of the behavior of creating\nconnections for disconnected devices. It's not clear why such policy was\nin place, and the feature might come useful outside OCI.\n\nLet's add an (undocumented) knob to configure the behavior. We might\nremove it (and perhaps make the behaviour default everywhere), or\ndocument and keep it if it turns out we need to use it.\n","title":"cloud-setup: add a chicken bit variable for creation of new connections","timestamp":"2025-04-11T11:43:28+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/0540b3c9bcdd56de9545858c9467156ce35a014b","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/nm-cloud-setup/main.c","src/nm-cloud-setup/nm-cloud-setup-utils.h"],"removed":[]},{"id":"548e27ef5f77cb7aa7dfce97fdd3788fffcdbf14","message":"cloud-setup: configure disconnected wired devices on OCI\n\nOn OCI VMs (virtual machines, as opposed to BM -- bare metal), the VNICs\ndon't get their addresses via DHCP and need us to get the address from\nthe metadata and apply it.\n\nhttps://issues.redhat.com/browse/NMT-1432\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2180\n","title":"cloud-setup: configure disconnected wired devices on OCI","timestamp":"2025-04-11T11:44:05+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/548e27ef5f77cb7aa7dfce97fdd3788fffcdbf14","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/nm-cloud-setup/main.c","src/nm-cloud-setup/nm-cloud-setup-utils.c"],"removed":[]},{"id":"79b1877c02e44d8113d7911a9aec38621ca12a3c","message":"test/nm-service: default the devices to DISCONNETED not UNAVAILABLE\n\nIt is a little odd that client tests connect \"UNAVAILABLE\" devices, and\nthe devices return to \"DISCONNECTED\" after deactivation.\n\nIt differs from what happens in reality, and some client tools\n(hey nm-cloud-setup) can break when they rightly assume that the\ndevice is not ready for activation when it's \"UNAVAILABLE\" not\n\"DISCONNECTED\".\n","title":"test/nm-service: default the devices to DISCONNETED not UNAVAILABLE","timestamp":"2025-04-11T11:44:05+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/79b1877c02e44d8113d7911a9aec38621ca12a3c","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/tests/client/test-client.check-on-disk/test_002.expected","src/tests/client/test-client.check-on-disk/test_003.expected","src/tests/client/test-client.check-on-disk/test_004.expected","tools/test-networkmanager-service.py"],"removed":[]},{"id":"39db524d940e611762f6355457dbf445503fd942","message":"test-client: expand MAC addresses from variable\n\nLess literals, more expanded variables. Makes it a little easier to read\nfor me.\n","title":"test-client: expand MAC addresses from variable","timestamp":"2025-04-11T11:44:05+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/39db524d940e611762f6355457dbf445503fd942","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/tests/client/test-client.py"],"removed":[]},{"id":"c42322bd0da7e032514e52c05137db40a94614ac","message":"test-client: split up _mock_devices()\n\nThe new VM OCI VNIC tests will need to create the devices, but leave one\ndisconnected.\n","title":"test-client: split up _mock_devices()","timestamp":"2025-04-11T11:44:05+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/c42322bd0da7e032514e52c05137db40a94614ac","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/tests/client/test-client.py"],"removed":[]},{"id":"cb7157f552fa90fa7f25611baf8eb36c93f6eb4d","message":"test-client: add test for OCI VNIC on VM\n\nTests that we create a connection for disconnected device.\n","title":"test-client: add test for OCI VNIC on VM","timestamp":"2025-04-11T11:44:05+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/cb7157f552fa90fa7f25611baf8eb36c93f6eb4d","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/tests/client/test-client.py"],"removed":[]},{"id":"fe0b6ad68c23eca8da3a47257fa6b7ec6dd5cfb7","message":"merge: branch 'lr/oci-vm-new-conn'\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2180\n","title":"merge: branch 'lr/oci-vm-new-conn'","timestamp":"2025-04-11T12:09:49+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/fe0b6ad68c23eca8da3a47257fa6b7ec6dd5cfb7","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/nm-cloud-setup/main.c","src/nm-cloud-setup/nm-cloud-setup-utils.c","src/nm-cloud-setup/nm-cloud-setup-utils.h","src/tests/client/test-client.check-on-disk/test_002.expected","src/tests/client/test-client.check-on-disk/test_003.expected","src/tests/client/test-client.check-on-disk/test_004.expected","src/tests/client/test-client.py","tools/test-networkmanager-service.py"],"removed":[]},{"id":"163c2574d885a2983702612788b3458c3d6ecc0d","message":"device: renew dhcp lease only if carrier was down\n\nMake sure nm_device_update_dynamic_ip_setup is called every time a carrier was down before and the link is now up again.\nPreviously the dhcp lease was not renewed if the carrier went down and then up again quickly enough.\nThis led to cases where an old IP was retained even though the device was connected to a different network with a different DHCP server.\n\nThis commit introduces device_link_carrier_changed_down\n\nFixes: d6429d3ddbc7 ('device: ensure DHCP is restarted every time the link goes up')\n","title":"device: renew dhcp lease only if carrier was down","timestamp":"2025-04-14T07:04:03+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/163c2574d885a2983702612788b3458c3d6ecc0d","author":{"name":"Friedrich Altheide","email":"friedrich.altheide@w34you.de"},"added":[],"modified":["src/core/devices/nm-device.c"],"removed":[]},{"id":"fcf304bbf1d00355428ba5242dcb9b624dd35729","message":"merge: branch 'carrier-down'\n\ndevice: renew dhcp lease if carrier was down\n\nCloses #1663\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2173","title":"merge: branch 'carrier-down'","timestamp":"2025-04-14T07:48:44+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/fcf304bbf1d00355428ba5242dcb9b624dd35729","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/core/devices/nm-device.c"],"removed":[]},{"id":"cce22337bb1fa0ed95be10f4adac00cf8921746d","message":"nmtui: add page for configuring loopback interface\n","title":"nmtui: add page for configuring loopback interface","timestamp":"2025-04-14T10:11:59+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/cce22337bb1fa0ed95be10f4adac00cf8921746d","author":{"name":"Jan Vaclav","email":"jvaclav@redhat.com"},"added":["src/nmtui/nmt-page-loopback.c","src/nmtui/nmt-page-loopback.h"],"modified":["NEWS","src/libnm-core-impl/nm-connection.c","src/nmtui/meson.build","src/nmtui/nm-editor-utils.c","src/nmtui/nmt-connect-connection-list.c","src/nmtui/nmt-editor.c"],"removed":[]},{"id":"597fec649682851450611a56a5a8d7309d3f4fce","message":"core/devices: generate connections with autoconnect=true\n\nPreviously, when a generated connection was edited, and the\nmachine was rebooted, the connection would not apply, and a\nnew generated connection would be made, because autoconnect\nwas set to FALSE.\n\nSet autoconnect to be true by default, so that the modified\ngenerated connection is applied.\n","title":"core/devices: generate connections with autoconnect=true","timestamp":"2025-04-14T10:12:09+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/597fec649682851450611a56a5a8d7309d3f4fce","author":{"name":"Jan Vaclav","email":"jvaclav@redhat.com"},"added":[],"modified":["src/core/devices/nm-device.c"],"removed":[]},{"id":"ade617c8224f1911d8cad916097d6f275b66ad52","message":"nmtui/editor: hide \"device\" field for loopback connections\n\nThis field is irrelevant for this device type, since it will always\nbe just \"lo\".\n","title":"nmtui/editor: hide \"device\" field for loopback connections","timestamp":"2025-04-14T10:14:51+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/ade617c8224f1911d8cad916097d6f275b66ad52","author":{"name":"Jan Vaclav","email":"jvaclav@redhat.com"},"added":[],"modified":["src/nmtui/nmt-editor.c","src/nmtui/nmt-page-loopback.c","src/nmtui/nmt-page-loopback.h"],"removed":[]}],"total_commits_count":15,"push_options":{},"repository":{"name":"NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","description":"NetworkManager — network management daemon","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","visibility_level":20}}