{"object_kind":"push","event_name":"push","before":"78b308cd5a5545275b81254ad2e070624e52e11b","after":"5639ddd3fd4124b6887e460c0a8eafe55db607f5","ref":"refs/heads/bg/ovs-base-settings","ref_protected":false,"checkout_sha":"5639ddd3fd4124b6887e460c0a8eafe55db607f5","message":null,"user_id":94562,"user_name":"Íñigo Huguet","user_username":"ihuguet","user_email":"","user_avatar":"https://gitlab.freedesktop.org/uploads/-/system/user/avatar/94562/avatar.png","project_id":411,"project":{"id":411,"name":"NetworkManager","description":"NetworkManager — network management daemon","web_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","avatar_url":"https://gitlab.freedesktop.org/uploads/-/system/project/avatar/411/nm_logo.png","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","namespace":"NetworkManager","visibility_level":20,"path_with_namespace":"NetworkManager/NetworkManager","default_branch":"main","ci_config_path":"","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git"},"commits":[{"id":"9edfc0438cb6391b01999022567e6ed5aa6bb8db","message":"n-dhcp4: fix resource leaks\n\nThe function n_dhcp4_c_connection_send_request does not release or take\nownership of its request argument. Because of that, setting it to NULL\nin the caller prevents the auto-cleanup of the variable to be executed,\ncausing a resource leak. Fix it.\n\nFixes: e23b3c9c3ac8 ('Squashed 'shared/n-dhcp4/' content from commit fb1d43449')\nFixes: 243cc433fb77 ('n-dhcp4: add new client probe function to send RELEASE message')\n","title":"n-dhcp4: fix resource leaks","timestamp":"2025-04-07T14:15:09+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/9edfc0438cb6391b01999022567e6ed5aa6bb8db","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/n-dhcp4/src/n-dhcp4-c-probe.c"],"removed":[]},{"id":"95b9b4b6782f91080a605c6e2314f067eff24fde","message":"merge: branch 'ih/coverity'\n\nFix some defects detected by Coverity\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2174","title":"merge: branch 'ih/coverity'","timestamp":"2025-04-07T14:15:27+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/95b9b4b6782f91080a605c6e2314f067eff24fde","author":{"name":"Íñigo Huguet","email":"inigohuguet@hotmail.com"},"added":[],"modified":["src/core/devices/nm-device.c","src/core/nm-bond-manager.c","src/n-dhcp4/src/n-dhcp4-c-probe.c"],"removed":[]},{"id":"961be7d971c403d7583c2b30f5979d0074f849ce","message":"cloud-setup: split up _nmc_skip_connection_by_type()\n\nSplit _nmc_skip_connection_by_type() so that we can get a little\nmore finely grained error reporting.\n","title":"cloud-setup: split up _nmc_skip_connection_by_type()","timestamp":"2025-04-11T11:42:54+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/961be7d971c403d7583c2b30f5979d0074f849ce","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/nm-cloud-setup/main.c","src/tests/client/test-client.py"],"removed":[]},{"id":"9895540a2447f46b4eba80cc41014272ca5f149d","message":"cloud-setup: add device argument to nmcs_add_and_activate()\n\nThis will allow us to add & complete connections for existing devices,\nsuch as VNICs on OCI VMs.\n","title":"cloud-setup: add device argument to nmcs_add_and_activate()","timestamp":"2025-04-11T11:43:00+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/9895540a2447f46b4eba80cc41014272ca5f149d","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/nm-cloud-setup/main.c","src/nm-cloud-setup/nm-cloud-setup-utils.c","src/nm-cloud-setup/nm-cloud-setup-utils.h"],"removed":[]},{"id":"93960639e8d99a8aba7975d4eba172c74b26ecc1","message":"cloud-setup: factor out creation of new connection\n\nWe're going to create connections on wired devices for OCI VM VNICs, and\nthey're going to also need the same user setting. Factor it out.\n","title":"cloud-setup: factor out creation of new connection","timestamp":"2025-04-11T11:43:20+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/93960639e8d99a8aba7975d4eba172c74b26ecc1","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/nm-cloud-setup/main.c"],"removed":[]},{"id":"0540b3c9bcdd56de9545858c9467156ce35a014b","message":"cloud-setup: add a chicken bit variable for creation of new connections\n\nMake it possible to opt in or out of the behavior of creating\nconnections for disconnected devices. It's not clear why such policy was\nin place, and the feature might come useful outside OCI.\n\nLet's add an (undocumented) knob to configure the behavior. We might\nremove it (and perhaps make the behaviour default everywhere), or\ndocument and keep it if it turns out we need to use it.\n","title":"cloud-setup: add a chicken bit variable for creation of new connections","timestamp":"2025-04-11T11:43:28+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/0540b3c9bcdd56de9545858c9467156ce35a014b","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/nm-cloud-setup/main.c","src/nm-cloud-setup/nm-cloud-setup-utils.h"],"removed":[]},{"id":"548e27ef5f77cb7aa7dfce97fdd3788fffcdbf14","message":"cloud-setup: configure disconnected wired devices on OCI\n\nOn OCI VMs (virtual machines, as opposed to BM -- bare metal), the VNICs\ndon't get their addresses via DHCP and need us to get the address from\nthe metadata and apply it.\n\nhttps://issues.redhat.com/browse/NMT-1432\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2180\n","title":"cloud-setup: configure disconnected wired devices on OCI","timestamp":"2025-04-11T11:44:05+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/548e27ef5f77cb7aa7dfce97fdd3788fffcdbf14","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/nm-cloud-setup/main.c","src/nm-cloud-setup/nm-cloud-setup-utils.c"],"removed":[]},{"id":"79b1877c02e44d8113d7911a9aec38621ca12a3c","message":"test/nm-service: default the devices to DISCONNETED not UNAVAILABLE\n\nIt is a little odd that client tests connect \"UNAVAILABLE\" devices, and\nthe devices return to \"DISCONNECTED\" after deactivation.\n\nIt differs from what happens in reality, and some client tools\n(hey nm-cloud-setup) can break when they rightly assume that the\ndevice is not ready for activation when it's \"UNAVAILABLE\" not\n\"DISCONNECTED\".\n","title":"test/nm-service: default the devices to DISCONNETED not UNAVAILABLE","timestamp":"2025-04-11T11:44:05+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/79b1877c02e44d8113d7911a9aec38621ca12a3c","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/tests/client/test-client.check-on-disk/test_002.expected","src/tests/client/test-client.check-on-disk/test_003.expected","src/tests/client/test-client.check-on-disk/test_004.expected","tools/test-networkmanager-service.py"],"removed":[]},{"id":"39db524d940e611762f6355457dbf445503fd942","message":"test-client: expand MAC addresses from variable\n\nLess literals, more expanded variables. Makes it a little easier to read\nfor me.\n","title":"test-client: expand MAC addresses from variable","timestamp":"2025-04-11T11:44:05+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/39db524d940e611762f6355457dbf445503fd942","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/tests/client/test-client.py"],"removed":[]},{"id":"c42322bd0da7e032514e52c05137db40a94614ac","message":"test-client: split up _mock_devices()\n\nThe new VM OCI VNIC tests will need to create the devices, but leave one\ndisconnected.\n","title":"test-client: split up _mock_devices()","timestamp":"2025-04-11T11:44:05+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/c42322bd0da7e032514e52c05137db40a94614ac","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/tests/client/test-client.py"],"removed":[]},{"id":"cb7157f552fa90fa7f25611baf8eb36c93f6eb4d","message":"test-client: add test for OCI VNIC on VM\n\nTests that we create a connection for disconnected device.\n","title":"test-client: add test for OCI VNIC on VM","timestamp":"2025-04-11T11:44:05+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/cb7157f552fa90fa7f25611baf8eb36c93f6eb4d","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/tests/client/test-client.py"],"removed":[]},{"id":"fe0b6ad68c23eca8da3a47257fa6b7ec6dd5cfb7","message":"merge: branch 'lr/oci-vm-new-conn'\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2180\n","title":"merge: branch 'lr/oci-vm-new-conn'","timestamp":"2025-04-11T12:09:49+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/fe0b6ad68c23eca8da3a47257fa6b7ec6dd5cfb7","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/nm-cloud-setup/main.c","src/nm-cloud-setup/nm-cloud-setup-utils.c","src/nm-cloud-setup/nm-cloud-setup-utils.h","src/tests/client/test-client.check-on-disk/test_002.expected","src/tests/client/test-client.check-on-disk/test_003.expected","src/tests/client/test-client.check-on-disk/test_004.expected","src/tests/client/test-client.py","tools/test-networkmanager-service.py"],"removed":[]},{"id":"163c2574d885a2983702612788b3458c3d6ecc0d","message":"device: renew dhcp lease only if carrier was down\n\nMake sure nm_device_update_dynamic_ip_setup is called every time a carrier was down before and the link is now up again.\nPreviously the dhcp lease was not renewed if the carrier went down and then up again quickly enough.\nThis led to cases where an old IP was retained even though the device was connected to a different network with a different DHCP server.\n\nThis commit introduces device_link_carrier_changed_down\n\nFixes: d6429d3ddbc7 ('device: ensure DHCP is restarted every time the link goes up')\n","title":"device: renew dhcp lease only if carrier was down","timestamp":"2025-04-14T07:04:03+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/163c2574d885a2983702612788b3458c3d6ecc0d","author":{"name":"Friedrich Altheide","email":"friedrich.altheide@w34you.de"},"added":[],"modified":["src/core/devices/nm-device.c"],"removed":[]},{"id":"fcf304bbf1d00355428ba5242dcb9b624dd35729","message":"merge: branch 'carrier-down'\n\ndevice: renew dhcp lease if carrier was down\n\nCloses #1663\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2173","title":"merge: branch 'carrier-down'","timestamp":"2025-04-14T07:48:44+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/fcf304bbf1d00355428ba5242dcb9b624dd35729","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/core/devices/nm-device.c"],"removed":[]},{"id":"bb850fda0ed98988a48f81928b8dedfa7ae65b6e","message":"nmcli: connection: process port-type, type and controller first\n\nIf the connection is a port we need to set the connection.port-type\nproperty. Usually this property is guessed by nmcli depending on the\nconnection type or the chosen controller, so it doesn't need to be\nspecified by the user. However, if it is explicitly set by the user\nwe should not guess, but just use it.\n\nWhen we process arguments like \"controller\" or \"type\" we call custom\nfunctions like set_connection_controller that will guess the port-type\nif needed. By processing port-type first, it will be set in the\nconnection by the time that these other properties are processed, so they\nwon't try to guess.\n\nAfter port-type, process connection.type and connection.controller, as we\nare usually capable of deducing the port-type from them. Type needs to\nbe processed first because some types like bond-slave or ovs-port have\nonly one possible port-type value so we must not try to guess from the\ncontroller.\n\nFixes: c5324ed285af ('nmcli: streamline connection addition')\n","title":"nmcli: connection: process port-type, type and controller first","timestamp":"2025-04-14T10:08:01+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/bb850fda0ed98988a48f81928b8dedfa7ae65b6e","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/nmcli/connections.c","src/nmcli/connections.h","src/nmcli/devices.c"],"removed":[]},{"id":"6a133d10a1e54c21fbacf7893f69c71fc6a41f48","message":"nmcli: connection: don't overwrite port-type if explicitly set\n\nWhen processing the \"type\" property we deduce the port-type in some\ncases and set it. If the user has chosen a port-type we must not\noverwrite it. In any case, we should raise an error when validating the\nconnection.\n\nFixes: c5324ed285af ('nmcli: streamline connection addition')\n","title":"nmcli: connection: don't overwrite port-type if explicitly set","timestamp":"2025-04-14T10:08:01+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/6a133d10a1e54c21fbacf7893f69c71fc6a41f48","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/nmcli/connections.c"],"removed":[]},{"id":"87a5d89f750d03a27402f5fd5470bed6723c5a98","message":"nmcli: choose the right port-type for OVS\n\nNormally it is possible not to define port-type in nmcli and it deduces\nit from connection.type or connection.controller. Some types like 'bond-slave'\nhave a single possible value for port-type. In other cases nmcli deduces\nthe port-type by getting the controller's type, like 'bond'.\n\nFor OVS connections, the second method of guessing by the controller's\ntype was used.  However, in OVS it is common to have different devices\nwith the same name, causing nmcli to use \"ovs-interface\" as port-type\nif it matched by controller name.\n\nFix if by deducing the port-type from the connection's type. An ovs-port\nconnection must always have port-type=ovs-bridge, and an ovs-interface\nconnection must always have port-type=ovs-port.\n\nNote that this is something that should be done in the daemon, not in\nthe clients, but this is a small patch that makes it to work in nmcli,\nat least. Without this, the mechanism of guessing from the parent would\nact, leading to wrong results.\n\nIdeally, all this should be done in the daemon, but currently many\nchecks in nmcli/libnm depends on having the port-type set, and it\nwould be lot of work to change it.\n\nFixes: c5324ed285af ('nmcli: streamline connection addition')\n","title":"nmcli: choose the right port-type for OVS","timestamp":"2025-04-14T10:08:01+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/87a5d89f750d03a27402f5fd5470bed6723c5a98","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/nmcli/connections.c"],"removed":[]},{"id":"9f6562869b664f330aab36085457bda1487c8631","message":"nmcli: improve the warning message about no controller found\n\nWhen nmcli tries to match a controller it filters by its type. The\ncontroller's type must match with the port's port-type. If no controller\nmatches, the printed warning was \"doesn't refer to any existing\nprofile\". However, the profile might exist, but with wrong type. Improve\nthe message so it makes that clear.\n\nFixes: aa12bb353bca ('cli: discover slave type for a connection with a master')\n","title":"nmcli: improve the warning message about no controller found","timestamp":"2025-04-14T10:08:01+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/9f6562869b664f330aab36085457bda1487c8631","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/nmcli/connections.c"],"removed":[]},{"id":"26f2673b9061dabccdd3ed937b49f737201d0cf5","message":"merge: branch 'ih/nmcli-ovs-port-type'\n\nnmcli: connection: process port-type, type and controller properties first\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2165","title":"merge: branch 'ih/nmcli-ovs-port-type'","timestamp":"2025-04-14T10:08:28+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/26f2673b9061dabccdd3ed937b49f737201d0cf5","author":{"name":"Íñigo Huguet","email":"inigohuguet@hotmail.com"},"added":[],"modified":["src/nmcli/connections.c","src/nmcli/connections.h","src/nmcli/devices.c"],"removed":[]},{"id":"5639ddd3fd4124b6887e460c0a8eafe55db607f5","message":"libnm-core: set ovs-dpdk and ovs-patch as non-base settings\n\nSettings \"ovs-dpdk\" and \"ovs-patch\" are currently marked with priority\nNM_SETTING_PRIORITY_HW_BASE, which makes them \"base\" settings. This\nmeans that they can be used as connection type, for example via \"nmcli\nconnection add type ovs-dpdk ...\".\n\nThis is wrong, as both settings can only belong to a connection of\ntype \"ovs-interface\". Decrease their priority and make them non-base\nsettings.\n\nThe problem was spotted when trying to add a ovs-patch connection via\nnmcli:\n\n  # nmcli connection add type ovs-patch ifname p con-name q ovs-patch.peer r controller s port-type ovs-port\n  Warning: controller='s' doesn't refer to any existing profile.\n\n  (process:4580): nm-CRITICAL **: 10:15:42.807: file ../src/libnm-core-impl/nm-connection.c: line 1682 (_normalize_ovs_interface_type): should not be reached\n\n  (process:4580): nm-WARNING **: 10:15:42.807: connection did not verify after normalization: ??\n\n  (process:4580): nm-CRITICAL **: 10:15:42.807: file ../src/libnm-core-impl/nm-connection.c: line 2170 (_connection_normalize): should not be reached\n  Error: Failed to add 'q' connection: ovs-interface.type: A connection with 'ovs-patch' setting must be of connection.type \"ovs-interface\" but is \"ovs-patch\"\n\nFixes: d0ec5011638e ('cli: assert that valid_parts are set for base types')\n","title":"libnm-core: set ovs-dpdk and ovs-patch as non-base settings","timestamp":"2025-04-14T10:08:55+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/5639ddd3fd4124b6887e460c0a8eafe55db607f5","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/libnm-core-impl/nm-meta-setting-base-impl.c","src/libnmc-setting/nm-meta-setting-base-impl.c","src/libnmc-setting/nm-meta-setting-desc.c","src/nmcli/gen-metadata-nm-settings-nmcli.xml.in"],"removed":[]}],"total_commits_count":27,"push_options":{},"repository":{"name":"NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","description":"NetworkManager — network management daemon","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","visibility_level":20}}