{"object_kind":"push","event_name":"push","before":"c61c23cc82145c234b261c76540f87adfcc33937","after":"592987ac31e82f2ec6a38cb979bfe1cabb032a63","ref":"refs/heads/jv/nmtui-lo","ref_protected":false,"checkout_sha":"592987ac31e82f2ec6a38cb979bfe1cabb032a63","message":null,"user_id":94502,"user_name":"Jan Vaclav","user_username":"jvaclav","user_email":"jvaclav@redhat.com","user_avatar":"https://secure.gravatar.com/avatar/63438947499d1b23df20545a5f7834ebf1fd6a34a1d5f6baad97d6e2d40df256?s=80&d=identicon","project_id":411,"project":{"id":411,"name":"NetworkManager","description":"NetworkManager — network management daemon","web_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","avatar_url":"https://gitlab.freedesktop.org/uploads/-/system/project/avatar/411/nm_logo.png","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","namespace":"NetworkManager","visibility_level":20,"path_with_namespace":"NetworkManager/NetworkManager","default_branch":"main","ci_config_path":"","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git"},"commits":[{"id":"bb850fda0ed98988a48f81928b8dedfa7ae65b6e","message":"nmcli: connection: process port-type, type and controller first\n\nIf the connection is a port we need to set the connection.port-type\nproperty. Usually this property is guessed by nmcli depending on the\nconnection type or the chosen controller, so it doesn't need to be\nspecified by the user. However, if it is explicitly set by the user\nwe should not guess, but just use it.\n\nWhen we process arguments like \"controller\" or \"type\" we call custom\nfunctions like set_connection_controller that will guess the port-type\nif needed. By processing port-type first, it will be set in the\nconnection by the time that these other properties are processed, so they\nwon't try to guess.\n\nAfter port-type, process connection.type and connection.controller, as we\nare usually capable of deducing the port-type from them. Type needs to\nbe processed first because some types like bond-slave or ovs-port have\nonly one possible port-type value so we must not try to guess from the\ncontroller.\n\nFixes: c5324ed285af ('nmcli: streamline connection addition')\n","title":"nmcli: connection: process port-type, type and controller first","timestamp":"2025-04-14T10:08:01+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/bb850fda0ed98988a48f81928b8dedfa7ae65b6e","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/nmcli/connections.c","src/nmcli/connections.h","src/nmcli/devices.c"],"removed":[]},{"id":"6a133d10a1e54c21fbacf7893f69c71fc6a41f48","message":"nmcli: connection: don't overwrite port-type if explicitly set\n\nWhen processing the \"type\" property we deduce the port-type in some\ncases and set it. If the user has chosen a port-type we must not\noverwrite it. In any case, we should raise an error when validating the\nconnection.\n\nFixes: c5324ed285af ('nmcli: streamline connection addition')\n","title":"nmcli: connection: don't overwrite port-type if explicitly set","timestamp":"2025-04-14T10:08:01+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/6a133d10a1e54c21fbacf7893f69c71fc6a41f48","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/nmcli/connections.c"],"removed":[]},{"id":"87a5d89f750d03a27402f5fd5470bed6723c5a98","message":"nmcli: choose the right port-type for OVS\n\nNormally it is possible not to define port-type in nmcli and it deduces\nit from connection.type or connection.controller. Some types like 'bond-slave'\nhave a single possible value for port-type. In other cases nmcli deduces\nthe port-type by getting the controller's type, like 'bond'.\n\nFor OVS connections, the second method of guessing by the controller's\ntype was used.  However, in OVS it is common to have different devices\nwith the same name, causing nmcli to use \"ovs-interface\" as port-type\nif it matched by controller name.\n\nFix if by deducing the port-type from the connection's type. An ovs-port\nconnection must always have port-type=ovs-bridge, and an ovs-interface\nconnection must always have port-type=ovs-port.\n\nNote that this is something that should be done in the daemon, not in\nthe clients, but this is a small patch that makes it to work in nmcli,\nat least. Without this, the mechanism of guessing from the parent would\nact, leading to wrong results.\n\nIdeally, all this should be done in the daemon, but currently many\nchecks in nmcli/libnm depends on having the port-type set, and it\nwould be lot of work to change it.\n\nFixes: c5324ed285af ('nmcli: streamline connection addition')\n","title":"nmcli: choose the right port-type for OVS","timestamp":"2025-04-14T10:08:01+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/87a5d89f750d03a27402f5fd5470bed6723c5a98","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/nmcli/connections.c"],"removed":[]},{"id":"9f6562869b664f330aab36085457bda1487c8631","message":"nmcli: improve the warning message about no controller found\n\nWhen nmcli tries to match a controller it filters by its type. The\ncontroller's type must match with the port's port-type. If no controller\nmatches, the printed warning was \"doesn't refer to any existing\nprofile\". However, the profile might exist, but with wrong type. Improve\nthe message so it makes that clear.\n\nFixes: aa12bb353bca ('cli: discover slave type for a connection with a master')\n","title":"nmcli: improve the warning message about no controller found","timestamp":"2025-04-14T10:08:01+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/9f6562869b664f330aab36085457bda1487c8631","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/nmcli/connections.c"],"removed":[]},{"id":"26f2673b9061dabccdd3ed937b49f737201d0cf5","message":"merge: branch 'ih/nmcli-ovs-port-type'\n\nnmcli: connection: process port-type, type and controller properties first\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2165","title":"merge: branch 'ih/nmcli-ovs-port-type'","timestamp":"2025-04-14T10:08:28+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/26f2673b9061dabccdd3ed937b49f737201d0cf5","author":{"name":"Íñigo Huguet","email":"inigohuguet@hotmail.com"},"added":[],"modified":["src/nmcli/connections.c","src/nmcli/connections.h","src/nmcli/devices.c"],"removed":[]},{"id":"37d8945b13fd04d474667c443c95333c8542312e","message":"libnm: fix memory leak when parsing IP configuration\n\nWhen the dictionary contains keys \"address\" and \"uri\", the first value\nis leaked.\n\n  ==4730== 14 bytes in 1 blocks are definitely lost in loss record 51 of 1,755\n  ==4730==    at 0x4841866: malloc (vg_replace_malloc.c:446)\n  ==4730==    by 0x4CC5CB9: g_malloc (gmem.c:100)\n  ==4730==    by 0x4CDF518: g_strdup (gstrfuncs.c:323)\n  ==4730==    by 0x496A6B8: g_strdup_inline (gstrfuncs.h:321)\n  ==4730==    by 0x496A6B8: nm_inet_ntop_dup (nm-inet-utils.h:355)\n  ==4730==    by 0x496A95B: nm_inet_parse_str (nm-inet-utils.c:539)\n  ==4730==    by 0x48AF3A3: _notify_update_prop_nameservers (nm-ip-config.c:179)\n\nFixes: 4422b1470496 ('core, libnm: support per-connection DNS URIs')\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2184\n","title":"libnm: fix memory leak when parsing IP configuration","timestamp":"2025-04-14T13:36:57+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/37d8945b13fd04d474667c443c95333c8542312e","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/libnm-client-impl/nm-ip-config.c"],"removed":[]},{"id":"14106431fbe7091ba41e593afbf2346c7ed6fdc3","message":"libnm-core: set ovs-dpdk and ovs-patch as non-base settings\n\nSettings \"ovs-dpdk\" and \"ovs-patch\" are currently marked with priority\nNM_SETTING_PRIORITY_HW_BASE, which makes them \"base\" settings. This\nmeans that they can be used as connection type, for example via \"nmcli\nconnection add type ovs-dpdk ...\".\n\nThis is wrong, as both settings can only belong to a connection of\ntype \"ovs-interface\". Decrease their priority and make them non-base\nsettings.\n\nThe problem was spotted when trying to add a ovs-patch connection via\nnmcli:\n\n  # nmcli connection add type ovs-patch ifname p con-name q ovs-patch.peer r controller s port-type ovs-port\n  Warning: controller='s' doesn't refer to any existing profile.\n\n  (process:4580): nm-CRITICAL **: 10:15:42.807: file ../src/libnm-core-impl/nm-connection.c: line 1682 (_normalize_ovs_interface_type): should not be reached\n\n  (process:4580): nm-WARNING **: 10:15:42.807: connection did not verify after normalization: ??\n\n  (process:4580): nm-CRITICAL **: 10:15:42.807: file ../src/libnm-core-impl/nm-connection.c: line 2170 (_connection_normalize): should not be reached\n  Error: Failed to add 'q' connection: ovs-interface.type: A connection with 'ovs-patch' setting must be of connection.type \"ovs-interface\" but is \"ovs-patch\"\n\nFixes: d0ec5011638e ('cli: assert that valid_parts are set for base types')\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2178\n","title":"libnm-core: set ovs-dpdk and ovs-patch as non-base settings","timestamp":"2025-04-14T13:39:13+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/14106431fbe7091ba41e593afbf2346c7ed6fdc3","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/libnm-core-impl/nm-meta-setting-base-impl.c","src/libnmc-setting/nm-meta-setting-base-impl.c","src/libnmc-setting/nm-meta-setting-desc.c","src/nmcli/gen-metadata-nm-settings-nmcli.xml.in"],"removed":[]},{"id":"b7b8b3a8ca441783aebf2db0410aefdd644ad9e5","message":"nmtui: add page for configuring loopback interface\n","title":"nmtui: add page for configuring loopback interface","timestamp":"2025-04-14T13:24:44+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/b7b8b3a8ca441783aebf2db0410aefdd644ad9e5","author":{"name":"Jan Vaclav","email":"jvaclav@redhat.com"},"added":["src/nmtui/nmt-page-loopback.c","src/nmtui/nmt-page-loopback.h"],"modified":["NEWS","po/POTFILES.in","src/libnm-core-impl/nm-connection.c","src/nmtui/meson.build","src/nmtui/nm-editor-utils.c","src/nmtui/nmt-connect-connection-list.c","src/nmtui/nmt-editor.c"],"removed":[]},{"id":"3050b30782e8dbf0ecad2f2420dfd0b1b81f6aa7","message":"core/devices: generate connections with autoconnect=true\n\nPreviously, when a generated connection was edited, and the\nmachine was rebooted, the connection would not apply, and a\nnew generated connection would be made, because autoconnect\nwas set to FALSE.\n\nSet autoconnect to be true by default, so that the modified\ngenerated connection is applied.\n","title":"core/devices: generate connections with autoconnect=true","timestamp":"2025-04-14T13:24:44+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/3050b30782e8dbf0ecad2f2420dfd0b1b81f6aa7","author":{"name":"Jan Vaclav","email":"jvaclav@redhat.com"},"added":[],"modified":["src/core/devices/nm-device.c"],"removed":[]},{"id":"592987ac31e82f2ec6a38cb979bfe1cabb032a63","message":"nmtui/editor: hide \"device\" field for loopback connections\n\nThis field is irrelevant for this device type, since it will always\nbe just \"lo\".\n","title":"nmtui/editor: hide \"device\" field for loopback connections","timestamp":"2025-04-14T13:24:44+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/592987ac31e82f2ec6a38cb979bfe1cabb032a63","author":{"name":"Jan Vaclav","email":"jvaclav@redhat.com"},"added":[],"modified":["src/nmtui/nmt-editor.c","src/nmtui/nmt-page-loopback.c","src/nmtui/nmt-page-loopback.h"],"removed":[]}],"total_commits_count":10,"push_options":{},"repository":{"name":"NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","description":"NetworkManager — network management daemon","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","visibility_level":20}}