{"object_kind":"push","event_name":"push","before":"d8eb9473eceb2d13f7a0a4a5d8611e2dfe89b3a2","after":"657779357125c84cdc2520182befc7d74f8765c8","ref":"refs/heads/bg/ethtool-netlink","ref_protected":false,"checkout_sha":"657779357125c84cdc2520182befc7d74f8765c8","message":null,"user_id":1050,"user_name":"Beniamino Galvani","user_username":"bgalvani","user_email":"","user_avatar":"https://gitlab.freedesktop.org/uploads/-/system/user/avatar/1050/avatar.png","project_id":411,"project":{"id":411,"name":"NetworkManager","description":"NetworkManager — network management daemon","web_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","avatar_url":"https://gitlab.freedesktop.org/uploads/-/system/project/avatar/411/nm_logo.png","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","namespace":"NetworkManager","visibility_level":20,"path_with_namespace":"NetworkManager/NetworkManager","default_branch":"main","ci_config_path":"","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git"},"commits":[{"id":"ec6d122cc96730b91f0aa1e3eee748992473c4ad","message":"release: bump version to 1.53.3 (development)\n","title":"release: bump version to 1.53.3 (development)","timestamp":"2025-04-14T19:16:15+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/ec6d122cc96730b91f0aa1e3eee748992473c4ad","author":{"name":"Filip Pokryvka","email":"fpokryvk@redhat.com"},"added":[],"modified":["meson.build"],"removed":[]},{"id":"b571e2be5a886b675c39b28f173d05aa299a879b","message":"man: fix syntax to match on connection-id\n\nFixes: 604c611cd052 ('core: add nm_utils_connection_match_spec_list()')\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/1746\n","title":"man: fix syntax to match on connection-id","timestamp":"2025-04-15T11:15:02+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/b571e2be5a886b675c39b28f173d05aa299a879b","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["man/NetworkManager.conf.xml"],"removed":[]},{"id":"f489d213f2a3df13c1144a568fc106efe4cf1f62","message":"nmtui: add page for configuring loopback interface\n","title":"nmtui: add page for configuring loopback interface","timestamp":"2025-04-15T11:43:06+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/f489d213f2a3df13c1144a568fc106efe4cf1f62","author":{"name":"Jan Vaclav","email":"jvaclav@redhat.com"},"added":["src/nmtui/nmt-page-loopback.c","src/nmtui/nmt-page-loopback.h"],"modified":["NEWS","po/POTFILES.in","src/libnm-core-impl/nm-connection.c","src/nmtui/meson.build","src/nmtui/nm-editor-utils.c","src/nmtui/nmt-connect-connection-list.c","src/nmtui/nmt-editor.c"],"removed":[]},{"id":"2953200a653e1878beba8543a20407744e8c5db5","message":"core/devices: generate connections with autoconnect=true\n\nPreviously, when a generated connection was edited, and the\nmachine was rebooted, the connection would not apply, and a\nnew generated connection would be made, because autoconnect\nwas set to FALSE.\n\nSet autoconnect to be true by default, so that the modified\ngenerated connection is applied.\n","title":"core/devices: generate connections with autoconnect=true","timestamp":"2025-04-15T11:43:06+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/2953200a653e1878beba8543a20407744e8c5db5","author":{"name":"Jan Vaclav","email":"jvaclav@redhat.com"},"added":[],"modified":["src/core/devices/nm-device.c"],"removed":[]},{"id":"de56b482f380a7c194bd2e212354ae489dcdbed8","message":"nmtui/editor: hide \"device\" field for loopback connections\n\nThis field is irrelevant for this device type, since it will always\nbe just \"lo\".\n","title":"nmtui/editor: hide \"device\" field for loopback connections","timestamp":"2025-04-15T11:43:06+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/de56b482f380a7c194bd2e212354ae489dcdbed8","author":{"name":"Jan Vaclav","email":"jvaclav@redhat.com"},"added":[],"modified":["src/nmtui/nmt-editor.c","src/nmtui/nmt-page-loopback.c","src/nmtui/nmt-page-loopback.h"],"removed":[]},{"id":"b62a0ae7b3e2428b3070489b28e210904cb4e72c","message":"merge: branch 'jv/nmtui-lo'\n\nnmtui: add support for configuring loopback interface\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2175","title":"merge: branch 'jv/nmtui-lo'","timestamp":"2025-04-16T07:01:02+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/b62a0ae7b3e2428b3070489b28e210904cb4e72c","author":{"name":"Jan Vaclav","email":"jvaclav@redhat.com"},"added":["src/nmtui/nmt-page-loopback.c","src/nmtui/nmt-page-loopback.h"],"modified":["NEWS","po/POTFILES.in","src/core/devices/nm-device.c","src/libnm-core-impl/nm-connection.c","src/nmtui/meson.build","src/nmtui/nm-editor-utils.c","src/nmtui/nmt-connect-connection-list.c","src/nmtui/nmt-editor.c"],"removed":[]},{"id":"f94d146c5a292d7083e6a0ba6307d457684c3b04","message":"platform: use consistent naming for ethtool functions\n\nFor unknown reasons (wrong copy and paste?) the getter functions had a\n\"link\" in the name. Remove it.\n","title":"platform: use consistent naming for ethtool functions","timestamp":"2025-04-16T10:26:02+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/f94d146c5a292d7083e6a0ba6307d457684c3b04","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/core/devices/nm-device.c","src/libnm-platform/nm-platform.c","src/libnm-platform/nm-platform.h"],"removed":[]},{"id":"c15eae5178a0fe01c37519947349726bb626c46a","message":"libnm-setting: remove unused include\n","title":"libnm-setting: remove unused include","timestamp":"2025-04-16T10:26:02+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/c15eae5178a0fe01c37519947349726bb626c46a","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/libnmc-setting/nm-meta-setting-desc.c"],"removed":[]},{"id":"78d9048aa8f755f5635cded2440f932fb4ca527b","message":"platform: move ethtool ioctl functions to a separate file\n\nWe're going to replace most of the ioctl-based ethtool functions with\na netlink-based equivalent. Move the ioctl ones to a separate file so\nthat it's easier to see what still needs to be converted. Also add a\ncommon prefix to the function names.\n","title":"platform: move ethtool ioctl functions to a separate file","timestamp":"2025-04-16T10:26:03+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/78d9048aa8f755f5635cded2440f932fb4ca527b","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":["src/libnm-platform/nmp-ethtool-ioctl.c","src/libnm-platform/nmp-ethtool-ioctl.h"],"modified":["src/core/platform/tests/test-link.c","src/libnm-platform/devlink/nm-devlink.c","src/libnm-platform/meson.build","src/libnm-platform/nm-linux-platform.c","src/libnm-platform/nm-platform-utils.c","src/libnm-platform/nm-platform-utils.h","src/libnm-platform/nm-platform.c","src/libnm-platform/nmp-object.c"],"removed":[]},{"id":"247ed4f5d6869b9c535348c8327874d19f0f5907","message":"platform: add ethtool netlink implementation\n\nIntroduce some basic infrastructure to perform ethtool operations via\nnetlink. As a proof of concept, implement the pause settings.\n\nNetlink has some advantages over ioctl():\n\n - it can be easily extended with new attributes;\n\n - it can return descriptive error messages via the extended ack\n   mechanism. For example, when setting the ring parameters to a value\n   outside the allowed range, userspace receives error code -EINVAL\n   and message \"requested ring size exceeds maximum\". ioctl() gets\n   only -EINVAL, which is shared among many error reasons;\n\n - since it's possible to specify an ifindex in the request, there are\n   no race conditions when the interface name changes;\n\nNew ethtool API is available only via netlink; however it makes sense\nto start using netlink also for the old API that NM is already using\n(pause, eee, rings, etc.) over ioctl() because of the advantages\ndescribed above.\n","title":"platform: add ethtool netlink implementation","timestamp":"2025-04-16T10:26:03+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/247ed4f5d6869b9c535348c8327874d19f0f5907","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":["src/libnm-platform/nmp-ethtool.c","src/libnm-platform/nmp-ethtool.h"],"modified":["src/libnm-platform/meson.build"],"removed":[]},{"id":"857c3f0d75920e3b7d79fa7969ac81abd8217d3f","message":"platform: use the new ethtool-netlink API for pause settings\n","title":"platform: use the new ethtool-netlink API for pause settings","timestamp":"2025-04-16T10:26:03+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/857c3f0d75920e3b7d79fa7969ac81abd8217d3f","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/libnm-platform/nm-linux-platform.c","src/libnm-platform/nm-platform.c","src/libnm-platform/nm-platform.h","src/libnm-platform/nmp-ethtool-ioctl.c","src/libnm-platform/nmp-ethtool-ioctl.h"],"removed":[]},{"id":"2e36e58132003b369b5f404475bb5aadad1c8466","message":"platform: replace EEE ethtool ioctl calls with netlink\n","title":"platform: replace EEE ethtool ioctl calls with netlink","timestamp":"2025-04-16T10:26:04+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/2e36e58132003b369b5f404475bb5aadad1c8466","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/libnm-platform/nm-linux-platform.c","src/libnm-platform/nm-platform.c","src/libnm-platform/nm-platform.h","src/libnm-platform/nmp-ethtool-ioctl.c","src/libnm-platform/nmp-ethtool-ioctl.h","src/libnm-platform/nmp-ethtool.c","src/libnm-platform/nmp-ethtool.h"],"removed":[]},{"id":"49237ad554af17ebac6828427d0656afacfbab6d","message":"platform: replace ring ethtool ioctl calls with netlink\n","title":"platform: replace ring ethtool ioctl calls with netlink","timestamp":"2025-04-16T10:26:05+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/49237ad554af17ebac6828427d0656afacfbab6d","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/libnm-platform/nm-linux-platform.c","src/libnm-platform/nm-platform.c","src/libnm-platform/nm-platform.h","src/libnm-platform/nmp-ethtool-ioctl.c","src/libnm-platform/nmp-ethtool-ioctl.h","src/libnm-platform/nmp-ethtool.c","src/libnm-platform/nmp-ethtool.h"],"removed":[]},{"id":"657779357125c84cdc2520182befc7d74f8765c8","message":"README: document the required kernel version\n\nAdd a new section in README.md that describes the required Linux\nkernel version.\n","title":"README: document the required kernel version","timestamp":"2025-04-16T10:26:06+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/657779357125c84cdc2520182befc7d74f8765c8","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["README.md"],"removed":[]}],"total_commits_count":14,"push_options":{},"repository":{"name":"NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","description":"NetworkManager — network management daemon","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","visibility_level":20}}