{"object_kind":"push","event_name":"push","before":"9c74fa8e367dbe521ed789551ffaed5c2d6b33d6","after":"7106daf1a37b61c3f862a5bb96199cd0536533ca","ref":"refs/heads/nm-1-52","ref_protected":false,"checkout_sha":"7106daf1a37b61c3f862a5bb96199cd0536533ca","message":null,"user_id":1050,"user_name":"Beniamino Galvani","user_username":"bgalvani","user_email":"","user_avatar":"https://gitlab.freedesktop.org/uploads/-/system/user/avatar/1050/avatar.png","project_id":411,"project":{"id":411,"name":"NetworkManager","description":"NetworkManager — network management daemon","web_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","avatar_url":"https://gitlab.freedesktop.org/uploads/-/system/project/avatar/411/nm_logo.png","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","namespace":"NetworkManager","visibility_level":20,"path_with_namespace":"NetworkManager/NetworkManager","default_branch":"main","ci_config_path":"","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git"},"commits":[{"id":"c3ed106d6392207a7464232235a252b1d83baed6","message":"libnm: macvlan: specify that promiscuous affects to the parent\n\nFixes: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/1732\nFixes: 4d0192e661e0 ('libnm-core: add NMSettingMacvlan')\n(cherry picked from commit 1fdcfb7abe91e67e94a6435544eb6964667bb412)\n","title":"libnm: macvlan: specify that promiscuous affects to the parent","timestamp":"2025-06-27T10:23:59+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/c3ed106d6392207a7464232235a252b1d83baed6","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/libnm-core-impl/nm-setting-macvlan.c","src/libnmc-setting/settings-docs.h.in","src/nmcli/gen-metadata-nm-settings-nmcli.xml.in"],"removed":[]},{"id":"75bb71fddf6fa9a27c3b6f4c1fafa5f410cfd5a9","message":"libnm: fix GObject introspection annotations for NMSecretAgentOld\n\nAdd some missing \"(nullable)\" annotations to parameters of the\ncallback functions in NMSecretAgentOld. Otherwise, PyGObject complains\nthat those parameters cannot be NULL when implementing a secret agent.\n\nFixes: d595f7843e31 ('libnm: add libnm/libnm-core (part 1)')\n(cherry picked from commit c01168f4f97f359e6d7ab5700710e1a7800859c4)\n","title":"libnm: fix GObject introspection annotations for NMSecretAgentOld","timestamp":"2025-06-27T10:24:13+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/75bb71fddf6fa9a27c3b6f4c1fafa5f410cfd5a9","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/libnm-client-public/nm-secret-agent-old.h"],"removed":[]},{"id":"9e640cb751d584d827780ce969517190505fc47e","message":"release: fix validation of gitlab token\n\nIf the token is wrong or expired, the command still returns\nsuccess. Check the content of the reply instead.\n\nFixes: f05192ada84b ('release.sh: release to freedesktop.org, not to GNOME')\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2148\n(cherry picked from commit 481afec6ea2b136fa8eb73a4d5e6e045570351fc)\n","title":"release: fix validation of gitlab token","timestamp":"2025-06-27T10:24:25+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/9e640cb751d584d827780ce969517190505fc47e","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["contrib/fedora/rpm/release.sh"],"removed":[]},{"id":"e766920e0b2c48ee4edba59c608a707c3fd39677","message":"vpn: fix logging message\n\nFixes: c4a7d6a06f3e ('vpn: honor the ipvX.method connection property')\n(cherry picked from commit ecce8fa461d9c00002762f7479cbb0c5792bd207)\n","title":"vpn: fix logging message","timestamp":"2025-06-27T10:25:21+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/e766920e0b2c48ee4edba59c608a707c3fd39677","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/core/vpn/nm-vpn-connection.c"],"removed":[]},{"id":"ca39902cee649b55fa0b7e01d2f85477d7d77448","message":"bond-slb: initialize dest hw address in GARP packets\n\nDetected by Coverity:\n    1. NetworkManager-1.53.1/src/core/nm-bond-manager.c:885:5: var_decl: Declaring variable \"data\" without initializer.\n    7. NetworkManager-1.53.1/src/core/nm-bond-manager.c:948:13: uninit_use_in_call: Using uninitialized value \"data\". Field \"data.d_hw_addr\" is uninitialized when calling \"sendto\".\n       946|               unaligned_write_ne32(data.s_ip_addr, tmp_addr);\n       947|               unaligned_write_ne32(data.d_ip_addr, tmp_addr);\n       948|->             if (sendto(sockfd, &data, sizeof(data), 0, (struct sockaddr *) &addr, sizeof(addr)) < 0)\n       949|                   return FALSE;\n       950|           }\n\nFixes: 3f2f922dd943 ('bonding: send ARP announcement on bonding-slb link/carrier down')\n(cherry picked from commit 42edb37499fdf848ec751b059a361fd37eab69d5)\n","title":"bond-slb: initialize dest hw address in GARP packets","timestamp":"2025-06-27T10:25:51+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/ca39902cee649b55fa0b7e01d2f85477d7d77448","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/core/nm-bond-manager.c"],"removed":[]},{"id":"d19068c9e349f8a219fad712c8af38bfda670f3f","message":"core: fix use after free in ping operations\n\nDetected by coverity, the ping_op pointers are used after being freed in\ncleanup_ping_operations. Although calling to g_list_remove is probably\nsafe because it only needs the value of the pointer, not to dereference\nit, better to follow best practices. One of the use after free was\nactually an error because we dereference ping_op->log_domain.\n\nFixes: 658aef0fa185 ('connection: Support connection.ip-ping-addresses')\n(cherry picked from commit ae7de5b353b8bdbfefd6a67c8fe53678cf78a60a)\n","title":"core: fix use after free in ping operations","timestamp":"2025-06-27T10:25:51+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/d19068c9e349f8a219fad712c8af38bfda670f3f","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/core/devices/nm-device.c"],"removed":[]},{"id":"a1e1dd29787d75c3603190687dbb71a90a0eda4e","message":"n-dhcp4: fix resource leaks\n\nThe function n_dhcp4_c_connection_send_request does not release or take\nownership of its request argument. Because of that, setting it to NULL\nin the caller prevents the auto-cleanup of the variable to be executed,\ncausing a resource leak. Fix it.\n\nFixes: e23b3c9c3ac8 ('Squashed 'shared/n-dhcp4/' content from commit fb1d43449')\nFixes: 243cc433fb77 ('n-dhcp4: add new client probe function to send RELEASE message')\n(cherry picked from commit 9edfc0438cb6391b01999022567e6ed5aa6bb8db)\n","title":"n-dhcp4: fix resource leaks","timestamp":"2025-06-27T10:25:51+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/a1e1dd29787d75c3603190687dbb71a90a0eda4e","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/n-dhcp4/src/n-dhcp4-c-probe.c"],"removed":[]},{"id":"051a4a27a2c026aa8e67b60b6a0d0e285bb29032","message":"merge: branch 'ih/coverity'\n\nFix some defects detected by Coverity\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2174\n\n(cherry picked from commit 95b9b4b6782f91080a605c6e2314f067eff24fde)\n","title":"merge: branch 'ih/coverity'","timestamp":"2025-06-27T10:25:52+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/051a4a27a2c026aa8e67b60b6a0d0e285bb29032","author":{"name":"Íñigo Huguet","email":"inigohuguet@hotmail.com"},"added":[],"modified":["src/core/devices/nm-device.c","src/core/nm-bond-manager.c","src/n-dhcp4/src/n-dhcp4-c-probe.c"],"removed":[]},{"id":"59be16b91a8a817b372b019ca0db53a329a7414f","message":"device: renew dhcp lease only if carrier was down\n\nMake sure nm_device_update_dynamic_ip_setup is called every time a carrier was down before and the link is now up again.\nPreviously the dhcp lease was not renewed if the carrier went down and then up again quickly enough.\nThis led to cases where an old IP was retained even though the device was connected to a different network with a different DHCP server.\n\nThis commit introduces device_link_carrier_changed_down\n\nFixes: d6429d3ddbc7 ('device: ensure DHCP is restarted every time the link goes up')\n(cherry picked from commit 163c2574d885a2983702612788b3458c3d6ecc0d)\n","title":"device: renew dhcp lease only if carrier was down","timestamp":"2025-06-27T10:26:51+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/59be16b91a8a817b372b019ca0db53a329a7414f","author":{"name":"Friedrich Altheide","email":"friedrich.altheide@w34you.de"},"added":[],"modified":["src/core/devices/nm-device.c"],"removed":[]},{"id":"2172c5ff5a652b57f33296855403cf4b8320094e","message":"libnm: fix memory leak when parsing IP configuration\n\nWhen the dictionary contains keys \"address\" and \"uri\", the first value\nis leaked.\n\n  ==4730== 14 bytes in 1 blocks are definitely lost in loss record 51 of 1,755\n  ==4730==    at 0x4841866: malloc (vg_replace_malloc.c:446)\n  ==4730==    by 0x4CC5CB9: g_malloc (gmem.c:100)\n  ==4730==    by 0x4CDF518: g_strdup (gstrfuncs.c:323)\n  ==4730==    by 0x496A6B8: g_strdup_inline (gstrfuncs.h:321)\n  ==4730==    by 0x496A6B8: nm_inet_ntop_dup (nm-inet-utils.h:355)\n  ==4730==    by 0x496A95B: nm_inet_parse_str (nm-inet-utils.c:539)\n  ==4730==    by 0x48AF3A3: _notify_update_prop_nameservers (nm-ip-config.c:179)\n\nFixes: 4422b1470496 ('core, libnm: support per-connection DNS URIs')\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2184\n(cherry picked from commit 37d8945b13fd04d474667c443c95333c8542312e)\n","title":"libnm: fix memory leak when parsing IP configuration","timestamp":"2025-06-27T10:28:43+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/2172c5ff5a652b57f33296855403cf4b8320094e","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/libnm-client-impl/nm-ip-config.c"],"removed":[]},{"id":"b83f847b4d6905d1131d956864c0614a569e2761","message":"libnm-core: set ovs-dpdk and ovs-patch as non-base settings\n\nSettings \"ovs-dpdk\" and \"ovs-patch\" are currently marked with priority\nNM_SETTING_PRIORITY_HW_BASE, which makes them \"base\" settings. This\nmeans that they can be used as connection type, for example via \"nmcli\nconnection add type ovs-dpdk ...\".\n\nThis is wrong, as both settings can only belong to a connection of\ntype \"ovs-interface\". Decrease their priority and make them non-base\nsettings.\n\nThe problem was spotted when trying to add a ovs-patch connection via\nnmcli:\n\n  # nmcli connection add type ovs-patch ifname p con-name q ovs-patch.peer r controller s port-type ovs-port\n  Warning: controller='s' doesn't refer to any existing profile.\n\n  (process:4580): nm-CRITICAL **: 10:15:42.807: file ../src/libnm-core-impl/nm-connection.c: line 1682 (_normalize_ovs_interface_type): should not be reached\n\n  (process:4580): nm-WARNING **: 10:15:42.807: connection did not verify after normalization: ??\n\n  (process:4580): nm-CRITICAL **: 10:15:42.807: file ../src/libnm-core-impl/nm-connection.c: line 2170 (_connection_normalize): should not be reached\n  Error: Failed to add 'q' connection: ovs-interface.type: A connection with 'ovs-patch' setting must be of connection.type \"ovs-interface\" but is \"ovs-patch\"\n\nFixes: d0ec5011638e ('cli: assert that valid_parts are set for base types')\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2178\n(cherry picked from commit 14106431fbe7091ba41e593afbf2346c7ed6fdc3)\n","title":"libnm-core: set ovs-dpdk and ovs-patch as non-base settings","timestamp":"2025-06-27T10:29:01+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/b83f847b4d6905d1131d956864c0614a569e2761","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/libnm-core-impl/nm-meta-setting-base-impl.c","src/libnmc-setting/nm-meta-setting-base-impl.c","src/libnmc-setting/nm-meta-setting-desc.c","src/nmcli/gen-metadata-nm-settings-nmcli.xml.in"],"removed":[]},{"id":"6d3ff1c30b33d51a4739d7335c4aa6ea0a80ba97","message":"man: fix syntax to match on connection-id\n\nFixes: 604c611cd052 ('core: add nm_utils_connection_match_spec_list()')\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/1746\n(cherry picked from commit b571e2be5a886b675c39b28f173d05aa299a879b)\n","title":"man: fix syntax to match on connection-id","timestamp":"2025-06-27T10:29:16+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/6d3ff1c30b33d51a4739d7335c4aa6ea0a80ba97","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["man/NetworkManager.conf.xml"],"removed":[]},{"id":"693e1e9742791c4885d4e23c0f72729889c43853","message":"nm-initrd-generator: fix IPv6 with square brackets in bond options\n\nIf any bond option contains an IPv6 address it needs to be enclosed with\n[]. Otherwise the ':' separators from the IP address can be confused\nwith the ':' separators from the 'bond=' cmdline arguments.\n\nHowever, the square brackets were ignored:\n    $ nm-initrd-generator -s \"bond=bond0:eth0,eth1:ns_ip6_target=[FC08::789:1:0:0:3]\"\n    NetworkManager-Message: 08:46:55.114: <warn>  [1745498815.1146] cmdline-reader: Ignoring invalid bond option: \"ns_ip6_target\" = \"[FC08\": '[FC08' is not a valid IPv6 address for 'ns_ip6_target' option\n    NetworkManager-Message: 08:46:55.114: <warn>  [1745498815.1148] cmdline-reader: Ignoring extra: '789:1:0:0:3]'.\n\nThe opening '[' was only being considered if it was the first character\nin `get_word`. Fix it and consider it if it's in the middle too.\n\nIf the brackets are used first and last, directly remove them as it is what\nmost callers expect. However, if it's in the middle there is no reasonable\nway to remove them, so don't do it. Instead, the caller will have to consider\nthis possibility when processing the content.\n\nFixes: ecc074b2f8a6 ('initrd: add command line parser')\nFixes https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/1755\n\n(cherry picked from commit aeaf8ca23c49cd0c90a692771697abf1a62796d2)\n","title":"nm-initrd-generator: fix IPv6 with square brackets in bond options","timestamp":"2025-06-27T10:29:39+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/693e1e9742791c4885d4e23c0f72729889c43853","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/nm-initrd-generator/nmi-cmdline-reader.c","src/nm-initrd-generator/tests/test-cmdline-reader.c"],"removed":[]},{"id":"399b08aab645503999232bff38f7ffacb41e8f60","message":"nm-initrd-generator: fix ignored prefix for IPv6 address with brackets\n\nWhen defining an IPv6 address with square brackets and prefix, like\n[dead::beef]/64, the prefix was silently ignored. The address was\naccepted only accidentally, because get_word replaced ']' with '\\0' so\nit resulted in a valid IPv6 address string, but without the prefix.\n\nThe previous commit has fixed get_word with better logic to handle the\nsquare brackets, uncovering this issue.\n\nFix it by explicitly splitting IP addresses and prefixes in\nreader_parse_ip so we get a valid address and prefix.\n\nAlso, use a prefix different to 64 in the test test_if_ip6_manual. 64 is\nthe default one, making that the test passed despite the defined prefix\nwas actually ignored.\n\nFixes: ecc074b2f8a6 ('initrd: add command line parser')\n(cherry picked from commit 6f6bb17a28e7247bfae8794f622b6855440b53e1)\n","title":"nm-initrd-generator: fix ignored prefix for IPv6 address with brackets","timestamp":"2025-06-27T10:29:39+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/399b08aab645503999232bff38f7ffacb41e8f60","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/nm-initrd-generator/nmi-cmdline-reader.c","src/nm-initrd-generator/tests/test-cmdline-reader.c"],"removed":[]},{"id":"e059388f056e5426dd246fd060e7da2c343630c1","message":"merge: branch 'ih/initrd-fix-bond-ip6'\n\nnm-initrd-generator: fix IPv6 with square brackets in bond options\n\nCloses #1755 and #1731\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2197\n\n(cherry picked from commit 34255b26922d9555cd3341f444087c8e81b0a21e)\n","title":"merge: branch 'ih/initrd-fix-bond-ip6'","timestamp":"2025-06-27T10:29:41+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/e059388f056e5426dd246fd060e7da2c343630c1","author":{"name":"Íñigo Huguet","email":"inigohuguet@hotmail.com"},"added":[],"modified":["src/nm-initrd-generator/nmi-cmdline-reader.c","src/nm-initrd-generator/tests/test-cmdline-reader.c"],"removed":[]},{"id":"37e72927d7973d1c44649c8489fd72f9a10408a9","message":"core: virtual devices can be available without a parent set\n\nWhen calling to nm_device_is_available, the device types that requires a\nparent like VLAN or MACVLAN checks that their parent exists.\n\nnm_device_is_available is a function to check if the device is available\nto activate a connection, so it makes sense that if the parent is not\npresent it can't be activated.\n\nHowever, this is wrong for 2 reasons:\n1. Most of they are virtual devices that might be unrealized when\n   checking its availability. If they're unrealized, their parent hasn't\n   been set yet.\n2. Even if they're realized, their current parent might not be the one\n   that is defined in the connection that is being activated.\n\nThis is causing that unrealized devices are not being activated as ports\nbecause nm_manager_get_best_device_for_connection thinks that they are\nnot available.\n\nGet rid of these checks for the parent in the is_available callbacks.\n\nFixes: ba86c208e0aa ('Revert \"core: prevent the activation of unavailable OVS interfaces only\"')\nFixes: 774badb1519a ('core: prevent the activation of unavailable devices')\n(cherry picked from commit 94595332c454384cd67ae6ab6e54e3684bc6a97a)\n","title":"core: virtual devices can be available without a parent set","timestamp":"2025-06-27T10:33:23+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/37e72927d7973d1c44649c8489fd72f9a10408a9","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/core/devices/nm-device-6lowpan.c","src/core/devices/nm-device-ipvlan.c","src/core/devices/nm-device-macsec.c","src/core/devices/nm-device-macvlan.c","src/core/devices/nm-device-vlan.c"],"removed":[]},{"id":"ff9032ff9d0d416285368a943ac629cb43e1f4da","message":"device: update the external-down unmanaged flag on port attach/release\n\nA device has the \"external-down\" unmanaged flag when:\n\n  !is-created-by-nm AND (!is-up OR (!has-address AND !is-controller))\n\nWhen the \"is-up\" or the \"has-address\" conditions change, we properly update\nthe unmanaged flag by calling _dev_unmanaged_check_external_down() in\n_dev_l3_cfg_notify_cb(PLATFORM_CHANGE_ON_IDLE).\n\nThe \"is-controller\" condition changes when another link indicates the\ncurrent device as controller. We currently don't update the unmanaged flag\nwhen that happens and so it's possible that the device stays unmanaged even\nif it has a port. This can be easily reproduced by running this commands:\n\n    ip link add veth0 type veth peer name veth1\n    ip link add vrf0 type vrf table 10\n    ip link set vrf0 up\n    ip link set veth0 master vrf0\n\nSometimes, the device shows as \"unmanaged\" instead of \"connected\n(externally)\".\n\nFix this by re-evaluating the \"external-down\" unmanaged flags on the\ncontroller when a port is attached or detached.\n\nFixes: c3586ce01a5b ('device: consider a device with slaves configured')\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2209\n(cherry picked from commit fd3eccfb1612a3bac87232e1cbaabc10da80c302)\n","title":"device: update the external-down unmanaged flag on port attach/release","timestamp":"2025-06-27T10:33:41+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/ff9032ff9d0d416285368a943ac629cb43e1f4da","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/core/devices/nm-device.c"],"removed":[]},{"id":"35f11cd6e130299cd554bb97e2c165031ed91a72","message":"ip-config: fix crash in DNS options evaluation\n\nFixes: 58287cbcc0c8 ('core: rework IP configuration in NetworkManager using layer 3 configuration')\n(cherry picked from commit c1350f40bdc769514f637b4b6754c4ff3ef67b66)\n","title":"ip-config: fix crash in DNS options evaluation","timestamp":"2025-06-27T10:33:45+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/35f11cd6e130299cd554bb97e2c165031ed91a72","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/core/nm-ip-config.c"],"removed":[]},{"id":"3dfd364502ccd3b26152dd853c00e7836a3a9579","message":"connectivity: fix compiler warning when building without concheck\n\nFix the following:\n\n../src/core/nm-connectivity.c:958:1: warning: ‘check_platform_config’ defined but not used [-Wunused-function]\n  958 | check_platform_config(NMConnectivity *self,\n      | ^~~~~~~~~~~~~~~~~~~~~\n\nFixes: 91d447df19a7 ('device: don't start connectivity check on unconfigured devices')\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2224\n(cherry picked from commit 1253cbad5afc0017ba146d8f20f059c10e63f163)\n(cherry picked from commit c1d94d70814d1d28ef842c3d81357575d78df954)\n","title":"connectivity: fix compiler warning when building without concheck","timestamp":"2025-06-27T10:33:52+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/3dfd364502ccd3b26152dd853c00e7836a3a9579","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/core/nm-connectivity.c"],"removed":[]},{"id":"7106daf1a37b61c3f862a5bb96199cd0536533ca","message":"ovs: set the tun interface up before stage3\n\nWhen using the netdev datapath, we wait that the tun link appears, we\ncall nm_device_set_ip_ifindex() (which also brings the link up) and\nthen we check that the link is ready, i.e. that udev has announced the\nlink and the MAC address is correct. After that, we schedule stage3\n(ip-config).\n\nIn this, there is a race condition that occurs sometimes in NMCI test\novs_datapath_type_netdev_with_cloned_mac. In rare conditions,\nnm_device_set_ip_ifindex() bring the interface up but then ovs-vswitch\nchanges again the flags of the interface without IFF_UP. The result is\nthat the interface stays down, breaking communications.\n\nTo fix this, we need to always call nm_device_bring_up() after the tun\ndevice is ready. The problem is that we can't do it in\n_netdev_tun_link_cb() because that function is already invoked\nsynchronously from platform code.\n\nInstead, simplify the handling of the netdev datapath. Every\n\"link-changed\" event from platform is handled by\n_netdev_tun_link_cb(), which always schedule a delayed function\n_netdev_tun_link_cb_in_idle(). This function just assigns the\nip-ifindex to the device if missing, and starts stage3 if the link is\nready. While doing so, it also bring the interface up.\n\nFixes: 99a6c6eda6e1 ('ovs, dpdk: fix creating ovs-interface when the ovs-bridge is netdev')\n\nhttps://issues.redhat.com/browse/RHEL-17358\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2218\n(cherry picked from commit 46e0d2b4e4eb5948db12186a3c60d3fd98ae8cd4)\n(cherry picked from commit dd0ca122e3ceaa51c043903581bfe8712a285817)\n","title":"ovs: set the tun interface up before stage3","timestamp":"2025-06-27T10:33:57+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/7106daf1a37b61c3f862a5bb96199cd0536533ca","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/core/devices/ovs/nm-device-ovs-interface.c"],"removed":[]}],"total_commits_count":20,"push_options":{},"repository":{"name":"NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","description":"NetworkManager — network management daemon","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","visibility_level":20}}