{"object_kind":"push","event_name":"push","before":"1c71c568e7736ce2075fd0d53c387f2221bab832","after":"a0f2961616e2ca50ebf8eeecde2900b00150ec4e","ref":"refs/heads/main","ref_protected":false,"checkout_sha":"a0f2961616e2ca50ebf8eeecde2900b00150ec4e","message":null,"user_id":1255007,"user_name":"Josephine Pfeiffer","user_username":"josie","user_email":"josie@redhat.com","user_avatar":"https://gitlab.freedesktop.org/uploads/-/system/user/avatar/1255007/avatar.png?v=1793690295","project_id":411,"project":{"id":411,"name":"NetworkManager","description":"NetworkManager — network management daemon","web_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","avatar_url":"https://gitlab.freedesktop.org/uploads/-/system/project/avatar/411/nm_logo.png?v=1793705007","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","namespace":"NetworkManager","visibility_level":20,"path_with_namespace":"NetworkManager/NetworkManager","default_branch":"main","ci_config_path":"","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git"},"commits":[{"id":"951c0f1afb2d0d6f0f8dc2520aa9ee91451a1cb2","message":"checkpoint: reactivate deactivating connections on rollback\n\nfind_settings_connection() matches any active connection with the saved\nprofile UUID. A connection still deactivating, e.g. while pre-down\ndispatcher scripts run, keeps the version ID saved in the checkpoint, so\nrollback skips its activation and leaves the device disconnected. With a\nmulti-connect profile, another device's activation can match, and its\nversion ID differs, so rollback reactivates an unchanged connection.\n\nOnly match active connections on the saved device that have not started\ndeactivating. Rollback then restores devices that are already\ndeactivating, so keep their external ports as for active devices.\n\nFixes: b9d11ffaa217 ('checkpoint: reactivate/update connections only if\n                      necessary on rollback')\n","title":"checkpoint: reactivate deactivating connections on rollback","timestamp":"2026-11-03T12:41:06+01:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/951c0f1afb2d0d6f0f8dc2520aa9ee91451a1cb2","author":{"name":"Josephine Pfeiffer","email":"josie@redhat.com"},"added":[],"modified":["src/core/nm-checkpoint.c"],"removed":[]},{"id":"929b8097a6ba1d70723530aa8acb95be7bae9327","message":"core/tests: cover checkpoint rollback with a running daemon\n\nRollback acts on device and active-connection state that only a running\ndaemon has, and the deactivating case needs a device held in\nDEACTIVATING. Run NetworkManager in a bubblewrap sandbox with its own\nnetwork namespace and bus, and let a fake dispatcher hold the pre-down\nreply until rollback has run.\n\nThe modes cover explicit and timed rollback with one device and with two\ndevices sharing a multi-connect profile, an unchanged profile, an\nexternal bridge port, and a recreated software device. The test skips\nwhen bwrap, dbus-run-session, ip or PyGObject is missing.\n","title":"core/tests: cover checkpoint rollback with a running daemon","timestamp":"2026-11-03T12:41:08+01:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/929b8097a6ba1d70723530aa8acb95be7bae9327","author":{"name":"Josephine Pfeiffer","email":"josie@redhat.com"},"added":["src/core/tests/test-checkpoint.py"],"modified":["src/core/meson.build"],"removed":[]},{"id":"c181c721ecb7747a648121991baaa91b094e079e","message":"ci: install bubblewrap and iproute for the checkpoint test\n\nWithout bwrap, and on Fedora and CentOS also without ip, the checkpoint\nrollback test skips in every CI image. Add the packages and update the\nimage tags to the new package lists.\n","title":"ci: install bubblewrap and iproute for the checkpoint test","timestamp":"2026-11-03T12:41:11+01:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/c181c721ecb7747a648121991baaa91b094e079e","author":{"name":"Josephine Pfeiffer","email":"josie@redhat.com"},"added":[],"modified":[".gitlab-ci.yml","contrib/alpine/REQUIRED_PACKAGES","contrib/arch/REQUIRED_PACKAGES","contrib/debian/REQUIRED_PACKAGES","contrib/fedora/REQUIRED_PACKAGES"],"removed":[]},{"id":"38c3c4b0b20d74f865d109551c036646c0de9194","message":"NEWS: mention the checkpoint rollback fixes\n\nA rollback that ran while a connection was deactivating left the device\ndisconnected, so the checkpoint did not restore connectivity.\n","title":"NEWS: mention the checkpoint rollback fixes","timestamp":"2026-11-03T12:42:02+01:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/38c3c4b0b20d74f865d109551c036646c0de9194","author":{"name":"Josephine Pfeiffer","email":"josie@redhat.com"},"added":[],"modified":["NEWS"],"removed":[]},{"id":"a0f2961616e2ca50ebf8eeecde2900b00150ec4e","message":"merge: branch 'jp/checkpoint-routing-rules'\n\nFix checkpoint rollback for connections that are still deactivating\nand for multi-connect profiles.\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2567\n","title":"merge: branch 'jp/checkpoint-routing-rules'","timestamp":"2026-11-03T12:50:41+01:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/a0f2961616e2ca50ebf8eeecde2900b00150ec4e","author":{"name":"Josephine Pfeiffer","email":"josie@redhat.com"},"added":["src/core/tests/test-checkpoint.py"],"modified":[".gitlab-ci.yml","NEWS","contrib/alpine/REQUIRED_PACKAGES","contrib/arch/REQUIRED_PACKAGES","contrib/debian/REQUIRED_PACKAGES","contrib/fedora/REQUIRED_PACKAGES","src/core/meson.build","src/core/nm-checkpoint.c"],"removed":[]}],"total_commits_count":5,"push_options":{},"repository":{"name":"NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","description":"NetworkManager — network management daemon","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","visibility_level":20}}