{"object_kind":"push","event_name":"push","before":"4fe2d881f81a000d906b614bab64f629faa2b169","after":"62c8e8b2caebbb86182c79223c0109048eac154e","ref":"refs/heads/main","ref_protected":false,"checkout_sha":"62c8e8b2caebbb86182c79223c0109048eac154e","message":null,"user_id":1255007,"user_name":"Josephine Pfeiffer","user_username":"josie","user_email":"josie@redhat.com","user_avatar":"https://gitlab.freedesktop.org/uploads/-/system/user/avatar/1255007/avatar.png?v=1794302114","project_id":411,"project":{"id":411,"name":"NetworkManager","description":"NetworkManager — network management daemon","web_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","avatar_url":"https://gitlab.freedesktop.org/uploads/-/system/project/avatar/411/nm_logo.png?v=1794302913","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","namespace":"NetworkManager","visibility_level":20,"path_with_namespace":"NetworkManager/NetworkManager","default_branch":"main","ci_config_path":"","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git"},"commits":[{"id":"274cf73ec8d9491f84e69b97561bfa783ba40a68","message":"vpn: fix crash on repeated activation when device is not ready\n\nIf the VPN has an ifindex but its NMDevice is not registered yet,\n_check_complete() waits for it via an idle handler. The early return\nonly happened while that handler was not scheduled, so a second\nIp4Config signal, or the handler itself, continued with device == NULL\nand crashed in nm_l3_config_data_set_allow_routes_without_address().\n\nAlways return while the device is missing and schedule the idle\nhandler only once. Also don't clear the connect timeout until the\ndevice is available, so that the activation fails with a timeout if\nthe device never shows up.\n\nFixes: 4c5478744c0f ('vpn: wait for device to become available before creating l3cd')\nResolves: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/2046\n","title":"vpn: fix crash on repeated activation when device is not ready","timestamp":"2026-11-10T10:00:46+03:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/274cf73ec8d9491f84e69b97561bfa783ba40a68","author":{"name":"-o_0-","email":"cefsdjkurddertgdv@gmail.com"},"added":[],"modified":["src/core/vpn/nm-vpn-connection.c"],"removed":[]},{"id":"62c8e8b2caebbb86182c79223c0109048eac154e","message":"merge: branch 'fix-vpn-null-device'\n\nPrevent a VPN activation crash when IP configuration arrives before the\ndevice is registered, and retain the connect timeout while waiting.\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2571\n\nResolves: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/2046\n","title":"merge: branch 'fix-vpn-null-device'","timestamp":"2026-11-10T10:32:34+01:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/62c8e8b2caebbb86182c79223c0109048eac154e","author":{"name":"Josephine Pfeiffer","email":"josie@redhat.com"},"added":[],"modified":["src/core/vpn/nm-vpn-connection.c"],"removed":[]}],"total_commits_count":2,"push_options":{},"repository":{"name":"NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","description":"NetworkManager — network management daemon","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","visibility_level":20}}