{"object_kind":"push","event_name":"push","before":"610e0cb8cd4bac0ee194a7c2c17a2d8ddbddeecf","after":"49e7db704793ca3b138e12e748a7e1e43210b369","ref":"refs/heads/main","ref_protected":false,"checkout_sha":"49e7db704793ca3b138e12e748a7e1e43210b369","message":null,"user_id":1031,"user_name":"Lubomir Rintel","user_username":"lkundrak","user_email":"","user_avatar":"https://secure.gravatar.com/avatar/0c78b09297e4f43bda3282627ada927e031aabd945d9a02df75ae525a18952a8?s=80&d=identicon","project_id":411,"project":{"id":411,"name":"NetworkManager","description":"NetworkManager — network management daemon","web_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","avatar_url":"https://gitlab.freedesktop.org/uploads/-/system/project/avatar/411/nm_logo.png","git_ssh_url":"git@gitlab.freedesktop.org:NetworkManager/NetworkManager.git","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","namespace":"NetworkManager","visibility_level":20,"path_with_namespace":"NetworkManager/NetworkManager","default_branch":"main","ci_config_path":"","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","url":"git@gitlab.freedesktop.org:NetworkManager/NetworkManager.git","ssh_url":"git@gitlab.freedesktop.org:NetworkManager/NetworkManager.git","http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git"},"commits":[{"id":"7023d8b444a9b2da6dd4d880170079dd297492a0","message":"test-client: fix TestNmCloudSetup valgrind run\n\nAllow running the following locally (for quick loval nm-c-s valgrind check),\nwithout requiring $NM_TEST_CLIENT_NMCLI_PATH to be set.\n\n $ NM_TEST_CLIENT_CLOUD_SETUP_PATH=build/src/nm-cloud-setup/nm-cloud-setup \\\n NMTST_USE_VALGRIND=1 python src/tests/client/test-client.py TestNmCloudSetup\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2119\n","title":"test-client: fix TestNmCloudSetup valgrind run","timestamp":"2025-01-28T14:05:48+01:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/7023d8b444a9b2da6dd4d880170079dd297492a0","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/tests/client/test-client.py"],"removed":[]},{"id":"cc4a0a9f1049fe9416a63b6008227073ce8216a2","message":"test-client: collect pexpect subprocess status\n\nAlways explicitly tear down pexpect instances and collect their\nresults. Assert on the results after orderly teardowns.\n\nTrack the current pexpect instance in test context so that it could be\nstill collected if the test blows up. That could provide more clue into\nwhat went wrong in the test if it's due to a crash the testee.\n\nBefore:\n\n [1573928.02238] config device C0:00:00:00:00:10: creating vlan connection for VLAN 700 on C0:00:00:00:00:10...\n [1573928.02330] config device C0:00:00:00:00:10: connection \"vlan2\" (ac3c08f5-3e5c-38a3-a366-c16253de6db2) created\n ======================================================================\n ERROR: test_oci_vlans (__main__.TestNmCloudSetup.test_oci_vlans)\n ----------------------------------------------------------------------\n Traceback (most recent call last):\n ...\n pexp.expect(\"some changes were applied for provider oci\")\n ~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n ...\n pexpect.exceptions.EOF: End Of File (EOF). Exception style platform.\n\nAfter:\n\n [1573928.02238] config device C0:00:00:00:00:10: creating vlan connection for VLAN 700 on C0:00:00:00:00:10...\n [1573928.02330] config device C0:00:00:00:00:10: connection \"vlan2\" (ac3c08f5-3e5c-38a3-a366-c16253de6db2) created\n *** pexpect'd process killed by SIGABRT ***\n ======================================================================\n ERROR: test_oci_vlans (__main__.TestNmCloudSetup.test_oci_vlans)\n ----------------------------------------------------------------------\n Traceback (most recent call last):\n ...\n pexp.expect(\"some changes were applied for provider oci\")\n ~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n ...\n pexpect.exceptions.EOF: End Of File (EOF). Exception style platform.\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2119\n","title":"test-client: collect pexpect subprocess status","timestamp":"2025-01-28T14:05:51+01:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/cc4a0a9f1049fe9416a63b6008227073ce8216a2","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/tests/client/test-client.py"],"removed":[]},{"id":"49e7db704793ca3b138e12e748a7e1e43210b369","message":"cloud-setup: avoid accidental cast into a smaller type\n\nThis resulted in what looked like more significant bits of GType pointer\nsometimes falling off the cliff, presumably because of a cast to\nNMDeviceType enum (that probably ends up actually being a char).\n\nThis was silent enough to not emit compiler warnings and only occurring\nwith some very rare situations (needs GCC with LTO and some of the\noptimization flags used by Fedora 41).\n\nFixes: cf6af54ffa4f ('cloud-setup: allow VETH along with ETHERNET too')\nFixes: 6ff4b9e57cbc ('cloud-setup: create VLANs for multiple VNICs on OCI')\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2119\n","title":"cloud-setup: avoid accidental cast into a smaller type","timestamp":"2025-01-28T14:05:55+01:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/49e7db704793ca3b138e12e748a7e1e43210b369","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/nm-cloud-setup/main.c"],"removed":[]}],"total_commits_count":3,"push_options":{},"repository":{"name":"NetworkManager","url":"git@gitlab.freedesktop.org:NetworkManager/NetworkManager.git","description":"NetworkManager — network management daemon","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","git_ssh_url":"git@gitlab.freedesktop.org:NetworkManager/NetworkManager.git","visibility_level":20}}