{"object_kind":"push","event_name":"push","before":"37d8945b13fd04d474667c443c95333c8542312e","after":"14106431fbe7091ba41e593afbf2346c7ed6fdc3","ref":"refs/heads/main","ref_protected":false,"checkout_sha":"14106431fbe7091ba41e593afbf2346c7ed6fdc3","message":null,"user_id":1050,"user_name":"Beniamino Galvani","user_username":"bgalvani","user_email":"","user_avatar":"https://gitlab.freedesktop.org/uploads/-/system/user/avatar/1050/avatar.png","project_id":411,"project":{"id":411,"name":"NetworkManager","description":"NetworkManager — network management daemon","web_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","avatar_url":"https://gitlab.freedesktop.org/uploads/-/system/project/avatar/411/nm_logo.png","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","namespace":"NetworkManager","visibility_level":20,"path_with_namespace":"NetworkManager/NetworkManager","default_branch":"main","ci_config_path":"","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git"},"commits":[{"id":"14106431fbe7091ba41e593afbf2346c7ed6fdc3","message":"libnm-core: set ovs-dpdk and ovs-patch as non-base settings\n\nSettings \"ovs-dpdk\" and \"ovs-patch\" are currently marked with priority\nNM_SETTING_PRIORITY_HW_BASE, which makes them \"base\" settings. This\nmeans that they can be used as connection type, for example via \"nmcli\nconnection add type ovs-dpdk ...\".\n\nThis is wrong, as both settings can only belong to a connection of\ntype \"ovs-interface\". Decrease their priority and make them non-base\nsettings.\n\nThe problem was spotted when trying to add a ovs-patch connection via\nnmcli:\n\n  # nmcli connection add type ovs-patch ifname p con-name q ovs-patch.peer r controller s port-type ovs-port\n  Warning: controller='s' doesn't refer to any existing profile.\n\n  (process:4580): nm-CRITICAL **: 10:15:42.807: file ../src/libnm-core-impl/nm-connection.c: line 1682 (_normalize_ovs_interface_type): should not be reached\n\n  (process:4580): nm-WARNING **: 10:15:42.807: connection did not verify after normalization: ??\n\n  (process:4580): nm-CRITICAL **: 10:15:42.807: file ../src/libnm-core-impl/nm-connection.c: line 2170 (_connection_normalize): should not be reached\n  Error: Failed to add 'q' connection: ovs-interface.type: A connection with 'ovs-patch' setting must be of connection.type \"ovs-interface\" but is \"ovs-patch\"\n\nFixes: d0ec5011638e ('cli: assert that valid_parts are set for base types')\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2178\n","title":"libnm-core: set ovs-dpdk and ovs-patch as non-base settings","timestamp":"2025-04-14T13:39:13+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/14106431fbe7091ba41e593afbf2346c7ed6fdc3","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/libnm-core-impl/nm-meta-setting-base-impl.c","src/libnmc-setting/nm-meta-setting-base-impl.c","src/libnmc-setting/nm-meta-setting-desc.c","src/nmcli/gen-metadata-nm-settings-nmcli.xml.in"],"removed":[]}],"total_commits_count":1,"push_options":{},"repository":{"name":"NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","description":"NetworkManager — network management daemon","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","visibility_level":20}}