{"object_kind":"push","event_name":"push","before":"e5ae9886035895ca7094de1be78e5a85fedde2fb","after":"ce26d85ad10574f4044b4a11aec3430823c85856","ref":"refs/heads/main","ref_protected":false,"checkout_sha":"ce26d85ad10574f4044b4a11aec3430823c85856","message":null,"user_id":1050,"user_name":"Beniamino Galvani","user_username":"bgalvani","user_email":"","user_avatar":"https://gitlab.freedesktop.org/uploads/-/system/user/avatar/1050/avatar.png","project_id":411,"project":{"id":411,"name":"NetworkManager","description":"NetworkManager — network management daemon","web_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","avatar_url":"https://gitlab.freedesktop.org/uploads/-/system/project/avatar/411/nm_logo.png","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","namespace":"NetworkManager","visibility_level":20,"path_with_namespace":"NetworkManager/NetworkManager","default_branch":"main","ci_config_path":"","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git"},"commits":[{"id":"247000deeda5b4aa42b4024acfb61a8198085ab3","message":"core: reject new connections if the feature is disabled or removed\n\nIf a feature like Wi-Fi, OVS, team, etc. is disabled or no longer\nsupported, it is better to report an error when the connection is\nadded via nmcli than accepting the connection and complaining later\nabout a \"missing plugin\"; there is no plugin and the connection will\nnever be able to activate.\n\nExample errors now:\n  # nmcli connection add type team\n  Error: Failed to add 'team-nm-team' connection: team support is disabled in this build\n\n  # nmcli connection add type gsm\n  Error: Failed to add 'gsm' connection: WWAN support is disabled in this build\n\n  # nmcli connection add type wimax nsp 00:99:88:77:66:55\n  Error: Failed to add 'wimax' connection: WiMAX is no longer supported\n\nNote that we don't touch libnm-core (the part defining the settings\nand properties), as that defines the API of NetworkManager. The API\nshould not change according to compile flags.\n","title":"core: reject new connections if the feature is disabled or removed","timestamp":"2025-10-21T15:31:58+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/247000deeda5b4aa42b4024acfb61a8198085ab3","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["config.h.meson","meson.build","src/core/nm-core-utils.c","src/core/nm-core-utils.h","src/core/settings/nm-settings.c","src/libnm-core-public/nm-errors.h"],"removed":[]},{"id":"c1baf09bf9254998cfe60a96f637e62dfe56c3db","message":"settings: ignore unsupported connections when they are loaded\n\nIn addition to rejecting new connections added via D-Bus when they are\nunsupported, also ignore the existing on-disk ones.\n","title":"settings: ignore unsupported connections when they are loaded","timestamp":"2025-10-21T15:31:58+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/c1baf09bf9254998cfe60a96f637e62dfe56c3db","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/core/settings/nm-settings.c"],"removed":[]},{"id":"1e81aaa1538645988c5e2e789b667d4a17686eff","message":"settings: document some data structures\n","title":"settings: document some data structures","timestamp":"2025-10-21T15:31:58+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/1e81aaa1538645988c5e2e789b667d4a17686eff","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/core/settings/nm-settings-storage.h","src/core/settings/nm-settings.c"],"removed":[]},{"id":"ce26d85ad10574f4044b4a11aec3430823c85856","message":"merge: branch 'bg/reject-unsupported-conns'\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2299\n","title":"merge: branch 'bg/reject-unsupported-conns'","timestamp":"2025-10-21T15:34:19+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/ce26d85ad10574f4044b4a11aec3430823c85856","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["config.h.meson","meson.build","src/core/nm-core-utils.c","src/core/nm-core-utils.h","src/core/settings/nm-settings-storage.h","src/core/settings/nm-settings.c","src/libnm-core-public/nm-errors.h"],"removed":[]}],"total_commits_count":4,"push_options":{},"repository":{"name":"NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","description":"NetworkManager — network management daemon","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","visibility_level":20}}