This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/copr-backend See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names - systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in copr-backend See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Scriptlets/#_scriptlets ===== MUST items ===== Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [ ]: License file installed when any subpackage combination is installed. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/logstash, /usr/share/logstash/patterns [ ]: Package must own all directories that it creates. Note: Directories without known owners: /etc/sudoers.d, /usr/lib/python3.12/site-packages, /etc/logrotate.d, /usr/share/logstash, /usr/lib/python3.12, /usr/share/logstash/patterns [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 3247 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [ ]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: copr-backend-1.177-1.git.67.200d0d1.fc39.noarch.rpm copr-backend-doc-1.177-1.git.67.200d0d1.fc39.noarch.rpm copr-backend-1.177-1.git.67.200d0d1.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpud300avz')] checks: 32, packages: 3 copr-backend.noarch: W: tmpfile-not-in-filelist /run/copr-backend copr-backend.noarch: W: tmpfile-not-in-filelist /var/lock/copr-backend copr-backend-doc.noarch: E: spelling-error ('latests', "%description -l en_US latests -> latest, latest's, la tests") copr-backend.noarch: W: post-without-tmpfile-creation /usr/lib/tmpfiles.d/copr-backend.conf copr-backend.noarch: W: non-standard-uid /var/lib/copr/public_html copr copr-backend.noarch: W: non-standard-uid /var/lib/copr/public_html/results copr copr-backend.noarch: W: non-standard-uid /var/log/copr-backend copr copr-backend.noarch: W: non-standard-uid /var/run/copr-backend copr copr-backend.noarch: W: non-standard-gid /etc/copr/copr-be.conf copr copr-backend.noarch: W: non-standard-gid /var/lib/copr/public_html copr copr-backend.noarch: W: non-standard-gid /var/lib/copr/public_html/results copr copr-backend.noarch: W: non-standard-gid /var/log/copr-backend copr copr-backend.noarch: W: non-standard-gid /var/run/copr-backend copr copr-backend.noarch: E: non-readable /etc/copr/copr-be.conf 640 copr-backend.noarch: E: non-readable /etc/sudoers.d/copr 600 copr-backend.noarch: W: no-manual-page-for-binary copr-assure-permissions copr-backend.noarch: W: no-manual-page-for-binary copr-aws-s3-hitcounter copr-backend.noarch: W: no-manual-page-for-binary copr-backend-analyze-results copr-backend.noarch: W: no-manual-page-for-binary copr-backend-generate-graphs copr-backend.noarch: W: no-manual-page-for-binary copr-backend-process-action copr-backend.noarch: W: no-manual-page-for-binary copr-backend-process-build copr-backend.noarch: W: no-manual-page-for-binary copr-backend-resultdir-cleaner copr-backend.noarch: W: no-manual-page-for-binary copr-backend-unknown-resalloc-tickets.py copr-backend.noarch: W: no-manual-page-for-binary copr-compress-live-logs copr-backend.noarch: W: no-manual-page-for-binary copr-rename-chroot copr-backend.noarch: W: no-manual-page-for-binary copr-repo copr-backend.noarch: W: no-manual-page-for-binary copr-run-dispatcher-backend copr-backend.noarch: W: no-manual-page-for-binary copr_find_obsolete_builds.sh copr-backend.noarch: W: no-manual-page-for-binary copr_find_wrong_chroot_artifacts.py copr-backend.noarch: W: no-manual-page-for-binary copr_fix_gpg.py copr-backend.noarch: W: no-manual-page-for-binary copr_log_hitcounter.py copr-backend.noarch: W: no-manual-page-for-binary copr_print_results_to_delete.py copr-backend.noarch: W: no-manual-page-for-binary copr_prune_results.py copr-backend.noarch: W: no-manual-page-for-binary copr_prune_srpms.py copr-backend.noarch: W: no-manual-page-for-binary copr_run_logger.py copr-backend.noarch: W: no-manual-page-for-binary copr_sign_unsigned.py copr-backend.noarch: W: no-manual-page-for-binary print_queues.py copr-backend.noarch: W: no-manual-page-for-binary copr-backend-service copr-backend.noarch: E: logrotate-user-writable-log-dir /var/log/copr-backend copr:copr 0755 copr-backend.noarch: E: logrotate-log-dir-not-packaged /var/log/copr-backend/workers copr-backend.spec: W: invalid-url Source0: copr-backend-git-67.200d0d1.tar.gz copr-backend.noarch: W: incoherent-version-in-changelog 1.177-1 ['1.177-1.git.67.200d0d1.fc39', '1.177-1.git.67.200d0d1'] copr-backend-doc.noarch: W: hidden-file-or-dir /usr/share/doc/copr-backend/html/.buildinfo copr-backend.noarch: E: file-parent-ownership-mismatch Path "/var/log/copr-backend/copr.log" owned by "root" is stored in directory owned by "copr" copr-backend.noarch: E: file-parent-ownership-mismatch Path "/var/log/copr-backend/prune_old.log" owned by "root" is stored in directory owned by "copr" copr-backend.noarch: E: explicit-lib-dependency libappstream-glib-builder copr-backend.noarch: E: executable-marked-as-config-file /etc/cron.daily/copr-backend copr-backend.noarch: E: executable-marked-as-config-file /etc/cron.weekly/copr-backend copr-backend.noarch: E: dir-or-file-in-var-run /var/run/copr-backend 3 packages and 0 specfiles checked; 11 errors, 38 warnings, 13 filtered, 11 badness; has taken 0.4 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "copr-backend-doc". (none): E: there is no installed rpm "copr-backend". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/fedora-copr/test-data-copr-backend/archive/v5/test-data-copr-backend-5.tar.gz : CHECKSUM(SHA256) this package : 3e59d1c09620b1b7e8e54a6bdf28c02d615f11ca2ddc6f096b94b29c0f486f2d CHECKSUM(SHA256) upstream package : 3e59d1c09620b1b7e8e54a6bdf28c02d615f11ca2ddc6f096b94b29c0f486f2d Requires -------- copr-backend (rpmlib, GLIBC filtered): (copr-selinux if selinux-policy-targeted) /bin/sh /usr/bin/bash /usr/bin/python3 /usr/bin/sh ansible config(copr-backend) createrepo_c crontabs gawk libappstream-glib-builder lighttpd mock modulemd-tools obs-signd openssh-clients prunerepo python(abi) python3-boto3 python3-cachetools python3-copr python3-copr-common python3-daemon python3-dateutil python3-gobject python3-humanize python3-jinja2 python3-munch python3-netaddr python3-novaclient python3-packaging python3-pytz python3-requests python3-resalloc python3-retask python3-setproctitle python3-tabulate redis rpm-sign rsync systemd zstd copr-backend-doc (rpmlib, GLIBC filtered): Provides -------- copr-backend: config(copr-backend) copr-backend python3.12dist(copr-backend) python3dist(copr-backend) copr-backend-doc: copr-backend-doc Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name copr-backend --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-39-i686 Active plugins: Python, Shell-api, Generic Disabled plugins: R, Perl, C/C++, PHP, Ocaml, fonts, Java, SugarActivity, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH