This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /var/lib/copr- rpmbuild/results/nixnote2/diff.txt See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ - Packages have proper BuildRequires/Requires on javapackages-tools (jpackage-utils) - Javadoc documentation files are generated and included in -javadoc subpackage Note: No javadoc subpackage present. Note: Javadocs are optional for Fedora versions >= 21 See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation - Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Note: No javadoc subpackage present See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation - Bundled jar/class files should be removed before build Note: Jar files in source (see attachment) See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Java/#_pre_built_dependencies ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Public domain MIT License BSD 3-Clause License GNU Lesser General Public License, Version 2.1 GNU General Public License, Version 3 GNU General Public License, Version 2", "GNU General Public License, Version 2", "GNU General Public License v2.0 or later", "GNU Lesser General Public License v2.1 or later", "BSD 3-Clause License", "MIT License", "GNU Lesser General Public License, Version 3", "MIT License [generated file]". 298 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/nixnote2/licensecheck.txt [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/128x128/apps, /usr/share/icons/hicolor/scalable/apps, /usr/share/icons/hicolor/scalable, /usr/share/icons/hicolor/256x256, /usr/share/icons/hicolor, /usr/share/icons/hicolor/128x128, /usr/share/icons/hicolor/48x48/apps, /usr/share/icons/hicolor/48x48, /usr/share/icons/hicolor/512x512/apps, /usr/share/icons/hicolor/256x256/apps, /usr/share/icons/hicolor/512x512 [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 92160 bytes in 5 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Maven: [ ]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: Old add_to_maven_depmap macro is not being used ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define debug_package %{nil} [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. Java: [ ]: Packages are noarch unless they use JNI Note: nixnote2 subpackage is not noarch. Please verify manually [ ]: Package uses upstream build method (ant/maven/etc.) ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 3461120 bytes in /usr/share [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: nixnote2-2.1.10-1.ndias.fc38.x86_64.rpm nixnote2-2.1.10-1.ndias.fc38.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpli08t9z0')] checks: 31, packages: 2 nixnote2.x86_64: W: position-independent-executable-suggested /usr/bin/nixnote2 nixnote2.x86_64: W: files-duplicate /usr/share/nixnote2/LICENSE /usr/share/doc/nixnote2/LICENSE nixnote2.x86_64: W: files-duplicate /usr/share/nixnote2/version.txt /usr/share/nixnote2/build-version.txt nixnote2.x86_64: W: files-duplicate /usr/share/nixnote2/images/material-light/black_dot.png /usr/share/nixnote2/images/black_dot.png nixnote2.x86_64: W: files-duplicate /usr/share/nixnote2/images/home.png /usr/share/nixnote2/images/classic-theme/home.png nixnote2.x86_64: W: files-duplicate /usr/share/nixnote2/images/left_arrow.png /usr/share/nixnote2/images/classic-theme/left_arrow.png nixnote2.x86_64: W: files-duplicate /usr/share/nixnote2/images/right_arrow.png /usr/share/nixnote2/images/classic-theme/right_arrow.png nixnote2.x86_64: W: files-duplicate /usr/share/nixnote2/images/synchronize.png /usr/share/nixnote2/images/classic-theme/synchronize.png nixnote2.x86_64: W: files-duplicate /usr/share/nixnote2/images/material-light/collapsed.png /usr/share/nixnote2/images/collapsed.png nixnote2.x86_64: W: files-duplicate /usr/share/nixnote2/images/material-light/down_arrow_small.png /usr/share/nixnote2/images/down_arrow_small.png nixnote2.x86_64: W: files-duplicate /usr/share/nixnote2/images/material-light/expanded.png /usr/share/nixnote2/images/expanded.png nixnote2.x86_64: W: files-duplicate /usr/share/nixnote2/images/tree-down.png /usr/share/nixnote2/images/material-light/tree-down.png nixnote2.x86_64: W: files-duplicate /usr/share/nixnote2/images/up_arrow_small.png /usr/share/nixnote2/images/material-light/up_arrow_small.png nixnote2.x86_64: W: files-duplicate /usr/share/nixnote2/images/purple-theme/notebook.png /usr/share/nixnote2/images/notebookSmall.png nixnote2.x86_64: W: files-duplicate /usr/share/nixnote2/images/stack.png /usr/share/nixnote2/images/purple-theme/stack-purple.png nixnote2.x86_64: W: files-duplicate /usr/share/nixnote2/images/windowIcon.png /usr/share/nixnote2/images/splash_logo.png:/usr/share/nixnote2/images/trayicon.png nixnote2.x86_64: W: class-path-in-manifest /usr/share/nixnote2/java/crypto.jar 2 packages and 0 specfiles checked; 0 errors, 17 warnings, 0 badness; has taken 0.4 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 nixnote2.x86_64: W: unused-direct-shlib-dependency /usr/bin/nixnote2 /lib64/libQt5DBus.so.5 nixnote2.x86_64: W: unused-direct-shlib-dependency /usr/bin/nixnote2 /lib64/libGL.so.1 nixnote2.x86_64: W: unused-direct-shlib-dependency /usr/bin/nixnote2 /lib64/libm.so.6 nixnote2.x86_64: W: position-independent-executable-suggested /usr/bin/nixnote2 nixnote2.x86_64: W: files-duplicate /usr/share/nixnote2/LICENSE /usr/share/doc/nixnote2/LICENSE nixnote2.x86_64: W: files-duplicate /usr/share/nixnote2/version.txt /usr/share/nixnote2/build-version.txt nixnote2.x86_64: W: files-duplicate /usr/share/nixnote2/images/material-light/black_dot.png /usr/share/nixnote2/images/black_dot.png nixnote2.x86_64: W: files-duplicate /usr/share/nixnote2/images/home.png /usr/share/nixnote2/images/classic-theme/home.png nixnote2.x86_64: W: files-duplicate /usr/share/nixnote2/images/left_arrow.png /usr/share/nixnote2/images/classic-theme/left_arrow.png nixnote2.x86_64: W: files-duplicate /usr/share/nixnote2/images/right_arrow.png /usr/share/nixnote2/images/classic-theme/right_arrow.png nixnote2.x86_64: W: files-duplicate /usr/share/nixnote2/images/synchronize.png /usr/share/nixnote2/images/classic-theme/synchronize.png nixnote2.x86_64: W: files-duplicate /usr/share/nixnote2/images/material-light/collapsed.png /usr/share/nixnote2/images/collapsed.png nixnote2.x86_64: W: files-duplicate /usr/share/nixnote2/images/material-light/down_arrow_small.png /usr/share/nixnote2/images/down_arrow_small.png nixnote2.x86_64: W: files-duplicate /usr/share/nixnote2/images/material-light/expanded.png /usr/share/nixnote2/images/expanded.png nixnote2.x86_64: W: files-duplicate /usr/share/nixnote2/images/tree-down.png /usr/share/nixnote2/images/material-light/tree-down.png nixnote2.x86_64: W: files-duplicate /usr/share/nixnote2/images/up_arrow_small.png /usr/share/nixnote2/images/material-light/up_arrow_small.png nixnote2.x86_64: W: files-duplicate /usr/share/nixnote2/images/purple-theme/notebook.png /usr/share/nixnote2/images/notebookSmall.png nixnote2.x86_64: W: files-duplicate /usr/share/nixnote2/images/stack.png /usr/share/nixnote2/images/purple-theme/stack-purple.png nixnote2.x86_64: W: files-duplicate /usr/share/nixnote2/images/windowIcon.png /usr/share/nixnote2/images/splash_logo.png:/usr/share/nixnote2/images/trayicon.png nixnote2.x86_64: W: class-path-in-manifest /usr/share/nixnote2/java/crypto.jar 1 packages and 0 specfiles checked; 0 errors, 20 warnings, 0 badness; has taken 0.3 s Source checksums ---------------- https://github.com/robert7/nixnote2/archive/tags/v2.1.10.tar.gz#/nixnote2-2.1.10.tar.gz : CHECKSUM(SHA256) this package : 3a8e1a530605b05f16329da8f1b8002f24b6debe8c03cad9ab8b0d0b22612b54 CHECKSUM(SHA256) upstream package : 8a9a73a6c194f44ef9f16064b8178cad46341e219a386c47980431a0e767c2c0 diff -r also reports differences Requires -------- nixnote2 (rpmlib, GLIBC filtered): libGL.so.1()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.15)(64bit) libQt5DBus.so.5()(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5PrintSupport.so.5()(64bit) libQt5PrintSupport.so.5(Qt_5)(64bit) libQt5Qml.so.5()(64bit) libQt5Qml.so.5(Qt_5)(64bit) libQt5Sql.so.5()(64bit) libQt5Sql.so.5(Qt_5)(64bit) libQt5WebKit.so.5()(64bit) libQt5WebKit.so.5(Qt_5)(64bit) libQt5WebKitWidgets.so.5()(64bit) libQt5WebKitWidgets.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libQt5Xml.so.5()(64bit) libQt5Xml.so.5(Qt_5)(64bit) libc.so.6()(64bit) libcurl.so.4()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libhunspell-1.7.so.0()(64bit) libm.so.6()(64bit) libpoppler-qt5.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libtidy.so.58()(64bit) rtld(GNU_HASH) tidy Provides -------- nixnote2: application() application(nixnote2.desktop) nixnote2 nixnote2(x86-64) Jar and class files in source ----------------------------- ./nixnote2-2.1.10/java/crypto.jar Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name nixnote2 --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-38-x86_64 Active plugins: Java, Generic, C/C++, Shell-api Disabled plugins: SugarActivity, Haskell, PHP, Python, Perl, fonts, R, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH