This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text ===== MUST items ===== Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License". 17 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/vimde/licensecheck.txt [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: %config files are marked noreplace or the reason is justified. Note: No (noreplace) in %config /etc/vimderc %config /etc/tmuxderc [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: vimde-2022.1.0-1.fc36.noarch.rpm vimde-2022.1.0-1.fc36.src.rpm vimde.noarch: E: description-line-too-long C A simple Vim based IDE using vim plugins for Saltstack and RPM based development. vimde.noarch: E: description-line-too-long C VimDE can easily be extended by adding new plugins and editing your local .vimderc vimde.noarch: W: invalid-license Apache 2.0 vimde.noarch: W: conffile-without-noreplace-flag /etc/tmuxderc vimde.noarch: W: conffile-without-noreplace-flag /etc/vimderc vimde.noarch: W: no-documentation vimde.noarch: W: hidden-file-or-dir /usr/share/tmuxde/plugins/tmux-themepack/.github vimde.noarch: W: hidden-file-or-dir /usr/share/tmuxde/plugins/tmux-themepack/.github vimde.noarch: E: env-script-interpreter /usr/share/tmuxde/plugins/tmux-themepack/bin/build-theme /usr/bin/env bash vimde.noarch: E: env-script-interpreter /usr/share/tmuxde/plugins/tmux-themepack/themepack.tmux /usr/bin/env bash vimde.noarch: E: version-control-internal-file /usr/share/vimde/bundle/Vundle.vim/.gitignore vimde.noarch: W: hidden-file-or-dir /usr/share/vimde/bundle/deoplete-jedi/.flake8 vimde.noarch: E: zero-length /usr/share/vimde/bundle/deoplete-jedi/.flake8 vimde.noarch: W: hidden-file-or-dir /usr/share/vimde/bundle/deoplete-jedi/.github vimde.noarch: W: hidden-file-or-dir /usr/share/vimde/bundle/deoplete-jedi/.github vimde.noarch: E: version-control-internal-file /usr/share/vimde/bundle/deoplete-jedi/.gitignore vimde.noarch: W: hidden-file-or-dir /usr/share/vimde/bundle/deoplete-jedi/.travis.yml vimde.noarch: W: hidden-file-or-dir /usr/share/vimde/bundle/deoplete.nvim/.github vimde.noarch: W: hidden-file-or-dir /usr/share/vimde/bundle/deoplete.nvim/.github vimde.noarch: E: version-control-internal-file /usr/share/vimde/bundle/deoplete.nvim/.gitignore vimde.noarch: E: version-control-internal-file /usr/share/vimde/bundle/nvim-yarp/.gitignore vimde.noarch: E: version-control-internal-file /usr/share/vimde/bundle/supertab/.gitignore vimde.noarch: E: version-control-internal-file /usr/share/vimde/bundle/vim-hug-neovim-rpc/.gitignore vimde.noarch: W: hidden-file-or-dir /usr/share/vimde/bundle/vim-pandoc-syntax/.github vimde.noarch: W: hidden-file-or-dir /usr/share/vimde/bundle/vim-pandoc-syntax/.github vimde.noarch: E: version-control-internal-file /usr/share/vimde/bundle/vim-pandoc-syntax/.gitignore vimde.noarch: W: hidden-file-or-dir /usr/share/vimde/bundle/vim-pandoc-syntax/.vintrc.yaml vimde.noarch: W: hidden-file-or-dir /usr/share/vimde/bundle/vim-pandoc/.github vimde.noarch: W: hidden-file-or-dir /usr/share/vimde/bundle/vim-pandoc/.github vimde.noarch: E: version-control-internal-file /usr/share/vimde/bundle/vim-pandoc/.gitignore vimde.noarch: W: hidden-file-or-dir /usr/share/vimde/bundle/vim-pandoc/.vintrc.yaml vimde.noarch: E: env-script-interpreter /usr/share/vimde/bundle/vim-pandoc/python3/vim_pandoc/async.py /usr/bin/env python vimde.noarch: E: non-executable-script /usr/share/vimde/bundle/vim-pandoc/python3/vim_pandoc/bib/citeproc.py 644 /usr/bin/env python2 vimde.noarch: E: version-control-internal-file /usr/share/vimde/bundle/vim-tmux-navigator/.gitignore vimde.noarch: E: non-executable-script /usr/share/vimde/bundle/vim-tmux-navigator/pattern-check 644 /usr/bin/env bash vimde.noarch: E: env-script-interpreter /usr/share/vimde/bundle/vim-tmux-navigator/vim-tmux-navigator.tmux /usr/bin/env bash vimde.noarch: E: version-control-internal-file /usr/share/vimde/bundle/vimux/.gitignore vimde.noarch: W: no-manual-page-for-binary vimde vimde.src: W: spelling-error Summary(en_US) tmux -> tux vimde.src: E: description-line-too-long C A simple Vim based IDE using vim plugins for Saltstack and RPM based development. vimde.src: E: description-line-too-long C VimDE can easily be extended by adding new plugins and editing your local .vimderc vimde.src: W: invalid-license Apache 2.0 vimde.src:46: W: mixed-use-of-spaces-and-tabs (spaces: line 46, tab: line 7) 2 packages and 0 specfiles checked; 21 errors, 22 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/vim-pandoc/vim-pandoc-syntax/archive/0d1129e5cf1b0e3a90e923c3b5f40133bf153f7c/vim-pandoc-syntax-0d1129e.tar.gz : CHECKSUM(SHA256) this package : b2bbda6375cbcb140ef6a2ba42e9115afa34813f0ad4ddaa99531425f90ae4b7 CHECKSUM(SHA256) upstream package : b2bbda6375cbcb140ef6a2ba42e9115afa34813f0ad4ddaa99531425f90ae4b7 https://github.com/vim-pandoc/vim-pandoc/archive/e49f9e7e3fc041dab0e9a1de4b564b3ddd8f77aa/vim-pandoc-e49f9e7.tar.gz : CHECKSUM(SHA256) this package : ebf6e1cff2430121e7659fb93e4578eedc0b6e468b1614fa1f8f751c2fa4b192 CHECKSUM(SHA256) upstream package : ebf6e1cff2430121e7659fb93e4578eedc0b6e468b1614fa1f8f751c2fa4b192 https://github.com/christoomey/vim-tmux-navigator/archive/44ba6fbe45895cd541ebfc87606add5c76e3829b/vim-tmux-navigator-44ba6fb.tar.gz : CHECKSUM(SHA256) this package : 8b7771d3d6f6c14cae3598f93df2250c2bf5ea65272543399303218c0a5c07b3 CHECKSUM(SHA256) upstream package : 8b7771d3d6f6c14cae3598f93df2250c2bf5ea65272543399303218c0a5c07b3 https://github.com/low-ghost/nerdtree-fugitive/archive/f7acffdc05b5db893daa8201f3ff85945da50fcb/nerdtree-fugitive-f7acffd.tar.gz : CHECKSUM(SHA256) this package : 7e27457e4146e21a7127dba35684475f05fc276adcd1ae7f3a7c2eb0a3936a84 CHECKSUM(SHA256) upstream package : 7e27457e4146e21a7127dba35684475f05fc276adcd1ae7f3a7c2eb0a3936a84 https://github.com/ervandew/supertab/archive/40fe711e088e2ab346738233dd5adbb1be355172/supertab-40fe711.tar.gz : CHECKSUM(SHA256) this package : 679077b99c2816daa82f1cb23b0f7dbddd36510f2fef97d33c9a0ad8e4aff690 CHECKSUM(SHA256) upstream package : 679077b99c2816daa82f1cb23b0f7dbddd36510f2fef97d33c9a0ad8e4aff690 https://github.com/deoplete-plugins/deoplete-jedi/archive/43058915007d92dc167b84dd5b8ada2d2a057a82/deoplete-jedi-4305891.tar.gz : CHECKSUM(SHA256) this package : 1562c0b5df562dabed4a5671290ec2c835ac7e9d75793ff419b0eb984c5123e9 CHECKSUM(SHA256) upstream package : 1562c0b5df562dabed4a5671290ec2c835ac7e9d75793ff419b0eb984c5123e9 https://github.com/roxma/vim-hug-neovim-rpc/archive/93ae38792bc197c3bdffa2716ae493c67a5e7957/vim-hug-neovim-rpc-93ae387.tar.gz : CHECKSUM(SHA256) this package : 3dd3cfc73486875932da253dcd7e1c69db6dab0df93cd51b0c30ed41f4a9f73a CHECKSUM(SHA256) upstream package : 3dd3cfc73486875932da253dcd7e1c69db6dab0df93cd51b0c30ed41f4a9f73a https://github.com/roxma/nvim-yarp/archive/b710bf4daccb603a423754794fb446e5fbb59576/nvim-yarp-b710bf4.tar.gz : CHECKSUM(SHA256) this package : a65969ad60deb86a291d61307c9b8e485d8a43a54f8675cb9528cf3ba87ce00d CHECKSUM(SHA256) upstream package : a65969ad60deb86a291d61307c9b8e485d8a43a54f8675cb9528cf3ba87ce00d https://github.com/Shougo/deoplete.nvim/archive/6.1.tar.gz : CHECKSUM(SHA256) this package : e355768ff81ddca974d64876d86d7a6a1a2208c062a7a28470b6583e03a9246c CHECKSUM(SHA256) upstream package : e355768ff81ddca974d64876d86d7a6a1a2208c062a7a28470b6583e03a9246c https://github.com/vim-scripts/vim-auto-save/archive/0.1.7.tar.gz : CHECKSUM(SHA256) this package : 3e33096be6762cbfe118f1b77ebe71e577308fb85c8671c541ac262c9bcd6f7f CHECKSUM(SHA256) upstream package : 3e33096be6762cbfe118f1b77ebe71e577308fb85c8671c541ac262c9bcd6f7f https://github.com/jimeh/tmux-themepack/archive/7c59902f64dcd7ea356e891274b21144d1ea5948/tmux-themepack-7c59902.tar.gz : CHECKSUM(SHA256) this package : d21005092831cbc9c6d990c42242b10091825956729329152c39d8ed91c35879 CHECKSUM(SHA256) upstream package : d21005092831cbc9c6d990c42242b10091825956729329152c39d8ed91c35879 https://github.com/benmills/vimux/archive/37f41195e6369ac602a08ec61364906600b771f1/vimux-37f4119.tar.gz : CHECKSUM(SHA256) this package : 236c11a8276e452435b16c643edbb3781e92297a4f43bc6560445874b58380e0 CHECKSUM(SHA256) upstream package : 236c11a8276e452435b16c643edbb3781e92297a4f43bc6560445874b58380e0 https://github.com/Glench/Vim-Jinja2-Syntax/archive/b59d179defbc9fd6e6f426569f8430592e1a6a1b/Vim-Jinja2-Syntax-b59d179.tar.gz : CHECKSUM(SHA256) this package : c915f29b518bfba7443781f394121c7a2e0d5a2a10e2343b6173d4db5cb23d12 CHECKSUM(SHA256) upstream package : c915f29b518bfba7443781f394121c7a2e0d5a2a10e2343b6173d4db5cb23d12 https://github.com/saltstack/salt-vim/archive/6ca9e3500cc39dd417b411435d58a1b720b331cc/salt_vim-6ca9e35.tar.gz : CHECKSUM(SHA256) this package : e37d229464688fa0042330e7cdbcc7642f72b8db00aac394e60aa639cf7254dc CHECKSUM(SHA256) upstream package : e37d229464688fa0042330e7cdbcc7642f72b8db00aac394e60aa639cf7254dc https://github.com/VundleVim/Vundle.vim/archive/b255382d6242d7ea3877bf059d2934125e0c4d95/Vundle.vim-b255382.tar.gz : CHECKSUM(SHA256) this package : b3c4bf3a0ca59d9c6ba49eb853dba66a359686bdae96e539aa332d1d1d0e1f4e CHECKSUM(SHA256) upstream package : b3c4bf3a0ca59d9c6ba49eb853dba66a359686bdae96e539aa332d1d1d0e1f4e https://github.com/c4t3l/vimde/archive/2022.1.0.tar.gz : CHECKSUM(SHA256) this package : 015ccbb3c9558abaac063e7ef2fabca50ceea055d0e3e60a37acaf77937eeab5 CHECKSUM(SHA256) upstream package : 015ccbb3c9558abaac063e7ef2fabca50ceea055d0e3e60a37acaf77937eeab5 Requires -------- vimde (rpmlib, GLIBC filtered): /usr/bin/env /usr/bin/python3 awesome-vim-colorschemes config(vimde) ctags git pandoc python3-bpython python3-jedi python3-msgpack python3-neovim python3-pudb python3-setproctitle surf tmux tmux-powerline vim-ale vim-enhanced vim-fugitive vim-nerdtree vim-powerline wemux Provides -------- vimde: config(vimde) vimde Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name vimde --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: PHP, Java, fonts, SugarActivity, Perl, R, Python, C/C++, Haskell, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH