This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
ones are mandatory, though)
- Remove this text
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files directly in %_libdir.
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/#_devel_packages
- If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %license.
Note: License file COPYING is not marked as %license
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/LicensingGuidelines/#_license_text
- Package does not use a name that already exists.
Note: A package with this name already exists. Please check
https://src.fedoraproject.org/rpms/dd_rescue
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/Naming/#_conflicting_package_names
===== MUST items =====
C/C++:
[ ]: Provides: bundled(gnulib) in place as required.
Note: Sources not installed
[ ]: Package does not contain kernel modules.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
Generic:
[ ]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GNU General Public License, Version
2", "*No copyright* GNU General Public License, Version 2 and/or
Public domain", "GNU General Public License v2.0 or later". 87 files
have unknown license. Detailed output of licensecheck in
/var/lib/copr-rpmbuild/results/dd_rescue/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 47763 bytes in 4 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[!]: Reviewer should test that the package builds in mock.
[ ]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[ ]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[ ]: Package should compile and build into binary rpms on all supported
architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on debuginfo package(s).
Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
Note: No rpmlint messages.
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
[x]: Package should not use obsolete m4 macros
Rpmlint
-------
Checking: dd_rescue-1.99.15-1.fc40.s390x.rpm
dd_rescue-debuginfo-1.99.15-1.fc40.s390x.rpm
dd_rescue-debugsource-1.99.15-1.fc40.s390x.rpm
dd_rescue-1.99.15-1.fc40.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
/usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp89zej35f')]
checks: 32, packages: 4
dd_rescue.s390x: E: spelling-error ('rhelp', '%description -l en_US rhelp -> help, whelp, r help')
dd_rescue.s390x: E: spelling-error ('ddrescue', '%description -l en_US ddrescue -> dd rescue, dd-rescue, rescuer')
dd_rescue.s390x: E: spelling-error ('sequent', '%description -l en_US sequent -> subsequent, sequence, consequent')
dd_rescue.src: E: spelling-error ('rhelp', '%description -l en_US rhelp -> help, whelp, r help')
dd_rescue.src: E: spelling-error ('ddrescue', '%description -l en_US ddrescue -> dd rescue, dd-rescue, rescuer')
dd_rescue.src: E: spelling-error ('sequent', '%description -l en_US sequent -> subsequent, sequence, consequent')
dd_rescue.s390x: W: no-soname /usr/lib64/libddr_crypt.so
dd_rescue.s390x: W: no-soname /usr/lib64/libddr_hash.so
dd_rescue.s390x: W: no-soname /usr/lib64/libddr_lzo.so
dd_rescue.s390x: W: no-soname /usr/lib64/libddr_null.so
dd_rescue.s390x: W: no-manual-page-for-binary dd_rhelp
dd_rescue.s390x: E: incorrect-fsf-address /usr/bin/dd_rhelp
4 packages and 0 specfiles checked; 7 errors, 5 warnings, 44 filtered, 7 badness; has taken 0.8 s
Rpmlint (debuginfo)
-------------------
Checking: dd_rescue-debuginfo-1.99.15-1.fc40.s390x.rpm
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
/usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp_svar2lu')]
checks: 32, packages: 1
1 packages and 0 specfiles checked; 0 errors, 0 warnings, 18 filtered, 0 badness; has taken 0.2 s
Rpmlint (installed packages)
----------------------------
(none): E: there is no installed rpm "dd_rescue-debugsource".
(none): E: there is no installed rpm "dd_rescue-debuginfo".
(none): E: there is no installed rpm "dd_rescue".
There are no files to process nor additional arguments.
Nothing to do, aborting.
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
/usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3
0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s
Unversioned so-files
--------------------
dd_rescue: /usr/lib64/libddr_MD5.so
dd_rescue: /usr/lib64/libddr_crypt.so
dd_rescue: /usr/lib64/libddr_hash.so
dd_rescue: /usr/lib64/libddr_lzo.so
dd_rescue: /usr/lib64/libddr_null.so
Source checksums
----------------
http://www.garloff.de/kurt/linux/ddrescue/dd_rescue-1.99.15.tar.bz2.asc :
CHECKSUM(SHA256) this package : 9ecb2172b8b4a43e5b5ba12323b13f6b8bd2352a285eb90c00ac8d2780efce57
CHECKSUM(SHA256) upstream package : 9ecb2172b8b4a43e5b5ba12323b13f6b8bd2352a285eb90c00ac8d2780efce57
http://www.kalysto.org/pkg/dd_rhelp-0.3.0.tar.gz :
CHECKSUM(SHA256) this package : 2f7c360eddab5ff9a9b8ee91d45541f00a86289984075de260b12e3f8476262f
CHECKSUM(SHA256) upstream package : 2f7c360eddab5ff9a9b8ee91d45541f00a86289984075de260b12e3f8476262f
http://www.garloff.de/kurt/linux/ddrescue/dd_rescue-1.99.15.tar.bz2 :
CHECKSUM(SHA256) this package : 83936f24fbb9ff70722b55f69cd0dff71bc4a4aabfcf9b56b5128f98bfe16f89
CHECKSUM(SHA256) upstream package : 83936f24fbb9ff70722b55f69cd0dff71bc4a4aabfcf9b56b5128f98bfe16f89
Requires
--------
dd_rescue (rpmlib, GLIBC filtered):
/usr/bin/bash
bc
coreutils
grep
libc.so.6()(64bit)
liblzo2.so.2()(64bit)
rtld(GNU_HASH)
sed
dd_rescue-debuginfo (rpmlib, GLIBC filtered):
dd_rescue-debugsource (rpmlib, GLIBC filtered):
Provides
--------
dd_rescue:
dd_rescue
dd_rescue(s390-64)
libddr_crypt.so()(64bit)
libddr_hash.so()(64bit)
libddr_lzo.so()(64bit)
libddr_null.so()(64bit)
dd_rescue-debuginfo:
dd_rescue-debuginfo
dd_rescue-debuginfo(s390-64)
debuginfo(build-id)
libddr_crypt.so-1.99.15-1.fc40.s390x.debug()(64bit)
libddr_hash.so-1.99.15-1.fc40.s390x.debug()(64bit)
libddr_lzo.so-1.99.15-1.fc40.s390x.debug()(64bit)
libddr_null.so-1.99.15-1.fc40.s390x.debug()(64bit)
dd_rescue-debugsource:
dd_rescue-debugsource
dd_rescue-debugsource(s390-64)
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name dd_rescue --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg
Buildroot used: fedora-40-s390x
Active plugins: C/C++, Generic, Shell-api
Disabled plugins: Perl, Ocaml, Python, fonts, Java, R, SugarActivity, Haskell, PHP
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH