This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package must not depend on deprecated() packages. Note: python2.7 is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/deprecating-packages/ - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1550953 bytes in 94 files. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_documentation ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/john-jumbo [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/john-jumbo [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. Note: Multiple Release: tags found [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [ ]: Package contains the mandatory BuildRequires and Requires:. ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1638400 bytes in /usr/share [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: john-jumbo-1.9.0-8.jumbo.1.git20231204.fc40.x86_64.rpm john-jumbo-1.9.0-8.jumbo.1.git20231204.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmps8nm7p85')] checks: 31, packages: 2 john-jumbo.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/john-jumbo/README.krb5tgs-17-18-23.md john-jumbo.x86_64: W: unstripped-binary-or-object /usr/bin/john-jumbo john-jumbo.x86_64: W: unstripped-binary-or-object /usr/libexec/john/john-avx john-jumbo.x86_64: W: unstripped-binary-or-object /usr/libexec/john/john-avx-omp john-jumbo.x86_64: W: unstripped-binary-or-object /usr/libexec/john/john-avx2 john-jumbo.x86_64: W: unstripped-binary-or-object /usr/libexec/john/john-avx2-omp john-jumbo.x86_64: W: unstripped-binary-or-object /usr/libexec/john/john-avx512bw john-jumbo.x86_64: W: unstripped-binary-or-object /usr/libexec/john/john-avx512bw-omp john-jumbo.x86_64: W: unstripped-binary-or-object /usr/libexec/john/john-avx512f john-jumbo.x86_64: W: unstripped-binary-or-object /usr/libexec/john/john-avx512f-omp john-jumbo.x86_64: W: unstripped-binary-or-object /usr/libexec/john/john-sse2 john-jumbo.x86_64: W: unstripped-binary-or-object /usr/libexec/john/john-sse2-omp john-jumbo.x86_64: W: unstripped-binary-or-object /usr/libexec/john/john-xop john-jumbo.x86_64: W: unstripped-binary-or-object /usr/libexec/john/john-xop-omp john-jumbo.x86_64: E: script-without-shebang /usr/bin/pkcs12kdf.py john-jumbo.x86_64: W: non-executable-in-bin /usr/bin/pkcs12kdf.py 644 john-jumbo.x86_64: W: no-manual-page-for-binary 1password2john.py john-jumbo.x86_64: W: no-manual-page-for-binary 7z2john.pl john-jumbo.x86_64: W: no-manual-page-for-binary DPAPImk2john.py john-jumbo.x86_64: W: no-manual-page-for-binary adxcsouf2john.py john-jumbo.x86_64: W: no-manual-page-for-binary aem2john.py john-jumbo.x86_64: W: no-manual-page-for-binary aix2john.pl john-jumbo.x86_64: W: no-manual-page-for-binary aix2john.py john-jumbo.x86_64: W: no-manual-page-for-binary andotp2john.py john-jumbo.x86_64: W: no-manual-page-for-binary androidbackup2john.py john-jumbo.x86_64: W: no-manual-page-for-binary androidfde2john.py john-jumbo.x86_64: W: no-manual-page-for-binary ansible2john.py john-jumbo.x86_64: W: no-manual-page-for-binary apex2john.py john-jumbo.x86_64: W: no-manual-page-for-binary apop2john.py john-jumbo.x86_64: W: no-manual-page-for-binary applenotes2john.py john-jumbo.x86_64: W: no-manual-page-for-binary aruba2john.py john-jumbo.x86_64: W: no-manual-page-for-binary atmail2john.pl john-jumbo.x86_64: W: no-manual-page-for-binary axcrypt2john.py john-jumbo.x86_64: W: no-manual-page-for-binary base64conv john-jumbo.x86_64: W: no-manual-page-for-binary bestcrypt2john.py john-jumbo.x86_64: W: no-manual-page-for-binary bestcryptve2john.py john-jumbo.x86_64: W: no-manual-page-for-binary bitcoin2john.py john-jumbo.x86_64: W: no-manual-page-for-binary bitshares2john.py john-jumbo.x86_64: W: no-manual-page-for-binary bitwarden2john.py john-jumbo.x86_64: W: no-manual-page-for-binary bks2john.py john-jumbo.x86_64: W: no-manual-page-for-binary blockchain2john.py john-jumbo.x86_64: W: no-manual-page-for-binary cardano2john.py john-jumbo.x86_64: W: no-manual-page-for-binary ccache2john.py john-jumbo.x86_64: W: no-manual-page-for-binary cisco2john.pl john-jumbo.x86_64: W: no-manual-page-for-binary codepage.pl john-jumbo.x86_64: W: no-manual-page-for-binary coinomi2john.py john-jumbo.x86_64: W: no-manual-page-for-binary cracf2john.py john-jumbo.x86_64: W: no-manual-page-for-binary dashlane2john.py john-jumbo.x86_64: W: no-manual-page-for-binary deepsound2john.py john-jumbo.x86_64: W: no-manual-page-for-binary diskcryptor2john.py john-jumbo.x86_64: W: no-manual-page-for-binary dmg2john.py john-jumbo.x86_64: W: no-manual-page-for-binary ecryptfs2john.py john-jumbo.x86_64: W: no-manual-page-for-binary ejabberd2john.py john-jumbo.x86_64: W: no-manual-page-for-binary electrum2john.py john-jumbo.x86_64: W: no-manual-page-for-binary encdatavault2john.py john-jumbo.x86_64: W: no-manual-page-for-binary encfs2john.py john-jumbo.x86_64: W: no-manual-page-for-binary enpass2john.py john-jumbo.x86_64: W: no-manual-page-for-binary enpass5tojohn.py john-jumbo.x86_64: W: no-manual-page-for-binary ethereum2john.py john-jumbo.x86_64: W: no-manual-page-for-binary filezilla2john.py john-jumbo.x86_64: W: no-manual-page-for-binary fuzz_option.pl john-jumbo.x86_64: W: no-manual-page-for-binary geli2john.py john-jumbo.x86_64: W: no-manual-page-for-binary genincstats.rb john-jumbo.x86_64: W: no-manual-page-for-binary gpg2john john-jumbo.x86_64: W: no-manual-page-for-binary hccapx2john.py john-jumbo.x86_64: W: no-manual-page-for-binary hextoraw.pl john-jumbo.x86_64: W: no-manual-page-for-binary htdigest2john.py john-jumbo.x86_64: W: no-manual-page-for-binary ibmiscanner2john.py john-jumbo.x86_64: W: no-manual-page-for-binary ikescan2john.py john-jumbo.x86_64: W: no-manual-page-for-binary ios7tojohn.pl john-jumbo.x86_64: W: no-manual-page-for-binary itunes_backup2john.pl john-jumbo.x86_64: W: no-manual-page-for-binary iwork2john.py john-jumbo.x86_64: W: no-manual-page-for-binary john-jumbo john-jumbo.x86_64: W: no-manual-page-for-binary kdcdump2john.py john-jumbo.x86_64: W: no-manual-page-for-binary keplr2john.py john-jumbo.x86_64: W: no-manual-page-for-binary keychain2john.py john-jumbo.x86_64: W: no-manual-page-for-binary keyring2john.py john-jumbo.x86_64: W: no-manual-page-for-binary keystore2john.py john-jumbo.x86_64: W: no-manual-page-for-binary kirbi2john.py john-jumbo.x86_64: W: no-manual-page-for-binary known_hosts2john.py john-jumbo.x86_64: W: no-manual-page-for-binary krb2john.py john-jumbo.x86_64: W: no-manual-page-for-binary kwallet2john.py john-jumbo.x86_64: W: no-manual-page-for-binary lastpass2john.py john-jumbo.x86_64: W: no-manual-page-for-binary ldif2john.pl john-jumbo.x86_64: W: no-manual-page-for-binary leet.pl john-jumbo.x86_64: W: no-manual-page-for-binary libreoffice2john.py john-jumbo.x86_64: W: no-manual-page-for-binary lion2john-alt.pl john-jumbo.x86_64: W: no-manual-page-for-binary lion2john.pl john-jumbo.x86_64: W: no-manual-page-for-binary lotus2john.py john-jumbo.x86_64: W: no-manual-page-for-binary luks2john.py john-jumbo.x86_64: W: no-manual-page-for-binary mac2john-alt.py john-jumbo.x86_64: W: no-manual-page-for-binary mac2john.py john-jumbo.x86_64: W: no-manual-page-for-binary mcafee_epo2john.py john-jumbo.x86_64: W: no-manual-page-for-binary monero2john.py john-jumbo.x86_64: W: no-manual-page-for-binary money2john.py john-jumbo.x86_64: W: no-manual-page-for-binary mosquitto2john.py john-jumbo.x86_64: W: no-manual-page-for-binary mozilla2john.py john-jumbo.x86_64: W: no-manual-page-for-binary multibit2john.py john-jumbo.x86_64: W: no-manual-page-for-binary neo2john.py john-jumbo.x86_64: W: no-manual-page-for-binary netntlm.pl john-jumbo.x86_64: W: no-manual-page-for-binary netscreen.py john-jumbo.x86_64: W: no-manual-page-for-binary office2john.py john-jumbo.x86_64: W: no-manual-page-for-binary openbsd_softraid2john.py john-jumbo.x86_64: W: no-manual-page-for-binary openssl2john.py john-jumbo.x86_64: W: no-manual-page-for-binary padlock2john.py john-jumbo.x86_64: W: no-manual-page-for-binary pass_gen.pl john-jumbo.x86_64: W: no-manual-page-for-binary pcap2john.py john-jumbo.x86_64: W: no-manual-page-for-binary pdf2john.pl john-jumbo.x86_64: W: no-manual-page-for-binary pdf2john.py john-jumbo.x86_64: W: no-manual-page-for-binary pem2john.py john-jumbo.x86_64: W: no-manual-page-for-binary pfx2john.py john-jumbo.x86_64: W: no-manual-page-for-binary pgpdisk2john.py john-jumbo.x86_64: W: no-manual-page-for-binary pgpsda2john.py john-jumbo.x86_64: W: no-manual-page-for-binary pgpwde2john.py john-jumbo.x86_64: W: no-manual-page-for-binary potcheck.pl john-jumbo.x86_64: W: no-manual-page-for-binary prosody2john.py john-jumbo.x86_64: W: no-manual-page-for-binary ps_token2john.py john-jumbo.x86_64: W: no-manual-page-for-binary pse2john.py john-jumbo.x86_64: W: no-manual-page-for-binary pwsafe2john.py john-jumbo.x86_64: W: no-manual-page-for-binary radius2john.pl john-jumbo.x86_64: W: no-manual-page-for-binary radius2john.py john-jumbo.x86_64: W: no-manual-page-for-binary rar2john john-jumbo.x86_64: W: no-manual-page-for-binary restic2john.py john-jumbo.x86_64: W: no-manual-page-for-binary rexgen2rules.pl john-jumbo.x86_64: W: no-manual-page-for-binary rulestack.pl john-jumbo.x86_64: W: no-manual-page-for-binary sap2john.pl john-jumbo.x86_64: W: no-manual-page-for-binary sense2john.py john-jumbo.x86_64: W: no-manual-page-for-binary sha-dump.pl john-jumbo.x86_64: W: no-manual-page-for-binary sha-test.pl john-jumbo.x86_64: W: no-manual-page-for-binary signal2john.py john-jumbo.x86_64: W: no-manual-page-for-binary sipdump2john.py john-jumbo.x86_64: W: no-manual-page-for-binary ssh2john.py john-jumbo.x86_64: W: no-manual-page-for-binary sspr2john.py john-jumbo.x86_64: W: no-manual-page-for-binary staroffice2john.py john-jumbo.x86_64: W: no-manual-page-for-binary strip2john.py john-jumbo.x86_64: W: no-manual-page-for-binary telegram2john.py john-jumbo.x86_64: W: no-manual-page-for-binary test_tezos2john.py john-jumbo.x86_64: W: no-manual-page-for-binary tezos2john.py john-jumbo.x86_64: W: no-manual-page-for-binary truecrypt2john.py john-jumbo.x86_64: W: no-manual-page-for-binary undrop john-jumbo.x86_64: W: no-manual-page-for-binary unrule.pl john-jumbo.x86_64: W: no-manual-page-for-binary vdi2john.pl john-jumbo.x86_64: W: no-manual-page-for-binary vmx2john.py john-jumbo.x86_64: W: no-manual-page-for-binary zed2john.py john-jumbo.x86_64: W: no-manual-page-for-binary zip2john john-jumbo.x86_64: W: install-file-in-docs /usr/share/doc/john-jumbo/INSTALL john-jumbo.x86_64: E: incorrect-fsf-address /usr/bin/openbsd_softraid2john.py john-jumbo.x86_64: W: incoherent-version-in-changelog 1.9.0-jumbo.1.7 ['1.9.0-8.jumbo.1.git20231204.fc40', '1.9.0-8.jumbo.1.git20231204'] john-jumbo.x86_64: W: file-not-utf8 /usr/share/doc/john-jumbo/CREDITS john-jumbo.x86_64: W: dangling-relative-symlink /usr/share/doc/john-jumbo/README ../README.md 2 packages and 0 specfiles checked; 2 errors, 148 warnings, 2 badness; has taken 1.9 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "john-jumbo". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/openwall/john/archive/4222aa48e282fdd608b4b54a7efadb834a999b42/john-jumbo-1.9.0-4222aa4.tar.gz#/john-jumbo-1.9.0-20231204-4222aa4.tar.gz : CHECKSUM(SHA256) this package : af6f756a79ddc9409e42118f6b5b77611cc55b4c9e0a4331dbd8207235aaa474 CHECKSUM(SHA256) upstream package : af6f756a79ddc9409e42118f6b5b77611cc55b4c9e0a4331dbd8207235aaa474 Requires -------- john-jumbo (rpmlib, GLIBC filtered): /usr/bin/perl /usr/bin/python2 /usr/bin/python3 /usr/bin/ruby john libbz2.so.1()(64bit) libc.so.6()(64bit) libcrypt.so.2()(64bit) libcrypt.so.2(XCRYPT_2.0)(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgmp.so.10()(64bit) libgomp.so.1()(64bit) libgomp.so.1(GOMP_1.0)(64bit) libgomp.so.1(GOMP_4.0)(64bit) libgomp.so.1(OMP_1.0)(64bit) libm.so.6()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) Provides -------- john-jumbo: john-jumbo john-jumbo(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name john-jumbo --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Perl, Shell-api, C/C++ Disabled plugins: PHP, Java, R, Haskell, Python, SugarActivity, fonts, Ocaml Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH