This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/pop-launcher See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Mozilla Public License 2.0", "GNU General Public License, Version 3 and/or Mozilla Public License 2.0", "Mozilla Public License 2.0", "GNU General Public License, Version 3", "*No copyright* Apache License 2.0", "MIT License", "BSD 0-Clause License", "*No copyright* MIT License", "*No copyright* The Unlicense", "Apache License 2.0", "Apache License 2.0 and/or MIT License", "zlib License", "*No copyright* zlib License", "BSD 3-Clause License", "*No copyright* GNU Lesser General Public License", "ISC License", "Apache License (v2.0) or MIT license", "*No copyright* Apache License 2.0 and/or MIT License", "*No copyright* Boost Software License 1.0", "Unicode License Agreement - Data Files and Software (2016)", "*No copyright* Apache License (v2.0) or MIT license", "BSD 2-Clause License", "*No copyright* GNU General Public License, Version 3", "Historical Permission Notice and Disclaimer - sell variant and/or NTP License (legal disclaimer)", "*No copyright* W3C License", "SSLeay", "OpenSSL License [generated file]", "Apache License 2.0 and/or Boost Software License 1.0", "Apache License 2.0 and/or MIT License [generated file]", "BSD 2-Clause with views sentence", "ISC License [generated file]", "OpenSSL License", "*No copyright* Apache License (v2.0) or MIT license and/or MIT License", "MIT Open Group variant", "*No copyright* GNU General Public License, Version 2". 14686 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/pop- launcher/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 8558 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: pop-launcher-1.2.3^git20241018.fca3b25-1.fc42.x86_64.rpm pop-launcher-debuginfo-1.2.3^git20241018.fca3b25-1.fc42.x86_64.rpm pop-launcher-debugsource-1.2.3^git20241018.fca3b25-1.fc42.x86_64.rpm pop-launcher-1.2.3^git20241018.fca3b25-1.fc42.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpf6r68x1o')] checks: 32, packages: 4 pop-launcher.x86_64: E: non-executable-script /usr/libexec/pop-launcher/scripts/session/session-bios.sh 644 /usr/bin/env sh pop-launcher.x86_64: E: non-executable-script /usr/libexec/pop-launcher/scripts/session/session-lock.sh 644 /usr/bin/env sh pop-launcher.x86_64: E: non-executable-script /usr/libexec/pop-launcher/scripts/session/session-logout.sh 644 /usr/bin/env sh pop-launcher.x86_64: E: non-executable-script /usr/libexec/pop-launcher/scripts/session/session-reboot.sh 644 /usr/bin/env sh pop-launcher.x86_64: E: non-executable-script /usr/libexec/pop-launcher/scripts/session/session-shutdown.sh 644 /usr/bin/env sh pop-launcher.x86_64: E: non-executable-script /usr/libexec/pop-launcher/scripts/session/session-suspend.sh 644 /usr/bin/env sh pop-launcher.x86_64: E: non-executable-script /usr/libexec/pop-launcher/scripts/system76-power/graphics-compute.sh 644 /usr/bin/env sh pop-launcher.x86_64: E: non-executable-script /usr/libexec/pop-launcher/scripts/system76-power/graphics-discrete.sh 644 /usr/bin/env sh pop-launcher.x86_64: E: non-executable-script /usr/libexec/pop-launcher/scripts/system76-power/graphics-hybrid.sh 644 /usr/bin/env sh pop-launcher.x86_64: E: non-executable-script /usr/libexec/pop-launcher/scripts/system76-power/graphics-integrated.sh 644 /usr/bin/env sh pop-launcher.x86_64: W: no-manual-page-for-binary pop-launcher pop-launcher.spec: W: invalid-url Source1: vendor-fca3b25.tar.gz 4 packages and 0 specfiles checked; 10 errors, 2 warnings, 18 filtered, 10 badness; has taken 2.5 s Rpmlint (debuginfo) ------------------- Checking: pop-launcher-debuginfo-1.2.3^git20241018.fca3b25-1.fc42.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmplxotk9ko')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.9 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "pop-launcher-debuginfo". (none): E: there is no installed rpm "pop-launcher-debugsource". (none): E: there is no installed rpm "pop-launcher". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/pop-os/launcher/archive/fca3b25552deca3bd64de8bfd1ebb38c45e4fb39/launcher-fca3b25.tar.gz : CHECKSUM(SHA256) this package : f4bbdaeece2bb9d8ea4d0d06d3976e0b9b7b97dfeae2f128647aa2b3db719a47 CHECKSUM(SHA256) upstream package : f4bbdaeece2bb9d8ea4d0d06d3976e0b9b7b97dfeae2f128647aa2b3db719a47 Requires -------- pop-launcher (rpmlib, GLIBC filtered): fd-find libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libgcc_s.so.1(GCC_4.2.0)(64bit) libm.so.6()(64bit) qalculate rtld(GNU_HASH) pop-launcher-debuginfo (rpmlib, GLIBC filtered): pop-launcher-debugsource (rpmlib, GLIBC filtered): Provides -------- pop-launcher: bundled(crate(addr2line)) bundled(crate(adler2)) bundled(crate(aho-corasick)) bundled(crate(android-tzdata)) bundled(crate(android_system_properties)) bundled(crate(anyhow)) bundled(crate(async-broadcast)) bundled(crate(async-channel)) bundled(crate(async-executor)) bundled(crate(async-fs)) bundled(crate(async-io)) bundled(crate(async-lock)) bundled(crate(async-oneshot)) bundled(crate(async-pidfd)) bundled(crate(async-process)) bundled(crate(async-recursion)) bundled(crate(async-signal)) bundled(crate(async-task)) bundled(crate(async-trait)) bundled(crate(atomic-waker)) bundled(crate(autocfg)) bundled(crate(backtrace)) bundled(crate(base64)) bundled(crate(bitflags)) bundled(crate(block)) bundled(crate(block-buffer)) bundled(crate(blocking)) bundled(crate(bumpalo)) bundled(crate(bytemuck)) bundled(crate(bytemuck_derive)) bundled(crate(byteorder)) bundled(crate(bytes)) bundled(crate(calloop)) bundled(crate(calloop-wayland-source)) bundled(crate(cc)) bundled(crate(cfb)) bundled(crate(cfg-if)) bundled(crate(cfg_aliases)) bundled(crate(chrono)) bundled(crate(concurrent-queue)) bundled(crate(const_format)) bundled(crate(const_format_proc_macros)) bundled(crate(core-foundation-sys)) bundled(crate(cosmic-client-toolkit)) bundled(crate(cosmic-protocols)) bundled(crate(cpufeatures)) bundled(crate(crossbeam-utils)) bundled(crate(crypto-common)) bundled(crate(cursor-icon)) bundled(crate(darling)) bundled(crate(darling_core)) bundled(crate(darling_macro)) bundled(crate(digest)) bundled(crate(dirs)) bundled(crate(dirs-sys)) bundled(crate(dlib)) bundled(crate(downcast-rs)) bundled(crate(endi)) bundled(crate(enumflags2)) bundled(crate(enumflags2_derive)) bundled(crate(equivalent)) bundled(crate(errno)) bundled(crate(event-listener)) bundled(crate(event-listener-strategy)) bundled(crate(fastrand)) bundled(crate(flume)) bundled(crate(fnv)) bundled(crate(fork)) bundled(crate(form_urlencoded)) bundled(crate(freedesktop-desktop-entry)) bundled(crate(futures)) bundled(crate(futures-channel)) bundled(crate(futures-core)) bundled(crate(futures-executor)) bundled(crate(futures-io)) bundled(crate(futures-lite)) bundled(crate(futures-macro)) bundled(crate(futures-micro)) bundled(crate(futures-sink)) bundled(crate(futures-task)) bundled(crate(futures-util)) bundled(crate(futures_codec)) bundled(crate(gen-z)) bundled(crate(generic-array)) bundled(crate(getrandom)) bundled(crate(gettext-rs)) bundled(crate(gettext-sys)) bundled(crate(gimli)) bundled(crate(hashbrown)) bundled(crate(hermit-abi)) bundled(crate(hex)) bundled(crate(http)) bundled(crate(http-body)) bundled(crate(http-body-util)) bundled(crate(httparse)) bundled(crate(human-sort)) bundled(crate(human_format)) bundled(crate(hyper)) bundled(crate(hyper-rustls)) bundled(crate(hyper-util)) bundled(crate(iana-time-zone)) bundled(crate(iana-time-zone-haiku)) bundled(crate(ident_case)) bundled(crate(idna)) bundled(crate(indexmap)) bundled(crate(infer)) bundled(crate(instant)) bundled(crate(io-lifetimes)) bundled(crate(ipnet)) bundled(crate(itoa)) bundled(crate(js-sys)) bundled(crate(lazy_static)) bundled(crate(libc)) bundled(crate(libloading)) bundled(crate(libmimalloc-sys)) bundled(crate(libredox)) bundled(crate(linux-raw-sys)) bundled(crate(locale_config)) bundled(crate(lock_api)) bundled(crate(log)) bundled(crate(malloc_buf)) bundled(crate(matchers)) bundled(crate(memchr)) bundled(crate(memmap2)) bundled(crate(memoffset)) bundled(crate(mimalloc)) bundled(crate(mime)) bundled(crate(mime_guess)) bundled(crate(miniz_oxide)) bundled(crate(mio)) bundled(crate(nanorand)) bundled(crate(new_mime_guess)) bundled(crate(nix)) bundled(crate(num-traits)) bundled(crate(num_cpus)) bundled(crate(numtoa)) bundled(crate(objc)) bundled(crate(objc-foundation)) bundled(crate(objc_id)) bundled(crate(object)) bundled(crate(once_cell)) bundled(crate(option-ext)) bundled(crate(ordered-stream)) bundled(crate(parking)) bundled(crate(percent-encoding)) bundled(crate(pin-project)) bundled(crate(pin-project-internal)) bundled(crate(pin-project-lite)) bundled(crate(pin-utils)) bundled(crate(piper)) bundled(crate(pkg-config)) bundled(crate(polling)) bundled(crate(ppv-lite86)) bundled(crate(proc-macro-crate)) bundled(crate(proc-macro2)) bundled(crate(quick-xml)) bundled(crate(quote)) bundled(crate(rand)) bundled(crate(rand_chacha)) bundled(crate(rand_core)) bundled(crate(recently-used-xbel)) bundled(crate(redox_users)) bundled(crate(regex)) bundled(crate(regex-automata)) bundled(crate(regex-syntax)) bundled(crate(reqwest)) bundled(crate(ring)) bundled(crate(ron)) bundled(crate(rustc-demangle)) bundled(crate(rustix)) bundled(crate(rustls)) bundled(crate(rustls-pemfile)) bundled(crate(rustls-pki-types)) bundled(crate(rustls-webpki)) bundled(crate(ryu)) bundled(crate(scoped-tls)) bundled(crate(scopeguard)) bundled(crate(serde)) bundled(crate(serde_derive)) bundled(crate(serde_json)) bundled(crate(serde_repr)) bundled(crate(serde_spanned)) bundled(crate(serde_urlencoded)) bundled(crate(serde_with)) bundled(crate(serde_with_macros)) bundled(crate(sha1)) bundled(crate(sharded-slab)) bundled(crate(shlex)) bundled(crate(signal-hook-registry)) bundled(crate(slab)) bundled(crate(smallvec)) bundled(crate(smithay-client-toolkit)) bundled(crate(socket2)) bundled(crate(spin)) bundled(crate(static_assertions)) bundled(crate(strsim)) bundled(crate(subtle)) bundled(crate(switcheroo-control)) bundled(crate(syn)) bundled(crate(sync_wrapper)) bundled(crate(sysfs-class)) bundled(crate(temp-dir)) bundled(crate(tempfile)) bundled(crate(textdistance)) bundled(crate(thiserror)) bundled(crate(thiserror-impl)) bundled(crate(thread_local)) bundled(crate(tinyvec)) bundled(crate(tinyvec_macros)) bundled(crate(tokio)) bundled(crate(tokio-macros)) bundled(crate(tokio-rustls)) bundled(crate(tokio-stream)) bundled(crate(toml)) bundled(crate(toml_datetime)) bundled(crate(toml_edit)) bundled(crate(tower-service)) bundled(crate(tracing)) bundled(crate(tracing-attributes)) bundled(crate(tracing-core)) bundled(crate(tracing-subscriber)) bundled(crate(try-lock)) bundled(crate(typenum)) bundled(crate(uds_windows)) bundled(crate(unicase)) bundled(crate(unicode-bidi)) bundled(crate(unicode-ident)) bundled(crate(unicode-normalization)) bundled(crate(unicode-xid)) bundled(crate(untrusted)) bundled(crate(url)) bundled(crate(urlencoding)) bundled(crate(uuid)) bundled(crate(version_check)) bundled(crate(waker-fn)) bundled(crate(want)) bundled(crate(wasi)) bundled(crate(wasm-bindgen)) bundled(crate(wasm-bindgen-backend)) bundled(crate(wasm-bindgen-futures)) bundled(crate(wasm-bindgen-macro)) bundled(crate(wasm-bindgen-macro-support)) bundled(crate(wasm-bindgen-shared)) bundled(crate(wayland-backend)) bundled(crate(wayland-client)) bundled(crate(wayland-csd-frame)) bundled(crate(wayland-cursor)) bundled(crate(wayland-protocols)) bundled(crate(wayland-protocols-wlr)) bundled(crate(wayland-scanner)) bundled(crate(wayland-server)) bundled(crate(wayland-sys)) bundled(crate(web-sys)) bundled(crate(webpki-roots)) bundled(crate(winapi)) bundled(crate(winapi-i686-pc-windows-gnu)) bundled(crate(winapi-x86_64-pc-windows-gnu)) bundled(crate(windows-core)) bundled(crate(windows-registry)) bundled(crate(windows-result)) bundled(crate(windows-strings)) bundled(crate(windows-sys)) bundled(crate(windows-targets)) bundled(crate(windows_aarch64_gnullvm)) bundled(crate(windows_aarch64_msvc)) bundled(crate(windows_i686_gnu)) bundled(crate(windows_i686_gnullvm)) bundled(crate(windows_i686_msvc)) bundled(crate(windows_x86_64_gnu)) bundled(crate(windows_x86_64_gnullvm)) bundled(crate(windows_x86_64_msvc)) bundled(crate(winnow)) bundled(crate(xcursor)) bundled(crate(xdg)) bundled(crate(xdg-home)) bundled(crate(xkbcommon)) bundled(crate(xkeysym)) bundled(crate(zbus)) bundled(crate(zbus_macros)) bundled(crate(zbus_names)) bundled(crate(zerocopy)) bundled(crate(zerocopy-derive)) bundled(crate(zeroize)) bundled(crate(zvariant)) bundled(crate(zvariant_derive)) bundled(crate(zvariant_utils)) pop-launcher pop-launcher(x86-64) pop-launcher-debuginfo: debuginfo(build-id) pop-launcher-debuginfo pop-launcher-debuginfo(x86-64) pop-launcher-debugsource: pop-launcher-debugsource pop-launcher-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name pop-launcher --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: Ocaml, fonts, Java, SugarActivity, Perl, PHP, Haskell, Python, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH