This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Header files in -devel subpackage, if present. Note: ifeffit : /usr/include/ifeffit.h ifeffit : /usr/share/ifeffit/config/ifeffit.h See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages - Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: ifeffit. Illegal package name: ifeffit. Does not provide -static: ifeffit. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#packaging-static-libraries ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License", "GNU General Public License v2.0 or later [generated file]", "GNU General Public License v2.0 or later", "FSF Unlimited License [generated file]", "NTP License [generated file]", "GNU General Public License, Version 2", "*No copyright* GNU General Public License, Version 2", "*No copyright* GNU General Public License", "NTP License", "GNU Library General Public License v2 or later [obsolete FSF postal address (Temple Place)]", "[generated file]", "*No copyright* [generated file]", "zlib/libpng license". 1131 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/ifeffit/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/ifeffit/cldata, /usr/share/ifeffit/config, /usr/share/ifeffit/fefftab, /usr/share/ifeffit [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/ifeffit/cldata, /usr/share/ifeffit/config, /usr/share/ifeffit/fefftab, /usr/share/ifeffit [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 3235840 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: ifeffit-1.2.13-4.fc35.x86_64.rpm ifeffit-debuginfo-1.2.13-4.fc35.x86_64.rpm ifeffit-debugsource-1.2.13-4.fc35.x86_64.rpm ifeffit-1.2.13-4.fc35.src.rpm ifeffit.x86_64: W: summary-ended-with-dot C IFEFFIT is an interactive program for XAFS analysis. It combines the high-quality analysis algorithms of AUTOBK and FEFFIT with graphical display of XAFS data and general data manipulation. ifeffit.x86_64: E: summary-too-long C IFEFFIT is an interactive program for XAFS analysis. It combines the high-quality analysis algorithms of AUTOBK and FEFFIT with graphical display of XAFS data and general data manipulation. ifeffit.x86_64: W: name-repeated-in-summary C IFEFFIT ifeffit.x86_64: E: description-line-too-long C IFEFFIT comes as a command-line program, but the underlying functionality is available as a programming library. ifeffit.x86_64: E: description-line-too-long C The IFEFFIT library can be used from C, Fortran, Tcl, Perl, and Python. This allows a variety of user interfaces ifeffit.x86_64: E: description-line-too-long C (both graphical and non-graphical) to be written around IFEFFIT. Currently, three graphical user interfaces: ifeffit.x86_64: E: description-line-too-long C G.I.FEFFIT, ATHENA/ARTEMIS, and SIXPACK are built on the underlying IFEFFIT library. IFEFFIT and all three GUIs ifeffit.x86_64: W: invalid-url URL: https://cars9.uchicago.edu/ifeffit/ ifeffit.x86_64: E: arch-dependent-file-in-usr-share /usr/share/ifeffit/libifeffit.so ifeffit.x86_64: W: unstripped-binary-or-object /usr/share/ifeffit/libifeffit.so ifeffit.x86_64: W: devel-file-in-non-devel-package /usr/include/ifeffit.h ifeffit.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libifeffit.a ifeffit.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libnopgplot.a ifeffit.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libxafs.a ifeffit.x86_64: W: devel-file-in-non-devel-package /usr/share/ifeffit/config/ifeffit.h ifeffit.x86_64: W: no-manual-page-for-binary autobk ifeffit.x86_64: W: no-manual-page-for-binary diffkk ifeffit.x86_64: W: no-manual-page-for-binary feff6 ifeffit.x86_64: W: no-manual-page-for-binary feffit ifeffit.x86_64: W: no-manual-page-for-binary ifeffit ifeffit-debuginfo.x86_64: W: invalid-url URL: https://cars9.uchicago.edu/ifeffit/ ifeffit-debugsource.x86_64: W: invalid-url URL: https://cars9.uchicago.edu/ifeffit/ ifeffit.src: W: summary-ended-with-dot C IFEFFIT is an interactive program for XAFS analysis. It combines the high-quality analysis algorithms of AUTOBK and FEFFIT with graphical display of XAFS data and general data manipulation. ifeffit.src: E: summary-too-long C IFEFFIT is an interactive program for XAFS analysis. It combines the high-quality analysis algorithms of AUTOBK and FEFFIT with graphical display of XAFS data and general data manipulation. ifeffit.src: W: name-repeated-in-summary C IFEFFIT ifeffit.src: E: description-line-too-long C IFEFFIT comes as a command-line program, but the underlying functionality is available as a programming library. ifeffit.src: E: description-line-too-long C The IFEFFIT library can be used from C, Fortran, Tcl, Perl, and Python. This allows a variety of user interfaces ifeffit.src: E: description-line-too-long C (both graphical and non-graphical) to be written around IFEFFIT. Currently, three graphical user interfaces: ifeffit.src: E: description-line-too-long C G.I.FEFFIT, ATHENA/ARTEMIS, and SIXPACK are built on the underlying IFEFFIT library. IFEFFIT and all three GUIs ifeffit.src: W: invalid-url URL: https://cars9.uchicago.edu/ifeffit/ ifeffit.src:15: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 15) 4 packages and 0 specfiles checked; 11 errors, 20 warnings. Rpmlint (debuginfo) ------------------- Checking: ifeffit-debuginfo-1.2.13-4.fc35.x86_64.rpm ifeffit-debuginfo.x86_64: W: invalid-url URL: https://cars9.uchicago.edu/ifeffit/ 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- ifeffit-debugsource.x86_64: W: invalid-url URL: https://cars9.uchicago.edu/ifeffit/ ifeffit.x86_64: W: summary-ended-with-dot C IFEFFIT is an interactive program for XAFS analysis. It combines the high-quality analysis algorithms of AUTOBK and FEFFIT with graphical display of XAFS data and general data manipulation. ifeffit.x86_64: E: summary-too-long C IFEFFIT is an interactive program for XAFS analysis. It combines the high-quality analysis algorithms of AUTOBK and FEFFIT with graphical display of XAFS data and general data manipulation. ifeffit.x86_64: W: name-repeated-in-summary C IFEFFIT ifeffit.x86_64: E: description-line-too-long C IFEFFIT comes as a command-line program, but the underlying functionality is available as a programming library. ifeffit.x86_64: E: description-line-too-long C The IFEFFIT library can be used from C, Fortran, Tcl, Perl, and Python. This allows a variety of user interfaces ifeffit.x86_64: E: description-line-too-long C (both graphical and non-graphical) to be written around IFEFFIT. Currently, three graphical user interfaces: ifeffit.x86_64: E: description-line-too-long C G.I.FEFFIT, ATHENA/ARTEMIS, and SIXPACK are built on the underlying IFEFFIT library. IFEFFIT and all three GUIs ifeffit.x86_64: W: invalid-url URL: https://cars9.uchicago.edu/ifeffit/ ifeffit.x86_64: E: arch-dependent-file-in-usr-share /usr/share/ifeffit/libifeffit.so ifeffit.x86_64: W: unstripped-binary-or-object /usr/share/ifeffit/libifeffit.so ifeffit.x86_64: W: devel-file-in-non-devel-package /usr/include/ifeffit.h ifeffit.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libifeffit.a ifeffit.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libnopgplot.a ifeffit.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libxafs.a ifeffit.x86_64: W: devel-file-in-non-devel-package /usr/share/ifeffit/config/ifeffit.h ifeffit.x86_64: W: no-manual-page-for-binary autobk ifeffit.x86_64: W: no-manual-page-for-binary diffkk ifeffit.x86_64: W: no-manual-page-for-binary feff6 ifeffit.x86_64: W: no-manual-page-for-binary feffit ifeffit.x86_64: W: no-manual-page-for-binary ifeffit ifeffit-debuginfo.x86_64: W: invalid-url URL: https://cars9.uchicago.edu/ifeffit/ 3 packages and 0 specfiles checked; 6 errors, 16 warnings. Unversioned so-files -------------------- ifeffit: /usr/share/ifeffit/libifeffit.so Source checksums ---------------- https://github.com/newville/ifeffit/archive/refs/tags/1.2.13.tar.gz : CHECKSUM(SHA256) this package : 46d8ea1b02ea81794c2afee41dd9d3d05fe1178cbd358ef6b9ecf2a77076d909 CHECKSUM(SHA256) upstream package : 46d8ea1b02ea81794c2afee41dd9d3d05fe1178cbd358ef6b9ecf2a77076d909 Requires -------- ifeffit (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) libgfortran.so.5()(64bit) libgfortran.so.5(GFORTRAN_8)(64bit) libm.so.6()(64bit) libtinfo.so.6()(64bit) readline rtld(GNU_HASH) ifeffit-debuginfo (rpmlib, GLIBC filtered): ifeffit-debugsource (rpmlib, GLIBC filtered): Provides -------- ifeffit: ifeffit ifeffit(x86-64) libifeffit.so()(64bit) ifeffit-debuginfo: debuginfo(build-id) ifeffit-debuginfo ifeffit-debuginfo(x86-64) ifeffit-debugsource: ifeffit-debugsource ifeffit-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name ifeffit --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: Haskell, R, Python, SugarActivity, Ocaml, Java, fonts, PHP, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH