This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. - Dist tag is present. Note: Multiple Release: tags found See: https://docs.fedoraproject.org/en-US/packaging-guidelines/DistTag/ - The License field must be a valid SPDX expression. Note: Not a valid SPDX expression 'GPLv3'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 - Spec file name must match the spec package %{name}, in the format %{name}.spec. Note: QtVsPlayermga8wally.spec should be QtVsPlayer.spec See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_spec_file_naming ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Unknown or generated", "GNU General Public License, Version 2 and/or GNU Library General Public License, Version 2.0 and/or MIT License [obsolete FSF postal address (Temple Place)]", "*No copyright* GNU General Public License, Version 3", "BSD 3-Clause License", "GNU Lesser General Public License", "GNU General Public License, Version 3". 249 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/QtVsPlayer/licensecheck.txt [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. Note: Especially check following dirs for bundled code: /var/lib/copr- rpmbuild/results/QtVsPlayer/upstream- unpacked/Source0/QtVsPlayer-1.0.52-6/include [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 6151 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Bad spec filename: /var/lib/copr- rpmbuild/results/QtVsPlayer/srpm-unpacked/QtVsPlayermga8wally.spec See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: QtVsPlayer-1.0.52-6.surf.fc41.x86_64.rpm QtVsPlayer-1.0.52-6.surf.fc41.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpjzl6_e97')] checks: 32, packages: 2 QtVsPlayer.x86_64: W: unstripped-binary-or-object /usr/bin/QtVsPlayer QtVsPlayer.x86_64: W: unstripped-binary-or-object /usr/lib64/QtVsPlayer/HCNetSDKCom/libSystemTransform.so QtVsPlayer.x86_64: W: unstripped-binary-or-object /usr/lib64/QtVsPlayer/libColorSpace.so QtVsPlayer.x86_64: E: symlink-has-too-many-up-segments /usr/lib64/QtVsPlayer/libopenal.so.1 ../../../../../../../../usr/lib64/libopenal.so.1.23.1 QtVsPlayer.x86_64: E: symlink-has-too-many-up-segments /usr/lib64/QtVsPlayer/libz.so.1 ../../../../../../../../usr/lib64/libz.so QtVsPlayer.x86_64: E: symlink-contains-up-and-down-segments /usr/lib64/QtVsPlayer/libopenal.so.1 ../../../../../../../../usr/lib64/libopenal.so.1.23.1 QtVsPlayer.x86_64: E: symlink-contains-up-and-down-segments /usr/lib64/QtVsPlayer/libopenal.so.1 ../../../../../../../../usr/lib64/libopenal.so.1.23.1 QtVsPlayer.x86_64: E: symlink-contains-up-and-down-segments /usr/lib64/QtVsPlayer/libopenal.so.1 ../../../../../../../../usr/lib64/libopenal.so.1.23.1 QtVsPlayer.x86_64: E: symlink-contains-up-and-down-segments /usr/lib64/QtVsPlayer/libz.so.1 ../../../../../../../../usr/lib64/libz.so QtVsPlayer.x86_64: E: symlink-contains-up-and-down-segments /usr/lib64/QtVsPlayer/libz.so.1 ../../../../../../../../usr/lib64/libz.so QtVsPlayer.x86_64: E: symlink-contains-up-and-down-segments /usr/lib64/QtVsPlayer/libz.so.1 ../../../../../../../../usr/lib64/libz.so QtVsPlayermga8wally.spec: E: superfluous-%clean-section QtVsPlayer.src: E: spelling-error ('librarys', "%description -l en_US librarys -> library, library's, library s") QtVsPlayer.src: E: spelling-error ('usr', '%description -l en_US usr -> use, us, user') QtVsPlayer.src: E: spelling-error ('playctrl', '%description -l en_US playctrl -> playact') QtVsPlayer.src: E: spelling-error ('txt', '%description -l en_US txt -> text, ext, tit') QtVsPlayer.src: E: spelling-error ('dir', '%description -l en_US dir -> deer, jr, rid') QtVsPlayer.x86_64: E: spelling-error ('librarys', "%description -l en_US librarys -> library, library's, library s") QtVsPlayer.x86_64: E: spelling-error ('playctrl', '%description -l en_US playctrl -> playact') QtVsPlayer.x86_64: E: spelling-error ('txt', '%description -l en_US txt -> text, ext, tit') QtVsPlayer.x86_64: E: spelling-error ('dir', '%description -l en_US dir -> deer, jr, rid') QtVsPlayer.x86_64: W: one-line-command-in-%post /sbin/ldconfig QtVsPlayer.x86_64: W: no-manual-page-for-binary QtVsPlayer QtVsPlayer.src: W: name-repeated-in-summary QtVsPlayer QtVsPlayer.x86_64: W: name-repeated-in-summary QtVsPlayer QtVsPlayermga8wally.spec:206: W: macro-in-%changelog %post QtVsPlayermga8wally.spec:206: W: macro-in-%changelog %preun QtVsPlayer.src: E: invalid-spec-name QtVsPlayer.x86_64: W: incoherent-version-in-changelog urfzoid@gmail.com ['1.0.52-6.surf.fc41', '1.0.52-6.surf'] QtVsPlayer.x86_64: E: files-duplicated-waste 4342992 QtVsPlayer.x86_64: W: files-duplicate /usr/lib64/QtVsPlayer/libStreamTransClient.so /usr/lib64/QtVsPlayer/HCNetSDKCom/libStreamTransClient.so QtVsPlayer.x86_64: W: files-duplicate /usr/lib64/QtVsPlayer/libcrypto.so.1.1 /usr/lib64/QtVsPlayer/libcrypto.so QtVsPlayer.x86_64: W: files-duplicate /usr/lib64/QtVsPlayer/libssl.so.1.1 /usr/lib64/QtVsPlayer/libssl.so QtVsPlayer.x86_64: E: explicit-lib-dependency lib64openal1 QtVsPlayer.x86_64: E: explicit-lib-dependency lib64qt5network5 QtVsPlayer.x86_64: W: empty-%preun QtVsPlayer.src: E: description-line-too-long QtVsPlayer can read local video files of Hikvision and display blue, green and red vectors. QtVsPlayer.src: E: description-line-too-long This is the end of an full network backup solution in combination with HikNetExtractor. QtVsPlayer.src: E: description-line-too-long Join us on IRC https://matrix.to/#/#QtVsPlayer:libera.chat or https://matrix.to/#/#QtVsPlayer:matrix.org QtVsPlayer.src: E: description-line-too-long This software use the PlayCtrl SDK libraries from HikVision, those librarys are under GPL-2 license. QtVsPlayer.src: E: description-line-too-long You will find it in /usr/share/licenses/QtVsPlayer/Licenses_playctrl_linux.txt or in SDK archive from HikVision website : QtVsPlayer.src: E: description-line-too-long https://www.hikvision.com/content/dam/hikvision/en/support/download/sdk/device-network-sdk/EN-HCNetSDKV6.1.9.4_build20220412_linux64.rar QtVsPlayer.x86_64: E: description-line-too-long QtVsPlayer can read local video files of Hikvision and display blue, green and red vectors. QtVsPlayer.x86_64: E: description-line-too-long This is the end of an full network backup solution in combination with HikNetExtractor. QtVsPlayer.x86_64: E: description-line-too-long Join us on IRC https://matrix.to/#/#QtVsPlayer:libera.chat or https://matrix.to/#/#QtVsPlayer:matrix.org QtVsPlayer.x86_64: E: description-line-too-long This software use the PlayCtrl SDK libraries from HikVision, those librarys are under GPL-2 license. QtVsPlayer.x86_64: E: description-line-too-long You will find it in /usr/share/licenses/QtVsPlayer/Licenses_playctrl_linux.txt or in SDK archive from HikVision website : QtVsPlayer.x86_64: E: description-line-too-long https://www.hikvision.com/content/dam/hikvision/en/support/download/sdk/device-network-sdk/EN-HCNetSDKV6.1.9.4_build20220412_linux64.rar QtVsPlayer.x86_64: W: dangling-relative-symlink /usr/lib64/QtVsPlayer/libopenal.so.1 ../../../../../../../../usr/lib64/libopenal.so.1.23.1 QtVsPlayer.x86_64: W: dangling-relative-symlink /usr/lib64/QtVsPlayer/libz.so.1 ../../../../../../../../usr/lib64/libz.so QtVsPlayer.x86_64: W: dangerous-command-in-%postun rm QtVsPlayer.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/lib64/QtVsPlayer/libcrypto.so QtVsPlayer.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/lib64/QtVsPlayer/libcrypto.so.1.1 QtVsPlayer.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/lib64/QtVsPlayer/libhpr.so 2 packages and 0 specfiles checked; 34 errors, 20 warnings, 7 filtered, 34 badness; has taken 1.7 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s (none): E: there is no installed rpm "QtVsPlayer". There are no files to process nor additional arguments. Nothing to do, aborting. Unversioned so-files -------------------- QtVsPlayer: /usr/lib64/QtVsPlayer/HCNetSDKCom/libAudioIntercom.so QtVsPlayer: /usr/lib64/QtVsPlayer/HCNetSDKCom/libHCAlarm.so QtVsPlayer: /usr/lib64/QtVsPlayer/HCNetSDKCom/libHCCoreDevCfg.so QtVsPlayer: /usr/lib64/QtVsPlayer/HCNetSDKCom/libHCDisplay.so QtVsPlayer: /usr/lib64/QtVsPlayer/HCNetSDKCom/libHCGeneralCfgMgr.so QtVsPlayer: /usr/lib64/QtVsPlayer/HCNetSDKCom/libHCIndustry.so QtVsPlayer: /usr/lib64/QtVsPlayer/HCNetSDKCom/libHCPlayBack.so QtVsPlayer: /usr/lib64/QtVsPlayer/HCNetSDKCom/libHCPreview.so QtVsPlayer: /usr/lib64/QtVsPlayer/HCNetSDKCom/libHCVoiceTalk.so QtVsPlayer: /usr/lib64/QtVsPlayer/HCNetSDKCom/libStreamTransClient.so QtVsPlayer: /usr/lib64/QtVsPlayer/HCNetSDKCom/libSystemTransform.so QtVsPlayer: /usr/lib64/QtVsPlayer/HCNetSDKCom/libanalyzedata.so QtVsPlayer: /usr/lib64/QtVsPlayer/libAudioRender.so QtVsPlayer: /usr/lib64/QtVsPlayer/libColorSpace.so QtVsPlayer: /usr/lib64/QtVsPlayer/libHCCore.so QtVsPlayer: /usr/lib64/QtVsPlayer/libPlayCtrl.so QtVsPlayer: /usr/lib64/QtVsPlayer/libStreamTransClient.so QtVsPlayer: /usr/lib64/QtVsPlayer/libSuperRender.so QtVsPlayer: /usr/lib64/QtVsPlayer/libcrypto.so QtVsPlayer: /usr/lib64/QtVsPlayer/libhcnetsdk.so QtVsPlayer: /usr/lib64/QtVsPlayer/libhpr.so QtVsPlayer: /usr/lib64/QtVsPlayer/libssl.so Source checksums ---------------- https://github.com/surfzoid/QtVsPlayer/archive/1.0.52-6/QtVsPlayer-1.0.52-6.tar.gz : CHECKSUM(SHA256) this package : d68308f6fce763300dc7b3ba23fbb8ae96e7d687dbb2264161a6259aa8c58421 CHECKSUM(SHA256) upstream package : d68308f6fce763300dc7b3ba23fbb8ae96e7d687dbb2264161a6259aa8c58421 Requires -------- QtVsPlayer (rpmlib, GLIBC filtered): /bin/sh ld-linux-x86-64.so.2()(64bit) lib64openal1 lib64qt5network5 libAudioRender.so()(64bit) libGL.so.1()(64bit) libHCCore.so()(64bit) libHCCoreDevCfg.so()(64bit) libPlayCtrl.so()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.15)(64bit) libQt5DBus.so.5()(64bit) libQt5DBus.so.5(Qt_5)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libX11.so.6()(64bit) libbz2.so.1()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libfreetype.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libhcnetsdk.so()(64bit) libhpr.so()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libuuid.so.1()(64bit) qtbase5-common rtld(GNU_HASH) Provides -------- QtVsPlayer: QtVsPlayer QtVsPlayer(x86-64) application() application(QtVsPlayer.desktop) libAudioIntercom.so()(64bit) libAudioRender.so()(64bit) libColorSpace.so()(64bit) libHCAlarm.so()(64bit) libHCCore.so()(64bit) libHCCoreDevCfg.so()(64bit) libHCDisplay.so()(64bit) libHCGeneralCfgMgr.so()(64bit) libHCIndustry.so()(64bit) libHCPlayBack.so()(64bit) libHCPreview.so()(64bit) libHCVoiceTalk.so()(64bit) libPlayCtrl.so()(64bit) libStreamTransClient.so()(64bit) libSuperRender.so()(64bit) libSystemTransform.so()(64bit) libanalyzedata.so()(64bit) libhcnetsdk.so()(64bit) libhpr.so()(64bit) mimehandler(application/x-extension-mp4) mimehandler(inode/directory) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name QtVsPlayer --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-41-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: fonts, PHP, R, SugarActivity, Haskell, Python, Ocaml, Java, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH