# ROCclr loads comgr at run time by soversion, so this needs to be checked when
# updating this package as it's used for the comgr requires for opencl and hip:
%global comgr_maj_api_ver 2
# See the file "rocclr/device/comgrctx.cpp" for reference:
# https://github.com/ROCm-Developer-Tools/ROCclr/blob/develop/device/comgrctx.cpp#L62
%global rocm_release 5.6
%global rocm_patch 1
%global rocm_version %{rocm_release}.%{rocm_patch}
Name: rocclr
Version: %{rocm_version}
Release: 1%{?dist}
Summary: ROCm Compute Language Runtime
Url: https://github.com/ROCm-Developer-Tools/clr
License: MIT
Source0: https://github.com/ROCm-Developer-Tools/clr/archive/refs/tags/rocm-%{version}.tar.gz#/%{name}-%{version}.tar.gz
# TODO: it would be nice to separate this into its own package:
Source1: https://github.com/ROCm-Developer-Tools/HIP/archive/refs/tags/rocm-%{version}.tar.gz#/HIP-%{version}.tar.gz
# TODO introduce HIPCC package so I can delete this:
Source2: https://github.com/ROCm-Developer-Tools/HIPCC/archive/refs/tags/rocm-%{version}.tar.gz#/HIPCC-%{version}.tar.gz
Patch0: https://github.com/ROCm-Developer-Tools/clr/commit/2cda949920a2ae5e88702ceaa806f5262070824c.patch
# Rebased upstream patch:
#https://github.com/ROCm-Developer-Tools/clr/commit/03bfa6168453cca9ddbc6aa1bf46324db186cbb3
Patch1: 0001-Install-.hipVersion-into-datadir-for-linux.patch
# Revert patch: this causes some issues with upstream LLVM 16 (RHBZ#2207599)
#https://github.com/ROCm-Developer-Tools/ROCclr/commit/041c00465b7adcee78085dc42253d42d1bb1f250
Patch4: 0001-Revert-SWDEV-325538-Enable-code-object-v5-by-default.patch
# HIPCC fixes:
Patch100: https://github.com/ROCm-Developer-Tools/HIPCC/commit/a11397e769f71227cfc44353842ea90707610236.patch
Patch101: https://github.com/ROCm-Developer-Tools/HIPCC/commit/560bee0df3b95d9cf18d5e52d7fa99ffe6b0f488.patch
# Moves FindHIP cmake to datadir, to fit better with hip-devel being noarch:
Patch6: 0001-Move-FindHIP-to-datadir.patch
# a fix for building blender
Patch8: 0001-add-long-variants-for-__ffsll.patch
BuildRequires: cmake
BuildRequires: clang-devel
BuildRequires: doxygen
BuildRequires: fdupes
BuildRequires: gcc-c++
BuildRequires: libffi-devel
BuildRequires: llvm-devel
BuildRequires: perl
BuildRequires: perl-generators
BuildRequires: pkgconfig(opengl)
BuildRequires: pkgconfig(numa)
BuildRequires: pkgconfig(ocl-icd)
BuildRequires: python3-cppheaderparser
BuildRequires: rocm-comgr-devel
BuildRequires: rocminfo >= %{rocm_release}
BuildRequires: rocm-runtime-devel >= %{rocm_release}
BuildRequires: zlib-devel
# Only the following architectures are supported, since the kernel support only
# exists for x86_64, aarch64, and ppc64le:
ExclusiveArch: x86_64 aarch64 ppc64le
# 32bit userspace is excluded as it likely doesn't work and is not very useful
# rocclr bundles OpenCL 2.2 headers
# Some work is needed to unbundle this, as it fails to compile with latest
Provides: bundled(opencl-headers) = 2.2
%description
ROCm Compute Language Runtime
%package -n rocm-opencl
Summary: ROCm OpenCL platform and device tool
Requires: comgr(major) = %{comgr_maj_api_ver}
Requires: ocl-icd%{?_isa}
Requires: opencl-filesystem
%description -n rocm-opencl
ROCm OpenCL language runtime.
Supports offline and in-process/in-memory compilation.
%package -n rocm-opencl-devel
Summary: ROCm OpenCL development package
Requires: rocm-opencl%{?_isa} = %{version}-%{release}
Requires: ocl-icd-devel%{?_isa}
%description -n rocm-opencl-devel
The AMD ROCm OpenCL development package.
%package -n rocm-clinfo
Summary: ROCm OpenCL platform and device tool
%description -n rocm-clinfo
A simple ROCm OpenCL application that enumerates all possible platform and
device information.
%package -n rocm-hip
Summary: ROCm HIP platform and device tool
Requires: comgr(major) = %{comgr_maj_api_ver}
Requires: hipcc = %{version}-%{release}
%description -n rocm-hip
ROCm HIP implementation specifically for AMD platforms.
%package -n rocm-hip-devel
Summary: ROCm HIP development package
Requires: rocm-hip%{?_isa} = %{version}-%{release}
Requires: hip-devel = %{version}-%{release}
Requires: rocm-comgr-devel
Requires: rocm-runtime-devel >= %{rocm_release}
%description -n rocm-hip-devel
ROCm HIP development package.
%package -n hipcc
Summary: HIP compiler driver
BuildArch: noarch
# hipcc requirements:
Requires: rocminfo >= %{rocm_release}
# 16.2 has an important fix for hipcc to work out of the box:
Requires: rocm-device-libs >= 16.2
Requires: clang
# Renamed hip to hipcc to prepare for hipcc package split
Provides: hip = %{version}-%{release}
Obsoletes: hip < 5.6.0
%description -n hipcc
hipcc is a compiler driver utility that will call clang or nvcc, depending on
target, and pass the appropriate include and library options for the target
compiler and HIP infrastructure.
%package -n hip-devel
Summary: HIP API development package
BuildArch: noarch
%description -n hip-devel
HIP is a C++ Runtime API and Kernel Language that allows developers to create
portable applications for AMD and NVIDIA GPUs from the same source code.
%package -n hip-doc
Summary: HIP API documentation package
BuildArch: noarch
%description -n hip-doc
This package contains documentation for the hip package
%prep
%autosetup -N -a 1 -n clr-rocm-%{version}
# ROCclr patches
%autopatch -p1 -M 99
# Enable experimental pre vega platforms
sed -i 's/\(ROC_ENABLE_PRE_VEGA.*\)false/\1true/' rocclr/utils/flags.hpp
# Disable RPATH
# https://github.com/ROCm-Developer-Tools/hipamd/issues/22
sed -i '/INSTALL_RPATH/d' \
opencl/tools/clinfo/CMakeLists.txt hipamd/CMakeLists.txt
# Upstream doesn't want OpenCL sonames because they don't guarantee API/ABI.
# For Fedora, SOVERSION can be major.minor (i.e. rocm_release) as rocm patch
# releases are very unlikely to break anything:
echo "set_target_properties(amdocl PROPERTIES VERSION %{version} SOVERSION %rocm_release)" \
>> opencl/amdocl/CMakeLists.txt
echo "libamdocl64.so.%{rocm_release}" > opencl/config/amdocl64.icd
echo "set_target_properties(cltrace PROPERTIES VERSION %{version} SOVERSION %rocm_release)" \
>> opencl/tools/cltrace/CMakeLists.txt
# Clean up unused bundled code
# Only keep opencl2.2 headers as are they needed for now:
ls -d opencl/khronos/* | grep -v headers | xargs rm -r
ls -d opencl/khronos/headers/* | grep -v opencl2.2 | xargs rm -r
# Unused opencl 2.2 test code:
rm -r opencl/khronos/headers/opencl2.2/tests/
# Don't change default C FLAGS and CXX FLAGS:
sed -i '/CMAKE_C.*_FLAGS/d' hipamd/src/CMakeLists.txt
pushd HIP-rocm-%{version}
#TODO introduce hipcc package to remove this:
gzip -dc %{SOURCE2} | tar --strip-components=1 -xof -
# HIP patches
%autopatch -p1 -m 100
# Fix script shebang (Fedora doesn't allow using "env"):
sed -i 's|\(/usr/bin/\)env perl|\1perl|' bin/hipcc.pl
# Drop some unnecessary includes:
sed -i '/^# Add paths to common HIP includes:/,/^$HIPCFLAGS/d' bin/hipcc.pl
# Disable doxygen timestamps:
sed -i 's/^\(HTML_TIMESTAMP.*\)YES/\1NO/' docs/doxygen-input/doxy.cfg
popd
%build
# PCH appears to be broken for aarch64, just disable for now
%cmake \
%ifarch aarch64
-D__HIP_ENABLE_PCH=OFF \
%endif
-DCMAKE_SHARED_LINKER_FLAGS=-Wl,-z,noexecstack \
-DHIP_COMMON_DIR=$(realpath HIP-rocm-%{version}) \
-DCMAKE_INSTALL_LIBDIR=%{_lib} \
-DHIPCC_BIN_DIR=$(realpath HIP-rocm-%{version})/bin \
-DHIP_PLATFORM=amd \
-DROCM_PATH=%{_prefix} \
-DBUILD_ICD=OFF \
-DCLR_BUILD_HIP=ON \
-DCLR_BUILD_OCL=ON \
-DFILE_REORG_BACKWARD_COMPATIBILITY=OFF \
-DCMAKE_BUILD_TYPE=RelWithDebInfo
%cmake_build
%install
%cmake_install
# Install OpenCL ICD configuration:
install -D -m 644 opencl/config/amdocl64.icd \
%{buildroot}%{_sysconfdir}/OpenCL/vendors/amdocl64.icd
# Avoid file conflicts with opencl-headers package:
mkdir -p %{buildroot}%{_includedir}/%{name}
mv %{buildroot}%{_includedir}/CL %{buildroot}%{_includedir}/%{name}/CL
# Avoid file conflicts with clinfo package:
mv %{buildroot}%{_bindir}/clinfo %{buildroot}%{_bindir}/rocm-clinfo
# Fix perl module files installation:
mkdir -p %{buildroot}%{perl_vendorlib}
mv %{buildroot}%{_bindir}/hip*.pm %{buildroot}%{perl_vendorlib}
# Eventually upstream plans to deprecate Perl usage, see HIPCC README:
# https://github.com/ROCm-Developer-Tools/HIPCC/blob/develop/README.md
# Clean up file dupes
%fdupes %{buildroot}/%{_docdir}/hip
# Note: fdupes doesn't work correctly with the following, so it's done manually
for i in %{buildroot}/%{_libdir}/cmake/hip{rtc,-lang}/*-config-version.cmake; do
if cmp -s $i %{buildroot}/%{_libdir}/cmake/hip/hip-config-version.cmake
then
ln -fs ../hip/hip-config-version.cmake $i
fi
done
if cmp -s %{buildroot}/%{_includedir}/hip/amd_detail/hip_prof_str.h \
%{buildroot}/%{_includedir}/hip_prof_str.h; then
ln -fs hip/amd_detail/hip_prof_str.h %{buildroot}/%{_includedir}
fi
# I have no idea why this is happening, patch0 should fix this
chmod 755 %{buildroot}%{_libdir}/lib*.so*
%files -n rocm-opencl
%license opencl/LICENSE.txt
%config(noreplace) %{_sysconfdir}/OpenCL/vendors/amdocl64.icd
%{_libdir}/libamdocl64.so.5{,.*}
%{_libdir}/libcltrace.so.5{,.*}
#Duplicated files:
%exclude %{_docdir}/*/LICENSE*
%files -n rocm-opencl-devel
%{_libdir}/libamdocl64.so
%{_libdir}/libcltrace.so
%{_includedir}/%{name}
%files -n rocm-clinfo
%license opencl/LICENSE.txt
%{_bindir}/rocm-clinfo
%files -n rocm-hip
%doc hipamd/README.md
%license hipamd/LICENSE.txt
%{_libdir}/libamdhip64.so.5{,.*}
%{_libdir}/libhiprtc.so.5{,.*}
%{_libdir}/libhiprtc-builtins.so.5{,.*}
%{_datadir}/hip
%files -n rocm-hip-devel
%{_bindir}/roc-*
%{_libdir}/libamdhip64.so
%{_libdir}/libhiprtc.so
%{_libdir}/libhiprtc-builtins.so
%{_libdir}/cmake/hip*
# Unnecessary file and is not FHS compliant:
%exclude %{_libdir}/.hipInfo
%files -n hipcc
%{_bindir}/hipcc{,.pl}
%{_bindir}/hipconfig{,.pl}
%{perl_vendorlib}/hip*.pm
# Don't include windows files
%exclude %{_bindir}/*.bat
%files -n hip-devel
%doc HIP-rocm-%{version}/README.md
%license HIP-rocm-%{version}/LICENSE.txt
%{_bindir}/hipdemangleatp
%{_bindir}/hipcc_cmake_linker_helper
%{_includedir}/hip
%{_includedir}/hip_prof_str.h
%{_datadir}/cmake/hip
%files -n hip-doc
%license HIP-rocm-%{version}/LICENSE.txt
%{_docdir}/hip
%changelog
* Tue Sep 12 2023 Jeremy Newton <alexjnewt at hotmail dot com> - 5.6.1-1
- Update to 5.6.1
* Sun Aug 20 2023 Tom Rix <trix@redhat.com> - 5.6.0-4
- A better fix for blender 3.6.x and rocFFT
* Fri Jul 21 2023 Fedora Release Engineering <releng@fedoraproject.org> - 5.6.0-3
- Rebuilt for https://fedoraproject.org/wiki/Fedora_39_Mass_Rebuild
* Tue Jul 04 2023 Jeremy Newton <alexjnewt at hotmail dot com> - 5.6.0-2
- Fix missing requires on rocm-hip-devel package
* Thu Jun 29 2023 Jeremy Newton <alexjnewt at hotmail dot com> - 5.6.0-1
- Update to 5.6
* Sun Jun 18 2023 Tom Rix <trix@redhat.com> - 5.5.1-9
- Fix building upstream blender 3.5.x
* Sat Jun 10 2023 Jeremy Newton <alexjnewt at hotmail dot com> - 5.5.1-8
- Fix hip-lang-config.cmake bug (upstream patch)
* Fri Jun 09 2023 Jeremy Newton <alexjnewt at hotmail dot com> - 5.5.1-7
- Fix hip-config.cmake bug (upstream patch)
* Fri Jun 02 2023 Jeremy Newton <alexjnewt at hotmail dot com> - 5.5.1-6
- Fix rocminfo requires for hip
* Tue May 30 2023 Jeremy Newton <alexjnewt at hotmail dot com> - 5.5.1-5
- Move some sed patching to patch files, sent some to upstream
- Add hipconfig patch for incorrect HIP_CLANG_INCLUDE detection
- Using rocm-device-libs 16.2 simplifies hipcc patching
- Minor clean up
* Tue May 30 2023 Jeremy Newton <alexjnewt at hotmail dot com> - 5.5.1-4
- Move libamdhip64.so to rocm-hip to workaround blender issue
* Tue May 30 2023 Jeremy Newton <alexjnewt at hotmail dot com> - 5.5.1-3
- Add "hip" runtime package; hipcc/hipconfig is required for blender at runtime
* Tue May 30 2023 Jeremy Newton <alexjnewt at hotmail dot com> - 5.5.1-2
- Add missing perl-generators for generating requires
- Fix some issues with hipcc.pl
- Add fix build for aarch64
* Sun May 28 2023 Jeremy Newton <alexjnewt at hotmail dot com> - 5.5.1-1
- Update to 5.5.1
- Workaround RHBZ#2207599
- Add noexecstack linker option
- Add doxygen docs
* Tue May 16 2023 Jeremy Newton <alexjnewt at hotmail dot com> - 5.5.0-1
- Initial package