Name: perl-Perl-Critic-Bangs Version: 1.14 Release: 1%{?dist} Summary: Collection of handy Perl::Critic policies License: Artistic-2.0 URL: https://metacpan.org/release/Perl-Critic-Bangs Source0: https://cpan.metacpan.org/authors/id/P/PE/PETDANCE/Perl-Critic-Bangs-%{version}.tar.gz BuildArch: noarch BuildRequires: coreutils BuildRequires: make BuildRequires: perl-generators BuildRequires: perl-interpreter BuildRequires: perl(:VERSION) >= 5.10.1 BuildRequires: perl(ExtUtils::MakeMaker) >= 6.76 BuildRequires: perl(strict) BuildRequires: perl(warnings) # Run-time: BuildRequires: perl(base) BuildRequires: perl(List::MoreUtils) BuildRequires: perl(Perl::Critic) >= 1.122 BuildRequires: perl(Perl::Critic::Policy) BuildRequires: perl(Perl::Critic::Utils) BuildRequires: perl(Readonly) # Tests only: BuildRequires: perl(English) BuildRequires: perl(File::Find) BuildRequires: perl(lib) BuildRequires: perl(Perl::Critic::Config) BuildRequires: perl(Perl::Critic::PolicyFactory) BuildRequires: perl(Perl::Critic::PolicyParameter) BuildRequires: perl(Perl::Critic::TestUtils) BuildRequires: perl(Perl::Critic::UserProfile) BuildRequires: perl(PPI::Document) BuildRequires: perl(Test::More) >= 0.96 Requires: perl(Perl::Critic) >= 1.122 # Remove under-specified dependencies %global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(Test::More\\)$ %description The rules included with the Perl::Critic::Bangs group include: - Commented-out code is usually noise. It should be removed. - Watch for comments like "XXX", "TODO", etc. - Tests should have a plan. - Variables like $user and $user2 are insufficiently distinguished. - Determining the class in a constructor by using "ref($proto) || $proto". - Adding modifiers to a regular expression made up entirely of a variable created with qr() is usually not doing what you expect. - Vague variables like $data or $info are not descriptive enough. %package tests Summary: Tests for %{name} Requires: %{name} = %{?epoch:%{epoch}:}%{version}-%{release} Requires: perl-Test-Harness Requires: perl(Test::More) >= 0.96 %description tests Tests from %{name}. Execute them with "%{_libexecdir}/%{name}/test". %prep %setup -q -n Perl-Critic-Bangs-%{version} %build perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 NO_PERLLOCAL=1 %{make_build} %install %{make_install} %{_fixperms} %{buildroot}/* # Install tests mkdir -p %{buildroot}%{_libexecdir}/%{name} # t/00_modules.t locates policies in MANIFEST cp -a MANIFEST t %{buildroot}%{_libexecdir}/%{name} # Remove tests that need modules in blib rm %{buildroot}%{_libexecdir}/%{name}/t/93_version.t cat > %{buildroot}%{_libexecdir}/%{name}/test << 'EOF' #!/bin/sh cd %{_libexecdir}/%{name} && exec prove -I . -j "$(getconf _NPROCESSORS_ONLN)" EOF chmod +x %{buildroot}%{_libexecdir}/%{name}/test %check export HARNESS_OPTIONS=j$(perl -e 'if ($ARGV[0] =~ /.*-j([0-9][0-9]*).*/) {print $1} else {print 1}' -- '%{?_smp_mflags}') make test %files %doc Changes README.md TODO %dir %{perl_vendorlib}/Perl %dir %{perl_vendorlib}/Perl/Critic %{perl_vendorlib}/Perl/Critic/Bangs.pm %dir %{perl_vendorlib}/Perl/Critic/Policy %{perl_vendorlib}/Perl/Critic/Policy/Bangs %{_mandir}/man3/Perl::Critic::Bangs.* %{_mandir}/man3/Perl::Critic::Policy::Bangs::* %files tests %{_libexecdir}/%{name} %changelog * Mon Oct 21 2024 Petr Pisar - 1.14-1 - 1.14 bump - Package the tests * Fri Jul 19 2024 Fedora Release Engineering - 1.12-24 - Rebuilt for https://fedoraproject.org/wiki/Fedora_41_Mass_Rebuild * Sat Apr 20 2024 Miroslav Suchý - 1.12-23 - convert license to SPDX * Thu Jan 25 2024 Fedora Release Engineering - 1.12-22 - Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild * Sun Jan 21 2024 Fedora Release Engineering - 1.12-21 - Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild * Fri Jul 21 2023 Fedora Release Engineering - 1.12-20 - Rebuilt for https://fedoraproject.org/wiki/Fedora_39_Mass_Rebuild * Fri Jan 20 2023 Fedora Release Engineering - 1.12-19 - Rebuilt for https://fedoraproject.org/wiki/Fedora_38_Mass_Rebuild * Fri Jul 22 2022 Fedora Release Engineering - 1.12-18 - Rebuilt for https://fedoraproject.org/wiki/Fedora_37_Mass_Rebuild * Wed Jun 01 2022 Jitka Plesnikova - 1.12-17 - Perl 5.36 rebuild * Fri Jan 21 2022 Fedora Release Engineering - 1.12-16 - Rebuilt for https://fedoraproject.org/wiki/Fedora_36_Mass_Rebuild * Thu Jul 22 2021 Fedora Release Engineering - 1.12-15 - Rebuilt for https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild * Sun May 23 2021 Jitka Plesnikova - 1.12-14 - Perl 5.34 rebuild * Wed Jan 27 2021 Fedora Release Engineering - 1.12-13 - Rebuilt for https://fedoraproject.org/wiki/Fedora_34_Mass_Rebuild * Tue Jul 28 2020 Fedora Release Engineering - 1.12-12 - Rebuilt for https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild * Tue Jun 23 2020 Jitka Plesnikova - 1.12-11 - Perl 5.32 rebuild * Thu Jan 30 2020 Fedora Release Engineering - 1.12-10 - Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild * Fri Jul 26 2019 Fedora Release Engineering - 1.12-9 - Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild * Fri May 31 2019 Jitka Plesnikova - 1.12-8 - Perl 5.30 rebuild * Fri Feb 01 2019 Fedora Release Engineering - 1.12-7 - Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild * Fri Jul 13 2018 Fedora Release Engineering - 1.12-6 - Rebuilt for https://fedoraproject.org/wiki/Fedora_29_Mass_Rebuild * Fri Jun 29 2018 Jitka Plesnikova - 1.12-5 - Perl 5.28 rebuild * Fri Feb 09 2018 Fedora Release Engineering - 1.12-4 - Rebuilt for https://fedoraproject.org/wiki/Fedora_28_Mass_Rebuild * Thu Jul 27 2017 Fedora Release Engineering - 1.12-3 - Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Mass_Rebuild * Tue Jun 06 2017 Jitka Plesnikova - 1.12-2 - Perl 5.26 rebuild * Thu May 25 2017 Petr Pisar - 1.12-1 - 1.12 bump * Sat Feb 11 2017 Fedora Release Engineering - 1.10-11 - Rebuilt for https://fedoraproject.org/wiki/Fedora_26_Mass_Rebuild * Mon May 16 2016 Jitka Plesnikova - 1.10-10 - Perl 5.24 rebuild * Thu Feb 04 2016 Fedora Release Engineering - 1.10-9 - Rebuilt for https://fedoraproject.org/wiki/Fedora_24_Mass_Rebuild * Thu Jun 18 2015 Fedora Release Engineering - 1.10-8 - Rebuilt for https://fedoraproject.org/wiki/Fedora_23_Mass_Rebuild * Sat Jun 06 2015 Jitka Plesnikova - 1.10-7 - Perl 5.22 rebuild * Fri Aug 29 2014 Jitka Plesnikova - 1.10-6 - Perl 5.20 rebuild * Sat Jun 07 2014 Fedora Release Engineering - 1.10-5 - Rebuilt for https://fedoraproject.org/wiki/Fedora_21_Mass_Rebuild * Sun Aug 04 2013 Fedora Release Engineering - 1.10-4 - Rebuilt for https://fedoraproject.org/wiki/Fedora_20_Mass_Rebuild * Wed Jul 31 2013 Petr Pisar - 1.10-3 - Perl 5.18 rebuild * Thu Feb 14 2013 Fedora Release Engineering - 1.10-2 - Rebuilt for https://fedoraproject.org/wiki/Fedora_19_Mass_Rebuild * Tue Aug 21 2012 Petr Pisar - 1.10-1 - 1.10 bump * Fri Jul 20 2012 Fedora Release Engineering - 1.08-6 - Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild * Wed Jun 20 2012 Petr Pisar - 1.08-5 - Perl 5.16 rebuild * Fri Jan 13 2012 Fedora Release Engineering - 1.08-4 - Rebuilt for https://fedoraproject.org/wiki/Fedora_17_Mass_Rebuild * Tue Jul 19 2011 Petr Sabata - 1.08-3 - Perl mass rebuild * Tue Jun 21 2011 Petr Pisar - 1.08-2 - BuildRequire perl(base) * Tue Jun 21 2011 Petr Pisar - 1.08-1 - 1.08 bump - License changed to Artistic 2.0 only. - Drops dependency on Perl::Critic::Utils::PPIRegexp to work with perl 5.14 * Thu Jan 27 2011 Petr Pisar 1.06-1 - Specfile autogenerated by cpanspec 1.78. - Remove BuildRoot stuff - Write description according POD. - Install into perl core directory.